Page MenuHomePhabricator

[builtins] Build for arm64_32 for watchOS (Darwin)
ClosedPublic

Authored by drodriguez on Wed, Mar 31, 2:30 PM.

Details

Summary

Trying to build the builtins code fails because arm64_32_SOURCES is
missing. Setting it to the same list used for aarch64_SOURCES solves
that problem and allow the builtins to compile for that architecture.

Additionally, arm64_32 is added as a possible architecture for watchos
platforms.

Diff Detail

Event Timeline

drodriguez created this revision.Wed, Mar 31, 2:30 PM
drodriguez requested review of this revision.Wed, Mar 31, 2:30 PM
Herald added a project: Restricted Project. · View Herald TranscriptWed, Mar 31, 2:30 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
compnerd accepted this revision.Wed, Mar 31, 7:36 PM

Thanks!

This revision is now accepted and ready to land.Wed, Mar 31, 7:36 PM
This revision was automatically updated to reflect the committed changes.

@drodriguez In future could you add me as a reviewer to Apple CMake changes as well?

@delcypher: I will. Is there any concerns about the code as landed?

The code in compiler-rt/cmake/builtin-config-ix.cmake is reasonable. Although we (Apple) should probably upstream our change because it's slightly different. I'm not sure about the change in compiler-rt/lib/builtins/CMakeLists.txt we don't have the change you made. I'll put a patch up to upstream our version and we'll see how it goes.