Page MenuHomePhabricator

delcypher (Dan Liew)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 21 2015, 4:29 PM (283 w, 23 h)

Recent Activity

Today

delcypher added a comment to D95184: [ASan] Stop blocking child thread progress from parent thread in `pthread_create` interceptor..

You should also change compiler-rt/lib/asan/asan_win.cpp like this:

diff --git a/compiler-rt/lib/asan/asan_win.cpp b/compiler-rt/lib/asan/asan_win.cpp
index 8044ae16ff9b..1577c83cf994 100644
--- a/compiler-rt/lib/asan/asan_win.cpp
+++ b/compiler-rt/lib/asan/asan_win.cpp
@@ -134,7 +134,7 @@ INTERCEPTOR(int, _except_handler4, void *a, void *b, void *c, void *d) {
 static thread_return_t THREAD_CALLING_CONV asan_thread_start(void *arg) {
   AsanThread *t = (AsanThread *)arg;
   SetCurrentThread(t);
-  return t->ThreadStart(GetTid(), /* signal_thread_is_registered */ nullptr);
+  return t->ThreadStart(GetTid());
 }

 INTERCEPTOR_WINAPI(HANDLE, CreateThread, LPSECURITY_ATTRIBUTES security,
Sat, Jan 23, 9:13 AM · Restricted Project
delcypher committed rG757b93bb7b38: [ASan] Fix broken Windows build due to 596d534ac3524052df210be8d3c01a33b2260a42. (authored by delcypher).
[ASan] Fix broken Windows build due to 596d534ac3524052df210be8d3c01a33b2260a42.
Sat, Jan 23, 9:13 AM

Yesterday

delcypher committed rG596d534ac352: [ASan] Stop blocking child thread progress from parent thread in… (authored by delcypher).
[ASan] Stop blocking child thread progress from parent thread in…
Fri, Jan 22, 11:35 PM
delcypher closed D95184: [ASan] Stop blocking child thread progress from parent thread in `pthread_create` interceptor..
Fri, Jan 22, 11:35 PM · Restricted Project
delcypher added inline comments to D95184: [ASan] Stop blocking child thread progress from parent thread in `pthread_create` interceptor..
Fri, Jan 22, 7:43 PM · Restricted Project
delcypher updated the diff for D95184: [ASan] Stop blocking child thread progress from parent thread in `pthread_create` interceptor..

Address second round of feedback.

Fri, Jan 22, 7:43 PM · Restricted Project
delcypher committed rGdd922bc2a621: [LSan] Introduce a callback mechanism to allow adding data reachable from… (authored by delcypher).
[LSan] Introduce a callback mechanism to allow adding data reachable from…
Fri, Jan 22, 7:27 PM
delcypher closed D95183: [LSan] Introduce a callback mechanism to allow adding data reachable from ThreadContexts to the frontier..
Fri, Jan 22, 7:27 PM · Restricted Project
delcypher added inline comments to D95184: [ASan] Stop blocking child thread progress from parent thread in `pthread_create` interceptor..
Fri, Jan 22, 6:29 PM · Restricted Project
delcypher updated the diff for D95184: [ASan] Stop blocking child thread progress from parent thread in `pthread_create` interceptor..

Address first round of feedback.

Fri, Jan 22, 6:12 PM · Restricted Project
delcypher updated the diff for D95183: [LSan] Introduce a callback mechanism to allow adding data reachable from ThreadContexts to the frontier..

Address first round of feedback.

Fri, Jan 22, 6:11 PM · Restricted Project
delcypher added inline comments to D95184: [ASan] Stop blocking child thread progress from parent thread in `pthread_create` interceptor..
Fri, Jan 22, 5:35 PM · Restricted Project
delcypher added inline comments to D95184: [ASan] Stop blocking child thread progress from parent thread in `pthread_create` interceptor..
Fri, Jan 22, 12:57 PM · Restricted Project
delcypher added inline comments to D95183: [LSan] Introduce a callback mechanism to allow adding data reachable from ThreadContexts to the frontier..
Fri, Jan 22, 12:47 PM · Restricted Project

Thu, Jan 21

delcypher updated the diff for D95184: [ASan] Stop blocking child thread progress from parent thread in `pthread_create` interceptor..

Tweak condition to make it easier to read.

Thu, Jan 21, 4:36 PM · Restricted Project
delcypher added a comment to D95184: [ASan] Stop blocking child thread progress from parent thread in `pthread_create` interceptor..

@vitalybuka This patch implements the "update the frontier" approach you outlined in the https://reviews.llvm.org/D94210 . The patch depends on https://reviews.llvm.org/D95183 .

Thu, Jan 21, 4:26 PM · Restricted Project
delcypher abandoned D94210: [ASan] Stop blocking child thread progress from parent thread in `pthread_create` interceptor..

This is superseded by https://reviews.llvm.org/D95183 and https://reviews.llvm.org/D95184 .

Thu, Jan 21, 4:21 PM · Restricted Project
delcypher requested review of D95184: [ASan] Stop blocking child thread progress from parent thread in `pthread_create` interceptor..
Thu, Jan 21, 4:19 PM · Restricted Project
delcypher requested review of D95183: [LSan] Introduce a callback mechanism to allow adding data reachable from ThreadContexts to the frontier..
Thu, Jan 21, 4:18 PM · Restricted Project
delcypher abandoned D94207: [NFC] Refactor `IgnoreObjectLocked`.

This change isn't needed anymore.

Thu, Jan 21, 4:05 PM · Restricted Project
delcypher abandoned D94209: Introduce `UnIgnoreObjectLocked` functions.

This change isn't needed anymore.

Thu, Jan 21, 4:05 PM · Restricted Project

Thu, Jan 7

delcypher added inline comments to D94190: [sanitizer][Darwin] GetMacosAlignedVersion() fails if sysctl is not setup.
Thu, Jan 7, 7:39 PM · Restricted Project
delcypher added inline comments to D94210: [ASan] Stop blocking child thread progress from parent thread in `pthread_create` interceptor..
Thu, Jan 7, 5:03 PM · Restricted Project
delcypher added inline comments to D94210: [ASan] Stop blocking child thread progress from parent thread in `pthread_create` interceptor..
Thu, Jan 7, 12:00 PM · Restricted Project
delcypher added inline comments to D94209: Introduce `UnIgnoreObjectLocked` functions.
Thu, Jan 7, 10:29 AM · Restricted Project

Wed, Jan 6

delcypher added a reviewer for D94210: [ASan] Stop blocking child thread progress from parent thread in `pthread_create` interceptor.: MadCoder.
Wed, Jan 6, 5:51 PM · Restricted Project
delcypher added inline comments to D94210: [ASan] Stop blocking child thread progress from parent thread in `pthread_create` interceptor..
Wed, Jan 6, 5:49 PM · Restricted Project
delcypher added inline comments to D94207: [NFC] Refactor `IgnoreObjectLocked`.
Wed, Jan 6, 5:47 PM · Restricted Project
delcypher requested review of D94210: [ASan] Stop blocking child thread progress from parent thread in `pthread_create` interceptor..
Wed, Jan 6, 5:44 PM · Restricted Project
delcypher requested review of D94209: Introduce `UnIgnoreObjectLocked` functions.
Wed, Jan 6, 5:39 PM · Restricted Project
delcypher requested review of D94207: [NFC] Refactor `IgnoreObjectLocked`.
Wed, Jan 6, 5:38 PM · Restricted Project

Dec 7 2020

delcypher accepted D91783: [compiler-rt] Allow appending to 'target_cflags' value from lit_config..

Thanks for addressing my feedback. LGTM

Dec 7 2020, 4:57 PM · Restricted Project

Dec 6 2020

delcypher requested changes to D91783: [compiler-rt] Allow appending to 'target_cflags' value from lit_config..

This seems reasonable but I do have a few nits.

Dec 6 2020, 4:32 PM · Restricted Project

Dec 3 2020

delcypher accepted D92563: [Lit] Fix flaky test on heavily loaded bots.

LGTM. @ostannard Thanks for investigating!

Dec 3 2020, 11:38 AM · Restricted Project

Oct 15 2020

delcypher added inline comments to D89493: [lit] Implement `not` as a builtin in the Lit internal shell.
Oct 15 2020, 10:52 PM · Restricted Project
delcypher added a comment to D89493: [lit] Implement `not` as a builtin in the Lit internal shell.

I'm not entirely satisfied with this patch -- if folks think we should implement not as an in-process builtin, let me know and I can look into that.

Oct 15 2020, 10:45 PM · Restricted Project

Oct 14 2020

delcypher added a comment to D89344: Introduce convenience macro ASAN_NO_INSTR_PTR..

Ubsan ignores volatile vars https://clang.llvm.org/docs/UndefinedBehaviorSanitizer.html
maybe better to make sure that asan does the same here as well?

Oct 14 2020, 11:31 AM · Restricted Project, Restricted Project
delcypher added a comment to D89344: Introduce convenience macro ASAN_NO_INSTR_PTR..

I recommend abandon interface change, add a test for llvm/lib/Transforms/Instrumentation if there is no any yet, and document this trick in https://clang.llvm.org/docs/AddressSanitizer.html

Oct 14 2020, 11:27 AM · Restricted Project, Restricted Project

Oct 13 2020

delcypher added a comment to D89344: Introduce convenience macro ASAN_NO_INSTR_PTR..
In D89344#2328787, @yln wrote:

Previously attribute((address_space(1))) had to be applied to pointer types to avoid instrumentation.

I wasn't aware of this. Is this a principled way to tell ASan to skip instrumentation of a local var, or is it used because "it works" (but it depends on implementation details)?
Note that I don't know the actual meaning/semantics of address_space.

My understanding is that attribute is used "because it works", not because it's principled in anyway.

IIUC correctly the address_space attribute maps to LLVM IR's notion of address space. Here's a snippet from the LLVM language reference

A global variable may be declared to reside in a target-specific numbered address space. For targets that support them, address spaces may affect how optimizations are performed and/or what target instructions are used to access the variable. The default address space is zero. The address space qualifier must precede any other attributes.

This suggests that there might be downsides to using this attribute (e.g. it might inhibit optimizations)

Would generalizing __attribute__((no_sanitize("address"))) to also apply to local vars (of pointer type) be a cleaner way?
https://clang.llvm.org/docs/AddressSanitizer.html#disabling-instrumentation-with-attribute-no-sanitize-address

I don't think that will work because I think no_sanitize is a function level attribute.

If there is a more principled attribute then I'm happy to change this patch to use it. If such an attribute doesn't exist then I do not think that this patch should be blocked on having a more principled attribute . The whole point of this patch is to introduce a macro that hides the current implementation details. Having the macro introduced in this patch means that we can change the underlying implementation details and users of the macro will not need to care.

Oct 13 2020, 4:52 PM · Restricted Project, Restricted Project
delcypher added a comment to D89344: Introduce convenience macro ASAN_NO_INSTR_PTR..
In D89344#2328787, @yln wrote:

Previously attribute((address_space(1))) had to be applied to pointer types to avoid instrumentation.

I wasn't aware of this. Is this a principled way to tell ASan to skip instrumentation of a local var, or is it used because "it works" (but it depends on implementation details)?
Note that I don't know the actual meaning/semantics of address_space.

Oct 13 2020, 4:47 PM · Restricted Project, Restricted Project
delcypher requested review of D89344: Introduce convenience macro ASAN_NO_INSTR_PTR..
Oct 13 2020, 2:32 PM · Restricted Project, Restricted Project

Oct 12 2020

delcypher accepted D84708: [compiler-rt] Allow override of 'emulator' value from lit_config..

LGTM.

Oct 12 2020, 12:01 PM · Restricted Project

Oct 9 2020

delcypher requested changes to D84708: [compiler-rt] Allow override of 'emulator' value from lit_config..

Ah I see. That seems pretty reasonable. I had forgotten that lit_config.params is set from the command line. I'd suggest adding the comment I've suggested to make this clearer.
It would also be helpful to update the commit message to expand on the reason why you are doing this with the reason you just gave me in this review.

Oct 9 2020, 2:08 PM · Restricted Project

Oct 8 2020

delcypher added a comment to D84708: [compiler-rt] Allow override of 'emulator' value from lit_config..

@abidh Can you explain why this is needed? The emulator is set at CMake configure time and its value depends on the target being tested. Why do you want to override this with a value from the lit_config object?

Oct 8 2020, 12:57 PM · Restricted Project
delcypher committed rG295d4e420fd0: [lit] Try to remove the flakeyness of `shtest-timeout.py` and `googletest… (authored by delcypher).
[lit] Try to remove the flakeyness of `shtest-timeout.py` and `googletest…
Oct 8 2020, 10:46 AM
delcypher closed D89020: [lit] Try to remove the flakeyness of `shtest-timeout.py` and `googletest-timeout.py`..
Oct 8 2020, 10:46 AM · Restricted Project

Oct 7 2020

delcypher added inline comments to D89020: [lit] Try to remove the flakeyness of `shtest-timeout.py` and `googletest-timeout.py`..
Oct 7 2020, 6:44 PM · Restricted Project
delcypher updated the diff for D89020: [lit] Try to remove the flakeyness of `shtest-timeout.py` and `googletest-timeout.py`..

Fix typo.

Oct 7 2020, 6:44 PM · Restricted Project
delcypher updated the diff for D89020: [lit] Try to remove the flakeyness of `shtest-timeout.py` and `googletest-timeout.py`..

Address first round of feedback.

Oct 7 2020, 6:42 PM · Restricted Project
delcypher abandoned D88807: [lit] Try to remove the flakeyness of `shtest-timeout.py` and `googletest-timeout.py`..

This patch is superseded by https://reviews.llvm.org/D89020.

Oct 7 2020, 5:24 PM · Restricted Project
delcypher requested review of D89020: [lit] Try to remove the flakeyness of `shtest-timeout.py` and `googletest-timeout.py`..
Oct 7 2020, 5:23 PM · Restricted Project

Oct 6 2020

delcypher requested review of D88938: [llvm-xsan] Introduce llvm-xsan.
Oct 6 2020, 5:50 PM · Restricted Project

Oct 5 2020

delcypher added a comment to D88807: [lit] Try to remove the flakeyness of `shtest-timeout.py` and `googletest-timeout.py`..
In D88807#2312194, @yln wrote:

Flaky tests are the worst! Thanks for working on this :)

I think the principled way here would be to have two separate lit invocations for timeout fail/pass:

not lit --timeout=1 infinite_hang.py
# Will hang for 1 second, then aborted by timeout.

lit --timeout=999 short.py
# Will take however long it takes to do `short.py`, then pass. 999 just means "very long timeout"
# This will be immediate on normal hosts, and whatever time it takes on resource constrained hosts.

Or am I missing something?

Oct 5 2020, 11:54 AM · Restricted Project

Oct 4 2020

delcypher requested review of D88807: [lit] Try to remove the flakeyness of `shtest-timeout.py` and `googletest-timeout.py`..
Oct 4 2020, 2:42 PM · Restricted Project

Aug 31 2020

delcypher accepted D86379: [sanitizer] When building tests on Darwin, always pass -arch and other common flags.

LGTM provided that you explain in the commit message why this change is being made.

Aug 31 2020, 3:28 PM · Restricted Project
delcypher added a comment to D86379: [sanitizer] When building tests on Darwin, always pass -arch and other common flags.

Also, I understand that the code in question isn't best already, but I don't have the bandwidth to refactor and test any more extensive changes. I'm only trying to address the problem of getting -arch arm64 / arm64e passed into tests, otherwise we're testing the wrong thing. Let's focus on that, please.

Aug 31 2020, 3:25 PM · Restricted Project
delcypher added inline comments to D86379: [sanitizer] When building tests on Darwin, always pass -arch and other common flags.
Aug 31 2020, 3:22 PM · Restricted Project
delcypher added inline comments to D86379: [sanitizer] When building tests on Darwin, always pass -arch and other common flags.
Aug 31 2020, 1:23 PM · Restricted Project
delcypher added a comment to D86379: [sanitizer] When building tests on Darwin, always pass -arch and other common flags.

Side note: This get_test_cc_for_arch function is bad in multiple ways.

Aug 31 2020, 1:18 PM · Restricted Project
delcypher requested changes to D86379: [sanitizer] When building tests on Darwin, always pass -arch and other common flags.
Aug 31 2020, 1:08 PM · Restricted Project
delcypher added a comment to D86379: [sanitizer] When building tests on Darwin, always pass -arch and other common flags.

Could you use get_test_cflags_for_apple_platform platform instead at all the call site?

Aug 31 2020, 1:07 PM · Restricted Project

Aug 20 2020

delcypher accepted D85952: [TSan][Darwin] Enable test on non-macOS platforms.
Aug 20 2020, 12:22 PM · Restricted Project
delcypher added a comment to D85952: [TSan][Darwin] Enable test on non-macOS platforms.

You should probably refer to https://reviews.llvm.org/D85803 or the commit that removed -mmacosx-version-min=10.12 in the commit message. Other than that LGTM. Thanks for cleaning this up.

Aug 20 2020, 12:22 PM · Restricted Project
delcypher accepted D85803: [TSan][Darwin] Remove unnecessary lit substitution.
Aug 20 2020, 12:20 PM · Restricted Project

Aug 17 2020

delcypher added inline comments to D86103: [TSan][libdispatch] Ensure TSan dylib works on old systems.
Aug 17 2020, 2:18 PM · Restricted Project

Aug 13 2020

delcypher added a comment to D85803: [TSan][Darwin] Remove unnecessary lit substitution.

@yln Are you sure this actually works for all platforms, in particular the watchOS simulator? The code you link (https://github.com/llvm/llvm-project/blob/master/compiler-rt/lib/tsan/CMakeLists.txt#L122) is not the minimum deploy target. That code just checks the SDK version used to build which is different from the minimum deploy target used.

Aug 13 2020, 1:59 PM · Restricted Project
delcypher added a comment to D85925: [compiler-rt][Darwin] Refactor minimum deployment target substitutions.

LGTM. Other than the nit.

Aug 13 2020, 1:49 PM · Restricted Project
delcypher added inline comments to D85854: [TSan][libdispatch] Add interceptors for dispatch_async_and_wait().
Aug 13 2020, 12:20 PM · Restricted Project

Aug 6 2020

delcypher added a comment to D85378: Fix off-by-one error in size of the required shadow memory passed to `MapDynamicShadow`..

@vitalybuka Do I need to worry about overflow here, i.e. kHighMemEnd is ULONG_MAX on some platform in which case we'd overflow and therefore ask for a shadow size of 0?

Aug 6 2020, 12:11 PM · Restricted Project
delcypher added a comment to D85387: [NFC] Make argument name passed to `FindAvailableMemoryRange()` consistent with parameter name..

@tejohnson Side comment about the refactor. The comments on MapDynamicShadow(...) say that is function is actually supposed to mmap the found memory as NO_ACCESS. The current implementation doesn't do this. It just finds a space but doesn't mmap it. Is this a problem?

Aug 6 2020, 12:02 PM · Restricted Project
delcypher added a comment to D85389: Fix bug where we request a shadow memory one page larger than necessary..

@yln Note there are other bugs here but I plan to fix this in future commits (e.g. if (size < gap_size) should be if (size <= gap_size)).

Aug 6 2020, 11:59 AM · Restricted Project
delcypher added a comment to D85378: Fix off-by-one error in size of the required shadow memory passed to `MapDynamicShadow`..

@tejohnson Looks like this bug is present on Linux too

uptr FindDynamicShadowStart() {
  uptr shadow_size_bytes = MemToShadowSize(kHighMemEnd);
#if ASAN_PREMAP_SHADOW          
  if (!PremapShadowFailed())
    return FindPremappedShadowStart(shadow_size_bytes);
#endif 

Thanks. Added @vitalybuka as reviewer since he may have a better understanding of the implications, I only just started looking at sanitizer code recently. Similar question to @yln - does this manifest now given the page size alignment? Could you fix the linux code as well?

Aug 6 2020, 11:58 AM · Restricted Project
delcypher added a comment to D85378: Fix off-by-one error in size of the required shadow memory passed to `MapDynamicShadow`..
In D85378#2200000, @yln wrote:

This latent bug was likely hidden because the shadow memory size is
always page aligned due to being allocated by mmap.

Is this bug still latent, or does it manifest now? Can you describe what happens when it is triggered?

Aug 6 2020, 11:57 AM · Restricted Project

Aug 5 2020

delcypher updated the summary of D85389: Fix bug where we request a shadow memory one page larger than necessary..
Aug 5 2020, 6:51 PM · Restricted Project
delcypher requested review of D85389: Fix bug where we request a shadow memory one page larger than necessary..
Aug 5 2020, 6:43 PM · Restricted Project
delcypher requested review of D85387: [NFC] Make argument name passed to `FindAvailableMemoryRange()` consistent with parameter name..
Aug 5 2020, 6:16 PM · Restricted Project
delcypher added a comment to D85378: Fix off-by-one error in size of the required shadow memory passed to `MapDynamicShadow`..

@tejohnson Looks like this bug is present on Linux too

Aug 5 2020, 5:35 PM · Restricted Project
delcypher requested review of D85378: Fix off-by-one error in size of the required shadow memory passed to `MapDynamicShadow`..
Aug 5 2020, 5:06 PM · Restricted Project

Jul 29 2020

delcypher accepted D84892: [Darwin][compiler-rt] kern.osproductversion unavailable pre macOS 10.13.

LGTM

Jul 29 2020, 3:32 PM · Restricted Project

Jul 27 2020

delcypher accepted D83977: [Darwin] Fix OS version checks inside simulators.

LGTM except for the lint checks failing. Please fix those before landing.

Jul 27 2020, 6:33 PM · Restricted Project
delcypher added inline comments to D83977: [Darwin] Fix OS version checks inside simulators.
Jul 27 2020, 6:18 PM · Restricted Project

Jul 24 2020

delcypher added inline comments to D83977: [Darwin] Fix OS version checks inside simulators.
Jul 24 2020, 6:59 PM · Restricted Project
delcypher requested changes to D83977: [Darwin] Fix OS version checks inside simulators.

Looks really good. I just have a few nits.

Jul 24 2020, 6:57 PM · Restricted Project

Jul 22 2020

delcypher updated subscribers of D83977: [Darwin] Fix OS version checks inside simulators.
Jul 22 2020, 5:51 PM · Restricted Project

Jul 21 2020

delcypher committed rG923cf890d15a: Avoid failing a CHECK in `DlAddrSymbolizer::SymbolizePC`. (authored by delcypher).
Avoid failing a CHECK in `DlAddrSymbolizer::SymbolizePC`.
Jul 21 2020, 12:50 PM
delcypher closed D84262: Avoid failing a CHECK in `DlAddrSymbolizer::SymbolizePC`..
Jul 21 2020, 12:50 PM · Restricted Project
delcypher updated the diff for D84262: Avoid failing a CHECK in `DlAddrSymbolizer::SymbolizePC`..

Fix failing test due to LSan.

Jul 21 2020, 12:47 PM · Restricted Project
Herald added a project to D84262: Avoid failing a CHECK in `DlAddrSymbolizer::SymbolizePC`.: Restricted Project.
Jul 21 2020, 12:14 PM · Restricted Project

Jul 17 2020

delcypher added inline comments to D83977: [Darwin] Fix OS version checks inside simulators.
Jul 17 2020, 2:30 PM · Restricted Project

Jul 16 2020

delcypher added inline comments to D79979: [Darwin] Fix OS version checks inside simulators.
Jul 16 2020, 11:03 AM · Restricted Project

Jul 14 2020

GitHub <noreply@github.com> committed rG4ee92ef9e7a0: Merge pull request #1104 from danliew-apple/cherry-pick-62083617 (authored by delcypher).
Merge pull request #1104 from danliew-apple/cherry-pick-62083617
Jul 14 2020, 4:44 PM
delcypher committed rGb5749104908b: Add missing call to `Symbolizer::LateInitialize()` in UBSan's standalone init. (authored by delcypher).
Add missing call to `Symbolizer::LateInitialize()` in UBSan's standalone init.
Jul 14 2020, 4:44 PM
GitHub <noreply@github.com> committed rGc94d846640a2: Merge pull request #1103 from danliew-apple/cherry-pick-62067724 (authored by delcypher).
Merge pull request #1103 from danliew-apple/cherry-pick-62067724
Jul 14 2020, 4:44 PM
delcypher committed rGe8a928d0b547: Unbreak ASan runtime in the simulators. (authored by delcypher).
Unbreak ASan runtime in the simulators.
Jul 14 2020, 4:44 PM
GitHub <noreply@github.com> committed rG86531c48cba5: Merge pull request #1095 from danliew-apple/cherry-pick-58789439_part3 (authored by delcypher).
Merge pull request #1095 from danliew-apple/cherry-pick-58789439_part3
Jul 14 2020, 4:43 PM
delcypher committed rGcf8a197fa250: [Darwin] Fix symbolization for recent simulator runtimes. (authored by delcypher).
[Darwin] Fix symbolization for recent simulator runtimes.
Jul 14 2020, 4:43 PM
delcypher committed rG1711bf6dfde3: [NFC] Introduce a `LateInitialize()` method to `SymbolizerTool` that is called… (authored by delcypher).
[NFC] Introduce a `LateInitialize()` method to `SymbolizerTool` that is called…
Jul 14 2020, 4:43 PM
delcypher committed rGbcffddf04b81: [Darwin] Fix a bug where the symbolizer would examine the wrong process. (authored by delcypher).
[Darwin] Fix a bug where the symbolizer would examine the wrong process.
Jul 14 2020, 4:43 PM
GitHub <noreply@github.com> committed rG95d1a2c4e813: Merge pull request #1071 from danliew-apple/cherry-pick-58789439_part2 (authored by delcypher).
Merge pull request #1071 from danliew-apple/cherry-pick-58789439_part2
Jul 14 2020, 4:43 PM
delcypher committed rG6a3b6b56f94f: [Sanitizer Common] Show command used to launch symbolizer process at high… (authored by delcypher).
[Sanitizer Common] Show command used to launch symbolizer process at high…
Jul 14 2020, 4:43 PM