- User Since
- May 15 2019, 3:35 PM (100 w, 3 d)
Fri, Apr 2
@delcypher: I will. Is there any concerns about the code as landed?
Wed, Mar 31
Dec 3 2019
@aemerson: Thank you very much for accepting. I think I reduced the test case correctly. I needed to use the result of the G_LOAD, or the code was not being generated with the necessary G_TRUNC. I didn't imagine that it was as easy as returning the result. I hope the new test is better than the last.
Reduced the test case.
Dec 2 2019
Generate the checks in the test with update_mir_test_checks.py. Check with FileCheck that the test actually passes.
Provide more context. Rebase on top of master, just in case.
Nov 27 2019
Jun 5 2019
100% agree with you that handling long paths on Windows is a battle that I cannot win. Sadly, even if I can modify a little where my checkout is, and I can reduce that path the best I can, but when CMake and a lot more pieces start creating directories, they will not take care of the length, and they might end up creating very long paths (inside my short path). The problem appeared when a tool started creating a directory (with a long-ish name which cannot be easily modified) inside the temporal directory for a test. Short path + short path + short path ended up being long path.
May 31 2019
I will hold this for a moment. The review can happen, but I would not merge it directly. I think I would need to return the results with the prefix in the cases I know it is necessary.