Page MenuHomePhabricator

[TableGen] Allow BitsInit to init integer in pseudo expansion
ClosedPublic

Authored by sepavloff on Mon, Mar 22, 12:53 AM.

Diff Detail

Event Timeline

sepavloff requested review of this revision.Mon, Mar 22, 12:53 AM
sepavloff created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptMon, Mar 22, 12:53 AM
llvm/utils/TableGen/PseudoLoweringEmitter.cpp
111

I would declare BI as BitsInit *BI, for consistency.

113

Please include a message in the assert, in the usual way.

sepavloff updated this revision to Diff 332319.Mon, Mar 22, 9:12 AM

Addressed reviewer's notes

I presume this change passes all the TableGen tests?

I presume this change passes all the TableGen tests?

I ran check-llvm.

Looks good to me.

This revision is now accepted and ready to land.Mon, Mar 22, 9:51 AM
This revision was landed with ongoing or failed builds.Mon, Mar 22, 9:52 PM
This revision was automatically updated to reflect the committed changes.
craig.topper added inline comments.
llvm/utils/TableGen/PseudoLoweringEmitter.cpp
113

Just use a cast instead of checking dyn_cast with an assert.

sepavloff added inline comments.Mon, Mar 22, 10:56 PM
llvm/utils/TableGen/PseudoLoweringEmitter.cpp
113