Page MenuHomePhabricator

Paul-C-Anagnostopoulos (Paul C. Anagnostopoulos)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 27 2020, 8:22 AM (18 w, 4 d)

Recent Activity

Today

Paul-C-Anagnostopoulos added a comment to D92674: [TableGen] Cache two things to improve speed..

I will break out the instruction namespace change, submit a second Phabricator revision, and remove it from this revision. Probably not until Sunday, so let's carry on with this discussion.

Fri, Dec 4, 1:50 PM · Restricted Project
Paul-C-Anagnostopoulos added a reviewer for D92674: [TableGen] Cache two things to improve speed.: craig.topper.
Fri, Dec 4, 1:43 PM · Restricted Project
Paul-C-Anagnostopoulos added a comment to D92674: [TableGen] Cache two things to improve speed..

@dblaikie will attest to the fact that I still don't understand the C++ baroque memory management model. It took me awhile to figure out how to use the std::unordered_map.

Fri, Dec 4, 1:41 PM · Restricted Project
Paul-C-Anagnostopoulos requested review of D92674: [TableGen] Cache two things to improve speed..
Fri, Dec 4, 11:19 AM · Restricted Project
Paul-C-Anagnostopoulos added a comment to D92269: [TableGen] Eliminate the 'code' type.

Thanks!

Fri, Dec 4, 6:35 AM · Restricted Project, Restricted Project, Restricted Project

Yesterday

Paul-C-Anagnostopoulos committed rG415fab6f67b4: [TableGen] Eliminate the 'code' type (authored by Paul-C-Anagnostopoulos).
[TableGen] Eliminate the 'code' type
Thu, Dec 3, 7:20 AM
Paul-C-Anagnostopoulos closed D92269: [TableGen] Eliminate the 'code' type.
Thu, Dec 3, 7:20 AM · Restricted Project, Restricted Project, Restricted Project
Paul-C-Anagnostopoulos added a comment to D92269: [TableGen] Eliminate the 'code' type.

I'm about to push this revision. I will be surprised if it does not break the build.

Thu, Dec 3, 7:02 AM · Restricted Project, Restricted Project, Restricted Project
Paul-C-Anagnostopoulos accepted D92477: [TableGen] Remove unused class RecordValResolver. NFC..

Cool! It had seen the TODO and planned to do something about it, but didn't realize the class wasn't used at all.

Thu, Dec 3, 5:13 AM · Restricted Project

Tue, Dec 1

Paul-C-Anagnostopoulos added a comment to D92423: [llvm-tblgen] Fixed 64-bit filters being sliced to 32 bits in FixedLenDecoderEmitter.

Does it make sense to define a const for the value (uint64_t)-1?

Tue, Dec 1, 1:33 PM · Restricted Project
Paul-C-Anagnostopoulos updated the diff for D92269: [TableGen] Eliminate the 'code' type.

Fixed some of the lint issues.

Tue, Dec 1, 10:46 AM · Restricted Project, Restricted Project, Restricted Project

Sat, Nov 28

Paul-C-Anagnostopoulos added a comment to D92269: [TableGen] Eliminate the 'code' type.

The TypeOf_xxx field is only used by the searchable tables backend. My trek through all the backends revealed it as the only one that needs to distinguish string and code, because it can emit the C++ initializer for any type of field. All the other backends know what is in each field they process. You can see from the various patches that there is nothing special about code fields in the other backends.

Sat, Nov 28, 5:20 PM · Restricted Project, Restricted Project, Restricted Project
Paul-C-Anagnostopoulos added a comment to D92269: [TableGen] Eliminate the 'code' type.

Yes, we could create !codeconcat instead, along with !codeinterleave, !codeeq, etc. We could also just extend the existing bang operators to work on the code type. I thought it was cleaner just to get rid of the distinction.

Sat, Nov 28, 4:05 PM · Restricted Project, Restricted Project, Restricted Project
Paul-C-Anagnostopoulos added a comment to D92269: [TableGen] Eliminate the 'code' type.

The TypeOf_xxx feature of searchable tables already exists. I just co-opted it as the way to tell the searchable table backend to emit the code without quotes. If we go with this revision, we will always need it in certain cases, when the code is constructed as a string and the backend cannot tell that it is a string.

Sat, Nov 28, 3:50 PM · Restricted Project, Restricted Project, Restricted Project
Paul-C-Anagnostopoulos requested review of D92269: [TableGen] Eliminate the 'code' type.
Sat, Nov 28, 11:40 AM · Restricted Project, Restricted Project, Restricted Project
Paul-C-Anagnostopoulos committed rG0aeaec13e76a: [Timer] Add a command option to enable/disable timer sorting. (authored by Paul-C-Anagnostopoulos).
[Timer] Add a command option to enable/disable timer sorting.
Sat, Nov 28, 8:44 AM
Paul-C-Anagnostopoulos closed D92146: [Timer] Add the timer option -sort-timers to enable/disable report sorting.
Sat, Nov 28, 8:44 AM · Restricted Project
Paul-C-Anagnostopoulos added a comment to D92146: [Timer] Add the timer option -sort-timers to enable/disable report sorting.

I will auto-LGTM this on Monday.

Sat, Nov 28, 7:23 AM · Restricted Project

Fri, Nov 27

Paul-C-Anagnostopoulos updated the diff for D92146: [Timer] Add the timer option -sort-timers to enable/disable report sorting.

I eliminated the new function and replaced it with the new option -sort-timers. Nice!

Fri, Nov 27, 11:07 AM · Restricted Project

Thu, Nov 26

Paul-C-Anagnostopoulos added a comment to D92146: [Timer] Add the timer option -sort-timers to enable/disable report sorting.

I still haven't gotten used to the fact that any old compilation unit can define command line options. Great idea!

Thu, Nov 26, 1:13 PM · Restricted Project

Wed, Nov 25

Paul-C-Anagnostopoulos updated the summary of D92146: [Timer] Add the timer option -sort-timers to enable/disable report sorting.
Wed, Nov 25, 6:10 PM · Restricted Project
Paul-C-Anagnostopoulos requested review of D92146: [Timer] Add the timer option -sort-timers to enable/disable report sorting.
Wed, Nov 25, 6:09 PM · Restricted Project

Mon, Nov 23

Paul-C-Anagnostopoulos accepted D90829: [GlobalISel][TableGen] Fix seg fault for zero instruction.

LGTM.

Mon, Nov 23, 10:18 AM · Restricted Project
Paul-C-Anagnostopoulos added a comment to D91703: [GISel] Teach TableGen to check predicates of immediate operands in patterns.

I'm no expert on GlobalISelEmiitter, but it doesn't appear to perform this check now. Your new code looks good to my untrained eye.

Mon, Nov 23, 10:16 AM · Restricted Project
Paul-C-Anagnostopoulos committed rGb23e84ffcff8: [TableGen] Eliminte source location from CodeInit (authored by Paul-C-Anagnostopoulos).
[TableGen] Eliminte source location from CodeInit
Mon, Nov 23, 8:31 AM
Paul-C-Anagnostopoulos closed D91932: [TableGen] Eliminte source location from CodeInit.
Mon, Nov 23, 8:31 AM · Restricted Project

Sun, Nov 22

Paul-C-Anagnostopoulos updated the diff for D91932: [TableGen] Eliminte source location from CodeInit.

I deleted some obsolete lines of code in Record.h.

Sun, Nov 22, 7:09 AM · Restricted Project
Paul-C-Anagnostopoulos requested review of D91932: [TableGen] Eliminte source location from CodeInit.
Sun, Nov 22, 7:02 AM · Restricted Project

Sat, Nov 21

Paul-C-Anagnostopoulos committed rG9b7b8de6d12f: [TableGen] [ISel Matcher Emitter] Rework with two passes: one to size, one to… (authored by Paul-C-Anagnostopoulos).
[TableGen] [ISel Matcher Emitter] Rework with two passes: one to size, one to…
Sat, Nov 21, 8:00 AM
Paul-C-Anagnostopoulos closed D91632: [TableGen] [ISel Matcher Emitter] Rework with two passes: one to size, one to emit.
Sat, Nov 21, 7:59 AM · Restricted Project

Thu, Nov 19

Paul-C-Anagnostopoulos added inline comments to D91632: [TableGen] [ISel Matcher Emitter] Rework with two passes: one to size, one to emit.
Thu, Nov 19, 6:01 AM · Restricted Project

Wed, Nov 18

Paul-C-Anagnostopoulos added a comment to D91632: [TableGen] [ISel Matcher Emitter] Rework with two passes: one to size, one to emit.

I will auto-LGTM this revision on Friday.

Wed, Nov 18, 3:26 PM · Restricted Project

Tue, Nov 17

Paul-C-Anagnostopoulos updated the diff for D91632: [TableGen] [ISel Matcher Emitter] Rework with two passes: one to size, one to emit.

Changed the child size to a size_t. And changed the VBR size to match.

Tue, Nov 17, 10:51 AM · Restricted Project
Paul-C-Anagnostopoulos added inline comments to D91632: [TableGen] [ISel Matcher Emitter] Rework with two passes: one to size, one to emit.
Tue, Nov 17, 9:15 AM · Restricted Project
Paul-C-Anagnostopoulos added a comment to D91632: [TableGen] [ISel Matcher Emitter] Rework with two passes: one to size, one to emit.

I'll get this in as soon as there is some more review *and* I manage to reinstate my building ability. I just updated Visual Studio and can't build anything. Sigh.

Tue, Nov 17, 9:09 AM · Restricted Project
Paul-C-Anagnostopoulos requested review of D91632: [TableGen] [ISel Matcher Emitter] Rework with two passes: one to size, one to emit.
Tue, Nov 17, 7:32 AM · Restricted Project
Paul-C-Anagnostopoulos committed rG498859cbf668: [TableGen] Clean up Target .td include files (authored by Paul-C-Anagnostopoulos).
[TableGen] Clean up Target .td include files
Tue, Nov 17, 6:46 AM
Paul-C-Anagnostopoulos closed D91483: [TableGen] Clean up Target .td include files.
Tue, Nov 17, 6:46 AM · Restricted Project
Paul-C-Anagnostopoulos accepted D91483: [TableGen] Clean up Target .td include files.

Auto-LGTM.

Tue, Nov 17, 6:43 AM · Restricted Project
Paul-C-Anagnostopoulos updated the diff for D91483: [TableGen] Clean up Target .td include files.

Remove //// markers and make one final check.

Tue, Nov 17, 6:36 AM · Restricted Project

Mon, Nov 16

Paul-C-Anagnostopoulos added a comment to D91483: [TableGen] Clean up Target .td include files.

I will auto-LGTM this on Tuesday.

Mon, Nov 16, 5:39 PM · Restricted Project
Paul-C-Anagnostopoulos added inline comments to D88385: [TableGen][M68K] (Patch 1/8) Utilities for complex instruction addressing modes: CodeBeads and logical operand helper functions.
Mon, Nov 16, 4:01 PM · Restricted Project

Sun, Nov 15

Paul-C-Anagnostopoulos added a comment to D91484: [TableGen] Improve a couple of descriptions in the command guide.

Accepted revision.

Sun, Nov 15, 7:01 AM · Restricted Project
Paul-C-Anagnostopoulos committed rGd4b3277d8e96: [TableGen] Improve a couple of descriptions in the command guide (authored by Paul-C-Anagnostopoulos).
[TableGen] Improve a couple of descriptions in the command guide
Sun, Nov 15, 7:00 AM
Paul-C-Anagnostopoulos closed D91484: [TableGen] Improve a couple of descriptions in the command guide.
Sun, Nov 15, 7:00 AM · Restricted Project
Paul-C-Anagnostopoulos added a comment to D91484: [TableGen] Improve a couple of descriptions in the command guide.

auto-LGTM

Sun, Nov 15, 6:58 AM · Restricted Project

Sat, Nov 14

Paul-C-Anagnostopoulos requested review of D91484: [TableGen] Improve a couple of descriptions in the command guide.
Sat, Nov 14, 1:13 PM · Restricted Project
Paul-C-Anagnostopoulos requested review of D91483: [TableGen] Clean up Target .td include files.
Sat, Nov 14, 1:03 PM · Restricted Project
Paul-C-Anagnostopoulos committed rG9671790b4f7d: [TableGen] Fix missing braces in if statement (authored by Paul-C-Anagnostopoulos).
[TableGen] Fix missing braces in if statement
Sat, Nov 14, 9:39 AM
Paul-C-Anagnostopoulos added inline comments to D91388: [TableGen] Add frontend/backend phase timing capability.
Sat, Nov 14, 7:29 AM · Restricted Project
Paul-C-Anagnostopoulos committed rG54f9ee334114: [TableGen] Add frontend/backend phase timing capability. (authored by Paul-C-Anagnostopoulos).
[TableGen] Add frontend/backend phase timing capability.
Sat, Nov 14, 7:11 AM
Paul-C-Anagnostopoulos closed D91388: [TableGen] Add frontend/backend phase timing capability.
Sat, Nov 14, 7:11 AM · Restricted Project
Paul-C-Anagnostopoulos committed rGc044709b8fbe: [TableGen] Clean up more .td files (authored by Paul-C-Anagnostopoulos).
[TableGen] Clean up more .td files
Sat, Nov 14, 4:33 AM
Paul-C-Anagnostopoulos closed D91431: [TableGen] Clean up more .td files.
Sat, Nov 14, 4:33 AM · Restricted Project

Fri, Nov 13

Paul-C-Anagnostopoulos accepted D90039: [AsmWriter] Factor out mnemonic generation to accessible getMnemonic..

LGTM.

Fri, Nov 13, 11:57 AM · Restricted Project
Paul-C-Anagnostopoulos updated the diff for D91388: [TableGen] Add frontend/backend phase timing capability.

I forgot to add the new -time-phases option to the xxx-tblgen documentation.

Fri, Nov 13, 8:45 AM · Restricted Project
Paul-C-Anagnostopoulos requested review of D91431: [TableGen] Clean up more .td files.
Fri, Nov 13, 8:26 AM · Restricted Project
Paul-C-Anagnostopoulos committed rG641428f9288b: [TableGen] Enhance the six comparison bang operators. (authored by Paul-C-Anagnostopoulos).
[TableGen] Enhance the six comparison bang operators.
Fri, Nov 13, 6:58 AM
Paul-C-Anagnostopoulos closed D91036: [TableGen] Enhance the six comparison bang operators..
Fri, Nov 13, 6:57 AM · Restricted Project

Thu, Nov 12

Paul-C-Anagnostopoulos requested review of D91388: [TableGen] Add frontend/backend phase timing capability.
Thu, Nov 12, 1:35 PM · Restricted Project
Paul-C-Anagnostopoulos committed rGba906eb16cdf: [CODE_OWNERS.TXT] Update to include yours truly as the TableGen owner (authored by Paul-C-Anagnostopoulos).
[CODE_OWNERS.TXT] Update to include yours truly as the TableGen owner
Thu, Nov 12, 6:50 AM
Paul-C-Anagnostopoulos added a comment to D86617: [GlobalISel][TableGen] Take first result for multi-output instructions.

I'm not yet familiar enough with instruction selection, so I'll leave the decision to others.

Thu, Nov 12, 5:56 AM · Restricted Project

Wed, Nov 11

Paul-C-Anagnostopoulos added a comment to D90039: [AsmWriter] Factor out mnemonic generation to accessible getMnemonic..

I see no problem with this.

Wed, Nov 11, 6:45 AM · Restricted Project

Tue, Nov 10

Paul-C-Anagnostopoulos committed rG467208a4926a: [IR] [TableGen] Cleanup pass over the IR TableGen files, part 2 (authored by Paul-C-Anagnostopoulos).
[IR] [TableGen] Cleanup pass over the IR TableGen files, part 2
Tue, Nov 10, 6:29 AM
Paul-C-Anagnostopoulos closed D91097: [IR] [TableGen] Cleanup pass over the IR TableGen files, part 2.
Tue, Nov 10, 6:29 AM · Restricted Project

Mon, Nov 9

Paul-C-Anagnostopoulos added a comment to D91036: [TableGen] Enhance the six comparison bang operators..

I will auto-LGTM this revision in 36 hours.

Mon, Nov 9, 6:04 PM · Restricted Project
Paul-C-Anagnostopoulos updated the diff for D91097: [IR] [TableGen] Cleanup pass over the IR TableGen files, part 2.

Restored the two !foldl operators discussed above.

Mon, Nov 9, 3:39 PM · Restricted Project
Paul-C-Anagnostopoulos added inline comments to D91097: [IR] [TableGen] Cleanup pass over the IR TableGen files, part 2.
Mon, Nov 9, 1:41 PM · Restricted Project
Paul-C-Anagnostopoulos requested review of D91097: [IR] [TableGen] Cleanup pass over the IR TableGen files, part 2.
Mon, Nov 9, 12:25 PM · Restricted Project
Paul-C-Anagnostopoulos committed rG91d2e5c81aeb: [TableGen] Add the !filter bang operator. (authored by Paul-C-Anagnostopoulos).
[TableGen] Add the !filter bang operator.
Mon, Nov 9, 7:57 AM
Paul-C-Anagnostopoulos closed D91008: [TableGen] Add the !filter bang operator..
Mon, Nov 9, 7:57 AM · Restricted Project

Sun, Nov 8

Paul-C-Anagnostopoulos committed rG2af0edefd6de: [IR] [TableGen] Cleanup pass over the IR TableGen files. (authored by Paul-C-Anagnostopoulos).
[IR] [TableGen] Cleanup pass over the IR TableGen files.
Sun, Nov 8, 11:47 AM
Paul-C-Anagnostopoulos closed D90946: [IR] [TableGen] Cleanup pass over the IR TableGen files.
Sun, Nov 8, 11:47 AM · Restricted Project
Paul-C-Anagnostopoulos accepted D90946: [IR] [TableGen] Cleanup pass over the IR TableGen files.

Auto-LGTM. I will move on to cleaning up more IR files.

Sun, Nov 8, 11:45 AM · Restricted Project
Paul-C-Anagnostopoulos added inline comments to D91036: [TableGen] Enhance the six comparison bang operators..
Sun, Nov 8, 11:42 AM · Restricted Project
Paul-C-Anagnostopoulos requested review of D91036: [TableGen] Enhance the six comparison bang operators..
Sun, Nov 8, 11:41 AM · Restricted Project

Sat, Nov 7

Paul-C-Anagnostopoulos added a comment to D90946: [IR] [TableGen] Cleanup pass over the IR TableGen files.

I will auto-LGTM this revision in 24 hours.

Sat, Nov 7, 2:03 PM · Restricted Project
Paul-C-Anagnostopoulos requested review of D91008: [TableGen] Add the !filter bang operator..
Sat, Nov 7, 10:26 AM · Restricted Project

Fri, Nov 6

Paul-C-Anagnostopoulos updated the diff for D90946: [IR] [TableGen] Cleanup pass over the IR TableGen files.

DA is an instruction field, not a boolean.

Fri, Nov 6, 8:56 AM · Restricted Project
Paul-C-Anagnostopoulos accepted D90937: [TableGen] Indentation and whitespace fixes in generated code. NFC..

Duly added to my initialism list.

Fri, Nov 6, 7:47 AM · Restricted Project
Paul-C-Anagnostopoulos added inline comments to D90946: [IR] [TableGen] Cleanup pass over the IR TableGen files.
Fri, Nov 6, 7:42 AM · Restricted Project
Paul-C-Anagnostopoulos added a comment to D90937: [TableGen] Indentation and whitespace fixes in generated code. NFC..

But what is "NFC"?

Fri, Nov 6, 7:39 AM · Restricted Project
Paul-C-Anagnostopoulos requested review of D90946: [IR] [TableGen] Cleanup pass over the IR TableGen files.
Fri, Nov 6, 7:31 AM · Restricted Project
Paul-C-Anagnostopoulos committed rGeed768b70094: [NVPTX] [TableGen] Use new features of TableGen to simplify and clarify. (authored by Paul-C-Anagnostopoulos).
[NVPTX] [TableGen] Use new features of TableGen to simplify and clarify.
Fri, Nov 6, 6:21 AM
Paul-C-Anagnostopoulos closed D90861: [NVPTX] [TableGen] Use new features of TableGen to simplify and clarify.
Fri, Nov 6, 6:20 AM · Restricted Project
Paul-C-Anagnostopoulos committed rG6ea6444f11c8: [TableGen] Clarify text and fix errors in the Programmer's Reference (authored by Paul-C-Anagnostopoulos).
[TableGen] Clarify text and fix errors in the Programmer's Reference
Fri, Nov 6, 5:57 AM
Paul-C-Anagnostopoulos closed D90881: [TableGen] Clarify text and fix errors in the Programmer's Reference.
Fri, Nov 6, 5:57 AM · Restricted Project

Thu, Nov 5

Paul-C-Anagnostopoulos requested review of D90881: [TableGen] Clarify text and fix errors in the Programmer's Reference.
Thu, Nov 5, 1:48 PM · Restricted Project
Paul-C-Anagnostopoulos committed rG6f288b11dba7: [TableGen] Clean up documentation toctrees; clarify two paragraphs. (authored by Paul-C-Anagnostopoulos).
[TableGen] Clean up documentation toctrees; clarify two paragraphs.
Thu, Nov 5, 1:20 PM
Paul-C-Anagnostopoulos closed D90804: [TableGen] Clean up documentation toctrees; clarify two paragraphs..
Thu, Nov 5, 1:19 PM · Restricted Project
Paul-C-Anagnostopoulos accepted D90804: [TableGen] Clean up documentation toctrees; clarify two paragraphs..

I will push this now.

Thu, Nov 5, 1:17 PM · Restricted Project
Paul-C-Anagnostopoulos added a comment to D90635: [TableGen] Add true and false literals to represent booleans.

Yes, I think it would be quite disruptive. But a strong stylistic suggestion in the documentation is in order.

Thu, Nov 5, 1:13 PM · Restricted Project
Paul-C-Anagnostopoulos added a comment to D90635: [TableGen] Add true and false literals to represent booleans.

I would have to invent a boolean type to prevent that assignment. That would be such a box of frogs that I quickly gave up on the idea. I'm not even sure we could do it compatibly. What would !eq(x, y) produce? And I don't think people would want !if(pred, ...) to require a boolean, since it doesn't in C++. [Much to my chagrin, and perhaps yours.]

Thu, Nov 5, 1:05 PM · Restricted Project
Paul-C-Anagnostopoulos added a comment to D90635: [TableGen] Add true and false literals to represent booleans.

Sorry, I'm not sure what you mean by "these." If you mean 'true' and 'false', they are simply named literals for 1 and 0. So they can be used in any context where an integer is allowed.

Thu, Nov 5, 12:58 PM · Restricted Project
Paul-C-Anagnostopoulos added a comment to D88385: [TableGen][M68K] (Patch 1/8) Utilities for complex instruction addressing modes: CodeBeads and logical operand helper functions.

A minor suggestion: Use the new true/false literals in the TableGen files. I believe it makes the code easier to read.

Thu, Nov 5, 12:40 PM · Restricted Project
Paul-C-Anagnostopoulos requested review of D90861: [NVPTX] [TableGen] Use new features of TableGen to simplify and clarify.
Thu, Nov 5, 12:30 PM · Restricted Project
Paul-C-Anagnostopoulos updated the diff for D90861: [NVPTX] [TableGen] Use new features of TableGen to simplify and clarify.

Cleaned up the other TableGen files.

Thu, Nov 5, 12:29 PM · Restricted Project
Paul-C-Anagnostopoulos added a comment to D90861: [NVPTX] [TableGen] Use new features of TableGen to simplify and clarify.

I see you accepted this revision. Shall I clean up the other .td files as part of this revision, or do them separately?

Thu, Nov 5, 10:28 AM · Restricted Project
Paul-C-Anagnostopoulos added inline comments to D90861: [NVPTX] [TableGen] Use new features of TableGen to simplify and clarify.
Thu, Nov 5, 10:27 AM · Restricted Project
Paul-C-Anagnostopoulos updated the diff for D90861: [NVPTX] [TableGen] Use new features of TableGen to simplify and clarify.

Cleaned out the spurious lines with ////.

Thu, Nov 5, 10:04 AM · Restricted Project