Page MenuHomePhabricator

[MLIR] Fix lowering of Affine IfOp in the presence of yield values.
ClosedPublic

Authored by Shukla-Gaurav on Mar 16 2021, 10:12 PM.

Details

Summary

This commit fixes the lowering of Affine.IfOp to SCF.IfOp in the
presence of yield values. These changes have been made as a part of
-lower-affine pass.

Relevant test case is added.

Diff Detail

Event Timeline

Shukla-Gaurav created this revision.Mar 16 2021, 10:12 PM
Shukla-Gaurav requested review of this revision.Mar 16 2021, 10:12 PM
bondhugula accepted this revision.Mar 16 2021, 11:22 PM

Thanks for fixing this!
Nit: in the commit summary: introduces the lowering -> fixes the lowering
Similarly, in the commit title: Add -> Fix

This revision is now accepted and ready to land.Mar 16 2021, 11:22 PM
bondhugula retitled this revision from [MLIR] Add lowering of Affine IfOp in the presence of yield values. to [MLIR] Fix lowering of Affine IfOp in the presence of yield values..Mar 16 2021, 11:22 PM

Updated commit title and summary.

Shukla-Gaurav edited the summary of this revision. (Show Details)Mar 16 2021, 11:39 PM
bondhugula accepted this revision.Mar 17 2021, 3:18 AM