[MLIR] Fix lowering of Affine IfOp in the presence of yield values.
ClosedPublic
Actions

Authored by Shukla-Gaurav on Mar 16 2021, 10:12 PM.

Details

Reviewers

bondhugula

Commits

rG8e3075c2b07e: [MLIR] Fix lowering of Affine IfOp in the presence of yield values.

Summary

This commit fixes the lowering of Affine.IfOp to SCF.IfOp in the
presence of yield values. These changes have been made as a part of
-lower-affine pass.

Relevant test case is added.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

Shukla-Gaurav created this revision.Mar 16 2021, 10:12 PM

Herald added subscribers: dcaballe, cota, teijeong and 16 others. · View Herald TranscriptMar 16 2021, 10:12 PM

Shukla-Gaurav requested review of this revision.Mar 16 2021, 10:12 PM

Herald added a project: Restricted Project. · View Herald TranscriptMar 16 2021, 10:12 PM

Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript

Harbormaster completed remote builds in B94167: Diff 331161.Mar 16 2021, 10:42 PM

Thanks for fixing this!
Nit: in the commit summary: introduces the lowering -> fixes the lowering
Similarly, in the commit title: Add -> Fix

This revision is now accepted and ready to land.Mar 16 2021, 11:22 PM

bondhugula retitled this revision from [MLIR] Add lowering of Affine IfOp in the presence of yield values. to [MLIR] Fix lowering of Affine IfOp in the presence of yield values..Mar 16 2021, 11:22 PM

Updated commit title and summary.

Shukla-Gaurav edited the summary of this revision. (Show Details)Mar 16 2021, 11:39 PM

Harbormaster completed remote builds in B94173: Diff 331168.Mar 17 2021, 12:18 AM

bondhugula accepted this revision.Mar 17 2021, 3:18 AM

Closed by commit rG8e3075c2b07e: [MLIR] Fix lowering of Affine IfOp in the presence of yield values. (authored by Shukla-Gaurav, committed by bondhugula). · Explain WhyMar 17 2021, 4:04 AM

This revision was automatically updated to reflect the committed changes.

bondhugula added a commit: rG8e3075c2b07e: [MLIR] Fix lowering of Affine IfOp in the presence of yield values..