Page MenuHomePhabricator

[test-suite] Robust warnings for Fortran Test Suite tests that require Ninja.
ClosedPublic

Authored by naromero77 on Feb 22 2021, 8:46 PM.

Details

Summary
  • Add CMake issue number to Fortran Test Suite warning.
  • Add CMake issue number in CMake Fortran module.
  • Add ninja_required helper function.
  • Add ninja_required to SPEC2017 CPU ROMS floating point tests.

Diff Detail

Repository
rT test-suite

Event Timeline

naromero77 created this revision.Feb 22 2021, 8:46 PM
naromero77 requested review of this revision.Feb 22 2021, 8:46 PM
naromero77 edited the summary of this revision. (Show Details)Feb 22 2021, 8:48 PM
naromero77 added subscribers: llvm-commits, naromero77.
Meinersbur added inline comments.Feb 22 2021, 9:04 PM
CMakeLists.txt
10–11

Assuming that we add ninja_required() to every test that needs it, this warning is unnecessary.

If such a test is included in TEST_SUITE_SUBDRS: Get warning and error
Otherwise: Warning does not apply

cmake/modules/Fortran.cmake
4

Wrap line?

9–19

Thanks for the explanation

naromero77 added inline comments.Feb 23 2021, 9:05 AM
CMakeLists.txt
10–11

Your suggestion is to just get rid of the warning in the top-level CMakeLists.txt completely, since its redundant with ninja_required()?

Can you confirm?

Meinersbur added inline comments.Feb 23 2021, 11:52 AM
CMakeLists.txt
10–11

Correct

naromero77 edited the summary of this revision. (Show Details)
  • Get rid of redudant warning in top-level CMakeLists when Ninja is not used.
  • Improve line wrapping.
naromero77 edited the summary of this revision. (Show Details)Feb 23 2021, 8:13 PM
This revision is now accepted and ready to land.Feb 24 2021, 8:02 AM