This is an archive of the discontinued LLVM Phabricator instance.

[NFC] Disallow unused prefixes under clang/test/Driver
ClosedPublic

Authored by mtrofin on Jan 28 2021, 7:59 PM.

Diff Detail

Event Timeline

mtrofin created this revision.Jan 28 2021, 7:59 PM
mtrofin requested review of this revision.Jan 28 2021, 7:59 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 28 2021, 7:59 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript

Ok for the fsanitize.c bits.

yaxunl added a comment.EditedJan 29 2021, 7:31 AM

LGTM for amdgpu and rocm changes.

MaskRay added inline comments.
clang/test/Driver/rocm-device-libs.cl
81–82

Since you changing the lines, consider indenting 2>&1

The most common style is to place 2>&1 | \ on the previous line.

PS4 changes lgtm.

mtrofin updated this revision to Diff 320246.Jan 29 2021, 5:20 PM
mtrofin marked an inline comment as done.

cleaned up the RUN line for rocm

clang/test/Driver/rocm-device-libs.cl
81–82

done

MaskRay added inline comments.Jan 29 2021, 6:17 PM
clang/test/Driver/rocm-device-libs.cl
81–82

All the continuation lines should be indented, i.e. FileCheck needs to be indented...

tra added a comment.Feb 1 2021, 10:20 AM

LGTM for CUDA.

This revision was not accepted when it landed; it landed in state Needs Review.Feb 1 2021, 10:35 AM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.