Page MenuHomePhabricator

dyung (Douglas Yung)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 4 2016, 4:47 PM (242 w, 1 d)

Recent Activity

Wed, Oct 21

dyung added a reverting change for rG5e656ee48bcc: Add "not" to an llvm-symbolizer test that expects to fail: rGade107360f59: Revert "Add "not" to an llvm-symbolizer test that expects to fail".
Wed, Oct 21, 10:00 PM
dyung committed rGade107360f59: Revert "Add "not" to an llvm-symbolizer test that expects to fail" (authored by dyung).
Revert "Add "not" to an llvm-symbolizer test that expects to fail"
Wed, Oct 21, 10:00 PM

Mon, Oct 19

dyung committed rG774ab60125ee: Add option to use older clang ABI behavior when passing certain union types as… (authored by dyung).
Add option to use older clang ABI behavior when passing certain union types as…
Mon, Oct 19, 6:26 PM
dyung closed D89747: Add option to use older clang ABI behavior when passing certain union types as function arguments.
Mon, Oct 19, 6:25 PM · Restricted Project
dyung added a comment to D89747: Add option to use older clang ABI behavior when passing certain union types as function arguments.

Sorry for the lack of context, I made my diffs using a new method this time, but I'll make sure it has the full context next time. Thanks!

Mon, Oct 19, 6:02 PM · Restricted Project
dyung requested review of D89747: Add option to use older clang ABI behavior when passing certain union types as function arguments.
Mon, Oct 19, 3:28 PM · Restricted Project

Tue, Oct 13

dyung accepted D89361: [X86][NFC] Fix RUN line bug in the testcase.

LGTM as well. I also tested it and it fails before your change, and passes with your change.

Tue, Oct 13, 9:34 PM · Restricted Project
dyung added inline comments to D78699: [X86] Passing union type through register..
Tue, Oct 13, 2:31 PM · Restricted Project
dyung added a comment to D78699: [X86] Passing union type through register..

Hi, the test you added seems to pass both before and after your change, is this intended?

Tue, Oct 13, 1:45 PM · Restricted Project

Wed, Oct 7

dyung committed rGea274be72be1: Add REQUIRES: x86-registered-target to test as it was failing on build bots… (authored by dyung).
Add REQUIRES: x86-registered-target to test as it was failing on build bots…
Wed, Oct 7, 12:29 PM

Fri, Oct 2

dyung committed rG24f406e6d39b: Relax newly added opcode alias check to check only for a number instead of a… (authored by dyung).
Relax newly added opcode alias check to check only for a number instead of a…
Fri, Oct 2, 12:19 PM

Sep 17 2020

dyung added a comment to D86360: Add new hidden option -print-changed which only reports changes to IR.

I have reverted this change and the follow-up commit in b03c2b8395ba94fb53f1e73a6473faedf628bbd9. Hopefully this should get the bots green again.

Sep 17 2020, 1:34 AM · Restricted Project
dyung added a reverting change for rGf9e6d1edc0da: Re-land: Add new hidden option -print-changed which only reports changes to IR: rGb03c2b8395ba: Revert "Re-land: Add new hidden option -print-changed which only reports….
Sep 17 2020, 1:33 AM
dyung committed rGb03c2b8395ba: Revert "Re-land: Add new hidden option -print-changed which only reports… (authored by dyung).
Revert "Re-land: Add new hidden option -print-changed which only reports…
Sep 17 2020, 1:33 AM
dyung added a reverting change for D86360: Add new hidden option -print-changed which only reports changes to IR: rGb03c2b8395ba: Revert "Re-land: Add new hidden option -print-changed which only reports….
Sep 17 2020, 1:33 AM · Restricted Project
dyung added a comment to D86360: Add new hidden option -print-changed which only reports changes to IR.

This commit seems to cause a test failure on some bots, e.g. here.

I think it was already fixed, the bot has been green for the last 2 runs.

Sep 17 2020, 12:17 AM · Restricted Project

Sep 2 2020

dyung added a comment to D86290: Move all fields of '-cc1' option related classes into def file databases.

I have reverted this change in 8d2d0e84857cb1f2d01456eb433b5172d3a0772b to get the build bots green again.

Sep 2 2020, 10:39 AM · Restricted Project
dyung added a reverting change for rGc4a2a1307484: Move all fields of '-cc1' option related classes into def file databases: rG8d2d0e84857c: Revert "Move all fields of '-cc1' option related classes into def file….
Sep 2 2020, 10:39 AM
dyung committed rG8d2d0e84857c: Revert "Move all fields of '-cc1' option related classes into def file… (authored by dyung).
Revert "Move all fields of '-cc1' option related classes into def file…
Sep 2 2020, 10:39 AM
dyung added a reverting change for D86290: Move all fields of '-cc1' option related classes into def file databases: rG8d2d0e84857c: Revert "Move all fields of '-cc1' option related classes into def file….
Sep 2 2020, 10:39 AM · Restricted Project

Sep 1 2020

dyung committed rGb1f394862053: Do not emit "-tune-cpu generic" for PS4 platform (authored by dyung).
Do not emit "-tune-cpu generic" for PS4 platform
Sep 1 2020, 12:38 PM
dyung closed D86965: Do not emit "-tune-cpu generic" for PS4 platform.
Sep 1 2020, 12:38 PM · Restricted Project
dyung requested review of D86965: Do not emit "-tune-cpu generic" for PS4 platform.
Sep 1 2020, 11:50 AM · Restricted Project

Aug 9 2020

dyung accepted D85624: [llvm-symbolizer] Add back --version and add a -v alias.

Looks good, thanks for fixing this for us!

Aug 9 2020, 11:53 PM · Restricted Project

Aug 5 2020

dyung committed rGbac1a0839f34: Fix typo in test. Thanks to Andrew Ng for spotting this! (authored by dyung).
Fix typo in test. Thanks to Andrew Ng for spotting this!
Aug 5 2020, 10:56 PM

Aug 4 2020

dyung added inline comments to D85148: Fix ARM build bots failures due to disabled x86_64-apple target.
Aug 4 2020, 1:17 AM · Restricted Project

Jul 29 2020

dyung abandoned D84885: Make test use a smaller file.

Thanks for the fix!

Jul 29 2020, 3:43 PM · Restricted Project, lld
dyung requested review of D84885: Make test use a smaller file.
Jul 29 2020, 12:30 PM · Restricted Project, lld

Jul 22 2020

dyung committed rGe0ee22884249: [clang][test] Fix test for external assemblers (authored by dyung).
[clang][test] Fix test for external assemblers
Jul 22 2020, 2:58 PM

Jul 8 2020

dyung committed rGf9888462cc76: Increase DIAG_SIZE_AST as we have hit it. (authored by dyung).
Increase DIAG_SIZE_AST as we have hit it.
Jul 8 2020, 11:30 PM

Jul 1 2020

dyung committed rG6f13299c02d4: Revert "Update lto.ll test after 3367e9da enabled multibyte NOPs in 64-bit mode. (authored by dyung).
Revert "Update lto.ll test after 3367e9da enabled multibyte NOPs in 64-bit mode.
Jul 1 2020, 4:46 PM
dyung added a reverting change for rG79f6a814ab93: Update lto.ll test after 3367e9da enabled multibyte NOPs in 64-bit mode.: rG6f13299c02d4: Revert "Update lto.ll test after 3367e9da enabled multibyte NOPs in 64-bit mode..
Jul 1 2020, 4:46 PM
dyung committed rG79f6a814ab93: Update lto.ll test after 3367e9da enabled multibyte NOPs in 64-bit mode. (authored by dyung).
Update lto.ll test after 3367e9da enabled multibyte NOPs in 64-bit mode.
Jul 1 2020, 4:45 PM

Jun 30 2020

dyung updated subscribers of rG56fc6b987ab8: Fixup BDVER1 and ZNVER1 definitions that were accidentally changed in recent….

@craig.topper, I made this fix after your refactor in 3537939cda86f0b5b06233eb99ddc9eb22935008. The main issue I wanted to bring to your attention is that you added FeatureLWP support to ZNVer1 which wasn't there before. If this is correct, please undo my change there. Thanks!

Jun 30 2020, 7:00 PM
dyung committed rG56fc6b987ab8: Fixup BDVER1 and ZNVER1 definitions that were accidentally changed in recent… (authored by dyung).
Fixup BDVER1 and ZNVER1 definitions that were accidentally changed in recent…
Jun 30 2020, 6:28 PM

Jun 6 2020

dyung committed rG059ba74bb6f6: Revert "[codeview] Put !heapallocsite on calls to operator new" (authored by dyung).
Revert "[codeview] Put !heapallocsite on calls to operator new"
Jun 6 2020, 5:04 PM
dyung added a reverting change for rG672ed5386024: [codeview] Put !heapallocsite on calls to operator new: rG059ba74bb6f6: Revert "[codeview] Put !heapallocsite on calls to operator new".
Jun 6 2020, 5:04 PM
dyung added a comment to D80966: [codeview] Put !heapallocsite on calls to operator new.

I've reverted this change in g059ba74bb6f6166ca7c1783ef81dd37a5209b758 to get the bots green again.

Jun 6 2020, 5:04 PM · Restricted Project

Jun 2 2020

dyung committed rG086be9fb2048: Fix test on PS4 linux bot. (authored by dyung).
Fix test on PS4 linux bot.
Jun 2 2020, 1:44 PM
dyung added a comment to D80931: AMDGPU: Fix clang side null pointer value for private.

Matt, this change to the test was causing a failure in the upstream PS4 linux bot here: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/68593

Jun 2 2020, 1:42 PM

May 23 2020

dyung added a comment to D76801: [AST] Print a<b<c>> without extra spaces in C++11 or later..

Hi, we noticed an issue with the GDB test suite that was bisected back to this change and I have put the details in PR46052. Can you take a look?

May 23 2020, 11:39 AM · Restricted Project

May 13 2020

dyung committed rG79af7314fbde: Fix PS4 build of compiler-rt runtime. (authored by dyung).
Fix PS4 build of compiler-rt runtime.
May 13 2020, 7:39 PM
dyung committed rG5435c5def24e: Add shim for fork() on PS4 as it is not supported there. (authored by dyung).
Add shim for fork() on PS4 as it is not supported there.
May 13 2020, 11:58 AM
dyung closed D79839: Add shim for fork() on PS4.
May 13 2020, 11:58 AM · Restricted Project

May 12 2020

dyung created D79839: Add shim for fork() on PS4.
May 12 2020, 11:57 PM · Restricted Project

Apr 30 2020

dyung committed rG046130490f23: Add header guards for header files that should not be included on the PS4… (authored by dyung).
Add header guards for header files that should not be included on the PS4…
Apr 30 2020, 4:40 PM
dyung closed D79194: Add header guards for header files that should not be included on the PS4 platform.
Apr 30 2020, 4:40 PM · Restricted Project
dyung added inline comments to D79194: Add header guards for header files that should not be included on the PS4 platform.
Apr 30 2020, 4:39 PM · Restricted Project
dyung updated the diff for D79194: Add header guards for header files that should not be included on the PS4 platform.

Removed REQUIRES line in test since it is not needed

Apr 30 2020, 4:39 PM · Restricted Project
dyung added inline comments to D79194: Add header guards for header files that should not be included on the PS4 platform.
Apr 30 2020, 3:06 PM · Restricted Project
dyung created D79194: Add header guards for header files that should not be included on the PS4 platform.
Apr 30 2020, 12:21 PM · Restricted Project

Apr 23 2020

dyung added a comment to D50078: clang-format: support aligned nested conditionals formatting.

Hi, this change that you submitted in commit 5daa25fd7a184524759b6ad065a8bd7e95aa149a seems to be causing the test "Clang-Unit :: Format/./FormatTests.exe/FormatTest.ConfigurableUseOfTab" to randomly fail about 50% of the time on Windows.

Take the most recent 5 runs of the llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast buildbot. Builds #31973, 31975 and 31976 all failed because of that test failing.

On my local Windows computer, if I build your commit and run the FormatTest unit test multiple times (the same binary without changing anything or rebuilding), that above test fails roughly 50% of the time.

Can you take a look to figure out why your change might be causing this instability?

Hi,
That is very strange indeed, nothing is supposed to be random here...
I will try to have a look, but I don't have a windows computer to test, and never seen this issue on linux/macos :-/

The linux (s390x arch) buildbot is also failing, http://lab.llvm.org:8011/builders/clang-s390x-linux/builds/31811/steps/ninja%20check%201/logs/stdio.
I reverted it in 47ef09e4848a970c530928496b54085cfdba5a76 to make buildbot happy.

Unfortunately I don't have access to either an s390x or a windows machine; is there a way to trigger a "private" build on buildbot, to use the same setup/build env ?
Or some other way to quickly get the required build env?

(Otherwise, could you please check if adding initialization of ConditionalsLevel to 0 in constructor of WhitespaceManager::Change class (WhitespaceManager.cpp:43).cpp fixes the issue ?)

Apr 23 2020, 10:16 AM · Restricted Project, Restricted Project

Apr 22 2020

dyung added a comment to D50078: clang-format: support aligned nested conditionals formatting.

Hi, this change that you submitted in commit 5daa25fd7a184524759b6ad065a8bd7e95aa149a seems to be causing the test "Clang-Unit :: Format/./FormatTests.exe/FormatTest.ConfigurableUseOfTab" to randomly fail about 50% of the time on Windows.

Apr 22 2020, 9:42 PM · Restricted Project, Restricted Project

Mar 31 2020

dyung committed rG41c135d6d288: Fix buildgo.sh script to fix linux build failure due to changes in ad1466f8cbc5. (authored by dyung).
Fix buildgo.sh script to fix linux build failure due to changes in ad1466f8cbc5.
Mar 31 2020, 10:00 AM
dyung closed D77111: Fix buildgo.sh script because of recent changes causing build failures with gcc on linux.
Mar 31 2020, 10:00 AM · Restricted Project

Mar 30 2020

dyung created D77111: Fix buildgo.sh script because of recent changes causing build failures with gcc on linux.
Mar 30 2020, 6:35 PM · Restricted Project

Mar 26 2020

dyung committed rG5db37f3bca3d: Make PS4 use -fno-use-init-array only as the ABI does not support .init_array. (authored by dyung).
Make PS4 use -fno-use-init-array only as the ABI does not support .init_array.
Mar 26 2020, 3:47 PM

Mar 25 2020

dyung committed rGd622612e618a: Relax newly added opcode checks to check only for a number instead of a… (authored by dyung).
Relax newly added opcode checks to check only for a number instead of a…
Mar 25 2020, 8:35 PM
dyung updated subscribers of D75849: [compiler-rt] Allow golang race detector to run on musl-c.

Hi @graywolf-at-work, @dvyukov

This change causes compiler-rt to fail to build lib/CMakeFiles/SanitizerLintCheck on Darwin with the following error:

clang-11: warning: include path for libstdc++ headers not found; pass '-stdlib=libc++' on the command line to use the libc++ standard library instead [-Wstdlibcxx-not-found]
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/nm: race_darwin_amd64.syso: No such file or directory.

Example: http://lab.llvm.org:8080/green/job/clang-stage1-RA/7900/consoleFull#-87031640a1ca8a51-895e-46c6-af87-ce24fa4cd561

Can you please take a look at this issue as soon as you can? Let me know if you need help reproducing this.

Apologies, I think I misdiagnosed the failure. I think there's another issue that follows the missing race_darwin_amd64.syso that is failing the build. I'll get back to you once I know more.

Mar 25 2020, 7:30 PM · Restricted Project, Restricted Project
dyung added inline comments to D75849: [compiler-rt] Allow golang race detector to run on musl-c.
Mar 25 2020, 6:58 PM · Restricted Project, Restricted Project

Mar 23 2020

dyung committed rG18e1a59eed55: Fix another instance where a variable was renamed in the generated LLVM IR. (authored by dyung).
Fix another instance where a variable was renamed in the generated LLVM IR.
Mar 23 2020, 11:22 PM
dyung committed rGe79b1ab65b8d: Make test more flexible for when the variable is renamed in the generated LLVM… (authored by dyung).
Make test more flexible for when the variable is renamed in the generated LLVM…
Mar 23 2020, 10:49 PM

Mar 9 2020

dyung committed rG54d82255fd27: Change tests to use -S instead of -c to work when an external assembler is used… (authored by dyung).
Change tests to use -S instead of -c to work when an external assembler is used…
Mar 9 2020, 4:13 PM
dyung closed D74104: Remove test dependency on the presence of an assembler.
Mar 9 2020, 4:13 PM · Restricted Project

Mar 2 2020

dyung added a comment to D74104: Remove test dependency on the presence of an assembler.

ping

Mar 2 2020, 8:24 PM · Restricted Project

Feb 27 2020

dyung committed rGb6f605cec5af: Change test to use -S so it works when an external assembler is used that is… (authored by dyung).
Change test to use -S so it works when an external assembler is used that is…
Feb 27 2020, 4:56 PM

Feb 20 2020

dyung added a comment to D74300: [ORC] Add generic initializer/deinitializer support..

I think there is still at least one bot failure due to this change:

Feb 20 2020, 1:49 AM · Restricted Project

Feb 19 2020

dyung committed rG6730f390a1fb: Fixup test after changes made in 709fd989. (authored by dyung).
Fixup test after changes made in 709fd989.
Feb 19 2020, 6:44 PM
dyung added a comment to D74791: Add a --shuffle-sections=seed option to lld.

It is also failing in at least 2 of the public bots:

Feb 19 2020, 5:01 PM · Restricted Project
dyung added a comment to D74790: [Sema][CodeComplete] Handle symlinks for include code completion.

`The test you added in this change seems to be failing on Windows, can you take a look?

Feb 19 2020, 1:10 PM · Restricted Project

Feb 6 2020

dyung committed rG02fffbb5fa9f: Fix test after test changes added in da3dc00 caused the test to break on… (authored by dyung).
Fix test after test changes added in da3dc00 caused the test to break on…
Feb 6 2020, 6:38 PM

Feb 5 2020

dyung created D74104: Remove test dependency on the presence of an assembler.
Feb 5 2020, 7:03 PM · Restricted Project

Jan 14 2020

dyung committed rGc6e69880ae4d: Modify test to use -S instead of -c so that it works when an external assembler… (authored by dyung).
Modify test to use -S instead of -c so that it works when an external assembler…
Jan 14 2020, 7:05 PM

Jan 9 2020

dyung committed rG3727ca313783: Relax opcode checks in test for G_READCYCLECOUNTER to check for only a number… (authored by dyung).
Relax opcode checks in test for G_READCYCLECOUNTER to check for only a number…
Jan 9 2020, 5:48 PM

Dec 12 2019

dyung committed rGbc0c60f714fc: Remove extra character I added to test my changes that I forgot to delete… (authored by dyung).
Remove extra character I added to test my changes that I forgot to delete…
Dec 12 2019, 6:25 PM
dyung committed rGb71475ff9ae0: Fix test to work correctly on 32-bit platforms. (authored by dyung).
Fix test to work correctly on 32-bit platforms.
Dec 12 2019, 5:29 PM

Dec 5 2019

dyung committed rGda650094b187: Fix build of LookupResult.cpp from aeda128 with Visual C++. (authored by dyung).
Fix build of LookupResult.cpp from aeda128 with Visual C++.
Dec 5 2019, 9:10 PM
dyung added a comment to D60499: [ASTImporter] Various source location and range import fixes..

This change caused the Import/namespace/struct-and-var/test.cpp test to fail on ARM due to an extra line with `-CXXRecordDecl being emitted by the compiler that was being matched instead of the intended line. I checked in a fix to tighten up the check a little more so that it gets the correct line in 757bc55. I don't think it should negatively affect the test, but please do review the change.

Dec 5 2019, 6:53 PM · Restricted Project
dyung committed rG757bc55f8314: Tighten up CHECK lines added in a9f10ebffa to work on ARM. (authored by dyung).
Tighten up CHECK lines added in a9f10ebffa to work on ARM.
Dec 5 2019, 6:44 PM

Nov 21 2019

dyung abandoned D70348: Add header guards for header files that should not be included on the PS4 platform.
Nov 21 2019, 2:10 AM · Restricted Project

Nov 15 2019

dyung added a comment to D70348: Add header guards for header files that should not be included on the PS4 platform.

You could probably just define add ORBIS to every line and then rely on the individual feature defines at the end of the line to re-enable the ones that are really supported. I assume the target-cpu is set to btver for ps4?

Nov 15 2019, 6:10 PM · Restricted Project
dyung created D70348: Add header guards for header files that should not be included on the PS4 platform.
Nov 15 2019, 3:42 PM · Restricted Project

Nov 12 2019

dyung committed rG7ebde1bf67da: Add a shim for setenv on PS4 since it does not exist. (authored by dyung).
Add a shim for setenv on PS4 since it does not exist.
Nov 12 2019, 3:29 PM
dyung closed D70033: Add a shim for setenv on PS4 since it does not exist on PS4.
Nov 12 2019, 3:29 PM · Restricted Project, Restricted Project

Nov 8 2019

dyung created D70033: Add a shim for setenv on PS4 since it does not exist on PS4.
Nov 8 2019, 3:56 PM · Restricted Project, Restricted Project

Oct 21 2019

dyung accepted D69196: Fix lld detection in standalone compiler-rt..

I tried applying this to our internal sources and it worked, so LGTM as well.

Oct 21 2019, 11:05 AM · Restricted Project, Restricted Project

Oct 18 2019

dyung added a comment to D69196: Fix lld detection in standalone compiler-rt..

Sorry for breaking this, I thought the change would be trivial, guess it was not. From what I can remember, Peter's change was causing our internal testing to break because we don't build/use LLD for our platform.

Oct 18 2019, 3:27 PM · Restricted Project, Restricted Project

Oct 11 2019

dyung committed rG0bb06f6f667e: Slightly relax restriction on exact order arguments must appear. (authored by dyung).
Slightly relax restriction on exact order arguments must appear.
Oct 11 2019, 7:27 PM
dyung committed rL374627: Slightly relax restriction on exact order arguments must appear..
Slightly relax restriction on exact order arguments must appear.
Oct 11 2019, 7:27 PM

Sep 30 2019

dyung committed rL373270: Request access for Douglas Yung.
Request access for Douglas Yung
Sep 30 2019, 3:47 PM

Sep 27 2019

dyung accepted D66176: Fix Driver/modules.cpp test to work when build directory name contains '.s'.

LGTM

Sep 27 2019, 2:22 PM · Restricted Project, Restricted Project

Sep 13 2019

dyung committed rG8607b93eabac: Make test check position independent as they sometimes come out reversed. NFCI. (authored by dyung).
Make test check position independent as they sometimes come out reversed. NFCI.
Sep 13 2019, 3:21 PM
dyung committed rL371904: Make test check position independent as they sometimes come out reversed. NFCI..
Make test check position independent as they sometimes come out reversed. NFCI.
Sep 13 2019, 3:11 PM

Sep 9 2019

dyung committed rG4bd6eb8ff201: Relax opcode checks in test to check for only a number instead of a specific… (authored by dyung).
Relax opcode checks in test to check for only a number instead of a specific…
Sep 9 2019, 1:15 PM
dyung committed rL371447: Relax opcode checks in test to check for only a number instead of a specific….
Relax opcode checks in test to check for only a number instead of a specific…
Sep 9 2019, 1:11 PM

Sep 8 2019

dyung committed rGdebac75deae3: Relax opcode checks in test to check for only a number instead of a specific… (authored by dyung).
Relax opcode checks in test to check for only a number instead of a specific…
Sep 8 2019, 6:22 PM
dyung committed rL371355: Relax opcode checks in test to check for only a number instead of a specific….
Relax opcode checks in test to check for only a number instead of a specific…
Sep 8 2019, 6:22 PM

Aug 30 2019

dyung added a comment to D66921: GlobalISel: Add known bits to InstructionSelector.

Is someone working on a fix for this that will go in soon? I am about to revert this change because it is blocking our internal builds as well as breaking both of the public PS4 bots.

Aug 30 2019, 10:13 AM

Aug 27 2019

dyung committed rGe816421087b4: Fixup build of clang-interpreter example after change in r370122. (authored by dyung).
Fixup build of clang-interpreter example after change in r370122.
Aug 27 2019, 7:13 PM
dyung committed rL370151: Fixup build of clang-interpreter example after change in r370122..
Fixup build of clang-interpreter example after change in r370122.
Aug 27 2019, 7:13 PM