Page MenuHomePhabricator

dyung (Douglas Yung)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 4 2016, 4:47 PM (275 w, 1 d)

Recent Activity

Tue, Jun 8

dyung added a comment to D102736: Fix tmp files being left on Windows builds..

Hi Amy, after your change, the compile time for one of our internal test files went from about 1 second to 30 seconds. I have put a repro and the details in PR50628, can you please take a look?

Tue, Jun 8, 5:17 PM · Restricted Project, Restricted Project

Sat, Jun 5

dyung added a comment to D103315: Add interface to order inlining.

This change appears to be causing 6 or 7 lit tests to hang. Can you take a look and fix or revert?

Sat, Jun 5, 10:53 PM · Restricted Project

Tue, Jun 1

dyung committed rG18225d45769b: Mark test as requiring asserts. (authored by dyung).
Mark test as requiring asserts.
Tue, Jun 1, 2:04 AM

Wed, May 26

dyung added a comment to D101555: [SLP]Improve handling of compensate external uses cost..

Hi, we are noticing a regression in the quality of the code generated by the compiler for btver2 after this change.

Wed, May 26, 2:31 AM · Restricted Project
dyung added a comment to D101555: [SLP]Improve handling of compensate external uses cost..
Wed, May 26, 2:21 AM · Restricted Project

Wed, May 19

dyung added a comment to D102542: [GlobalISel] Simplify G_ICMP to true/false when the result is known.

We're seeing a test failure in prelegalizer-combiner-icmp-to-true-false-known-bits.mir on our 2-stage LTO builder:

FAIL: LLVM :: CodeGen/AArch64/GlobalISel/prelegalizer-combiner-icmp-to-true-false-known-bits.mir (2029 of 43749)
******************** TEST 'LLVM :: CodeGen/AArch64/GlobalISel/prelegalizer-combiner-icmp-to-true-false-known-bits.mir' FAILED ********************
Script:
--
: 'RUN: at line 2';   /b/s/w/ir/x/w/staging/llvm_build/tools/clang/stage2-bins/bin/llc -debugify-and-strip-all-safe -mtriple aarch64 -run-pass=aarch64-prelegalizer-combiner --aarch64prelegalizercombinerhelper-only-enable-rule="icmp_to_true_false_known_bits" -global-isel -verify-machineinstrs /b/s/w/ir/x/w/llvm-project/llvm/test/CodeGen/AArch64/GlobalISel/prelegalizer-combiner-icmp-to-true-false-known-bits.mir -o - | /b/s/w/ir/x/w/staging/llvm_build/tools/clang/stage2-bins/bin/FileCheck /b/s/w/ir/x/w/llvm-project/llvm/test/CodeGen/AArch64/GlobalISel/prelegalizer-combiner-icmp-to-true-false-known-bits.mir
--
Exit Code: 2

Command Output (stderr):
--
LLVM ERROR: Invalid rule identifier
FileCheck error: '<stdin>' is empty.
FileCheck command line:  /b/s/w/ir/x/w/staging/llvm_build/tools/clang/stage2-bins/bin/FileCheck /b/s/w/ir/x/w/llvm-project/llvm/test/CodeGen/AArch64/GlobalISel/prelegalizer-combiner-icmp-to-true-false-known-bits.mir

--

Would it be possible to revert the change unless the issue can be addressed quickly?

Wed, May 19, 1:13 AM · Restricted Project

Tue, May 18

dyung added a comment to D98714: [SLP] Add insertelement instructions to vectorizable tree.

Hi, this change has caused a regression in the codegen for one of our internal tests. Consider the following code:

__attribute__((noinline))
__m256d add_pd_002(__m256d a, __m256d b) {
  __m256d r = (__m256d){ a[0] + a[1], a[2] + a[3], b[0] + b[1], b[2] + b[3] };
  return __builtin_shufflevector(r, a, 0, -1, 2, 3);
}

If you compile this with "-g0 -O3 -march=btver2", prior to your commit the compiler would generate the following code for the function:

# %bb.0:                                # %entry
        vinsertf128     $1, %xmm1, %ymm0, %ymm0
        vhaddpd %ymm1, %ymm0, %ymm0

But after your change it is now generating the following code:

# %bb.0:                                # %entry
        vextractf128    $1, %ymm1, %xmm2
        vhaddpd %xmm0, %xmm0, %xmm0
        vhaddpd %xmm2, %xmm1, %xmm1
        vperm2f128      $2, %ymm0, %ymm1, %ymm0 # ymm0 = ymm0[0,1],ymm1[0,1]

From your commit description, it sounds like this is expected and will be fixed in a follow-up commit. Is my understanding of this correct?

I see a different result for btver2.

# %bb.0:
        vextractf128    $1, %ymm1, %xmm2
        vhaddpd %xmm1, %xmm0, %xmm0
        vhaddpd %xmm2, %xmm1, %xmm1
        vinsertf128     $1, %xmm1, %ymm0, %ymm0

But I used llvm-11, most probably there is a difference with llvm-12.

Currently, it is impossible to fix this issue. This problem will be fixed after non-power-2 vectorization support in SLP is landed since here we have a build vector of 3 elements (the second index in shuffle is -1 and thus the second sum is optimized out resulting in the build of <4 x double> vector using just 3 insertelement instructions). Looks like previously this patter was recognized by another transformation pass but currently SLP tries to vectorize it

Tue, May 18, 10:28 AM · Restricted Project
dyung added a comment to D98714: [SLP] Add insertelement instructions to vectorizable tree.

Hi, this change has caused a regression in the codegen for one of our internal tests. Consider the following code:

__attribute__((noinline))
__m256d add_pd_002(__m256d a, __m256d b) {
  __m256d r = (__m256d){ a[0] + a[1], a[2] + a[3], b[0] + b[1], b[2] + b[3] };
  return __builtin_shufflevector(r, a, 0, -1, 2, 3);
}

If you compile this with "-g0 -O3 -march=btver2", prior to your commit the compiler would generate the following code for the function:

# %bb.0:                                # %entry
        vinsertf128     $1, %xmm1, %ymm0, %ymm0
        vhaddpd %ymm1, %ymm0, %ymm0

But after your change it is now generating the following code:

# %bb.0:                                # %entry
        vextractf128    $1, %ymm1, %xmm2
        vhaddpd %xmm0, %xmm0, %xmm0
        vhaddpd %xmm2, %xmm1, %xmm1
        vperm2f128      $2, %ymm0, %ymm1, %ymm0 # ymm0 = ymm0[0,1],ymm1[0,1]

From your commit description, it sounds like this is expected and will be fixed in a follow-up commit. Is my understanding of this correct?

Hi, could you check if D101555 fixes this issue?

Tue, May 18, 2:17 AM · Restricted Project

Mon, May 17

dyung added a comment to D98714: [SLP] Add insertelement instructions to vectorizable tree.

Hi, this change has caused a regression in the codegen for one of our internal tests. Consider the following code:

Mon, May 17, 4:42 PM · Restricted Project

Fri, May 14

dyung added a comment to D102489: [Clang,Driver] Add -fveclib=Darwin_libsystem_m support..

The test added in this commit was failing on the PS4 bot (https://lab.llvm.org/buildbot/#/builders/139/builds/4059). I've reverted the change in 59b419adc6e608db8d7c31efcc37f34c0b57b7d0 to get the bot green again.

Fri, May 14, 10:42 PM · Restricted Project
dyung added a reverting change for rG187a14e1f399: [Clang,Driver] Add -fveclib=Darwin_libsystem_m support.: rG59b419adc6e6: Revert "[Clang,Driver] Add -fveclib=Darwin_libsystem_m support.".
Fri, May 14, 10:42 PM
dyung committed rG59b419adc6e6: Revert "[Clang,Driver] Add -fveclib=Darwin_libsystem_m support." (authored by dyung).
Revert "[Clang,Driver] Add -fveclib=Darwin_libsystem_m support."
Fri, May 14, 10:41 PM
dyung added a reverting change for D102489: [Clang,Driver] Add -fveclib=Darwin_libsystem_m support.: rG59b419adc6e6: Revert "[Clang,Driver] Add -fveclib=Darwin_libsystem_m support.".
Fri, May 14, 10:41 PM · Restricted Project

May 6 2021

dyung added inline comments to D101259: [clang-tidy] Fix cppcoreguidelines-pro-type-vararg false positives with __builtin_ms_va_list.
May 6 2021, 9:38 AM · Restricted Project

Apr 27 2021

dyung added a comment to D101218: [lld/mac] add test coverage for -sectcreate and -order_file with --reproduce.

Hi, the file you create here sectdata.txt is being flagged as a virus by Windows Defender in our internal bot causing the file to be automatically deleted and the test to fail. Is there a reason why you need to use that particular string for the file? Can something else be used that won't trigger the antivirus?

Apr 27 2021, 12:46 PM · Restricted Project, Restricted Project

Apr 14 2021

dyung added a comment to D97196: [clang-tidy] Add new check 'bugprone-unhandled-exception-at-new'..

This appears to be failing on the PS4 linux bot likely due to the PS4 target has exceptions disabled by default. Can you take a look?

Apr 14 2021, 12:36 AM · Restricted Project, Restricted Project

Mar 31 2021

dyung added a comment to D99556: Add support to -Wa,--version in clang.

It also fails with the PS4 triple because we default to an external assembler that isn't present: https://lab.llvm.org/buildbot/#/builders/139/builds/2161/steps/6/logs/FAIL__Clang__as-version_s

Mar 31 2021, 6:32 PM · Restricted Project

Mar 30 2021

dyung committed rGc5109d3c7936: Fix path in test added in e0577b3130a646b0ee090c04a40400483031c7a9 to work with… (authored by dyung).
Fix path in test added in e0577b3130a646b0ee090c04a40400483031c7a9 to work with…
Mar 30 2021, 4:19 AM

Mar 9 2021

dyung committed rG6a7a20835774: Add requirement for aarch64-registered-target to test change added in… (authored by dyung).
Add requirement for aarch64-registered-target to test change added in…
Mar 9 2021, 12:27 PM

Mar 8 2021

dyung added a comment to D86377: [tsan] Use large address space mapping on Apple Silicon Macs.

Hi, our internal x86_64 linux builder is failing after your commit with the error:

Mar 8 2021, 1:54 AM · Restricted Project

Feb 24 2021

dyung added a comment to D96565: [lld-macho] Fix cpuSubtype for non-x86_64 archs.

FYI, arm64 is aarch64, not arm I believe. I've updated a few tests you added to reflect that.

Feb 24 2021, 2:29 AM · Restricted Project, Restricted Project
dyung committed rG691c3d59484f: Update REQUIRES line in 4 tests that attempt to use arm64 which should be… (authored by dyung).
Update REQUIRES line in 4 tests that attempt to use arm64 which should be…
Feb 24 2021, 2:26 AM
dyung committed rG91e31ebbbe0c: Add REQUIRES aarch64 to test incompatible-arch.s since it fails if that target… (authored by dyung).
Add REQUIRES aarch64 to test incompatible-arch.s since it fails if that target…
Feb 24 2021, 12:05 AM

Feb 21 2021

dyung closed D97180: Add myself to be notified for sie-linux-builder failures..
Feb 21 2021, 11:38 PM · Restricted Project
dyung committed rZORG84a9d7a9404c: Have the buildbot email me when there is a failure on the sie-linux-builder… (authored by dyung).
Have the buildbot email me when there is a failure on the sie-linux-builder…
Feb 21 2021, 11:38 PM
dyung requested review of D97180: Add myself to be notified for sie-linux-builder failures..
Feb 21 2021, 11:23 PM · Restricted Project

Feb 16 2021

dyung added a comment to D96346: [NFC][PPC] Refactor TOC representation to allow several entries for the same symbol.

Unfortunately it fails to build with GCC which LLVM still tries to stay compatible with:
http://lab.llvm.org:8014/#/builders/16/builds/2211
gcc-11.0.0-0.19.fc34.x86_64
gcc-10.2.1-9.fc33.x86_64
llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:86:8: error: explicit specialization of 'template<class T> struct llvm::DenseMapInfo' outside its namespace must use a nested-name-specifier [-fpermissive]

86 | struct DenseMapInfo<std::pair<const MCSymbol *, MCSymbolRefExpr::VariantKind>> {
   |        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

I have filed it to an existing GCC bugreport: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92598

Feb 16 2021, 11:21 PM · Restricted Project, Restricted Project
dyung committed rG0e3d7e61867d: Fix gcc build after de3a485d9 due to a gcc bug: https://gcc.gnu. (authored by dyung).
Fix gcc build after de3a485d9 due to a gcc bug: https://gcc.gnu.
Feb 16 2021, 10:02 PM

Feb 11 2021

dyung committed rG7b4832648a63: NFCI. With the move to the new pass manager by default, sanitize-coverage.c is… (authored by dyung).
NFCI. With the move to the new pass manager by default, sanitize-coverage.c is…
Feb 11 2021, 1:19 PM

Feb 9 2021

dyung added a comment to D95915: [clang][driver] Only warn once about invalid -stdlib value.

It also failed on the PS4 linux bot: http://lab.llvm.org:8014/#/builders/125/builds/125

Feb 9 2021, 10:59 PM · Restricted Project

Feb 8 2021

dyung committed rG4c23e42fe5b4: Mark 4 tests added in 6d766c8bf9df as requiring an x86 backend as they fail… (authored by dyung).
Mark 4 tests added in 6d766c8bf9df as requiring an x86 backend as they fail…
Feb 8 2021, 10:50 PM

Feb 5 2021

dyung closed D94885: Add SIE linux build bot.
Feb 5 2021, 1:07 AM · Restricted Project
dyung committed rZORGb7b17e18b1b1: Add worker sie-linux-builder and builder llvm-clang-x86_64-sie-ubuntu-fast. (authored by dyung).
Add worker sie-linux-builder and builder llvm-clang-x86_64-sie-ubuntu-fast.
Feb 5 2021, 1:07 AM

Jan 29 2021

dyung added a comment to D95660: [NFC] Disallow unused prefixes under clang/test/Driver.

PS4 changes lgtm.

Jan 29 2021, 11:30 AM · Restricted Project

Jan 22 2021

dyung updated the diff for D94885: Add SIE linux build bot.

Updated patch with review feedback.

Jan 22 2021, 12:28 AM · Restricted Project
dyung added a comment to D94885: Add SIE linux build bot.

Thanks, I'll update my patch with your suggestions. I think I was using an older template for the jobs which is why I was using outdated stuff. Sorry about that!

Jan 22 2021, 12:27 AM · Restricted Project
dyung committed rGf20bb857adda: Update filename to workers.py file in documentation (authored by dyung).
Update filename to workers.py file in documentation
Jan 22 2021, 12:21 AM
dyung closed D94886: Update name to workers.py file in documentation.
Jan 22 2021, 12:21 AM · Restricted Project

Jan 19 2021

dyung updated the diff for D94885: Add SIE linux build bot.

Update removing some unneeded stuff.

Jan 19 2021, 3:31 AM · Restricted Project

Jan 17 2021

dyung requested review of D94886: Update name to workers.py file in documentation.
Jan 17 2021, 11:59 AM · Restricted Project
dyung requested review of D94885: Add SIE linux build bot.
Jan 17 2021, 11:53 AM · Restricted Project

Jan 15 2021

dyung committed rGbe68c9222b85: [NFC] Add -std=c11 to attr-availability.c (authored by dyung).
[NFC] Add -std=c11 to attr-availability.c
Jan 15 2021, 9:06 PM
dyung closed D94829: [NFC] Add -std=c11 to attr-availability.c.
Jan 15 2021, 9:06 PM · Restricted Project
dyung accepted D94829: [NFC] Add -std=c11 to attr-availability.c.

lgtm

Jan 15 2021, 2:44 PM · Restricted Project

Jan 14 2021

dyung committed rGf85b1531666d: Add -fexceptions to test as it uses them and fails on platforms where it is not… (authored by dyung).
Add -fexceptions to test as it uses them and fails on platforms where it is not…
Jan 14 2021, 1:27 PM

Dec 18 2020

dyung added a comment to D93559: Rename files with same (case insensitive) name.

This issue also affects Windows, so please commit this change.

Dec 18 2020, 12:22 PM · Restricted Project

Dec 7 2020

dyung committed rGccc5160df100: Fixup test in path to use C:\ instead of D:\ which may be mapped to a removable. (authored by dyung).
Fixup test in path to use C:\ instead of D:\ which may be mapped to a removable.
Dec 7 2020, 4:44 PM
dyung closed D92787: Update missing_pdb.test input binary to point to a more likely non-removable media path.
Dec 7 2020, 4:44 PM · Restricted Project
dyung updated the summary of D92787: Update missing_pdb.test input binary to point to a more likely non-removable media path.
Dec 7 2020, 2:09 PM · Restricted Project
dyung requested review of D92787: Update missing_pdb.test input binary to point to a more likely non-removable media path.
Dec 7 2020, 2:08 PM · Restricted Project

Nov 23 2020

dyung added a comment to D91058: [DebugInfo] Refactor code for emitting DWARF expressions for FP constants.

Hi Pavel, your change caused an assertion failure to be hit in our internal test suite. I have filed a repro with the assertion failure and a callstack in PR48277. Can you please take a look?

Nov 23 2020, 6:53 PM · Restricted Project

Nov 13 2020

dyung added a comment to D89755: [fuzzer] Add Windows Visual C++ exception intercept.

The fix would normally be put in a separate change. If it is a small change, you could probably just do a post-commit review. We would like to get this either fixed or reverted so that we can get our internal build bot green again.

Nov 13 2020, 5:29 PM · Restricted Project

Oct 21 2020

dyung added a reverting change for rG5e656ee48bcc: Add "not" to an llvm-symbolizer test that expects to fail: rGade107360f59: Revert "Add "not" to an llvm-symbolizer test that expects to fail".
Oct 21 2020, 10:00 PM
dyung committed rGade107360f59: Revert "Add "not" to an llvm-symbolizer test that expects to fail" (authored by dyung).
Revert "Add "not" to an llvm-symbolizer test that expects to fail"
Oct 21 2020, 10:00 PM

Oct 19 2020

dyung committed rG774ab60125ee: Add option to use older clang ABI behavior when passing certain union types as… (authored by dyung).
Add option to use older clang ABI behavior when passing certain union types as…
Oct 19 2020, 6:26 PM
dyung closed D89747: Add option to use older clang ABI behavior when passing certain union types as function arguments.
Oct 19 2020, 6:25 PM · Restricted Project
dyung added a comment to D89747: Add option to use older clang ABI behavior when passing certain union types as function arguments.

Sorry for the lack of context, I made my diffs using a new method this time, but I'll make sure it has the full context next time. Thanks!

Oct 19 2020, 6:02 PM · Restricted Project
dyung requested review of D89747: Add option to use older clang ABI behavior when passing certain union types as function arguments.
Oct 19 2020, 3:28 PM · Restricted Project

Oct 13 2020

dyung accepted D89361: [X86][NFC] Fix RUN line bug in the testcase.

LGTM as well. I also tested it and it fails before your change, and passes with your change.

Oct 13 2020, 9:34 PM · Restricted Project
dyung added inline comments to D78699: [X86] Passing union type through register..
Oct 13 2020, 2:31 PM · Restricted Project
dyung added a comment to D78699: [X86] Passing union type through register..

Hi, the test you added seems to pass both before and after your change, is this intended?

Oct 13 2020, 1:45 PM · Restricted Project

Oct 7 2020

dyung committed rGea274be72be1: Add REQUIRES: x86-registered-target to test as it was failing on build bots… (authored by dyung).
Add REQUIRES: x86-registered-target to test as it was failing on build bots…
Oct 7 2020, 12:29 PM

Oct 2 2020

dyung committed rG24f406e6d39b: Relax newly added opcode alias check to check only for a number instead of a… (authored by dyung).
Relax newly added opcode alias check to check only for a number instead of a…
Oct 2 2020, 12:19 PM

Sep 17 2020

dyung added a comment to D86360: Add new hidden option -print-changed which only reports changes to IR.

I have reverted this change and the follow-up commit in b03c2b8395ba94fb53f1e73a6473faedf628bbd9. Hopefully this should get the bots green again.

Sep 17 2020, 1:34 AM · Restricted Project
dyung added a reverting change for rGf9e6d1edc0da: Re-land: Add new hidden option -print-changed which only reports changes to IR: rGb03c2b8395ba: Revert "Re-land: Add new hidden option -print-changed which only reports….
Sep 17 2020, 1:33 AM
dyung committed rGb03c2b8395ba: Revert "Re-land: Add new hidden option -print-changed which only reports… (authored by dyung).
Revert "Re-land: Add new hidden option -print-changed which only reports…
Sep 17 2020, 1:33 AM
dyung added a reverting change for D86360: Add new hidden option -print-changed which only reports changes to IR: rGb03c2b8395ba: Revert "Re-land: Add new hidden option -print-changed which only reports….
Sep 17 2020, 1:33 AM · Restricted Project
dyung added a comment to D86360: Add new hidden option -print-changed which only reports changes to IR.

This commit seems to cause a test failure on some bots, e.g. here.

I think it was already fixed, the bot has been green for the last 2 runs.

Sep 17 2020, 12:17 AM · Restricted Project

Sep 2 2020

dyung added a comment to D86290: Move all fields of '-cc1' option related classes into def file databases.

I have reverted this change in 8d2d0e84857cb1f2d01456eb433b5172d3a0772b to get the build bots green again.

Sep 2 2020, 10:39 AM · Restricted Project
dyung added a reverting change for rGc4a2a1307484: Move all fields of '-cc1' option related classes into def file databases: rG8d2d0e84857c: Revert "Move all fields of '-cc1' option related classes into def file….
Sep 2 2020, 10:39 AM
dyung committed rG8d2d0e84857c: Revert "Move all fields of '-cc1' option related classes into def file… (authored by dyung).
Revert "Move all fields of '-cc1' option related classes into def file…
Sep 2 2020, 10:39 AM
dyung added a reverting change for D86290: Move all fields of '-cc1' option related classes into def file databases: rG8d2d0e84857c: Revert "Move all fields of '-cc1' option related classes into def file….
Sep 2 2020, 10:39 AM · Restricted Project

Sep 1 2020

dyung committed rGb1f394862053: Do not emit "-tune-cpu generic" for PS4 platform (authored by dyung).
Do not emit "-tune-cpu generic" for PS4 platform
Sep 1 2020, 12:38 PM
dyung closed D86965: Do not emit "-tune-cpu generic" for PS4 platform.
Sep 1 2020, 12:38 PM · Restricted Project
dyung requested review of D86965: Do not emit "-tune-cpu generic" for PS4 platform.
Sep 1 2020, 11:50 AM · Restricted Project

Aug 9 2020

dyung accepted D85624: [llvm-symbolizer] Add back --version and add a -v alias.

Looks good, thanks for fixing this for us!

Aug 9 2020, 11:53 PM · Restricted Project

Aug 5 2020

dyung committed rGbac1a0839f34: Fix typo in test. Thanks to Andrew Ng for spotting this! (authored by dyung).
Fix typo in test. Thanks to Andrew Ng for spotting this!
Aug 5 2020, 10:56 PM

Aug 4 2020

dyung added inline comments to D85148: Fix ARM build bots failures due to disabled x86_64-apple target.
Aug 4 2020, 1:17 AM · Restricted Project

Jul 29 2020

dyung abandoned D84885: Make test use a smaller file.

Thanks for the fix!

Jul 29 2020, 3:43 PM · Restricted Project, lld
dyung requested review of D84885: Make test use a smaller file.
Jul 29 2020, 12:30 PM · Restricted Project, lld

Jul 22 2020

dyung committed rGe0ee22884249: [clang][test] Fix test for external assemblers (authored by dyung).
[clang][test] Fix test for external assemblers
Jul 22 2020, 2:58 PM

Jul 8 2020

dyung committed rGf9888462cc76: Increase DIAG_SIZE_AST as we have hit it. (authored by dyung).
Increase DIAG_SIZE_AST as we have hit it.
Jul 8 2020, 11:30 PM

Jul 1 2020

dyung committed rG6f13299c02d4: Revert "Update lto.ll test after 3367e9da enabled multibyte NOPs in 64-bit mode. (authored by dyung).
Revert "Update lto.ll test after 3367e9da enabled multibyte NOPs in 64-bit mode.
Jul 1 2020, 4:46 PM
dyung added a reverting change for rG79f6a814ab93: Update lto.ll test after 3367e9da enabled multibyte NOPs in 64-bit mode.: rG6f13299c02d4: Revert "Update lto.ll test after 3367e9da enabled multibyte NOPs in 64-bit mode..
Jul 1 2020, 4:46 PM
dyung committed rG79f6a814ab93: Update lto.ll test after 3367e9da enabled multibyte NOPs in 64-bit mode. (authored by dyung).
Update lto.ll test after 3367e9da enabled multibyte NOPs in 64-bit mode.
Jul 1 2020, 4:45 PM

Jun 30 2020

dyung updated subscribers of rG56fc6b987ab8: Fixup BDVER1 and ZNVER1 definitions that were accidentally changed in recent….

@craig.topper, I made this fix after your refactor in 3537939cda86f0b5b06233eb99ddc9eb22935008. The main issue I wanted to bring to your attention is that you added FeatureLWP support to ZNVer1 which wasn't there before. If this is correct, please undo my change there. Thanks!

Jun 30 2020, 7:00 PM
dyung committed rG56fc6b987ab8: Fixup BDVER1 and ZNVER1 definitions that were accidentally changed in recent… (authored by dyung).
Fixup BDVER1 and ZNVER1 definitions that were accidentally changed in recent…
Jun 30 2020, 6:28 PM

Jun 6 2020

dyung committed rG059ba74bb6f6: Revert "[codeview] Put !heapallocsite on calls to operator new" (authored by dyung).
Revert "[codeview] Put !heapallocsite on calls to operator new"
Jun 6 2020, 5:04 PM
dyung added a reverting change for rG672ed5386024: [codeview] Put !heapallocsite on calls to operator new: rG059ba74bb6f6: Revert "[codeview] Put !heapallocsite on calls to operator new".
Jun 6 2020, 5:04 PM
dyung added a comment to D80966: [codeview] Put !heapallocsite on calls to operator new.

I've reverted this change in g059ba74bb6f6166ca7c1783ef81dd37a5209b758 to get the bots green again.

Jun 6 2020, 5:04 PM · Restricted Project

Jun 2 2020

dyung committed rG086be9fb2048: Fix test on PS4 linux bot. (authored by dyung).
Fix test on PS4 linux bot.
Jun 2 2020, 1:44 PM
dyung added a comment to D80931: AMDGPU: Fix clang side null pointer value for private.

Matt, this change to the test was causing a failure in the upstream PS4 linux bot here: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/68593

Jun 2 2020, 1:42 PM

May 23 2020

dyung added a comment to D76801: [AST] Print a<b<c>> without extra spaces in C++11 or later..

Hi, we noticed an issue with the GDB test suite that was bisected back to this change and I have put the details in PR46052. Can you take a look?

May 23 2020, 11:39 AM · Restricted Project

May 13 2020

dyung committed rG79af7314fbde: Fix PS4 build of compiler-rt runtime. (authored by dyung).
Fix PS4 build of compiler-rt runtime.
May 13 2020, 7:39 PM
dyung committed rG5435c5def24e: Add shim for fork() on PS4 as it is not supported there. (authored by dyung).
Add shim for fork() on PS4 as it is not supported there.
May 13 2020, 11:58 AM
dyung closed D79839: Add shim for fork() on PS4.
May 13 2020, 11:58 AM · Restricted Project

May 12 2020

dyung created D79839: Add shim for fork() on PS4.
May 12 2020, 11:57 PM · Restricted Project

Apr 30 2020

dyung committed rG046130490f23: Add header guards for header files that should not be included on the PS4… (authored by dyung).
Add header guards for header files that should not be included on the PS4…
Apr 30 2020, 4:40 PM
dyung closed D79194: Add header guards for header files that should not be included on the PS4 platform.
Apr 30 2020, 4:40 PM · Restricted Project
dyung added inline comments to D79194: Add header guards for header files that should not be included on the PS4 platform.
Apr 30 2020, 4:39 PM · Restricted Project