Page MenuHomePhabricator

[Dexter] add normcase conversion to visual studio's 'delete conditional breakpoint' method
AcceptedPublic

Authored by TWeaver on Jan 20 2021, 6:54 AM.

Details

Summary

Visual studio debugger breakpoints sometimes have uppercase or lowercase drive letters.

This quick fix simply normcases the parameter passed to _delete_conditional_breakpoint as well as the bound breakpoints File attribute for comparision.

Diff Detail

Event Timeline

TWeaver requested review of this revision.Jan 20 2021, 6:54 AM
TWeaver created this revision.

This looks good to me - does this need a test case?

TWeaver updated this revision to Diff 319267.Jan 26 2021, 4:17 AM

Added more context to diff

This looks good to me - does this need a test case?

I would argue this is minor enough to go in without one, but I'm happy to add one if you feel strongly in favour for a test going in too.

I would argue this is minor enough to go in without one, but I'm happy to add one if you feel strongly in favour for a test going in too.

I'm not especially concerned about it, it does seem like it might be needless bloat - if anyone else disagrees however I'm not opposed to the adding of a test either, especially if there aren't many unit tests around here.

jmorse accepted this revision.Jan 27 2021, 8:41 AM

IMO: change is fine, case sensitiveness on Windows is a more general problem that should be addressed generally. (We'll need to revisit this later).

This revision is now accepted and ready to land.Jan 27 2021, 8:41 AM