Page MenuHomePhabricator

TWeaver (Tom Weaver)
User

Projects

User does not belong to any projects.

User Details

User Since
May 29 2018, 4:24 AM (139 w, 1 d)

Recent Activity

Yesterday

TWeaver added a comment to D95045: [Dexter] add normcase conversion to visual studio's 'delete conditional breakpoint' method.

This looks good to me - does this need a test case?

Tue, Jan 26, 4:19 AM · debug-info
TWeaver updated the diff for D95045: [Dexter] add normcase conversion to visual studio's 'delete conditional breakpoint' method.

Added more context to diff

Tue, Jan 26, 4:17 AM · debug-info

Wed, Jan 20

TWeaver updated subscribers of D95045: [Dexter] add normcase conversion to visual studio's 'delete conditional breakpoint' method.
Wed, Jan 20, 7:09 AM · debug-info
TWeaver requested review of D95045: [Dexter] add normcase conversion to visual studio's 'delete conditional breakpoint' method.
Wed, Jan 20, 6:54 AM · debug-info

Tue, Jan 5

TWeaver added a comment to D91737: [Dexter] Avoid potentially infinite loop in dbgeng driver.

The "go" method of Debugger classes in Dexter used to be called once, to launch the process. However with the new DebuggerController classes it's now used to set the target process free running until we hit a relevant source line. Alas, I'd baked the former assumption into the DbgEng driver and had the "go" method do nothing. This can lead to an infinite loop where the DebuggerController repeatedly calls "go".

Tue, Jan 5, 9:32 AM · Restricted Project

Nov 6 2020

TWeaver accepted D90931: [debuginfo-tests] NFC: Move test that was committed to the wrong location.

LGTM. thanks for spotting this... <hangs head in shame>

Nov 6 2020, 5:22 AM · debug-info, Restricted Project

Nov 5 2020

TWeaver added a comment to D89803: [dexter] Add support for Visual Studio 2019 to Dexter.

@MaskRay duly noted, thanks for the info.

Nov 5 2020, 6:55 AM · Restricted Project, debug-info

Nov 4 2020

TWeaver committed rG3ebcef4b7377: [Dexter] add visual studio 2019 debugger support (authored by n-omer).
[Dexter] add visual studio 2019 debugger support
Nov 4 2020, 8:58 AM
TWeaver closed D89803: [dexter] Add support for Visual Studio 2019 to Dexter.
Nov 4 2020, 8:58 AM · Restricted Project, debug-info
TWeaver committed rG91c3c67c407d: [Dexter] add an optnone attribute debug experience test for loops. (authored by n-omer).
[Dexter] add an optnone attribute debug experience test for loops.
Nov 4 2020, 8:55 AM
TWeaver closed D89873: [debuginfo-tests] [dexter] Add test to check debug experience with __attribute__((optnone)).
Nov 4 2020, 8:55 AM · Restricted Project, debug-info

Nov 3 2020

TWeaver added a comment to D89873: [debuginfo-tests] [dexter] Add test to check debug experience with __attribute__((optnone)).

I'll get this committed for you shortly.

Nov 3 2020, 6:32 AM · Restricted Project, debug-info
TWeaver accepted D89873: [debuginfo-tests] [dexter] Add test to check debug experience with __attribute__((optnone)).

Hey Nabeel, thanks for this.

Nov 3 2020, 6:32 AM · Restricted Project, debug-info

Oct 29 2020

TWeaver added a comment to D89462: [debuginfo-tests] [dexter] Add tests to check debug experience.

fix for any builds that don't have lldb available:

Oct 29 2020, 4:45 AM · Restricted Project, debug-info

Oct 28 2020

TWeaver committed rGf2f4554f8804: [debuginfo-tests][dexter] add requires lldb to two tests (authored by TWeaver).
[debuginfo-tests][dexter] add requires lldb to two tests
Oct 28 2020, 10:34 AM
TWeaver accepted D89803: [dexter] Add support for Visual Studio 2019 to Dexter.

Hi Nabeel,

Oct 28 2020, 8:36 AM · Restricted Project, debug-info
TWeaver committed rGafc44efc262b: [debuginfo-tests][dexter] Add two new debug experience tests (authored by n-omer).
[debuginfo-tests][dexter] Add two new debug experience tests
Oct 28 2020, 7:24 AM
TWeaver closed D89462: [debuginfo-tests] [dexter] Add tests to check debug experience.
Oct 28 2020, 7:23 AM · Restricted Project, debug-info
TWeaver added a comment to D89462: [debuginfo-tests] [dexter] Add tests to check debug experience.

Hi Nabeel,

Oct 28 2020, 7:08 AM · Restricted Project, debug-info

Oct 21 2020

TWeaver closed D89689: [debuginfo-tests] [dexter] Add missing entries to the dexter docs table of contents.
Oct 21 2020, 5:59 AM · debug-info
TWeaver added a project to D89803: [dexter] Add support for Visual Studio 2019 to Dexter: debug-info.
Oct 21 2020, 5:59 AM · Restricted Project, debug-info

Oct 20 2020

TWeaver added a comment to rG7d8c19a4e9ed: [Dexter][NFC] Add Missing Commands to Commands.md Contents.

https://reviews.llvm.org/D89689

Oct 20 2020, 3:21 AM
TWeaver added a comment to D89689: [debuginfo-tests] [dexter] Add missing entries to the dexter docs table of contents.

landed in rG7d8c19a4e9ed8f39eda0f0f383d5ff8f1485471b

Oct 20 2020, 3:21 AM · debug-info

Oct 19 2020

TWeaver committed rG7d8c19a4e9ed: [Dexter][NFC] Add Missing Commands to Commands.md Contents (authored by n-omer).
[Dexter][NFC] Add Missing Commands to Commands.md Contents
Oct 19 2020, 8:39 AM
TWeaver accepted D89689: [debuginfo-tests] [dexter] Add missing entries to the dexter docs table of contents.

Hi Nabeel,

Oct 19 2020, 6:19 AM · debug-info

Jun 11 2020

TWeaver added a comment to D81319: [Dexter] Add --source-dir-root flag.

First off, thanks for the feedback!

I also wondered where the best place would be for this path mapping. However, I still think DebuggerBase is a good spot as the debuggers currently rely on knowing context.source_files. So whichever tool wants to use the debuggers will also have to fill context.source_files, and therefore also run in the problem of needing to remap paths to the ones used in the compilation unit. Moving this mapping into the test tool would prevent other tools from reusing it.

Also, moving this mapping into the test tool would require to make the source_files be relative paths (to the source_root_dir) before calling the debuggers.
This leads to a future me now needing to remember what kind of path is used where: An absolute file system path (test tool), a path relative to source_root_dir (DebuggerController), or a debug info path (Debugger).

WDYT?

Jun 11 2020, 10:27 AM · debug-info, Restricted Project

Jun 10 2020

TWeaver added a comment to D81319: [Dexter] Add --source-dir-root flag.

Hey and thanks for this!

Jun 10 2020, 11:05 AM · debug-info, Restricted Project

Jun 5 2020

TWeaver added a comment to D79786: [Dexter] Add DexLimitSteps command and ConditionalController implementation.

recommitted rGc6aa829644f30d5590451b892918298f8117c985

Jun 5 2020, 6:33 AM · debug-info
TWeaver committed rGc6aa829644f3: [Dexter] Add DexLimitSteps command and ConditionalController (authored by TWeaver).
[Dexter] Add DexLimitSteps command and ConditionalController
Jun 5 2020, 4:56 AM

Jun 3 2020

TWeaver added a comment to D79786: [Dexter] Add DexLimitSteps command and ConditionalController implementation.

Hi Adrian (@aprantl)

Jun 3 2020, 8:44 AM · debug-info
TWeaver added a reverting change for rG81e836a5a675: [Dexter] Add DexLimitSteps command and ConditionalController: rG05eabb52045f: Revert "[Dexter] Add DexLimitSteps command and ConditionalController".
Jun 3 2020, 4:55 AM
TWeaver committed rG05eabb52045f: Revert "[Dexter] Add DexLimitSteps command and ConditionalController" (authored by TWeaver).
Revert "[Dexter] Add DexLimitSteps command and ConditionalController"
Jun 3 2020, 4:55 AM
TWeaver added a comment to D79786: [Dexter] Add DexLimitSteps command and ConditionalController implementation.

seems I've made a more mundane error of committing a diff file as part of my patch. this has been reverted for now.

Jun 3 2020, 4:53 AM · debug-info
TWeaver added a comment to D79786: [Dexter] Add DexLimitSteps command and ConditionalController implementation.

@aprantl I'll take a look, thanks for pointing them out.

Jun 3 2020, 4:20 AM · debug-info

Jun 2 2020

TWeaver closed D79786: [Dexter] Add DexLimitSteps command and ConditionalController implementation.

Landed in commit rG81e836a5a675f6a3d9d35560fddbbb87fdf66201

Jun 2 2020, 9:52 AM · debug-info
TWeaver closed D78633: [Dexter] Add os.path.normcase(...) transform to test path early..

Landed in commit rGbf1cdc2c6c0460b7121ac653c796ef4995b1dfa9

Jun 2 2020, 9:52 AM · debug-info
TWeaver committed rG81e836a5a675: [Dexter] Add DexLimitSteps command and ConditionalController (authored by TWeaver).
[Dexter] Add DexLimitSteps command and ConditionalController
Jun 2 2020, 8:47 AM
TWeaver committed rGbf1cdc2c6c04: [Dexter] Add os.path.normcase(...) transform to test path early. (authored by TWeaver).
[Dexter] Add os.path.normcase(...) transform to test path early.
Jun 2 2020, 8:14 AM
TWeaver updated the diff for D79786: [Dexter] Add DexLimitSteps command and ConditionalController implementation.

removed and replaced LoadDebuggerException with DebuggerException in LLDB.

Jun 2 2020, 8:14 AM · debug-info

May 18 2020

TWeaver updated the diff for D69943: Attempt to Salvage Debug Info or undef intrinsics when dropping trivially deletable instructions in reassociate pass.

Updated diff to correct revision for easing future historical searches

May 18 2020, 8:34 AM · Restricted Project
TWeaver added inline comments to D80052: [docs] Sketch outline for HowToUpdateDebugInfo.rst.
May 18 2020, 3:42 AM · debug-info, Restricted Project

May 15 2020

TWeaver added inline comments to D79786: [Dexter] Add DexLimitSteps command and ConditionalController implementation.
May 15 2020, 9:12 AM · debug-info
TWeaver added a comment to D79786: [Dexter] Add DexLimitSteps command and ConditionalController implementation.

@echristo thanks for your interest. do you need any further clarification on what dexter does or how this patch fits in with the existing behaviour?

May 15 2020, 7:33 AM · debug-info

May 13 2020

TWeaver added a comment to D79786: [Dexter] Add DexLimitSteps command and ConditionalController implementation.

missing note, dbgeng does not support the new DexLimitSteps commands as of right now.

May 13 2020, 7:00 AM · debug-info

May 12 2020

TWeaver created D79786: [Dexter] Add DexLimitSteps command and ConditionalController implementation.
May 12 2020, 7:29 AM · debug-info

Apr 27 2020

TWeaver added a comment to D78633: [Dexter] Add os.path.normcase(...) transform to test path early..

I prefer the current approach for readabilities sake as well as separating the two method calls out.

Apr 27 2020, 9:39 AM · debug-info
TWeaver added a comment to D78633: [Dexter] Add os.path.normcase(...) transform to test path early..

no, this would cause file path comparisons that are case sensitive to potentially fail on drive letter for windows.

Apr 27 2020, 5:51 AM · debug-info

Apr 22 2020

TWeaver updated the diff for D78633: [Dexter] Add os.path.normcase(...) transform to test path early..

removed accidental new line deletion

Apr 22 2020, 7:00 AM · debug-info
TWeaver created D78633: [Dexter] Add os.path.normcase(...) transform to test path early..
Apr 22 2020, 6:28 AM · debug-info
TWeaver added a comment to D78621: [dexter] Require python >= 3.6.

in ./debuginfo-tests/CMakeLists.txt we have the following on line 27:

Apr 22 2020, 5:55 AM · Restricted Project, debug-info
TWeaver added a comment to D78621: [dexter] Require python >= 3.6.

@jmorse I believe there's already a test in the cmake/config that checks the python version when generating the build.

Apr 22 2020, 5:55 AM · Restricted Project, debug-info
TWeaver accepted D78621: [dexter] Require python >= 3.6.

thanks for this, LGTM.

Apr 22 2020, 5:55 AM · Restricted Project, debug-info

Apr 21 2020

TWeaver added a comment to rGb1097e29d3d0: [Dexter] Fix failing clang-opt-bisect sub tool test.

fix for failing test reported at D76926

Apr 21 2020, 6:27 AM
TWeaver added a comment to D76926: [Dexter] Add Debugger Controller To Dexter.

fix for reported test failure at:

Apr 21 2020, 6:26 AM · Restricted Project, debug-info
TWeaver committed rGb1097e29d3d0: [Dexter] Fix failing clang-opt-bisect sub tool test (authored by TWeaver).
[Dexter] Fix failing clang-opt-bisect sub tool test
Apr 21 2020, 5:54 AM
TWeaver added a comment to D76926: [Dexter] Add Debugger Controller To Dexter.

thanks for reporting. this issue should now be fixed.

Apr 21 2020, 5:54 AM · Restricted Project, debug-info

Apr 20 2020

TWeaver committed rG9cf9710bb0d6: [Dexter][NFC] Add Debugger Controller To Dexter (authored by TWeaver).
[Dexter][NFC] Add Debugger Controller To Dexter
Apr 20 2020, 8:05 AM
TWeaver closed D76926: [Dexter] Add Debugger Controller To Dexter.
Apr 20 2020, 8:05 AM · Restricted Project, debug-info

Apr 1 2020

TWeaver added a comment to D76609: [DEXTER] Add support for windows in regression test suite..

The cdb tests taking longer may be a result of the dexter regression suite running along side them. SFAIK that's not intended behaviour.

Apr 1 2020, 8:27 AM · Restricted Project, debug-info

Mar 31 2020

TWeaver committed rGb6d2212f5276: [Dexter] Add support for Windows to regression test suite. (authored by TWeaver).
[Dexter] Add support for Windows to regression test suite.
Mar 31 2020, 2:46 AM
TWeaver added a comment to D76609: [DEXTER] Add support for windows in regression test suite..

I've also added an internal ticket to add darwin support to the dexter regression suite... I don't think there'll be much appetite in-house for it but if there's a clear need to add it in the future then of course we'll consider putting in the work.

Mar 31 2020, 2:42 AM · Restricted Project, debug-info
TWeaver added a comment to D76609: [DEXTER] Add support for windows in regression test suite..

Hi Davide,

Mar 31 2020, 2:42 AM · Restricted Project, debug-info
TWeaver added a comment to D76609: [DEXTER] Add support for windows in regression test suite..

I've actually mailed these via the mailing list by accident, here's a copy of what I mailed:

Mar 31 2020, 2:42 AM · Restricted Project, debug-info

Mar 27 2020

TWeaver committed rG89025da9f676: [Dexter] Add support for Windows to regression test suite. (authored by TWeaver).
[Dexter] Add support for Windows to regression test suite.
Mar 27 2020, 11:30 AM
TWeaver closed D76609: [DEXTER] Add support for windows in regression test suite..
Mar 27 2020, 11:30 AM · Restricted Project, debug-info
TWeaver added a comment to D75343: [RFC][debuginfo-tests][dexter] Add a test generation tool.

@Pierre-vh and not a problem buddy, I wish you all the best in your future endeavours, don't worry about feedback on the controller patch if it's not related to your current work! :) you get on with what you need to.

Mar 27 2020, 10:55 AM · Restricted Project, debug-info
TWeaver added a comment to D75343: [RFC][debuginfo-tests][dexter] Add a test generation tool.

The debugger controller patch is now live and awaiting review at

Mar 27 2020, 7:37 AM · Restricted Project, debug-info
TWeaver created D76926: [Dexter] Add Debugger Controller To Dexter.
Mar 27 2020, 7:05 AM · Restricted Project, debug-info
TWeaver added a comment to D75343: [RFC][debuginfo-tests][dexter] Add a test generation tool.

I hope you're keeping safe in these unprecedented times!

Mar 27 2020, 4:50 AM · Restricted Project, debug-info

Mar 23 2020

TWeaver added a reviewer for D76609: [DEXTER] Add support for windows in regression test suite.: rnk.
Mar 23 2020, 7:36 AM · Restricted Project, debug-info
TWeaver created D76609: [DEXTER] Add support for windows in regression test suite..
Mar 23 2020, 7:03 AM · Restricted Project, debug-info

Mar 16 2020

TWeaver committed rG09f4bdc03f89: [DexTer] Add step.UNKNOWN check for NoneType line numbers. (authored by TWeaver).
[DexTer] Add step.UNKNOWN check for NoneType line numbers.
Mar 16 2020, 9:49 AM
TWeaver closed D75992: [DEXTER] Add step.UNKNOWN check to DexTer for None valued steps..
Mar 16 2020, 9:49 AM · Restricted Project, debug-info

Mar 11 2020

TWeaver added inline comments to D75992: [DEXTER] Add step.UNKNOWN check to DexTer for None valued steps..
Mar 11 2020, 1:01 PM · Restricted Project, debug-info
TWeaver added inline comments to D75992: [DEXTER] Add step.UNKNOWN check to DexTer for None valued steps..
Mar 11 2020, 10:09 AM · Restricted Project, debug-info
TWeaver added inline comments to D75992: [DEXTER] Add step.UNKNOWN check to DexTer for None valued steps..
Mar 11 2020, 10:09 AM · Restricted Project, debug-info
TWeaver created D75992: [DEXTER] Add step.UNKNOWN check to DexTer for None valued steps..
Mar 11 2020, 7:58 AM · Restricted Project, debug-info

Mar 4 2020

TWeaver added a comment to D75343: [RFC][debuginfo-tests][dexter] Add a test generation tool.

Hi Pierre,

Mar 4 2020, 10:05 AM · Restricted Project, debug-info

Mar 3 2020

TWeaver added a comment to D75343: [RFC][debuginfo-tests][dexter] Add a test generation tool.

I haven't attempted to generalize my work as I entirely rely on the LLDB library for this (and I work on Linux so I can't work with any other debugger supported by Dexter)
Maybe we can try to find something together? Where do you wish to discuss this?

Mar 3 2020, 10:21 AM · Restricted Project, debug-info
TWeaver added inline comments to D75343: [RFC][debuginfo-tests][dexter] Add a test generation tool.
Mar 3 2020, 8:38 AM · Restricted Project, debug-info
TWeaver added a comment to D75343: [RFC][debuginfo-tests][dexter] Add a test generation tool.

Hi Pierre,

Mar 3 2020, 6:02 AM · Restricted Project, debug-info

Feb 12 2020

TWeaver accepted D74409: [debuginfo-tests][Dexter] Fix process creation flake-out on Windows.

LGTM

Feb 12 2020, 7:55 AM · Restricted Project
TWeaver added a comment to D74409: [debuginfo-tests][Dexter] Fix process creation flake-out on Windows.

Hi Reid,

Feb 12 2020, 6:04 AM · Restricted Project

Jan 24 2020

TWeaver committed rGf5147765ba17: [DebugInfo][LiveDebugValues] Teach Live Debug Values About Meta Instructions (authored by TWeaver).
[DebugInfo][LiveDebugValues] Teach Live Debug Values About Meta Instructions
Jan 24 2020, 8:32 AM
TWeaver closed D73210: [OPT_DPG][LIVEDEBUGVALUES] Teach Live Debug Values About Meta Instructions.
Jan 24 2020, 8:32 AM · Restricted Project, debug-info

Jan 23 2020

TWeaver added a comment to D73210: [OPT_DPG][LIVEDEBUGVALUES] Teach Live Debug Values About Meta Instructions.

Hi David,

Jan 23 2020, 10:18 AM · Restricted Project, debug-info
TWeaver added inline comments to D73210: [OPT_DPG][LIVEDEBUGVALUES] Teach Live Debug Values About Meta Instructions.
Jan 23 2020, 10:18 AM · Restricted Project, debug-info
TWeaver updated the diff for D73210: [OPT_DPG][LIVEDEBUGVALUES] Teach Live Debug Values About Meta Instructions.

KILL instruction is no reinstated and failing check line has been removed.

Jan 23 2020, 6:57 AM · Restricted Project, debug-info
TWeaver added a reviewer for D73210: [OPT_DPG][LIVEDEBUGVALUES] Teach Live Debug Values About Meta Instructions: djtodoro.
Jan 23 2020, 6:03 AM · Restricted Project, debug-info
TWeaver added a comment to D73210: [OPT_DPG][LIVEDEBUGVALUES] Teach Live Debug Values About Meta Instructions.

I missed adding you as a reviewer @djtodoro , my apologies. This has been rectified.

Jan 23 2020, 6:03 AM · Restricted Project, debug-info

Jan 22 2020

TWeaver added inline comments to D73210: [OPT_DPG][LIVEDEBUGVALUES] Teach Live Debug Values About Meta Instructions.
Jan 22 2020, 9:55 AM · Restricted Project, debug-info
TWeaver created D73210: [OPT_DPG][LIVEDEBUGVALUES] Teach Live Debug Values About Meta Instructions.
Jan 22 2020, 9:09 AM · Restricted Project, debug-info
TWeaver closed D70497: [DBG] Teach DebugEntityHistoryCalculator about Kill instructions..

Hello Everyone,

Jan 22 2020, 7:23 AM · Restricted Project, debug-info

Jan 14 2020

TWeaver committed rGe7b2d9f4702c: [DBG][LIVEDEBUGVALUES][NFC] Add Targeted LiveDebugValues Behaviour Tests. (authored by TWeaver).
[DBG][LIVEDEBUGVALUES][NFC] Add Targeted LiveDebugValues Behaviour Tests.
Jan 14 2020, 7:54 AM
TWeaver committed rGb10f6b711227: Revert "[DBG][LIVEDEBUGVALUES][NFC] Add Targeted LiveDebugValues Behaviour… (authored by TWeaver).
Revert "[DBG][LIVEDEBUGVALUES][NFC] Add Targeted LiveDebugValues Behaviour…
Jan 14 2020, 7:15 AM
TWeaver added a reverting change for rG35787e3a062a: [DBG][LIVEDEBUGVALUES][NFC] Add Targeted LiveDebugValues Behaviour Tests.: rGb10f6b711227: Revert "[DBG][LIVEDEBUGVALUES][NFC] Add Targeted LiveDebugValues Behaviour….
Jan 14 2020, 7:15 AM
TWeaver committed rG35787e3a062a: [DBG][LIVEDEBUGVALUES][NFC] Add Targeted LiveDebugValues Behaviour Tests. (authored by TWeaver).
[DBG][LIVEDEBUGVALUES][NFC] Add Targeted LiveDebugValues Behaviour Tests.
Jan 14 2020, 6:46 AM
TWeaver closed D72515: Add Targeted LiveDebugValues Tests That Exercise Specific Expected Behaviours .
Jan 14 2020, 6:46 AM · Restricted Project, debug-info

Jan 13 2020

TWeaver added a comment to D72515: Add Targeted LiveDebugValues Tests That Exercise Specific Expected Behaviours .

I'll land this tomorrow as I'm off home now and don't want to risk getting buildbot emails all night.

Jan 13 2020, 10:36 AM · Restricted Project, debug-info
TWeaver updated the diff for D72515: Add Targeted LiveDebugValues Tests That Exercise Specific Expected Behaviours .

updated diff

Jan 13 2020, 10:35 AM · Restricted Project, debug-info