User Details
- User Since
- Feb 15 2018, 9:11 AM (153 w, 5 d)
Mon, Jan 11
Simplified setting to undef using replaceDbgUsesWithUndef().
Tue, Jan 5
Restored erroneously removed source patch!
Dec 7 2020
Removed excess intrinsics, attributes and metadata from test.
Nov 28 2020
Addressed review comments:
Nov 26 2020
Ping.
Oct 29 2020
Jun 11 2020
Abandoned in favour of the alternative D79863.
Jun 10 2020
This revision was closed with commit c6c65164. I'm uncertain why the commit's 'differential revision' tag failed to trigger the autoclose.
Jun 8 2020
May 28 2020
Are there any more suggestions please?
May 26 2020
May 22 2020
Removed unused return value from SalvageDebugInfo().
- Corrected comment
- Removed unnecessary reference in iteration
- Added missing pointer dereference
May 19 2020
Polite ping :)
May 14 2020
- Removed some excess debug information from post-ra test
- Made sink Filecheck test more strict
May 13 2020
May 7 2020
This work was completed in D58484.
Apr 27 2020
- Removed the call to reverse() in InstCombine.cpp and updated the debuginfo_add.ll test accordingly.
- Moved some comments in InstCombine to a more appropriate spot.
- Simplified an iteration in InstCombine as suggested.
Apr 22 2020
Applied clang-format-diff.
Apr 20 2020
Apr 17 2020
Apr 6 2020
Closed by commit 135709aa9013565b9d02000bb0ca744f7585e6a5.
Mar 30 2020
Mar 27 2020
Mar 26 2020
Removed unnecessary CHECK line. It was erroneous anyway!
Simplified the CHECK expression to match only the component of the dbg.value call that is significant for this test.
Feb 25 2020
The diagnostics were implemented in D58484.
Feb 19 2020
Feb 18 2020
This revision will soon be abandoned along with D66426, unless there are any further comments.
It would seem that there just isn't sufficient interest in this, so I'm going to mark this revision as abandoned if there are no further comments.
Jan 24 2020
Jan 17 2020
ping
Jan 14 2020
Jan 10 2020
ping
Jan 8 2020
Hello @ruiu and @MaskRay , can I help with any more technical queries concerning this proposal? Also with respect to the associated D70316 that enables printing of watermark note sections and computing of watermarks in readobj?
Jan 6 2020
Ping
Dec 11 2019
Dec 9 2019
Modified extractSegments() in watermark.h.
Dec 5 2019
Removed library test accidentally added in last update.
Added --compute-watermark, additional tests, use of library from update to D66426.
Watermark functionality now placed in separate source and header in the object library. This is used by Writer and SyntheticSections.
Dec 4 2019
Nov 27 2019
Nov 20 2019
Nov 19 2019
@ruiu observed that the watermark computation was reliant on the segment ordering in the ELF file. This ordering can change without affecting the loadable image. Therefore, we now apply an ordering based on the segment's virtual address when calculating the watermark.
Nov 15 2019
Sep 13 2019
Sep 10 2019
Sep 6 2019
This update applies suggested source corrections, enables readobj to output the note and adds logic to writeWatermark() to exclude the ELF Header and Program Header Table (PHT) from the watermark. In this diff the PHT can only be excluded if it is the first or last segment. If it is neither, an error is emitted.
Sep 3 2019
This was closed with commit 7b39513302, svn r363248.
Aug 30 2019
This was closed with revision r370458, commit fa1fe93789.
Aug 29 2019
Update to apply the corrections pointed out by @MaskRay .
Aug 28 2019
The diff has been updated to apply the visibility to symbols created with --add-symbol where a visibility flag is not specified. The flag name has also been changed from --binary-symbol-visibility to --new-symbol-visibility
Aug 20 2019
Aug 19 2019
Aug 15 2019
Is your GNU objcopy patched to use STV_HIDDEN or STV_PROTECTED for _binary_a_{start,end,size}?
objcopy -I binary -O elf64-x86-64 a b => Symbols in b are STV_HIDDEN/STV_PROTECTED?
Aug 14 2019
Aug 9 2019
Aug 7 2019
Jul 25 2019
Jul 18 2019
Jul 17 2019
Jul 15 2019
Does anyone have any thoughts on these additions?
Jun 27 2019
Jun 26 2019
Additional regexes to match more messages containing source:line information. Also added a test.
Jun 25 2019
Tidied up the test and added some additional cases. Added an assert explaining the tested binding values.