- User Since
- Mar 5 2019, 4:12 AM (81 w, 5 d)
Fri, Sep 25
I think wait for someone with more experience in this area to give approval, but aside from the outstanding comments, LGTM.
Thu, Sep 24
LGTM. I think the Implicit flag idea might be able to be folded into this patch without much issue, but it's not urgent and can definitely be shifted to another patch (or even just left as a TODO).
Wed, Sep 23
Updated changes for latest master (there may be some lurking unseen errors, still trying to flush any out), addressed some review comments. Right now, I think the only thing holding this patch up is the discussion on the llvm-dev mailing list about using DBG_VALUE_LIST as the default for all debug values. If anyone on this review has any input for that, please go ahead and reply to the chain - I think that the latest proposal I put forward should satisfy everyone's requirements, but I don't want to push ahead without being sure of that.
Aug 27 2020
Jul 24 2020
Add test to confirm that addMachineRegExpression is being correctly used for DBG_VALUE_LIST regs; replace if-else chain with switch in AsmPrinter::emitDebugValueComment.
Add a simple unit test for the new function.
Jul 21 2020
Remove unused MF attributes.
Remove unused data from tests, add/modify comments, move VarVec declaration up, fix error in duplicated-op-removal.
Jul 17 2020
Jul 15 2020
Jul 10 2020
Rename appendOpsToLoc->appendOpsToArg to fit the rest of the names, update isUndefDebugValue check to check all operands (pulled ahead from a patch further up the stack).
Remove useless const, add rename that somehow escaped last diff.
Remove old comments from tests.
Jul 9 2020
Address latest review comments.
Update: Duplicate registers in the debug operands could be an issue with the previous patch version, and duplicates aren't easy to prevent, so always treat DBG_VALUE_LISTs as potentially having them.
Jun 29 2020
Apologies for the update spam, this is the last one: remove unused lines from test.
Also /s/var/list/ in the test filenames.
Addressing the review comments: remove the note-to-self comments, and rename DBG_VALUE_VAR -> DBG_VALUE_LIST. This could change again if people think something else would be more appropriate, but this looks to have general approval.
I think the preferred way of resolving this would be to post to llvm-dev and make sure the authors of D70642 are CC'ed. As far as I can see D70642 is less space-efficient, but allows for referring to the same argument multiple times. Given the DW_OP_dup/over operators, I'm not sure if that is necessary.
Jun 23 2020
Jun 22 2020
Jun 19 2020
Allow for malformed DBG_VALUEs to be printed.
Jun 18 2020
Jun 17 2020
Fixes broken tests and code error.
Jun 15 2020
Apr 20 2020
Closed, since as per the discussion above this change is undesired and unnecessary.
Mar 2 2020
Actually, after looking at how this is being used in the child revisions, it looks like this should be folded into handle_options - that function is already used to check whether the supplied options to a tool are valid, and raises an Error if not. That seems more consistent with the rest of Dexter than returning a ReturnCode.FAIL, which is currently only used if the test is run without any errors but has a failing score.
LGTM except for the inline comment.
Feb 27 2020
Feb 17 2020
Feb 13 2020
Feb 12 2020
Jan 23 2020
Fix spelling error.
Add test, address nit comment. Note that some of the current test checks should pass even without this patch if commit 636c93 is not reverted, as some of the redundant debug info would be dropped.
Jan 20 2020
Jan 15 2020
Dec 19 2019
Merged in commit: llvmorg-10-init-12272-g89d19d60adb9
Dec 18 2019
Dec 17 2019
Format, addressing review comments
@djtodoro Does this latest change look good to you?
Dec 13 2019
Use shared functionality for zero/sign extension ops, fix tests
Dec 12 2019
Rebased and updated for latest master, fixed clang version and unused attributes in tests.
Dec 10 2019
Dec 6 2019
Dec 4 2019
Use Undef int1 when undef-ing a DbgVariable without a type.
Maintain order of debug intrinsics in empty block elimination, fix test
Dec 3 2019
Merged in commit: llvmorg-10-init-11043-g269a9afe25cb