User Details
- User Since
- Mar 5 2019, 4:12 AM (98 w, 3 d)
Tue, Jan 19
Ping - this one has had a lot of discussion, and I think all of the substantial concerns have been addressed; are there any further comments?
Ping.
Ping.
Ping - any further comments?
Mon, Jan 18
Fixed issue in which DBG_VALUE_LIST expressions were being emitted without subregister masking.
Fri, Jan 15
Rebased onto recent master (resolving clashes with the DW_OP_implicit_ptr patch); rewrote dbg-value-list-spill.mir test.
Wed, Jan 13
Rebased onto recent master, fixed test failures.
Rebased onto recent master, address review comment.
Rebased onto recent master.
Rebased onto recent master, minor change to Args storage (std::vector -> SmallVector) and added args_begin() and args_end().
Rebased onto recent master, added smarter iterator for variable location operands.
Rebased onto recent master.
Rebased onto recent master, fixed test failures.
Rebased onto recent master, fixed some test failures.
Rebased onto recent master, fixed up MachineSink implementation.
Rebased onto recent master (993c488ed), addressed review comments (except for the question about dbg-value-list-spill.mir).
Mon, Jan 11
Thu, Jan 7
Wed, Jan 6
Mon, Jan 4
Dec 16 2020
Dec 10 2020
Dec 8 2020
Rebased onto recent master, no functional changes; moved the salvageDebugInfoImpl refactoring into a separate NFC patch; addressed outstanding review comments.
Rebased onto recent master; no functional changes.
Rebase onto recent master, no functional changes.
Rebase onto recent master; no functional changes except applying the existing changes to the new InstrEmitter::EmitDbgInstrRef function.
Rebase onto recent master, no functional changes from rebase. Minor changes to findDbgUsers/findDbgValues to handle DIArgLists in which the same value appears more than once.
Rebase onto recent master; no functional changes from rebase. Minor change to DbgVariableIntrinsic::setUndef to handle DIArglists in which the same value appears more than once.
Rebase onto recent master; minor non-functional changes (renamed "ParseX()" functions to "parseX()").
Rebased onto recent master, no changes.
Rebased onto recent master; no functional changes from rebase.
Rebased to recent master, no actual changes.
Rebased onto recent master; no functional changes, minor adjustments in DwarfDebug::emitDebugLocValue.
Rebased onto recent master.
Rebased onto recent master.
Dec 3 2020
Fixed a pair of bugs; 1) added DIArgList support to the ValueMapper so that DIArgList arguments are properly updated during inlining, and 2) prevented RAUW from setting DIArgList arguments to null (now uses an UndefValue instead).
Nov 20 2020
Nov 18 2020
Oct 28 2020
I've added a test for the symptom that revealed this bug in llvm-mca. I'm also writing a unit test for AsmLexer that tests the underlying behaviour by verifying that CommentConsumers will not be sent characters that are not part of the line comment, since the problem is not specific to llvm-mca (although it's the only place that has seen an error so far, as far as I can tell).
Oct 27 2020
Oct 19 2020
LGTM, this new approach looks solid. As per usual, wait for further approval from someone with more authority in this area.
Oct 5 2020
Oct 1 2020
- Fixed a few minor errors, including a linux compile error
- Rebased onto latest master, moving changes into VarLocBasedImpl.cpp.
Sep 30 2020
Sep 28 2020
Add documentation for DBG_VALUE_LIST and DW_OP_LLVM_arg.
LGTM, though recommend waiting for a more experienced reviewer to give approval.
Sep 25 2020
I think wait for someone with more experience in this area to give approval, but aside from the outstanding comments, LGTM.
Sep 24 2020
LGTM. I think the Implicit flag idea might be able to be folded into this patch without much issue, but it's not urgent and can definitely be shifted to another patch (or even just left as a TODO). Should probably be looked at by others with experience in the area, but I think most of the comments are probably going to be for the later patches in this stack.
Sep 23 2020
Updated changes for latest master (there may be some lurking unseen errors, still trying to flush any out), addressed some review comments. Right now, I think the only thing holding this patch up is the discussion on the llvm-dev mailing list about using DBG_VALUE_LIST as the default for all debug values. If anyone on this review has any input for that, please go ahead and reply to the chain - I think that the latest proposal I put forward should satisfy everyone's requirements, but I don't want to push ahead without being sure of that.
Aug 27 2020
Jul 24 2020
Add test to confirm that addMachineRegExpression is being correctly used for DBG_VALUE_LIST regs; replace if-else chain with switch in AsmPrinter::emitDebugValueComment.
Add a simple unit test for the new function.
Jul 21 2020
Remove unused MF attributes.
Remove unused data from tests, add/modify comments, move VarVec declaration up, fix error in duplicated-op-removal.
Jul 17 2020
Jul 15 2020
Jul 10 2020
Rename appendOpsToLoc->appendOpsToArg to fit the rest of the names, update isUndefDebugValue check to check all operands (pulled ahead from a patch further up the stack).
Remove useless const, add rename that somehow escaped last diff.