Page MenuHomePhabricator

Orlando (Orlando Cazalet-Hyams)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 28 2019, 8:58 AM (78 w, 2 d)

Recent Activity

Wed, Sep 23

Orlando added inline comments to D87357: [SelectionDAG][DebugInfo] Use entry-values to recover parameters values.
Wed, Sep 23, 4:12 AM · Restricted Project, debug-info

Tue, Sep 22

Orlando added a comment to D68620: DebugInfo: Use base address selection entries for debug_loc.

I guess all of these measurements were done without Split DWARF (shouldn't make things better/worse overall (across .o and .dwo), really, compared to DWARFv5 non-split - but means when only looking at .o files the difference of avoiding more debug_addr entries is more significant because there's fewer remaining .o debug bytes to begin with) and without compression (-gz) enabled?

Tue, Sep 22, 9:48 AM · Restricted Project
Orlando added inline comments to D87233: [POC][DebugInfo] Use entry values within IR.
Tue, Sep 22, 9:42 AM · Restricted Project, debug-info
Orlando added inline comments to D87357: [SelectionDAG][DebugInfo] Use entry-values to recover parameters values.
Tue, Sep 22, 9:38 AM · Restricted Project, debug-info
Orlando added a comment to D68620: DebugInfo: Use base address selection entries for debug_loc.

Just to clarify: when I say "elf" here I'm talking about the linked executable file, and "object files" are the pre-link .o files.

Tue, Sep 22, 6:25 AM · Restricted Project
Orlando added a comment to D68620: DebugInfo: Use base address selection entries for debug_loc.

The following builds are with clang @ 485e6db8729 (3rd September) targeting x86.

+---------------------------------------------------------------+
| File size (bytes) of clang-3.4 built with -O2 -gdwarf-4       |
*===============================================================*
|                    | base addr    | no base addr | % change   |
+--------------------+--------------+--------------+------------+
| Accumulated object | 1874653208   | 1924003152   | +2.63      |
| file sizes         |              |              |            |
+--------------------+--------------+--------------+------------+
| Elf size           | 527591064    | 513946184    | -2.57      |
+--------------------+--------------+--------------+------------+
Tue, Sep 22, 5:38 AM · Restricted Project

Mon, Sep 21

Orlando added a comment to D68620: DebugInfo: Use base address selection entries for debug_loc.

Out of curiosity I also did a clang-3.4 build too using master @ 485e6db8729 (3rd September) with "-O2 -gdwarf-4". It is smaller when disabling base address specifiers (and emitting DWARFv 4) too:
With base addresses (default): Total File Size: 527591064
Without base addresses: Total File Size: 513946184 (-2.59 %)

Mon, Sep 21, 7:57 AM · Restricted Project
Orlando updated subscribers of D87233: [POC][DebugInfo] Use entry values within IR.
Mon, Sep 21, 7:20 AM · Restricted Project, debug-info
Orlando added inline comments to D87233: [POC][DebugInfo] Use entry values within IR.
Mon, Sep 21, 5:38 AM · Restricted Project, debug-info

Thu, Sep 17

Orlando added a comment to D68620: DebugInfo: Use base address selection entries for debug_loc.

I have here a copy of the table I shared earlier, with a new row "ShouldUseBaseAddress=false". The stats for this row are taken at 57d8acac64b (D86153) with the changes mentioned in my previous comment (disabling base address specifiers).

+------------------------------------------------------------------------------------------- +
| Mean binary size for benchmarks normalized as a percentage of llvm-3 builds                |
+---------------------------------+------------+------------------+-----------------+--------+
| llvm version                    | .debug_loc | other debug info | everything else | Total  |
+---------------------------------+------------+------------------+-----------------+--------+
| llvm-3                          | 13.7       | 33.2             | 53.1            | 100    |
| llvm-4                          | 12.7       | 33.8             | 53.8            | 100.3  |
| llvm-5                          | 13.4       | 35.6             | 54.6            | 103.7  |
| llvm-7                          | 18.4       | 35.6             | 54.0            | 108.0  |
| llvm-8                          | 17.5       | 37.1             | 54.5            | 109.1  |
| llvm-9                          | 19.7       | 37.2             | 54.6            | 111.5  |
| llvm-10 before dblaikie commit  | 19.8       | 37.4             | 54.9            | 112.1  |
| llvm-10 with dblaikie commit    | 25.6       | 37.4             | 54.9            | 117.9  |
| llvm-10                         | 25.8       | 37.5             | 54.8            | 118.1  |
| llvm-master before my commits   | 26.2       | 37.4             | 54.8            | 118.4  |
| llvm-master with my commits     | 18.4       | 35.5             | 55.3            | 109.3  |
| ShouldUseBaseAddress=false      | 14.9       | 35.5             | 55.3            | 105.7  |
+---------------------------------+------------+------------------+-----------------+--------+
Thu, Sep 17, 2:49 PM · Restricted Project
Orlando added a comment to D68620: DebugInfo: Use base address selection entries for debug_loc.

Ah, OK - so it sounds like we're back down below the size before I added debug_loc base address specifiers? That's good to hear!

Thu, Sep 17, 2:01 AM · Restricted Project

Wed, Sep 16

Orlando added inline comments to D82678: [CGP] Set debug locations when optimizing phi types.
Wed, Sep 16, 11:37 AM · debug-info, Restricted Project
Orlando added inline comments to D82678: [CGP] Set debug locations when optimizing phi types.
Wed, Sep 16, 10:28 AM · debug-info, Restricted Project
Orlando abandoned D79949: [WIP][Example] Drop out-of-scope variable locations.

The real thing exists over at D82129 (landed).

Wed, Sep 16, 1:23 AM · Restricted Project
Orlando added a comment to D68620: DebugInfo: Use base address selection entries for debug_loc.

Thanks for the data!

Wed, Sep 16, 1:16 AM · Restricted Project

Tue, Sep 15

Orlando added a comment to D68620: DebugInfo: Use base address selection entries for debug_loc.

@Orlando mentioned he was collecting some size data that would be relevant here, he'll post it when he's done. Basically .debug_loc sizes at various points.

Tue, Sep 15, 7:39 AM · Restricted Project

Thu, Sep 3

Orlando added a comment to D86937: Adding GDB PrettyPrinter for mlir::Identifier..

I've reverted this for now (485e6db8729) because one of our internal build bot is failing in the same way. I don't think many (any?) of the bots on http://lab.llvm.org:8011/console build the debuginfo-tests project!

Thu, Sep 3, 2:55 AM · Restricted Project
Orlando added a reverting change for rG9e9e6e698d8e: Adding GDB PrettyPrinter for mlir::Identifier.: rG485e6db87293: Revert "Adding GDB PrettyPrinter for mlir::Identifier.".
Thu, Sep 3, 2:50 AM
Orlando committed rG485e6db87293: Revert "Adding GDB PrettyPrinter for mlir::Identifier." (authored by Orlando).
Revert "Adding GDB PrettyPrinter for mlir::Identifier."
Thu, Sep 3, 2:50 AM
Orlando added a reverting change for D86937: Adding GDB PrettyPrinter for mlir::Identifier.: rG485e6db87293: Revert "Adding GDB PrettyPrinter for mlir::Identifier.".
Thu, Sep 3, 2:50 AM · Restricted Project

Aug 27 2020

Orlando added a comment to D86152: [DwarfDebug] Improve multi-BB single location detection in validThroughout (3/4).

Before landing I removed the XFAIL:* from llvm/test/DebugInfo/AArch64/inlined-argument.ll because it passes with this patch.

Aug 27 2020, 4:25 AM · debug-info, Restricted Project
Orlando added a reverting change for rGb9d977b0ca60: [DWARF] Add cuttoff guarding quadratic validThroughout behaviour: rGb6cca0ec05cf: Revert "[DWARF] Add cuttoff guarding quadratic validThroughout behaviour".
Aug 27 2020, 4:14 AM
Orlando committed rGb6cca0ec05cf: Revert "[DWARF] Add cuttoff guarding quadratic validThroughout behaviour" (authored by Orlando).
Revert "[DWARF] Add cuttoff guarding quadratic validThroughout behaviour"
Aug 27 2020, 4:14 AM
Orlando committed rG57d8acac64b8: [DwarfDebug] Improve validThroughout performance (4/4) (authored by Orlando).
[DwarfDebug] Improve validThroughout performance (4/4)
Aug 27 2020, 4:14 AM
Orlando committed rG3c491881d2ae: [DwarfDebug] Improve multi-BB single location detection in validThroughout (3/4) (authored by Orlando).
[DwarfDebug] Improve multi-BB single location detection in validThroughout (3/4)
Aug 27 2020, 4:14 AM
Orlando added a reverting change for D83236: [DWARF] Add cutoff guarding validThroughout to avoid near-quadratic behaviour: rGb6cca0ec05cf: Revert "[DWARF] Add cuttoff guarding quadratic validThroughout behaviour".
Aug 27 2020, 4:14 AM · Restricted Project
Orlando committed rG0b5a8050ea39: [DwarfDebug] Improve single location detection in validThroughout (2/4) (authored by Orlando).
[DwarfDebug] Improve single location detection in validThroughout (2/4)
Aug 27 2020, 4:14 AM
Orlando committed rGe048ea7b1a05: [NFC][DebugInfo] Create InstructionOrdering helper class (1/4) (authored by Orlando).
[NFC][DebugInfo] Create InstructionOrdering helper class (1/4)
Aug 27 2020, 4:14 AM
Orlando closed D86153: [DwarfDebug] Improve validThroughout performance (4/4).
Aug 27 2020, 4:14 AM · debug-info, Restricted Project
Orlando closed D86152: [DwarfDebug] Improve multi-BB single location detection in validThroughout (3/4).
Aug 27 2020, 4:14 AM · debug-info, Restricted Project
Orlando closed D86151: [DwarfDebug] Improve single location detection in validThroughout (2/4).
Aug 27 2020, 4:14 AM · debug-info, Restricted Project
Orlando closed D86150: [NFC][DebugInfo] Create InstructionOrdering helper class (1/4).
Aug 27 2020, 4:14 AM · debug-info, Restricted Project

Aug 26 2020

Orlando added a comment to D86152: [DwarfDebug] Improve multi-BB single location detection in validThroughout (3/4).

@djtodoro do you have any more thoughts on this patch? Copying part of my inline comment here for any other reviewers:

Aug 26 2020, 7:36 AM · debug-info, Restricted Project

Aug 25 2020

Orlando closed D85636: [llvm-dwarfdump] Fix misleading scope byte coverage statistics.
Aug 25 2020, 1:57 AM · Restricted Project, debug-info
Orlando added inline comments to D86152: [DwarfDebug] Improve multi-BB single location detection in validThroughout (3/4).
Aug 25 2020, 1:55 AM · debug-info, Restricted Project
Orlando updated the diff for D86152: [DwarfDebug] Improve multi-BB single location detection in validThroughout (3/4).

A small update to address comments from @djtodoro.

Aug 25 2020, 1:53 AM · debug-info, Restricted Project
Orlando added a comment to D85636: [llvm-dwarfdump] Fix misleading scope byte coverage statistics.

Oops, I didn't include the Phabricator revision line in the commit message.

Aug 25 2020, 1:43 AM · Restricted Project, debug-info
Orlando committed rG3ff4d75c9cbf: [llvm-dwarfdump] Fix misleading scope byte coverage statistics (authored by Orlando).
[llvm-dwarfdump] Fix misleading scope byte coverage statistics
Aug 25 2020, 1:38 AM
Orlando added a comment to D85636: [llvm-dwarfdump] Fix misleading scope byte coverage statistics.

Hi @djtodoro thanks for taking a look!

Aug 25 2020, 1:05 AM · Restricted Project, debug-info

Aug 21 2020

Orlando updated the diff for D85636: [llvm-dwarfdump] Fix misleading scope byte coverage statistics.

+ Rebase
+ Update test for latest yaml2obj with change suggested by @Higuoxing (thank you!).
+ Make the test more interesting, @dblaikie wdyt?

Aug 21 2020, 2:56 AM · Restricted Project, debug-info

Aug 20 2020

Orlando added inline comments to D85636: [llvm-dwarfdump] Fix misleading scope byte coverage statistics.
Aug 20 2020, 2:57 AM · Restricted Project, debug-info
Orlando added a comment to D86151: [DwarfDebug] Improve single location detection in validThroughout (2/4).

Just a note: This patch moves the InstructionOrdering class added in D86150 out from DbgEntityHistoryCalculator.cpp to DbgEntityHistoryCalculator.h so that we're able to use it in DebugHandlerBase.

Aug 20 2020, 2:17 AM · debug-info, Restricted Project

Aug 19 2020

Orlando added a comment to D86150: [NFC][DebugInfo] Create InstructionOrdering helper class (1/4).

Thanks for the review! I'll land the patch alongside the others in the stack when they're good to go.

Aug 19 2020, 10:21 AM · debug-info, Restricted Project
Orlando added a comment to D83895: [DebugInfo] Process DBG_VALUE_LIST in LiveDebugVariables.

Hi, sorry for leaving this for so long! I think it will take me a couple of passes to fully understand it, but for now I left some inline nits/questions. Please feel free to leave the nit changes until later revisions.

Aug 19 2020, 2:26 AM · Restricted Project, debug-info
Orlando added a comment to D85636: [llvm-dwarfdump] Fix misleading scope byte coverage statistics.

Thanks @jhenderson. I think this should have also addressed @dblaikie's concerns regarding the test, so I will aim to land this in a couple of days if there are no objections.

Aug 19 2020, 1:06 AM · Restricted Project, debug-info
Orlando added a comment to D86153: [DwarfDebug] Improve validThroughout performance (4/4).

Thank you @aprantl.

Aug 19 2020, 1:01 AM · debug-info, Restricted Project
Orlando added inline comments to D86150: [NFC][DebugInfo] Create InstructionOrdering helper class (1/4).
Aug 19 2020, 12:56 AM · debug-info, Restricted Project
Orlando updated the summary of D86150: [NFC][DebugInfo] Create InstructionOrdering helper class (1/4).
Aug 19 2020, 12:56 AM · debug-info, Restricted Project

Aug 18 2020

Orlando requested review of D86153: [DwarfDebug] Improve validThroughout performance (4/4).
Aug 18 2020, 10:17 AM · debug-info, Restricted Project
Orlando added reviewers for D86152: [DwarfDebug] Improve multi-BB single location detection in validThroughout (3/4): vsk, djtodoro, dblaikie, aprantl.
Aug 18 2020, 10:16 AM · debug-info, Restricted Project
Orlando requested review of D86152: [DwarfDebug] Improve multi-BB single location detection in validThroughout (3/4).
Aug 18 2020, 10:16 AM · debug-info, Restricted Project
Orlando requested review of D86151: [DwarfDebug] Improve single location detection in validThroughout (2/4).
Aug 18 2020, 10:12 AM · debug-info, Restricted Project
Orlando requested review of D86150: [NFC][DebugInfo] Create InstructionOrdering helper class (1/4).
Aug 18 2020, 10:11 AM · debug-info, Restricted Project
Orlando added inline comments to D86045: [llvm-dwarfdump] --statistics: switch to json::OStream. NFC.
Aug 18 2020, 2:36 AM · Restricted Project

Aug 14 2020

Orlando updated the diff for D85636: [llvm-dwarfdump] Fix misleading scope byte coverage statistics.

Thank you so much @Higuoxing, that's very kind!

Aug 14 2020, 8:30 AM · Restricted Project, debug-info
Orlando updated the diff for D85636: [llvm-dwarfdump] Fix misleading scope byte coverage statistics.

Thanks @aprantl and @jhenderson.

Aug 14 2020, 5:15 AM · Restricted Project, debug-info

Aug 12 2020

Orlando added inline comments to D85636: [llvm-dwarfdump] Fix misleading scope byte coverage statistics.
Aug 12 2020, 10:30 AM · Restricted Project, debug-info

Aug 11 2020

Orlando updated the diff for D85636: [llvm-dwarfdump] Fix misleading scope byte coverage statistics.

Hi @dstenb, thanks for taking a look. I've updated the diff to include a test but it feels a little unwieldy. Is there a better way to test this?

Aug 11 2020, 3:49 AM · Restricted Project, debug-info

Aug 10 2020

Orlando requested review of D85636: [llvm-dwarfdump] Fix misleading scope byte coverage statistics.
Aug 10 2020, 4:14 AM · Restricted Project, debug-info

Jul 31 2020

Orlando added inline comments to D85018: [WIP][POC][DebugInfo] Support for DW_AT_start_scope for scoped variables.
Jul 31 2020, 4:04 AM · Restricted Project

Jul 30 2020

Orlando added a comment to D84891: WIP: [Verifier] Flag dbg.declares which specify different addresses for the same fragment.

Hi @vsk, just a inline question from me. And in addition, I noticed that SourceLevelDebugging specifically states "there can only be one call to llvm.dbg.declare for a given concrete local variable". I wonder if we should update this to say something like "there can only be one call to llvm.dbg.declare for a given fragment of a local variable"?

Jul 30 2020, 2:42 AM · Restricted Project

Jul 22 2020

Orlando committed rGce6de3747bce: [DebugInfo] Drop location ranges for variables which exist entirely outside the… (authored by Orlando).
[DebugInfo] Drop location ranges for variables which exist entirely outside the…
Jul 22 2020, 5:11 AM
Orlando closed D82129: [DebugInfo] Drop location ranges for variables which exist entirely outside the variable's scope.
Jul 22 2020, 5:11 AM · debug-info, Restricted Project
Orlando added a comment to D82129: [DebugInfo] Drop location ranges for variables which exist entirely outside the variable's scope.

LGTM once Paul's comment is addressed.

Jul 22 2020, 1:43 AM · debug-info, Restricted Project

Jul 20 2020

Orlando added a comment to D82129: [DebugInfo] Drop location ranges for variables which exist entirely outside the variable's scope.

Thanks everyone for the review and discussion so far. The general idea of the patch has been okayed and it just needs a code review now. Could anyone please take a look?

Jul 20 2020, 1:57 AM · debug-info, Restricted Project

Jul 10 2020

Orlando added a comment to D83495: [DebugInfo] Add DWARF emission for DBG_VALUE_LIST.

Hey, just noticed a couple of comments to remove from the tests.

Jul 10 2020, 2:47 AM · Restricted Project, debug-info

Jul 7 2020

Orlando added a comment to D82129: [DebugInfo] Drop location ranges for variables which exist entirely outside the variable's scope.

I think I didn't fully grasp that the blocks were being (tail-)merged, which makes the scope ambiguous, and all the rest. So I withdraw the objection on that basis. DWARF is fine with multiple variables pointing to the same location, but it's less forgiving about scopes IIRC, much like it can't describe multiple source attributions for an instructions. This all makes me sad, but that's how DWARF is at the moment.

Is there still an open question about whether this wants to be a cleanup pass or a verifier check? I apologize for losing track.

Jul 7 2020, 6:33 AM · debug-info, Restricted Project

Jul 6 2020

Orlando added a comment to D82129: [DebugInfo] Drop location ranges for variables which exist entirely outside the variable's scope.

Does anyone have any concerns with this patch that they feel have not been addressed?

Jul 6 2020, 1:50 AM · debug-info, Restricted Project
Orlando updated the summary of D82129: [DebugInfo] Drop location ranges for variables which exist entirely outside the variable's scope.
Jul 6 2020, 1:50 AM · debug-info, Restricted Project

Jun 29 2020

Orlando added a comment to D82129: [DebugInfo] Drop location ranges for variables which exist entirely outside the variable's scope.

Looking closer at COFF/register-variables.ll, it doesn't look like a bug but instead another victim of how we model debug info. Before running -branch-folder (Control Flow Optimizer) all the instructions in the else block belong to the else block scope. The branch folder merges the common tails from 'then' and 'else' into 'else', merging the debug-locations while it does so. @jmorse summarised the situation well offline: Every time we call getMergedLocation, we are creating the conditions where this occurs, and eliminating it during compilation would be a high burden.

Hmm - could you explain that in more detail? If we merge the locations both if and else scopes would cease to exist (since we can't represent that ambiguity), right? But the dbg.value doesn't use/care about its !dbg, so it continues existing/describing a variable location over some unrelated instructions?

Jun 29 2020, 1:34 AM · debug-info, Restricted Project

Jun 25 2020

Orlando added a comment to D82129: [DebugInfo] Drop location ranges for variables which exist entirely outside the variable's scope.

This patch depends on the ranges for all scopes to be (reasonably) correct,

I'd say instead that 'variable locations depend on the ranges for all scopes to be (reasonably) correct'. And that this patch just acknowledges that relationship and clears away what we cannot use/see in a debugger.

Either way, the question remains: when we find cases where we need to "clear away" something, is that a bug, or is this merely a cleanup pass? In the case of the test I commented on, it's a bug, and I'd rather not be hiding bugs.

Jun 25 2020, 7:26 AM · debug-info, Restricted Project

Jun 24 2020

Orlando added a comment to D82129: [DebugInfo] Drop location ranges for variables which exist entirely outside the variable's scope.

This patch depends on the ranges for all scopes to be (reasonably) correct,

Jun 24 2020, 2:40 AM · debug-info, Restricted Project

Jun 22 2020

Orlando updated the diff for D82129: [DebugInfo] Drop location ranges for variables which exist entirely outside the variable's scope.

Addressed comments from @aprantl

Jun 22 2020, 4:16 AM · debug-info, Restricted Project

Jun 19 2020

Orlando added a comment to D82129: [DebugInfo] Drop location ranges for variables which exist entirely outside the variable's scope.

Hi @aprantl, thanks for taking a look.

Jun 19 2020, 3:14 PM · debug-info, Restricted Project
Orlando added a comment to D82129: [DebugInfo] Drop location ranges for variables which exist entirely outside the variable's scope.

@djtodoro, @dblaikie, thank you both for your comments.

Jun 19 2020, 3:44 AM · debug-info, Restricted Project

Jun 18 2020

Orlando created D82129: [DebugInfo] Drop location ranges for variables which exist entirely outside the variable's scope.
Jun 18 2020, 3:21 PM · debug-info, Restricted Project

Jun 4 2020

Orlando accepted D79863: [DebugInfo] Refactor SalvageDebugInfo and SalvageDebugInfoForDbgValues.

Sorry for the delay, LGTM. Please wait 24h to see if anyone else has any further comments.

Jun 4 2020, 4:50 AM · debug-info, Restricted Project
Orlando added inline comments to D80957: [LiveDebugValues] Cache LexicalScopes::getMachineBasicBlocks, NFCI.
Jun 4 2020, 1:02 AM · Restricted Project

Jun 3 2020

Orlando added inline comments to D80957: [LiveDebugValues] Cache LexicalScopes::getMachineBasicBlocks, NFCI.
Jun 3 2020, 2:10 AM · Restricted Project

Jun 2 2020

Orlando added a comment to D80691: Proposed fix for PR46114.

@Orlando I think you are probably right. It should indeed prints $0=1. I appreciate your patience and my apology for the report. Shall I close the original PR?

Jun 2 2020, 7:41 AM · debug-info, Restricted Project
Orlando updated subscribers of D80691: Proposed fix for PR46114.

Thanks @Orlando, I think I agree with your reasoning. My patch on introducing an undef is based on the same reasoning (but I could be totally wrong).

Let's see what we should do instead.

Before earlycse, we have:

  %0 = load i32, i32* @a, align 4, !dbg !26, !tbaa !27
  call void @llvm.dbg.value(metadata i32 0, metadata !22, metadata !DIExpression()), !dbg !31
  %1 = load i32, i32* @a, align 4, !dbg !32, !tbaa !27
  call void @llvm.dbg.value(metadata i32 %1, metadata !22, metadata !DIExpression()), !dbg !31

!26 = !DILocation(line: 5, column: 11, scope: !17)
!31 = !DILocation(line: 0, scope: !17)
!32 = !DILocation(line: 6, column: 15, scope: !17)

after earlycse, we have:

  %0 = load i32, i32* @a, align 4, !dbg !26, !tbaa !27
; I omitted the variable !21 here since it's irrelevant.
  call void @llvm.dbg.value(metadata i32 0, metadata !22, metadata !DIExpression()), !dbg !31
  call void @llvm.dbg.value(metadata i32 %0, metadata !22, metadata !DIExpression()), !dbg !31

!21 = !DILocalVariable(name: "d", scope: !17, file: !3, line: 5, type: !12)
!22 = !DILocalVariable(name: "l_52", scope: !17, file: !3, line: 5, type: !12)
!26 = !DILocation(line: 5, column: 11, scope: !17)
!31 = !DILocation(line: 0, scope: !17)
!32 = !DILocation(line: 6, column: 20, scope: !17)

Could you please help me verify the following?
Based on my understanding, it seems that when eliminating the second load i32, i32* @a in EarlyCSE, we should use the location !32 instead of !26 for the resulting load i32, i32* @a.
Thanks.

Jun 2 2020, 6:03 AM · debug-info, Restricted Project
Orlando added a comment to D80957: [LiveDebugValues] Cache LexicalScopes::getMachineBasicBlocks, NFCI.

This makes sense to me.

Jun 2 2020, 2:45 AM · Restricted Project

Jun 1 2020

Orlando added inline comments to D80929: [NFC][LiveDebugvalues] Document how LiveDebugValues operates.
Jun 1 2020, 9:06 AM · Restricted Project
Orlando added a comment to D78369: [DebugInfo] Reduce SalvageDebugInfo() functions.

LGTM. There are two other text only LGTMs on this patch and AFAICT the only blocker is the (inline) discussion on whether salvageDebugInfo needs renaming, but there doesn't seem to be a consensus. Does anyone have a strong opinion on this subject?

Jun 1 2020, 3:41 AM · Restricted Project, debug-info
Orlando added a comment to D80691: Proposed fix for PR46114.

This is quite a long reply so I've got a very small "summary" at the end.

Jun 1 2020, 3:09 AM · debug-info, Restricted Project

May 29 2020

Orlando requested changes to D80691: Proposed fix for PR46114.

I think that this patch reduces variable coverage by undefing dbg.values which
it cannot salvage that would otherwise be RAUWd.

May 29 2020, 2:08 AM · debug-info, Restricted Project
Orlando added inline comments to D78369: [DebugInfo] Reduce SalvageDebugInfo() functions.
May 29 2020, 1:03 AM · Restricted Project, debug-info

May 28 2020

Orlando added a comment to D80691: Proposed fix for PR46114.

I had another look at this and followed it up on the ticket (PR46114).

May 28 2020, 7:35 AM · debug-info, Restricted Project
Orlando added a comment to D80691: Proposed fix for PR46114.

I had another look at this and followed it up on the ticket (PR46114).

May 28 2020, 7:34 AM · debug-info, Restricted Project
Orlando added inline comments to D78369: [DebugInfo] Reduce SalvageDebugInfo() functions.
May 28 2020, 4:51 AM · Restricted Project, debug-info
Orlando added a project to D80691: Proposed fix for PR46114: debug-info.

Thanks for working on this!

May 28 2020, 3:12 AM · debug-info, Restricted Project

May 19 2020

Orlando added inline comments to D79863: [DebugInfo] Refactor SalvageDebugInfo and SalvageDebugInfoForDbgValues.
May 19 2020, 2:40 AM · debug-info, Restricted Project
Orlando added a comment to D79863: [DebugInfo] Refactor SalvageDebugInfo and SalvageDebugInfoForDbgValues.

I left some nits inline but otherwise I think this is good.

May 19 2020, 1:36 AM · debug-info, Restricted Project

May 18 2020

Orlando committed rG709c52b9553f: [DebugInfo][DWARF] Emit a single location instead of a location list (authored by Orlando).
[DebugInfo][DWARF] Emit a single location instead of a location list
May 18 2020, 2:06 AM
Orlando closed D79571: [DebugInfo][DWARF] Emit a single location instead of a location list.
May 18 2020, 2:06 AM · Restricted Project, debug-info
Orlando added a comment to D79571: [DebugInfo][DWARF] Emit a single location instead of a location list.

Thank you both, and @jmorse for doing a lot of the heavy lifting on this before I got to it.

May 18 2020, 2:05 AM · Restricted Project, debug-info

May 15 2020

Orlando added inline comments to D79571: [DebugInfo][DWARF] Emit a single location instead of a location list.
May 15 2020, 3:02 AM · Restricted Project, debug-info

May 14 2020

Orlando created D79949: [WIP][Example] Drop out-of-scope variable locations.
May 14 2020, 10:16 AM · Restricted Project

May 13 2020

Orlando updated the diff for D79571: [DebugInfo][DWARF] Emit a single location instead of a location list.

+ Addressed your inline comments.

May 13 2020, 2:07 AM · Restricted Project, debug-info

May 12 2020

Orlando updated the diff for D79571: [DebugInfo][DWARF] Emit a single location instead of a location list.

I've updated the diff to include 'single-location-inlined-param.mir' and 'single-location-interrupted-scope.mir' which should cover both of those cases IIUC.

May 12 2020, 2:39 AM · Restricted Project, debug-info