Fix use of undefined session variable

[thopre]

Summary

Commit eb0f1b51e7bcf46cf8868ea0186f8e8f086e6ed8 introduced uses of
variable session in lnt/server/reporting/summaryreport.py but one of
them is in function _build_data_table() which does not have a session
parameter. This commit adds the parameter and update call sites
accordingly, fixing one of Flake8's F821 warning (undefined name).

[tnfchris]

This commit adds the parameter and update call sites
accordingly, fixing one of Flake8's F821 warning (undefined name).

Sorry I'm not very well versed in Flake8, but why does this fix this specific warning? session isn't used so just wondering how it suppresses undefined name.

[thopre]

lnt/server/reporting/summaryreport.py

344

@tnfchris This existing use of session is "undefined name" for Flake8 because session is not defined in that context. This patch adds the session parameter to the method this code is part of, thereby making session no longer undefined.

[tnfchris]

Aha thanks for the explanation

lnt/server/reporting/summaryreport.py

def build(self, session):
         # The table keys are tuples of:
         #  (<test name>,
         #   <metric>, # Value is either 'Compile Time' or 'Execution Time'.
         #   <arch>,
         #   <build mode>, # Value is either 'Debug' or 'Release'.
         #   <machine id>)
 
         self.data_table = {}
-        self._build_data_table()
+        self._build_data_table(session)
 
         # Compute indexed data table by applying the indexing functions.
         self._build_indexed_data_table()
 
         # Normalize across all machines.
         self._build_normalized_data_table()
 
         # Build final organized data tables.
         self._build_final_data_tables()
 
-    def _build_data_table(self):
+    def _build_data_table(self, session):
         def get_nts_datapoints_for_sample(ts, sample):
             # Get the basic sample info.
             run_id = sample[0]
             machine_id = run_machine_id_map[run_id]
             run_parameters = run_parameters_map[run_id]
 
             # Get the test.
             test = ts_tests[sample[1]]
def _build_data_table(self, session):
 
                 # Preload the run parameters.
                 run_parameters_map = dict((r.id, r.parameters)
                                           for r in ts_runs)
 
                 # Load all the samples for all runs we are interested in.
                 columns = [ts.Sample.run_id, ts.Sample.test_id]
                 columns.extend(f.column for f in ts.sample_fields)
                 samples = session.query(*columns).filter(
                     ts.Sample.run_id.in_(list(run_id_map.keys())))
                 for sample in samples:
                     for key, value in get_datapoints_for_sample(ts, sample):
                         items = self.data_table.get(key)
                         if items is None:
                             items = [[]
                                      for _ in self.report_orders]
                             self.data_table[key] = items