This is an archive of the discontinued LLVM Phabricator instance.

Differential D94842

Extend mandatory Flake8 cleanness
ClosedPublic

Authored by thopre on Jan 15 2021, 3:55 PM.

Details

Reviewers
tnfchris
danilaml
cmatthews
Summary

With the wider Flake8 run clean, this commit makes it mandatory and
removes the redundant narrower Flake8 call on the whitelist, removing
the now useless whitelist.

Diff Detail

Revision Contents

PathSize
17 lines

Diff 317103

tox.ini

[base]
# Files we'd like to keep lint clean. Lets hope we can expand this list.
whitelist_files = ./setup.py
./deployment/
./lnt/formats/
./lnt/util/
./lnt/tests/
./lnt/testing/
./tests/server/ui/
[tox] [tox]
envlist = py27 envlist = py27
py3 py3
mypy mypy
flake8 flake8
docs docs
[testenv] [testenv]
Show All 16 Linescommands =
- mypy --junit-xml=junit-{envname}.xml --ignore-missing-imports lnt - mypy --junit-xml=junit-{envname}.xml --ignore-missing-imports lnt
[testenv:flake8] [testenv:flake8]
skip_install = true skip_install = true
deps = deps =
flake8 flake8
commands = commands =
# Still lots of problems. # Lets keep the clean files clean.
- flake8 --statistics --exclude=./lnt/external/ ./lnt/ ./tests/ ./setup.py ./deployment/ flake8 --statistics --exclude=./lnt/external/ ./lnt/ ./tests/ ./setup.py ./deployment/
# But lets keep the clean files clean.
flake8 {[base]whitelist_files}
[testenv:docs] [testenv:docs]
skip_install = true skip_install = true
deps = deps =
sphinx<2.0.0 sphinx<2.0.0
sphinx_bootstrap_theme sphinx_bootstrap_theme
commands = commands =
make -C {toxinidir}/docs/ html make -C {toxinidir}/docs/ html