Page MenuHomePhabricator

danilaml (Danila Malyutin)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 28 2018, 12:53 PM (146 w, 5 d)

Recent Activity

Yesterday

danilaml closed D94767: [LNT] Fix some ResourceWarnings.

Landed in https://github.com/llvm/llvm-lnt/commit/e736349f7cca1b18e93b6a12e222db0bafcf54f5

Mon, Jan 18, 3:34 AM

Fri, Jan 15

danilaml closed D94775: [LNT] add __pycache__ to ignored files.

Landed in https://github.com/llvm/llvm-lnt/commit/2e93cbd17fd5eb4b2e3773e5022186feac554d7c

Fri, Jan 15, 6:52 AM
danilaml updated the diff for D94775: [LNT] add __pycache__ to ignored files.
Fri, Jan 15, 6:45 AM
danilaml added reviewers for D94775: [LNT] add __pycache__ to ignored files: thopre, cmatthews, MatzeB.
Fri, Jan 15, 6:44 AM
danilaml requested review of D94775: [LNT] add __pycache__ to ignored files.
Fri, Jan 15, 6:42 AM
danilaml closed D94774: [LNT] Fix F811 warnings.

Committed in https://github.com/llvm/llvm-lnt/commit/0982122b76efad15e244a18b42ce77de2a906140

Fri, Jan 15, 6:36 AM
danilaml added a reviewer for D94774: [LNT] Fix F811 warnings: thopre.
Fri, Jan 15, 6:32 AM
danilaml requested review of D94774: [LNT] Fix F811 warnings.
Fri, Jan 15, 6:31 AM
danilaml added inline comments to D94767: [LNT] Fix some ResourceWarnings.
Fri, Jan 15, 6:25 AM
danilaml added inline comments to D94767: [LNT] Fix some ResourceWarnings.
Fri, Jan 15, 6:09 AM
danilaml updated the diff for D94767: [LNT] Fix some ResourceWarnings.
Fri, Jan 15, 6:09 AM
danilaml accepted D94758: Ignore files generated by running tox.

LGTM

Fri, Jan 15, 5:58 AM
danilaml added a reviewer for D94767: [LNT] Fix some ResourceWarnings: thopre.
Fri, Jan 15, 5:03 AM
danilaml requested review of D94767: [LNT] Fix some ResourceWarnings.
Fri, Jan 15, 4:59 AM
danilaml added a comment to D94418: [LNT] Python 3 support: fix several bytes/str inconsistencies.

Sorry, I'm not aware of a buildbot for LNT. I did not even know there was one before.

Fri, Jan 15, 3:03 AM
danilaml added a comment to D94418: [LNT] Python 3 support: fix several bytes/str inconsistencies.

I'm personally more enclined to prevent lit from running without lit installed because then some of the tests are skipped.

Fri, Jan 15, 2:45 AM

Thu, Jan 14

danilaml added a comment to D94418: [LNT] Python 3 support: fix several bytes/str inconsistencies.

Sorry, pushed to the wrong branch (Phabricator/arcanist workflow is annoying >_<) and didn't notice your comment.

Hm, I've made sure that all tests pass on both py2 and py3 before submitting and I can't reproduce it on my machine.
Could you check if test_suite-profile-import.py.tmp.err and test_suite-profile-import.py.tmp.log have any suspicious errors (they should be in <..>/test_run_tmp/runtest/Output/)?

Do you use tox to run the tests?

I use lit directly (lit -svv ./tests) which what I understand tox does as well. I've rerun all tests using tox and the only test that failed was server/ui/V4Pages.py (I believe it's because I've already had an lnt instance running and that test doesn't account for that possibility).

Are you testing your patch on top of 042938b5c332fa63f1fefdd7116f39e161b8c51b? My guess is you are testing on a commit prior to f98bc1b3018248fbe551b0e7491ac5ba388216d5 which prevents tests involving profile from being run. Btw, using tox with a comparison of before/after logs allows you to spot codestyle issues added by your patch like the double glob import I pointed out.

Best regards,

Thomas

Thu, Jan 14, 9:46 AM
danilaml added inline comments to D93900: [llvm-readef/obj] - Change the design structure of ELF dumper. NFCI..
Thu, Jan 14, 9:35 AM · Restricted Project
danilaml added a comment to D86126: Fix issue 47160: "`llvm::is_trivially_copyable` -- static assertion failure after DR 1734".

ping?

Thu, Jan 14, 9:01 AM · Restricted Project
danilaml added a comment to D94418: [LNT] Python 3 support: fix several bytes/str inconsistencies.

Sorry, pushed to the wrong branch (Phabricator/arcanist workflow is annoying >_<) and didn't notice your comment.

Hm, I've made sure that all tests pass on both py2 and py3 before submitting and I can't reproduce it on my machine.
Could you check if test_suite-profile-import.py.tmp.err and test_suite-profile-import.py.tmp.log have any suspicious errors (they should be in <..>/test_run_tmp/runtest/Output/)?

Do you use tox to run the tests?

I use lit directly (lit -svv ./tests) which what I understand tox does as well. I've rerun all tests using tox and the only test that failed was server/ui/V4Pages.py (I believe it's because I've already had an lnt instance running and that test doesn't account for that possibility).

Thu, Jan 14, 8:22 AM
danilaml added a comment to D94418: [LNT] Python 3 support: fix several bytes/str inconsistencies.

Sorry, pushed to the wrong branch (Phabricator/arcanist workflow is annoying >_<) and didn't notice your comment.

Thu, Jan 14, 8:07 AM
danilaml added a comment to D94418: [LNT] Python 3 support: fix several bytes/str inconsistencies.

Could you explain me what does the test you added do? I'm not familiar with lnt runtest and its option nor with all the lit thingy.

Thu, Jan 14, 5:25 AM
danilaml added a comment to D94418: [LNT] Python 3 support: fix several bytes/str inconsistencies.

Fixed tests.

Thu, Jan 14, 4:26 AM
danilaml updated the diff for D94418: [LNT] Python 3 support: fix several bytes/str inconsistencies.
Thu, Jan 14, 4:01 AM

Wed, Jan 13

danilaml added a comment to D94418: [LNT] Python 3 support: fix several bytes/str inconsistencies.

Added a test.

Wed, Jan 13, 9:59 AM
danilaml updated the diff for D94418: [LNT] Python 3 support: fix several bytes/str inconsistencies.
Wed, Jan 13, 9:53 AM

Mon, Jan 11

danilaml added inline comments to D94418: [LNT] Python 3 support: fix several bytes/str inconsistencies.
Mon, Jan 11, 10:00 AM
danilaml added a comment to D94418: [LNT] Python 3 support: fix several bytes/str inconsistencies.

I'll try to come up with a test case. I thought there were already tests for profile data, so I need to look into why they didn't catch it.

Mon, Jan 11, 9:58 AM
danilaml added inline comments to D94418: [LNT] Python 3 support: fix several bytes/str inconsistencies.
Mon, Jan 11, 8:13 AM
danilaml added reviewers for D94418: [LNT] Python 3 support: fix several bytes/str inconsistencies: thopre, cmatthews, jmolloy, kristof.beyls.
Mon, Jan 11, 8:10 AM
danilaml requested review of D94418: [LNT] Python 3 support: fix several bytes/str inconsistencies.
Mon, Jan 11, 8:06 AM

Thu, Dec 31

danilaml added a comment to D75746: [LoopVectorizer] Simplify branch in the remainder loop for trivial cases.

Is there no transform that can be taught to do this cleanup instead?

Thu, Dec 31, 8:03 AM · Restricted Project
danilaml updated the diff for D75746: [LoopVectorizer] Simplify branch in the remainder loop for trivial cases.
Thu, Dec 31, 5:08 AM · Restricted Project

Mon, Dec 28

danilaml added inline comments to D93794: Fixed a build error when using CMake 3.15.1 + NDK-R20.
Mon, Dec 28, 4:33 AM · Restricted Project

Dec 10 2020

danilaml added inline comments to rGf5d07a05bbd4: [Hexagon] Realign HVX vectors wherever possible.
Dec 10 2020, 7:34 AM
danilaml added inline comments to rGf5d07a05bbd4: [Hexagon] Realign HVX vectors wherever possible.
Dec 10 2020, 4:05 AM

Nov 27 2020

danilaml added a reviewer for D76127: [TableGen] Do not set ReadOnly attribute on intrinsics with side effects: jdoerfert.
Nov 27 2020, 3:14 AM · Restricted Project
danilaml added a comment to D76127: [TableGen] Do not set ReadOnly attribute on intrinsics with side effects.

@TOCK
I've meant the surrounding context for the diff (https://llvm.org/docs/Phabricator.html#phabricator-request-review-web),
i.e. git show HEAD -U999999

Nov 27 2020, 3:12 AM · Restricted Project

Nov 26 2020

danilaml added a comment to D76127: [TableGen] Do not set ReadOnly attribute on intrinsics with side effects.

The diffs lack context.

Nov 26 2020, 6:09 AM · Restricted Project

Nov 19 2020

danilaml added reviewers for D86126: Fix issue 47160: "`llvm::is_trivially_copyable` -- static assertion failure after DR 1734": serge-sans-paille, fedor.sergeev.

I've taken a liberty of adding more reviewers to hopefully help get this going.

Nov 19 2020, 2:36 AM · Restricted Project

Oct 30 2020

danilaml added a comment to D86126: Fix issue 47160: "`llvm::is_trivially_copyable` -- static assertion failure after DR 1734".

Ping?

Oct 30 2020, 6:29 AM · Restricted Project

Oct 14 2020

danilaml added inline comments to D89220: [clang-rename] Simplify the code of handling class paritial specializations, NFC..
Oct 14 2020, 5:04 AM · Restricted Project

Oct 6 2020

danilaml added a comment to D75746: [LoopVectorizer] Simplify branch in the remainder loop for trivial cases.

Rebased.
Had some time to come back to this.
I've tried implementing the following proposed way to get VTC locally:

Oct 6 2020, 7:00 AM · Restricted Project
danilaml updated the diff for D75746: [LoopVectorizer] Simplify branch in the remainder loop for trivial cases.
Oct 6 2020, 6:47 AM · Restricted Project

Jul 10 2020

danilaml closed D83396: [LNT] Use minimized version of jquery.scrolltofixed.

Committed in 4c57b004f148dffc6db199890d91fc3e6e578972

Jul 10 2020, 8:44 AM

Jul 8 2020

danilaml added reviewers for D83396: [LNT] Use minimized version of jquery.scrolltofixed: jmolloy, cmatthews.
Jul 8 2020, 7:25 AM
danilaml added a comment to D83396: [LNT] Use minimized version of jquery.scrolltofixed.

Btw, it looks like lnt's .arcconfig is missing a callsign which broke moz-phab when I tried to submit using it.

Jul 8 2020, 7:21 AM
danilaml created D83396: [LNT] Use minimized version of jquery.scrolltofixed.
Jul 8 2020, 7:18 AM

Jul 7 2020

danilaml added a comment to D62574: Add support for target-configurable address spaces..

It's generally not safe to alter address spaces below the top level. C is just very permissive about it.

Jul 7 2020, 9:44 AM · Restricted Project

Jul 6 2020

danilaml added a comment to D62574: Add support for target-configurable address spaces..

What are the remaining roadblocks left before this patch can be merged? I'm interested in having a target-specific way to define the allowed explicit/implicit address space conversions.
Also, it appears that currently whether implicit casts between pointers of different AS are allowed is determined by the superset relations only, however https://reviews.llvm.org/D73360 introduced another (openCL-specific) variable into the mix: whether the conversion is a top level or not. IMHO, this should also be configured by the target, although I'm not sure whether it needs a separate hook (isBitcastNoop or similar?) or it needs to check the legality of the implicit casts differently.

Jul 6 2020, 8:05 AM · Restricted Project

Jul 3 2020

danilaml committed rG38909f31bd08: [IR] Short-circuit comparison with itself for Attributes (authored by danilaml).
[IR] Short-circuit comparison with itself for Attributes
Jul 3 2020, 6:26 AM
danilaml closed D82295: [IR] Short-circuit comparison with itself for Attributes.
Jul 3 2020, 6:26 AM · Restricted Project

Jun 30 2020

danilaml added a comment to D82295: [IR] Short-circuit comparison with itself for Attributes.

ping

Jun 30 2020, 7:34 AM · Restricted Project

Jun 25 2020

danilaml abandoned D71657: [SDAG] Handle BUILD_PAIR in ComputeNumSignBits.

@RKSimon sadly not.

Jun 25 2020, 3:12 AM · Restricted Project

Jun 23 2020

danilaml updated the diff for D82295: [IR] Short-circuit comparison with itself for Attributes.
Jun 23 2020, 4:45 AM · Restricted Project
danilaml added a comment to D82295: [IR] Short-circuit comparison with itself for Attributes.

@dblaikie It was actually failing on some of the lit tests when compiler was compiled with EXPENSIVE_CHECKS enabled (kind of how I discovered it), but after this recent refactor which removed a sort step: https://github.com/llvm/llvm-project/commit/ed766f1bb1040a520fb5646ab75851e2b0fd66df#diff-7b43e801c5abbb03d571f9aad6af63a5L792
I don't know if the codepath with ::sort (which has those checks) can be hit from llvm IR. Instead, I've added an explicit check to AttributesTest.cpp that currently asserts.

Jun 23 2020, 4:45 AM · Restricted Project

Jun 22 2020

danilaml added inline comments to D43620: [Pipeliner] Fixed node order issue related to zero latency edges.
Jun 22 2020, 8:35 AM · Restricted Project
danilaml updated the diff for D82295: [IR] Short-circuit comparison with itself for Attributes.
Jun 22 2020, 8:01 AM · Restricted Project
danilaml added inline comments to D82295: [IR] Short-circuit comparison with itself for Attributes.
Jun 22 2020, 6:57 AM · Restricted Project
danilaml added reviewers for D82295: [IR] Short-circuit comparison with itself for Attributes: dblaikie, t.p.northover, jyknight.
Jun 22 2020, 6:57 AM · Restricted Project
danilaml created D82295: [IR] Short-circuit comparison with itself for Attributes.
Jun 22 2020, 6:26 AM · Restricted Project

Jun 18 2020

Herald added a project to D43620: [Pipeliner] Fixed node order issue related to zero latency edges: Restricted Project.

Sorry for commenting on an old merge PR, but was looking through some asserts and stumbled on this code which raised some questions.

Jun 18 2020, 7:34 AM · Restricted Project

Apr 6 2020

danilaml added inline comments to D75746: [LoopVectorizer] Simplify branch in the remainder loop for trivial cases.
Apr 6 2020, 8:38 AM · Restricted Project
danilaml updated the diff for D75746: [LoopVectorizer] Simplify branch in the remainder loop for trivial cases.
Apr 6 2020, 8:05 AM · Restricted Project

Apr 3 2020

danilaml added inline comments to rG37943e518c5a: [docs] Added solutions to slow build under common problems..
Apr 3 2020, 8:02 AM
danilaml updated the diff for D75746: [LoopVectorizer] Simplify branch in the remainder loop for trivial cases.
Apr 3 2020, 7:29 AM · Restricted Project
danilaml added inline comments to D75746: [LoopVectorizer] Simplify branch in the remainder loop for trivial cases.
Apr 3 2020, 6:57 AM · Restricted Project
danilaml updated the diff for D75746: [LoopVectorizer] Simplify branch in the remainder loop for trivial cases.
Apr 3 2020, 6:24 AM · Restricted Project
danilaml updated the diff for D75746: [LoopVectorizer] Simplify branch in the remainder loop for trivial cases.
Apr 3 2020, 6:24 AM · Restricted Project

Apr 2 2020

danilaml added inline comments to D68510: [PATCH 16/27] [noalias] Clone scopes and llvm.noalias.decl when unrolling..
Apr 2 2020, 3:45 AM · Restricted Project

Mar 20 2020

danilaml added a comment to D75746: [LoopVectorizer] Simplify branch in the remainder loop for trivial cases.

Updated revision with additional checks and rebased.

Mar 20 2020, 10:50 AM · Restricted Project
danilaml updated the diff for D75746: [LoopVectorizer] Simplify branch in the remainder loop for trivial cases.
Mar 20 2020, 10:49 AM · Restricted Project

Mar 18 2020

danilaml committed rG2aaafaf5005f: [NFC] Add missing REQUIRES clause to a test (authored by danilaml).
[NFC] Add missing REQUIRES clause to a test
Mar 18 2020, 7:03 AM
danilaml committed rG940ba1465b2c: Fix possible assertion when using PBQP with debug info (authored by danilaml).
Fix possible assertion when using PBQP with debug info
Mar 18 2020, 5:57 AM
danilaml closed D76129: Fix possible assertion when using PBQP with debug info.
Mar 18 2020, 5:57 AM · Restricted Project

Mar 17 2020

danilaml updated the diff for D76129: Fix possible assertion when using PBQP with debug info.
Mar 17 2020, 8:31 AM · Restricted Project

Mar 16 2020

danilaml added inline comments to D76129: Fix possible assertion when using PBQP with debug info.
Mar 16 2020, 10:52 AM · Restricted Project
danilaml added inline comments to D76129: Fix possible assertion when using PBQP with debug info.
Mar 16 2020, 8:42 AM · Restricted Project
danilaml updated the diff for D76129: Fix possible assertion when using PBQP with debug info.
Mar 16 2020, 8:42 AM · Restricted Project
danilaml added a comment to D73501: [SCEV] rewriteLoopExitValues(): even if have hard uses, still rewrite if cheap (PR44668).

@lebedev.ri I've been successfully using a pass based on https://reviews.llvm.org/D12494 in a downstream port (although I'm not sure if it's enough to fix all ARM's regressions). I was planning to submit it for the review after some touch ups (i.e. it only uses legacy pm) but haven't found the time for that yet. I also need to evaluate whether it is still needed after D75908 (that might take some time).

Mar 16 2020, 5:52 AM · Restricted Project

Mar 13 2020

danilaml added a comment to D75746: [LoopVectorizer] Simplify branch in the remainder loop for trivial cases.

ping

Mar 13 2020, 10:44 AM · Restricted Project
danilaml updated the diff for D76129: Fix possible assertion when using PBQP with debug info.
Mar 13 2020, 10:11 AM · Restricted Project
danilaml added inline comments to D76129: Fix possible assertion when using PBQP with debug info.
Mar 13 2020, 9:39 AM · Restricted Project
danilaml updated the diff for D76129: Fix possible assertion when using PBQP with debug info.
Mar 13 2020, 9:39 AM · Restricted Project
danilaml updated the diff for D76129: Fix possible assertion when using PBQP with debug info.
Mar 13 2020, 7:28 AM · Restricted Project
danilaml added a comment to D76129: Fix possible assertion when using PBQP with debug info.

Test generated from the following C code:

Mar 13 2020, 7:28 AM · Restricted Project
danilaml added a reviewer for D76129: Fix possible assertion when using PBQP with debug info: aadg.
Mar 13 2020, 6:55 AM · Restricted Project
danilaml updated the summary of D76129: Fix possible assertion when using PBQP with debug info.
Mar 13 2020, 6:22 AM · Restricted Project
danilaml created D76129: Fix possible assertion when using PBQP with debug info.
Mar 13 2020, 6:22 AM · Restricted Project

Mar 6 2020

danilaml added inline comments to D75746: [LoopVectorizer] Simplify branch in the remainder loop for trivial cases.
Mar 6 2020, 8:13 AM · Restricted Project
danilaml added reviewers for D75746: [LoopVectorizer] Simplify branch in the remainder loop for trivial cases: Ayal, fhahn, hsaito, gilr, rengolin, dcaballe.
Mar 6 2020, 8:13 AM · Restricted Project
danilaml updated the diff for D75746: [LoopVectorizer] Simplify branch in the remainder loop for trivial cases.
Mar 6 2020, 8:13 AM · Restricted Project
danilaml updated the diff for D75746: [LoopVectorizer] Simplify branch in the remainder loop for trivial cases.
Mar 6 2020, 8:13 AM · Restricted Project
danilaml added inline comments to D75746: [LoopVectorizer] Simplify branch in the remainder loop for trivial cases.
Mar 6 2020, 7:41 AM · Restricted Project
danilaml created D75746: [LoopVectorizer] Simplify branch in the remainder loop for trivial cases.
Mar 6 2020, 7:41 AM · Restricted Project

Feb 19 2020

danilaml added a comment to D65673: [MBP] Disable aggressive loop rotate in plain mode.

@Carrot this seems to be reverted, but aggressive loop rotate still has mostly negative affect on performance in internal benchmarks that I've run.
Could you please elaborate on how branches taken was reduced from 2 to 1 (and how it was calculated) for the test case you mentioned in the https://reviews.llvm.org/D43256#1534855

Feb 19 2020, 8:14 AM · Restricted Project

Jan 1 2020

danilaml added a comment to D71657: [SDAG] Handle BUILD_PAIR in ComputeNumSignBits.

@craig.topper this pass runs on IR. In the real code that prompted me to come up with this patch the BB block was split during ISel building phase, because (IUC) it was too big. And just so happens that the split was right between sext to i64 and mul. I've tried to simulate it with the code above.
@bjope Thanks. That might be a valid option for testing (although it's not really target specific at this point). However, it might be moot if it turns out there is no way to either 1) check whether two CopyFromRegs came from the same IR value or 2) find out in other ways that one node is just replicated sign bit of the other node.

Jan 1 2020, 7:08 AM · Restricted Project

Dec 30 2019

danilaml added inline comments to D71657: [SDAG] Handle BUILD_PAIR in ComputeNumSignBits.
Dec 30 2019, 8:13 AM · Restricted Project

Dec 23 2019

danilaml added a comment to D71657: [SDAG] Handle BUILD_PAIR in ComputeNumSignBits.

One of the motivating examples (not sure how stable this IR to use as a test) is something like this (needs -mllvm -disable-cgp to prevent sext sinking):

define i64 @foo(i32 %a, i32 %b) local_unnamed_addr {
entry:
  %conv6 = sext i32 %a to i64
  %conv17 = sext i32 %b to i64
  %add = add i64 %conv6, 42
  %cmp0 = icmp slt i64 %conv17, %add
  br i1 %cmp0, label %exit, label %exit2 ; branch to prevent bb merging
Dec 23 2019, 9:25 AM · Restricted Project
danilaml added inline comments to D71657: [SDAG] Handle BUILD_PAIR in ComputeNumSignBits.
Dec 23 2019, 8:02 AM · Restricted Project