Page MenuHomePhabricator
People cmatthews

cmatthews (Chris Matthews)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 9 2015, 11:31 AM (305 w, 5 d)

Recent Activity
View All

Jan 20 2021

cmatthews accepted D94759: Mirror LLVM's arc config.
Jan 20 2021, 10:02 AM

Jan 14 2021

cmatthews accepted D94722: Fix whitespaces flake8 errors and warnings.
Jan 14 2021, 2:02 PM
cmatthews accepted D94721: Fix multiple import on one line.
Jan 14 2021, 2:02 PM
cmatthews accepted D94723: Fix under and over continuation indentation.
Jan 14 2021, 2:01 PM
cmatthews accepted D94720: Fix non multiple of 4 indentation.
Jan 14 2021, 2:01 PM
cmatthews accepted D94686: Fix all unused imports flake8 warnings.
Jan 14 2021, 12:59 PM
cmatthews accepted D94635: Fix server/ui/V4Pages test.

LGTM

Jan 14 2021, 10:55 AM
cmatthews accepted D94663: Fix use of wrong and undef variable.

LGTM.

Jan 14 2021, 10:53 AM
cmatthews added a comment to D94686: Fix all unused imports flake8 warnings.

Could you put your analysis of why the noqa is needed in the noqa comments, so that it will be easy to understand from looking at the code?

Jan 14 2021, 10:52 AM

Oct 2 2020

cmatthews accepted D87235: Test default compare in global status page.

LGTM. Thanks!

Oct 2 2020, 1:01 PM

Sep 21 2020

cmatthews accepted D88061: [Testsuite] allow a linker to be specified.

LGTM. Thanks!

Sep 21 2020, 6:04 PM

Jul 8 2020

cmatthews accepted D83396: [LNT] Use minimized version of jquery.scrolltofixed.

Good idea. Thanks!

Jul 8 2020, 10:45 AM

Jun 6 2020

cmatthews accepted D81337: Add max-failures option to lit documentation.

Good idea!

Jun 6 2020, 6:08 PM · Restricted Project

May 1 2020

cmatthews accepted D79250: Fix crash in psycopg2 with docker image.
May 1 2020, 6:44 PM
cmatthews accepted D79238: Fix pip install line in Dockerfile.

Thanks, I didn’t have a system to check my changes on!

May 1 2020, 6:44 PM

Apr 30 2020

cmatthews requested changes to D61598: lnt runtest test-suite: add --qemu-user-mode support.

Sure, this is fine. Can you add a test?

Apr 30 2020, 10:41 AM
cmatthews accepted D78632: [LNT] Fix rm-machine error reporting.

Sorry, I was reviewing out of order and approved: D79183 which also has a fix for this. I like the test case though, could you commit the test case?

Apr 30 2020, 10:40 AM
cmatthews accepted D79183: Fix dynamic import of http.client.

Thanks!

Apr 30 2020, 10:40 AM
cmatthews accepted D76308: [LNT] Fix legend color .

Thanks!

Apr 30 2020, 10:40 AM
cmatthews accepted D75891: [LNT] Fix get_sliding_runs of RunInfo.

Good catch! Thanks!

Apr 30 2020, 10:08 AM

Apr 12 2020

cmatthews accepted D77986: [lit] Move llvm-test-suite result codes into llvm/lit.

Lgtm. Thanks!

Apr 12 2020, 8:50 PM · Restricted Project

Feb 14 2020

cmatthews accepted D74593: Fixes a bug in pstat module.
Feb 14 2020, 10:12 AM

Feb 13 2020

cmatthews accepted D74175: Removing SVN download of LIT due to MonoRepo.

LGTM

Feb 13 2020, 1:29 PM · Restricted Project
cmatthews added a comment to D74175: Removing SVN download of LIT due to MonoRepo.

Just to confirm, you are using git+git not git+https?

Feb 13 2020, 10:43 AM · Restricted Project

Feb 7 2020

cmatthews requested changes to D74175: Removing SVN download of LIT due to MonoRepo.

Can you remove the commented out old line. Otherwise, LGTM.

Feb 7 2020, 4:14 PM · Restricted Project
cmatthews added a comment to D74175: Removing SVN download of LIT due to MonoRepo.

In the past there has been rev lock between LNT and LIT, so we try to fetch the most up to date lit we can. The pypi version can be quite out of date.

Feb 7 2020, 3:38 PM · Restricted Project
cmatthews requested changes to D74175: Removing SVN download of LIT due to MonoRepo.

How is the lit requirement no longer needed? This URL does not work, but the we still require lit to be installed for the system to work. I think this needed to be updated to fetch the latest lit from the GitHub repo.

Feb 7 2020, 11:58 AM · Restricted Project

Feb 3 2020

cmatthews accepted D42894: [LNT] Use session saved baseline in run comparison report.

LGTM

Feb 3 2020, 11:39 AM · Restricted Project

Jan 17 2020

cmatthews accepted D72278: [test] On Mac, don't try to use result of sysctl command if calling it failed..

LGMT.

Jan 17 2020, 12:09 PM · Restricted Project

Jan 10 2020

cmatthews accepted D72278: [test] On Mac, don't try to use result of sysctl command if calling it failed..

LGTM. Could you maybe update the message something like warning: calling sysctl failed, defaulting to no fma3

Jan 10 2020, 2:34 PM · Restricted Project

Dec 5 2019

cmatthews added a comment to D68779: [LNT][NFC] Fix global import in function.

I think we need testing on all versions of python we support. I suggest one version on 3 that is recent only. We currently have no python3 users, so maybe just 3.6 and newer?

Dec 5 2019, 10:52 AM

Dec 4 2019

cmatthews accepted D68802: [LNT] Python 3 support: fix writing report to tmp file.
Dec 4 2019, 11:37 AM
cmatthews accepted D68920: [LNT] Python 3 support: specify how to sort dict.
Dec 4 2019, 11:37 AM
cmatthews accepted D68989: [LNT] Python 3 support: don't assume URL params order.

We should probably use the url parser on these, and check them formally. This is okay for now though.

Dec 4 2019, 11:37 AM
cmatthews accepted D69042: [LNT] Python 3 support: define hash for Order class.
Dec 4 2019, 11:37 AM
cmatthews accepted D68987: [LNT] Python 3 support: store color value as int.
Dec 4 2019, 11:37 AM
cmatthews accepted D68988: [LNT] Python 3 support: adapt regex for div by 0 msg.
Dec 4 2019, 11:37 AM
cmatthews accepted D68986: [LNT] Python 3 support: adapt XML parsing with extra entities.
Dec 4 2019, 11:30 AM
cmatthews added a comment to D69053: [LNT] Switch docker image to Python 3.

I don't use Docker. Can someone else review?

Dec 4 2019, 11:28 AM
cmatthews accepted D69055: [LNT] Code cleanup: consistently use space after comma.
Dec 4 2019, 11:28 AM
cmatthews accepted D69054: [LNT] Remove useless import fallback.
Dec 4 2019, 11:28 AM
cmatthews accepted D69052: [LNT] Python 3 support: enable testing for Python 3.
Dec 4 2019, 11:28 AM

Nov 11 2019

cmatthews accepted D67821: [LNT] Python 3 support: use Python 2's division behavior.

Thanks for the comments. LGTM.

Nov 11 2019, 10:13 AM
cmatthews added a comment to D68779: [LNT][NFC] Fix global import in function.

I don't understand why we are not using normal import at the top level here?

Nov 11 2019, 10:13 AM

Oct 16 2019

cmatthews added a comment to D69056: [LNT] [WIP] Remove Python2 support.

FWIW, we are still using python2 everywhere. I think the python3 version needs to stew for a bit so we can find any bugs that might have been introduced.

Oct 16 2019, 10:00 AM

Oct 15 2019

cmatthews committed rL374950: Add Chris Matthews.
Add Chris Matthews
Oct 15 2019, 2:42 PM

Oct 9 2019

cmatthews accepted D68220: [LNT] Python 3 support: stable showtests output.

Yeah, that seems fine.

Oct 9 2019, 11:17 AM

Sep 27 2019

cmatthews committed rL373111: Make the short version of --cmake-define -D.
Make the short version of --cmake-define -D
Sep 27 2019, 11:52 AM
cmatthews accepted D67884: [LNT] Sort machines by ID as expected by test case.

Yeah, this LGTM.

Sep 27 2019, 11:19 AM · Restricted Project

Sep 18 2019

cmatthews committed rL372241: Support for codesigning executables on Darwin.
Support for codesigning executables on Darwin
Sep 18 2019, 11:16 AM
cmatthews accepted D65751: [LNT] Add support for v2 fmt in test data library.

Thanks!

Sep 18 2019, 10:40 AM · Restricted Project
cmatthews accepted D65794: [LNT] Add docker containerization files.

Looks good. Thanks!

Sep 18 2019, 10:40 AM · Restricted Project

Sep 13 2019

cmatthews accepted D67534: [LNT] Python 3 support: Minor automatic 2to3 fixups.

LGTM.

Sep 13 2019, 10:51 AM · Restricted Project
cmatthews added inline comments to D67535: [LNT] Python 3 support: Update `<>` and `None` comparisons.
Sep 13 2019, 10:43 AM · Restricted Project
cmatthews accepted D67533: [LNT] Python 3 support: Set up (client) setup requirements.

LGTM.

Sep 13 2019, 10:40 AM · Restricted Project
cmatthews accepted D67532: [LNT] Python 3 support: print statements.

LGTM. Thanks!

Sep 13 2019, 10:33 AM · Restricted Project

Sep 3 2019

cmatthews added inline comments to D65751: [LNT] Add support for v2 fmt in test data library.
Sep 3 2019, 10:58 AM · Restricted Project

Aug 12 2019

cmatthews accepted D65747: [LNT] Add unittests for test data creation library.

LGTM.

Aug 12 2019, 10:58 AM · Restricted Project
cmatthews accepted D65751: [LNT] Add support for v2 fmt in test data library.

Looks good.

Aug 12 2019, 10:58 AM · Restricted Project

Jul 10 2019

cmatthews resigned from D64065: Skip test earlier if metric is not found in compare.py.
Jul 10 2019, 10:54 AM · Restricted Project

Jul 1 2019

cmatthews accepted D64028: [zorg] Add a new build script for use with monorepo.

LGTM, thanks!

Jul 1 2019, 1:31 PM · Restricted Project

Jun 5 2019

cmatthews accepted D61662: in test_suite run_test function, opt and self.opt is same obect.

LGTM. Thanks

Jun 5 2019, 10:59 AM · Restricted Project

Jan 22 2019

cmatthews committed rL351904: This should not have been comitted!.
This should not have been comitted!
Jan 22 2019, 4:19 PM

Jan 7 2019

cmatthews accepted D56133: [LNT] fix ValueError in corner case.

LGTM. Thanks!

Jan 7 2019, 4:14 PM

Dec 20 2018

cmatthews committed rL349791: A few more linter fixups.
A few more linter fixups
Dec 20 2018, 10:29 AM
cmatthews committed rL349790: Some more parts of the tree that are linter clean now.
Some more parts of the tree that are linter clean now
Dec 20 2018, 10:29 AM
cmatthews committed rL349789: Suppress most common linter warnings: we probably will not fix these, and they….
Suppress most common linter warnings: we probably will not fix these, and they…
Dec 20 2018, 10:29 AM
cmatthews committed rL349788: Cleanups suggested by linter.
Cleanups suggested by linter
Dec 20 2018, 10:29 AM
cmatthews committed rL349787: Imports fixups.
Imports fixups
Dec 20 2018, 10:29 AM
cmatthews committed rL349786: Also print stats, so we can see how we are progressing.
Also print stats, so we can see how we are progressing
Dec 20 2018, 10:29 AM
cmatthews committed rL349785: Fix whitespace here too.
Fix whitespace here too
Dec 20 2018, 10:28 AM

Dec 18 2018

cmatthews committed rL349594: Whitespace fixups.
Whitespace fixups
Dec 18 2018, 4:24 PM
cmatthews committed rL349593: Unused import.
Unused import
Dec 18 2018, 4:24 PM
cmatthews committed rL349592: Unused import.
Unused import
Dec 18 2018, 4:24 PM
cmatthews committed rL349591: whitespace fixup, unused import.
whitespace fixup, unused import
Dec 18 2018, 4:24 PM
cmatthews committed rL349590: whitespace fixup.
whitespace fixup
Dec 18 2018, 4:24 PM
cmatthews committed rL349589: fatal was not imported, and fix formatting.
fatal was not imported, and fix formatting
Dec 18 2018, 4:24 PM
cmatthews committed rL349588: Remove another * import, and put back the import that is needed..
Remove another * import, and put back the import that is needed.
Dec 18 2018, 4:14 PM
cmatthews committed rL349587: Help mypy understand this.
Help mypy understand this
Dec 18 2018, 4:14 PM
cmatthews committed rL349586: Get rid of nasty * imports.
Get rid of nasty * imports
Dec 18 2018, 4:13 PM
cmatthews committed rL349584: I think this is unused.
I think this is unused
Dec 18 2018, 3:58 PM
cmatthews committed rL349583: Fixup invalid imports.
Fixup invalid imports
Dec 18 2018, 3:58 PM
cmatthews committed rL349582: Some type annotations to make Mypy happier.
Some type annotations to make Mypy happier
Dec 18 2018, 3:58 PM
cmatthews committed rL349579: Getting server UI tests working in flake8.
Getting server UI tests working in flake8
Dec 18 2018, 3:43 PM
cmatthews committed rL349578: Scaleability improvements: don't expire objects and use better query.
Scaleability improvements: don't expire objects and use better query
Dec 18 2018, 3:43 PM
cmatthews committed rL349577: Add a whitelist of files to keep linter clean.
Add a whitelist of files to keep linter clean
Dec 18 2018, 3:43 PM
cmatthews committed rL349576: Do bulk add to avoid DB round trips.
Do bulk add to avoid DB round trips
Dec 18 2018, 3:43 PM
cmatthews committed rL349575: Prevent detached object errors.
Prevent detached object errors
Dec 18 2018, 3:42 PM
cmatthews committed rL349574: Short circuit regression fix checking.
Short circuit regression fix checking
Dec 18 2018, 3:42 PM

Dec 14 2018

cmatthews committed rL349220: Make sure hooks are not run before they are loaded.
Make sure hooks are not run before they are loaded
Dec 14 2018, 4:38 PM
cmatthews committed rL349219: Make a cache for machine -> order lookup.
Make a cache for machine -> order lookup
Dec 14 2018, 4:38 PM
cmatthews committed rL349218: Register hooks in command line importing.
Register hooks in command line importing
Dec 14 2018, 4:38 PM

Dec 13 2018

cmatthews committed rL349116: whitespace fixups to blast.
whitespace fixups to blast
Dec 13 2018, 4:45 PM
cmatthews committed rL349114: Tox based testing.
Tox based testing
Dec 13 2018, 4:33 PM
cmatthews committed rL349113: pep8 whitespace fixups.
pep8 whitespace fixups
Dec 13 2018, 4:33 PM
cmatthews committed rL349112: Unused import.
Unused import
Dec 13 2018, 4:33 PM
cmatthews committed rL349111: Seems like a lot of E266 in the lit test cases, disable that.
Seems like a lot of E266 in the lit test cases, disable that
Dec 13 2018, 4:33 PM
cmatthews committed rL349110: Use ToT lit.
Use ToT lit
Dec 13 2018, 4:33 PM
cmatthews committed rL349109: Add some project policy for formatting so style tools are more useful.
Add some project policy for formatting so style tools are more useful
Dec 13 2018, 4:33 PM
cmatthews committed rL349108: Unused imports.
Unused imports
Dec 13 2018, 4:33 PM