This is an archive of the discontinued LLVM Phabricator instance.

Differential D94840

Add import needed for typing hints
ClosedPublic

Authored by thopre on Jan 15 2021, 3:55 PM.

Details

Reviewers
tnfchris
danilaml
cmatthews
Summary

baseline()'s typing hint refers to testsuitedb type but there is no
import for that module. This commit fixes that.

Diff Detail

Event Timeline

thopre created this revision.Jan 15 2021, 3:55 PM
Herald added a subscriber: dkolesnichenko. · View Herald TranscriptJan 15 2021, 3:55 PM
thopre requested review of this revision.Jan 15 2021, 3:55 PM
Harbormaster completed remote builds in B85444: Diff 317101.Jan 15 2021, 3:55 PM
thopre added a child revision: D94842: Extend mandatory Flake8 cleanness.Jan 15 2021, 3:56 PM
tnfchris accepted this revision.Jan 16 2021, 5:29 AM

was it being indirectly imported before?

This revision is now accepted and ready to land.Jan 16 2021, 5:29 AM
thopre added a comment.Jan 16 2021, 6:27 AM
In D94840#2503260, @tnfchris wrote:

was it being indirectly imported before?

That would be my guess yes

thopre closed this revision.Jan 16 2021, 6:27 AM

Revision Contents

PathSize
lnt/
server/
ui/
1 line

Diff 317101

lnt/server/ui/views.py

Show All 30 Lines
import lnt.server.reporting.latestrunsreport import lnt.server.reporting.latestrunsreport
import lnt.server.reporting.runs import lnt.server.reporting.runs
import lnt.server.reporting.summaryreport import lnt.server.reporting.summaryreport
import lnt.server.ui.util import lnt.server.ui.util
import lnt.util import lnt.util
import lnt.util.ImportData import lnt.util.ImportData
import lnt.util.stats import lnt.util.stats
from lnt.external.stats import stats as ext_stats from lnt.external.stats import stats as ext_stats
from lnt.server.db import testsuitedb
from lnt.server.reporting.analysis import ComparisonResult, calc_geomean from lnt.server.reporting.analysis import ComparisonResult, calc_geomean
from lnt.server.ui import util from lnt.server.ui import util
from lnt.server.ui.decorators import frontend, db_route, v4_route from lnt.server.ui.decorators import frontend, db_route, v4_route
from lnt.server.ui.globals import db_url_for, v4_url_for, v4_redirect from lnt.server.ui.globals import db_url_for, v4_url_for, v4_redirect
from lnt.server.ui.util import FLASH_DANGER, FLASH_SUCCESS, FLASH_INFO from lnt.server.ui.util import FLASH_DANGER, FLASH_SUCCESS, FLASH_INFO
from lnt.server.ui.util import PrecomputedCR from lnt.server.ui.util import PrecomputedCR
from lnt.server.ui.util import baseline_key, convert_revision from lnt.server.ui.util import baseline_key, convert_revision
from lnt.server.ui.util import mean from lnt.server.ui.util import mean
▲ Show 20 Lines • Show All 1,874 Lines • Show Last 20 Lines