This is an archive of the discontinued LLVM Phabricator instance.

[lld][WebAssembly] Delay creation of internal __wasm_memory_init function
ClosedPublic

Authored by sbc100 on Dec 10 2020, 7:56 AM.

Details

Summary

This also allows for its creation to be conditional so it is
completely elided when not needed.

Diff Detail

Event Timeline

sbc100 created this revision.Dec 10 2020, 7:56 AM
sbc100 requested review of this revision.Dec 10 2020, 7:56 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 10 2020, 7:56 AM
sbc100 updated this revision to Diff 310897.Dec 10 2020, 7:57 AM

revert part

tlively accepted this revision.Dec 10 2020, 9:52 AM

"not completely elided" => "completely elided" in the description.

lld/wasm/SyntheticSections.h
242–243

It looks like this argument is no longer used.

This revision is now accepted and ready to land.Dec 10 2020, 9:52 AM
sbc100 edited the summary of this revision. (Show Details)Dec 10 2020, 10:38 AM
This revision was landed with ongoing or failed builds.Dec 10 2020, 10:47 AM
This revision was automatically updated to reflect the committed changes.
sbc100 marked an inline comment as done.