Page MenuHomePhabricator

wingo (Andy Wingo)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 12 2019, 6:38 AM (74 w, 4 d)

Recent Activity

Today

wingo added a comment to D90948: [WebAssembly] call_indirect issues table number relocs.

Well, this patch was a bit of a journey! But finally it's ready, having calved off a number of precursor patches that landed already. Notably we needed to fix wasm-ld to be able to understand table symbols, before emitting them here.

Fri, Jan 15, 6:11 AM · Restricted Project
wingo committed rGe9f1ed2306b1: [WebAssembly] MC layer writes table symbols to object files (authored by wingo).
[WebAssembly] MC layer writes table symbols to object files
Fri, Jan 15, 5:57 AM
wingo closed D92215: [WebAssembly] MC layer writes table symbols to object files.
Fri, Jan 15, 5:56 AM · Restricted Project
wingo added inline comments to D92215: [WebAssembly] MC layer writes table symbols to object files.
Fri, Jan 15, 5:28 AM · Restricted Project
wingo updated the diff for D92215: [WebAssembly] MC layer writes table symbols to object files.

Reword comment

Fri, Jan 15, 5:27 AM · Restricted Project
wingo added inline comments to D92215: [WebAssembly] MC layer writes table symbols to object files.
Fri, Jan 15, 4:16 AM · Restricted Project
wingo added a comment to D92215: [WebAssembly] MC layer writes table symbols to object files.

Ready for review when you have a moment. Thanks! @sbc100

Fri, Jan 15, 12:27 AM · Restricted Project
wingo committed rG38dfce706f79: [WebAssembly] Add support for table linking to wasm-ld (authored by wingo).
[WebAssembly] Add support for table linking to wasm-ld
Fri, Jan 15, 12:25 AM
wingo closed D91870: [WebAssembly] Add support for table linking to wasm-ld.
Fri, Jan 15, 12:24 AM · Restricted Project

Yesterday

wingo added a comment to D91870: [WebAssembly] Add support for table linking to wasm-ld.

Thanks for the review!

Thu, Jan 14, 11:59 PM · Restricted Project
wingo added inline comments to D91870: [WebAssembly] Add support for table linking to wasm-ld.
Thu, Jan 14, 8:05 AM · Restricted Project
wingo updated the diff for D91870: [WebAssembly] Add support for table linking to wasm-ld.

Address feedback

Thu, Jan 14, 8:05 AM · Restricted Project
wingo added a comment to D94677: [lld][WebAssembly] Common superclass for input globals/events/tables.

This followup refactor is as suggested in https://reviews.llvm.org/D94075. NFC.

Thu, Jan 14, 4:52 AM · Restricted Project
wingo added a comment to D91870: [WebAssembly] Add support for table linking to wasm-ld.

I think this one is ready for review @sbc100, when you have a moment :)

Thu, Jan 14, 4:50 AM · Restricted Project
wingo requested review of D94677: [lld][WebAssembly] Common superclass for input globals/events/tables.
Thu, Jan 14, 4:49 AM · Restricted Project
wingo updated the diff for D91870: [WebAssembly] Add support for table linking to wasm-ld.

Rebase to include synthetic tables

Thu, Jan 14, 2:23 AM · Restricted Project
wingo committed rG53e3b81faaf3: [lld][WebAssembly] Add support for handling table symbols (authored by wingo).
[lld][WebAssembly] Add support for handling table symbols
Thu, Jan 14, 2:20 AM
wingo closed D94075: [lld][WebAssembly] Add support for handling table symbols.
Thu, Jan 14, 2:20 AM · Restricted Project
wingo added a comment to D94075: [lld][WebAssembly] Add support for handling table symbols.

Pushing, given the earlier LGTM, let me know if I am misinterpreting things. Cheers & thanks for the review :)

Thu, Jan 14, 2:18 AM · Restricted Project
wingo updated the diff for D94075: [lld][WebAssembly] Add support for handling table symbols.

Address feedback

Thu, Jan 14, 1:55 AM · Restricted Project
wingo added inline comments to D94075: [lld][WebAssembly] Add support for handling table symbols.
Thu, Jan 14, 1:51 AM · Restricted Project
wingo added a comment to D94075: [lld][WebAssembly] Add support for handling table symbols.

It would be good to add some test cases with multi-table and input and output. Is there a fundamental reason we can't do that yet?

Thu, Jan 14, 1:43 AM · Restricted Project

Tue, Jan 12

wingo added a comment to D94075: [lld][WebAssembly] Add support for handling table symbols.

Gentle ping to @sbc100 :)

Tue, Jan 12, 12:03 AM · Restricted Project

Tue, Jan 5

wingo added 1 blocking reviewer(s) for D94075: [lld][WebAssembly] Add support for handling table symbols: sbc100.
Tue, Jan 5, 3:16 AM · Restricted Project
wingo updated the diff for D91870: [WebAssembly] Add support for table linking to wasm-ld.

Split from D94075

Tue, Jan 5, 3:15 AM · Restricted Project
wingo requested review of D94075: [lld][WebAssembly] Add support for handling table symbols.
Tue, Jan 5, 3:14 AM · Restricted Project
wingo planned changes to D91870: [WebAssembly] Add support for table linking to wasm-ld.

Will split this one.

Tue, Jan 5, 3:14 AM · Restricted Project
wingo committed rG9ad83fd6dc46: [WebAssembly] call_indirect causes indirect function table import (authored by wingo).
[WebAssembly] call_indirect causes indirect function table import
Tue, Jan 5, 2:24 AM
wingo closed D92840: [WebAssembly] call_indirect causes indirect function table import.
Tue, Jan 5, 2:24 AM · Restricted Project
wingo added a comment to D92840: [WebAssembly] call_indirect causes indirect function table import.

Landing, given @sbc100's lgtm-with-nit. Thanks all for your patience and happy new year :)

Tue, Jan 5, 2:08 AM · Restricted Project
wingo updated the diff for D90948: [WebAssembly] call_indirect issues table number relocs.

Rebase

Tue, Jan 5, 2:05 AM · Restricted Project
wingo updated the diff for D92840: [WebAssembly] call_indirect causes indirect function table import.

Copy/paste GetOrCreateFunctionTableSymbol into WebAssemblyAsmParser

Tue, Jan 5, 1:57 AM · Restricted Project
wingo updated the diff for D92321: [WebAssembly] Allow element sections for nonzero table numbers.

Revert change to incorrect changeset

Tue, Jan 5, 1:48 AM · Restricted Project
wingo updated the diff for D92321: [WebAssembly] Allow element sections for nonzero table numbers.

Copy/paste GetOrCreateFunctionTableSymbol into WebAssemblyAsmParser

Tue, Jan 5, 1:47 AM · Restricted Project
wingo updated the diff for D92321: [WebAssembly] Allow element sections for nonzero table numbers.

Rebase

Tue, Jan 5, 1:35 AM · Restricted Project
wingo updated the diff for D92320: [WebAssembly][lld] Fix call-indirect.s test to validate.

Rebase

Tue, Jan 5, 1:35 AM · Restricted Project
wingo updated the diff for D92315: [WebAssembly] Change prefix on data segment flags to WASM_DATA_SEGMENT.

Rebase

Tue, Jan 5, 1:34 AM · Restricted Project
wingo updated the diff for D90948: [WebAssembly] call_indirect issues table number relocs.

Rebase

Tue, Jan 5, 1:34 AM · Restricted Project
wingo updated the diff for D92215: [WebAssembly] MC layer writes table symbols to object files.

Rebase

Tue, Jan 5, 1:33 AM · Restricted Project
wingo updated the diff for D91870: [WebAssembly] Add support for table linking to wasm-ld.

Rebase

Tue, Jan 5, 1:32 AM · Restricted Project
wingo updated the diff for D92840: [WebAssembly] call_indirect causes indirect function table import.

Rebase

Tue, Jan 5, 1:32 AM · Restricted Project

Dec 10 2020

wingo added inline comments to D92840: [WebAssembly] call_indirect causes indirect function table import.
Dec 10 2020, 12:28 AM · Restricted Project

Dec 9 2020

wingo updated the diff for D90948: [WebAssembly] call_indirect issues table number relocs.

Rebase to address change in D92840

Dec 9 2020, 6:43 AM · Restricted Project
wingo updated the diff for D92840: [WebAssembly] call_indirect causes indirect function table import.

AsmParser uses WebAssemblyUtilities, links to WebAssemblyCodeGen

Dec 9 2020, 6:27 AM · Restricted Project
wingo added inline comments to D92840: [WebAssembly] call_indirect causes indirect function table import.
Dec 9 2020, 6:18 AM · Restricted Project
wingo added inline comments to D92840: [WebAssembly] call_indirect causes indirect function table import.
Dec 9 2020, 2:14 AM · Restricted Project
wingo added inline comments to D92840: [WebAssembly] call_indirect causes indirect function table import.
Dec 9 2020, 1:49 AM · Restricted Project
wingo added inline comments to D92840: [WebAssembly] call_indirect causes indirect function table import.
Dec 9 2020, 1:16 AM · Restricted Project

Dec 8 2020

wingo added a comment to D91870: [WebAssembly] Add support for table linking to wasm-ld.

Maybe there are two logical parts we can separate here:

  1. Support for first class tables in input files
  1. Support for the special __indirect_function_table

I guess they are somewhat intertwined by I can imagine landing (1) without changing the way we handle the special table 0. Maybe its not worth the work to split up?

Dec 8 2020, 6:10 AM · Restricted Project
wingo updated the diff for D92321: [WebAssembly] Allow element sections for nonzero table numbers.

Rebase

Dec 8 2020, 5:53 AM · Restricted Project
wingo updated the diff for D92320: [WebAssembly][lld] Fix call-indirect.s test to validate.

Rebase

Dec 8 2020, 5:53 AM · Restricted Project
wingo updated the diff for D92315: [WebAssembly] Change prefix on data segment flags to WASM_DATA_SEGMENT.

Rebase

Dec 8 2020, 5:52 AM · Restricted Project
wingo updated the diff for D90948: [WebAssembly] call_indirect issues table number relocs.

Rebase

Dec 8 2020, 5:52 AM · Restricted Project
wingo updated the diff for D92215: [WebAssembly] MC layer writes table symbols to object files.

Rebase

Dec 8 2020, 5:52 AM · Restricted Project
wingo updated the diff for D91870: [WebAssembly] Add support for table linking to wasm-ld.

Rebase

Dec 8 2020, 5:51 AM · Restricted Project
wingo updated the diff for D92840: [WebAssembly] call_indirect causes indirect function table import.

Fix comments

Dec 8 2020, 5:31 AM · Restricted Project
wingo added inline comments to D91870: [WebAssembly] Add support for table linking to wasm-ld.
Dec 8 2020, 5:23 AM · Restricted Project
wingo requested review of D92840: [WebAssembly] call_indirect causes indirect function table import.
Dec 8 2020, 5:22 AM · Restricted Project
wingo updated the summary of D91870: [WebAssembly] Add support for table linking to wasm-ld.
Dec 8 2020, 1:59 AM · Restricted Project
wingo updated the diff for D91870: [WebAssembly] Add support for table linking to wasm-ld.

Address feedback

Dec 8 2020, 1:54 AM · Restricted Project
wingo added a comment to D91870: [WebAssembly] Add support for table linking to wasm-ld.

New patch addresses micro-feedback, but still thinking if a patch split is possible. Probably also want to land a precursor also to ensure that the compiler produces __indirect_function_table imports for object files with call_indirect but no TABLE_INDEX relocs.

Dec 8 2020, 1:54 AM · Restricted Project

Dec 7 2020

wingo committed rGd823cc7cad1d: [WebAssembly][MC] Fix placement of table section (authored by wingo).
[WebAssembly][MC] Fix placement of table section
Dec 7 2020, 7:19 AM
wingo closed D92323: [WebAssembly][MC] Fix placement of table section.
Dec 7 2020, 7:19 AM · Restricted Project
wingo updated the summary of D92323: [WebAssembly][MC] Fix placement of table section.
Dec 7 2020, 6:59 AM · Restricted Project
wingo updated the diff for D92323: [WebAssembly][MC] Fix placement of table section.

Rebase

Dec 7 2020, 6:57 AM · Restricted Project

Dec 2 2020

wingo added inline comments to D91870: [WebAssembly] Add support for table linking to wasm-ld.
Dec 2 2020, 8:01 AM · Restricted Project

Dec 1 2020

wingo added a comment to D91870: [WebAssembly] Add support for table linking to wasm-ld.

I will assume that all of the clang-tidy feedback is valid and will adjust accordingly. Otherwise I think this is ready for review @sbc100. If it is too big, I think there may be small pieces I can split off, or it could just make sense as-is.

Dec 1 2020, 5:58 AM · Restricted Project
wingo added a comment to D92323: [WebAssembly][MC] Fix placement of table section.

I guess we wait for D92359 and then land this on top of that.

Dec 1 2020, 1:23 AM · Restricted Project
wingo added inline comments to D92323: [WebAssembly][MC] Fix placement of table section.
Dec 1 2020, 1:17 AM · Restricted Project
wingo added inline comments to D92323: [WebAssembly][MC] Fix placement of table section.
Dec 1 2020, 1:13 AM · Restricted Project
wingo added inline comments to D92323: [WebAssembly][MC] Fix placement of table section.
Dec 1 2020, 1:12 AM · Restricted Project
wingo added inline comments to D92323: [WebAssembly][MC] Fix placement of table section.
Dec 1 2020, 12:21 AM · Restricted Project
wingo added inline comments to D92359: [WebAssembly] Support select and block for reference types.
Dec 1 2020, 12:18 AM · Restricted Project

Nov 30 2020

wingo requested review of D92323: [WebAssembly][MC] Fix placement of table section.
Nov 30 2020, 7:18 AM · Restricted Project
wingo requested review of D92321: [WebAssembly] Allow element sections for nonzero table numbers.
Nov 30 2020, 6:29 AM · Restricted Project
wingo requested review of D92320: [WebAssembly][lld] Fix call-indirect.s test to validate.
Nov 30 2020, 6:28 AM · Restricted Project
wingo requested review of D92315: [WebAssembly] Change prefix on data segment flags to WASM_DATA_SEGMENT.
Nov 30 2020, 6:06 AM · Restricted Project

Nov 27 2020

wingo added a comment to D90948: [WebAssembly] call_indirect issues table number relocs.

Okeydoke, finally ready for review. Probably needs more tests for multi-table linking. Probably should follow up to remove the "legacy" handling of __indirect_function_table in the linker. Or should wasm-ld support old object files for a while?

Nov 27 2020, 2:27 AM · Restricted Project
wingo retitled D90948: [WebAssembly] call_indirect issues table number relocs from [WebAssembly] [WIP] call_indirect issues table number relocs to [WebAssembly] call_indirect issues table number relocs.
Nov 27 2020, 2:22 AM · Restricted Project
wingo updated the diff for D90948: [WebAssembly] call_indirect issues table number relocs.

All working

Nov 27 2020, 2:20 AM · Restricted Project
wingo updated the diff for D91870: [WebAssembly] Add support for table linking to wasm-ld.

Fix a couple missing / bogus places where TABLE_NUMBER relocs were incorrectly handled in the linker

Nov 27 2020, 2:18 AM · Restricted Project
wingo added a reviewer for D92215: [WebAssembly] MC layer writes table symbols to object files: sbc100.
Nov 27 2020, 1:12 AM · Restricted Project
wingo requested review of D92215: [WebAssembly] MC layer writes table symbols to object files.
Nov 27 2020, 1:11 AM · Restricted Project
wingo updated the diff for D91870: [WebAssembly] Add support for table linking to wasm-ld.

Rebase

Nov 27 2020, 12:42 AM · Restricted Project

Nov 25 2020

wingo added a comment to D91637: [WebAssembly] Only emit indirect function table import if needed.

Looks like we need one more rebase now that https://reviews.llvm.org/D91849 has landed.

Nov 25 2020, 8:29 AM · Restricted Project
wingo added a comment to D91849: [WebAssembly] Factor out WasmTableType in binary format.

thanks!!

Nov 25 2020, 8:28 AM · Restricted Project
wingo updated the diff for D91637: [WebAssembly] Only emit indirect function table import if needed.

Rebase

Nov 25 2020, 8:28 AM · Restricted Project
wingo updated the diff for D91870: [WebAssembly] Add support for table linking to wasm-ld.

Rebase

Nov 25 2020, 3:24 AM · Restricted Project
wingo updated the diff for D91637: [WebAssembly] Only emit indirect function table import if needed.

Rebase

Nov 25 2020, 2:21 AM · Restricted Project
wingo added a comment to D91637: [WebAssembly] Only emit indirect function table import if needed.

This patch doesn't seem to apply to the master branch of llvm.

Nov 25 2020, 1:49 AM · Restricted Project
wingo added a comment to D91849: [WebAssembly] Factor out WasmTableType in binary format.

I'm seeing a lot of tests fail. For example just the MC tests:

Nov 25 2020, 1:46 AM · Restricted Project
wingo updated the diff for D91849: [WebAssembly] Factor out WasmTableType in binary format.

Rebase (no conflicts)

Nov 25 2020, 1:45 AM · Restricted Project

Nov 24 2020

wingo planned changes to D90948: [WebAssembly] call_indirect issues table number relocs.
Nov 24 2020, 8:12 AM · Restricted Project
wingo updated the diff for D90948: [WebAssembly] call_indirect issues table number relocs.

Rebase; still a WIP.

Nov 24 2020, 8:12 AM · Restricted Project
wingo added a comment to D91637: [WebAssembly] Only emit indirect function table import if needed.

If this looks good to you, feel very free to land :)

Nov 24 2020, 7:33 AM · Restricted Project
wingo updated the diff for D91637: [WebAssembly] Only emit indirect function table import if needed.

Remove extraneous test change

Nov 24 2020, 7:31 AM · Restricted Project
wingo added inline comments to D91637: [WebAssembly] Only emit indirect function table import if needed.
Nov 24 2020, 7:31 AM · Restricted Project
wingo planned changes to D90948: [WebAssembly] call_indirect issues table number relocs.

Needs to rebase on top of https://reviews.llvm.org/D91870.

Nov 24 2020, 1:55 AM · Restricted Project
wingo added a comment to D91849: [WebAssembly] Factor out WasmTableType in binary format.

I guess I should ask for commit rights so I can land after approval; would you be OK sponsoring my request, Sam? In the meantime if you would like to land this one that would be grand :)

Nov 24 2020, 1:54 AM · Restricted Project
wingo updated the summary of D91849: [WebAssembly] Factor out WasmTableType in binary format.
Nov 24 2020, 1:46 AM · Restricted Project