- User Since
- Sep 16 2016, 10:22 AM (226 w, 1 d)
Thu, Jan 14
Would you mind formatting the commit message to wrap at 80 chars? I know llvm commits are bit all over the place on the style used but I find wrapped commit message easier to read myself.
Nice. I like that we were able to delete almost as much code as was added here.
Wed, Jan 13
Tue, Jan 12
This change does point to perhaps some refactoring that we should do at some point to try to remove some the boiler place that is common among symbol types, and input elements, as well as how the symbol are added to the symbol table.
I suppose the synthetic table is there so it can one day be used for the indirect function table? Should we wait until then to actually add it?
Fri, Jan 8
OK, -DCMAKE_BUILD_WITH_INSTALL_RPATH=ON worked for me
This change broke the emscripten SDK builders which build with LLVM_LINK_LLVM_DYLIB and expect the resulting binaries to be portable/relocatable.
Wed, Jan 6
Mon, Dec 21
Fri, Dec 18
Dec 17 2020
lgtm .. assuming we do eventually figure out how to trigger this using a unit test. I generally agree with you that it rather strange that ::markLive is called at all on an undefined synbol.
Dec 14 2020
wasm changes lgtm assuming other backends agree.
Dec 10 2020
Added a test. Once again I wish we had a good disassembler to make the test more readable.
IIUC comdat is a propoerty shared by a group of a definitions (not declarations) so I don't see who an import could be part of a comdat group.
( i didn't see any response the the two comments, one regarding the extra debugging output and the other regarding the include the .type foo,@function lines in test code).
Lets just go with duplicating the function for now (along with a TODO to followup).
Dec 9 2020
Dec 8 2020
One side effect is that that defs in this file that use classes from the non-atomic memory file such as LoadPatImmOff and LoadPatImmOff will no longer have the HasAtomics as part of their Requires. Does this seems reasonble?
I'm not sure how to address the duplication of got and the associated FIXME. Adding some others to the review list who might know a way to deal with that without duplication.
Dec 7 2020
Dec 6 2020
The alternative to this approach looks like implementing something
like PredicateControl in Mips.td where we can split the predicates
into groups so they don't clobber each other.
Dec 4 2020
Dec 3 2020
- fix start
- rebase + add test
Still need to add testing..
Dec 2 2020
- remove some debugging
Dec 1 2020
Do all these change essentially match the ELF linker? A brief look makes me thing they do.
Maybe there are two logical parts we can separate here:
I guess we wait for D92359 and then land this on top of that.
Oh I see .. up until now we import the table.
Nov 30 2020
I believe there is some coverage of createInitMemoryFunction in the tests.. although maybe not in a very useful/readable way.