Page MenuHomePhabricator

sbc100 (Sam Clegg)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 16 2016, 10:22 AM (226 w, 1 d)

Recent Activity

Yesterday

sbc100 accepted D90948: [WebAssembly] call_indirect issues table number relocs.

Great!

Fri, Jan 15, 8:15 AM · Restricted Project
sbc100 added a comment to D92215: [WebAssembly] MC layer writes table symbols to object files.

still lgtm

Fri, Jan 15, 4:26 AM · Restricted Project
sbc100 accepted D92215: [WebAssembly] MC layer writes table symbols to object files.
Fri, Jan 15, 1:57 AM · Restricted Project

Thu, Jan 14

sbc100 added a comment to D91870: [WebAssembly] Add support for table linking to wasm-ld.

Would you mind formatting the commit message to wrap at 80 chars? I know llvm commits are bit all over the place on the style used but I find wrapped commit message easier to read myself.

Thu, Jan 14, 8:12 AM · Restricted Project
sbc100 accepted D91870: [WebAssembly] Add support for table linking to wasm-ld.
Thu, Jan 14, 8:10 AM · Restricted Project
sbc100 added a comment to D91870: [WebAssembly] Add support for table linking to wasm-ld.

Nice. I like that we were able to delete almost as much code as was added here.

Thu, Jan 14, 5:21 AM · Restricted Project

Wed, Jan 13

sbc100 committed rG07b6aeb5685f: [lld][WebAssembly] Fix for TLS + --relocatable (authored by sbc100).
[lld][WebAssembly] Fix for TLS + --relocatable
Wed, Jan 13, 7:51 AM
sbc100 closed D93554: [lld][WebAssembly] Fix for TLS + --relocatable.
Wed, Jan 13, 7:51 AM · Restricted Project
sbc100 updated the diff for D93554: [lld][WebAssembly] Fix for TLS + --relocatable.

rebase

Wed, Jan 13, 7:49 AM · Restricted Project
sbc100 updated the summary of D93554: [lld][WebAssembly] Fix for TLS + --relocatable.
Wed, Jan 13, 7:46 AM · Restricted Project

Tue, Jan 12

sbc100 added a comment to D94075: [lld][WebAssembly] Add support for handling table symbols.

This change does point to perhaps some refactoring that we should do at some point to try to remove some the boiler place that is common among symbol types, and input elements, as well as how the symbol are added to the symbol table.

Tue, Jan 12, 2:34 AM · Restricted Project
sbc100 added a comment to D94075: [lld][WebAssembly] Add support for handling table symbols.

I suppose the synthetic table is there so it can one day be used for the indirect function table? Should we wait until then to actually add it?

Tue, Jan 12, 2:33 AM · Restricted Project

Fri, Jan 8

sbc100 added a comment to D93177: [CMake] Don't enable BUILD_WITH_INSTALL_RPATH when using custom build rpath.

OK, -DCMAKE_BUILD_WITH_INSTALL_RPATH=ON worked for me

Fri, Jan 8, 7:11 AM · Restricted Project
sbc100 added a comment to D93177: [CMake] Don't enable BUILD_WITH_INSTALL_RPATH when using custom build rpath.

This change broke the emscripten SDK builders which build with LLVM_LINK_LLVM_DYLIB and expect the resulting binaries to be portable/relocatable.

Fri, Jan 8, 7:08 AM · Restricted Project

Wed, Jan 6

sbc100 committed rG30d314aae10e: [MC][WebAssembly] Avoid recalculating indexes in -gsplit-dwarf mode (authored by sbc100).
[MC][WebAssembly] Avoid recalculating indexes in -gsplit-dwarf mode
Wed, Jan 6, 1:35 AM
sbc100 closed D93650: [MC][WebAssembly] Avoid recalculating indexes in -gsplit-dwarf mode.
Wed, Jan 6, 1:35 AM · Restricted Project

Mon, Dec 21

sbc100 added a reviewer for D93650: [MC][WebAssembly] Avoid recalculating indexes in -gsplit-dwarf mode: dschuff.
Mon, Dec 21, 10:28 AM · Restricted Project
sbc100 updated the summary of D93650: [MC][WebAssembly] Avoid recalculating indexes in -gsplit-dwarf mode.
Mon, Dec 21, 10:28 AM · Restricted Project
sbc100 requested review of D93650: [MC][WebAssembly] Avoid recalculating indexes in -gsplit-dwarf mode.
Mon, Dec 21, 10:25 AM · Restricted Project

Fri, Dec 18

sbc100 added a reviewer for D93554: [lld][WebAssembly] Fix for TLS + --relocatable: tlively.
Fri, Dec 18, 10:04 AM · Restricted Project
sbc100 requested review of D93554: [lld][WebAssembly] Fix for TLS + --relocatable.
Fri, Dec 18, 10:03 AM · Restricted Project
sbc100 updated the diff for D91577: [lld][WebAssembly] Add --unresolved-symbols=import-dynamic.

rebase

Fri, Dec 18, 9:15 AM · Restricted Project

Dec 17 2020

sbc100 accepted D93472: [WebAssembly][lld] Don't mark a file live from an undefine symbol.

lgtm .. assuming we do eventually figure out how to trigger this using a unit test. I generally agree with you that it rather strange that ::markLive is called at all on an undefined synbol.

Dec 17 2020, 10:40 AM · Restricted Project

Dec 14 2020

sbc100 added a comment to D93184: Make lld::wasm::link() or lld::elf::link() more thread-safe.

wasm changes lgtm assuming other backends agree.

Dec 14 2020, 2:47 PM · Restricted Project, lld

Dec 10 2020

sbc100 committed rGe52881a28702: [lld][WebAssembly] Split __wasm_apply_relocs function in two (authored by sbc100).
[lld][WebAssembly] Split __wasm_apply_relocs function in two
Dec 10 2020, 5:08 PM
sbc100 closed D93066: [lld][WebAssembly] Split __wasm_apply_relocs function in two.
Dec 10 2020, 5:07 PM · Restricted Project
sbc100 added a comment to D93066: [lld][WebAssembly] Split __wasm_apply_relocs function in two.

Added a test. Once again I wish we had a good disassembler to make the test more readable.

Dec 10 2020, 3:39 PM · Restricted Project
sbc100 updated the diff for D93066: [lld][WebAssembly] Split __wasm_apply_relocs function in two.
  • feedback
Dec 10 2020, 3:38 PM · Restricted Project
sbc100 accepted D92950: [WebAssembly] [lld] Exclude COMDAT sections.
Dec 10 2020, 3:01 PM · Restricted Project
sbc100 added a comment to D92952: [WebAssembly] Support COMDAT sections in assembly syntax.

IIUC comdat is a propoerty shared by a group of a definitions (not declarations) so I don't see who an import could be part of a comdat group.

Dec 10 2020, 2:27 PM · Restricted Project
sbc100 accepted D92952: [WebAssembly] Support COMDAT sections in assembly syntax.

( i didn't see any response the the two comments, one regarding the extra debugging output and the other regarding the include the .type foo,@function lines in test code).

Dec 10 2020, 2:04 PM · Restricted Project
sbc100 added a reviewer for D93066: [lld][WebAssembly] Split __wasm_apply_relocs function in two: tlively.
Dec 10 2020, 1:32 PM · Restricted Project
sbc100 updated the diff for D93066: [lld][WebAssembly] Split __wasm_apply_relocs function in two.

revert

Dec 10 2020, 1:32 PM · Restricted Project
sbc100 requested review of D93066: [lld][WebAssembly] Split __wasm_apply_relocs function in two.
Dec 10 2020, 1:28 PM · Restricted Project
sbc100 committed rG199497086e46: [lld][WebAssembly] Delay creation of internal __wasm_memory_init function (authored by sbc100).
[lld][WebAssembly] Delay creation of internal __wasm_memory_init function
Dec 10 2020, 10:48 AM
sbc100 closed D93035: [lld][WebAssembly] Delay creation of internal __wasm_memory_init function.
Dec 10 2020, 10:47 AM · Restricted Project
sbc100 updated the summary of D93035: [lld][WebAssembly] Delay creation of internal __wasm_memory_init function.
Dec 10 2020, 10:38 AM · Restricted Project
sbc100 added a comment to D92840: [WebAssembly] call_indirect causes indirect function table import.

Lets just go with duplicating the function for now (along with a TODO to followup).

Dec 10 2020, 8:25 AM · Restricted Project
sbc100 updated the diff for D93035: [lld][WebAssembly] Delay creation of internal __wasm_memory_init function.

revert part

Dec 10 2020, 7:57 AM · Restricted Project
sbc100 added a reviewer for D93035: [lld][WebAssembly] Delay creation of internal __wasm_memory_init function: tlively.
Dec 10 2020, 7:56 AM · Restricted Project
sbc100 requested review of D93035: [lld][WebAssembly] Delay creation of internal __wasm_memory_init function.
Dec 10 2020, 7:56 AM · Restricted Project

Dec 9 2020

sbc100 committed rGd8ed639a6a3b: [lld][WebAssembly] Don't emit names for data segments that we omit (authored by sbc100).
[lld][WebAssembly] Don't emit names for data segments that we omit
Dec 9 2020, 9:00 PM
sbc100 closed D92997: [lld][WebAssembly] Don't emit names for data segments that we omit.
Dec 9 2020, 9:00 PM · Restricted Project
sbc100 updated the summary of D92997: [lld][WebAssembly] Don't emit names for data segments that we omit.
Dec 9 2020, 8:58 PM · Restricted Project
sbc100 requested review of D92997: [lld][WebAssembly] Don't emit names for data segments that we omit.
Dec 9 2020, 8:57 PM · Restricted Project
sbc100 added a comment to D92952: [WebAssembly] Support COMDAT sections in assembly syntax.

Great!

Dec 9 2020, 7:59 PM · Restricted Project
sbc100 committed rG9a72d3e3e456: [WebAssembly] Add support for named data sections in wasm binaries (authored by sbc100).
[WebAssembly] Add support for named data sections in wasm binaries
Dec 9 2020, 1:02 PM
sbc100 closed D92909: [WebAssembly] Add support for named data sections in wasm binaries.
Dec 9 2020, 1:02 PM · Restricted Project
sbc100 added inline comments to D92840: [WebAssembly] call_indirect causes indirect function table import.
Dec 9 2020, 10:07 AM · Restricted Project

Dec 8 2020

sbc100 added a reviewer for D92909: [WebAssembly] Add support for named data sections in wasm binaries: tlively.
Dec 8 2020, 9:49 PM · Restricted Project
sbc100 requested review of D92909: [WebAssembly] Add support for named data sections in wasm binaries.
Dec 8 2020, 9:49 PM · Restricted Project
sbc100 committed rG1b6d879ec1fc: [WebAssembly] Fix code generated for atomic operations in PIC mode (authored by sbc100).
[WebAssembly] Fix code generated for atomic operations in PIC mode
Dec 8 2020, 6:49 PM
sbc100 closed D92744: [WebAssembly] Fix code generated for atomic operations in PIC mode.
Dec 8 2020, 6:49 PM · Restricted Project
sbc100 added inline comments to D92744: [WebAssembly] Fix code generated for atomic operations in PIC mode.
Dec 8 2020, 5:10 PM · Restricted Project
sbc100 added a comment to D92744: [WebAssembly] Fix code generated for atomic operations in PIC mode.

One side effect is that that defs in this file that use classes from the non-atomic memory file such as LoadPatImmOff and LoadPatImmOff will no longer have the HasAtomics as part of their Requires. Does this seems reasonble?

Dec 8 2020, 3:14 PM · Restricted Project
sbc100 updated the summary of D92744: [WebAssembly] Fix code generated for atomic operations in PIC mode.
Dec 8 2020, 3:07 PM · Restricted Project
sbc100 added a comment to D92840: [WebAssembly] call_indirect causes indirect function table import.

I'm not sure how to address the duplication of got and the associated FIXME. Adding some others to the review list who might know a way to deal with that without duplication.

Dec 8 2020, 12:38 PM · Restricted Project
sbc100 added a reviewer for D92840: [WebAssembly] call_indirect causes indirect function table import: dschuff.
Dec 8 2020, 12:38 PM · Restricted Project
sbc100 added reviewers for D92840: [WebAssembly] call_indirect causes indirect function table import: aardappel, aheejin.
Dec 8 2020, 12:36 PM · Restricted Project

Dec 7 2020

sbc100 added reviewers for D92744: [WebAssembly] Fix code generated for atomic operations in PIC mode: tlively, aheejin.
Dec 7 2020, 10:50 AM · Restricted Project
sbc100 accepted D92691: [WebAssembly] Add Object and ObjectWriter support for wasm COMDAT sections.
Dec 7 2020, 9:27 AM · Restricted Project

Dec 6 2020

sbc100 updated the diff for D92744: [WebAssembly] Fix code generated for atomic operations in PIC mode.

add test

Dec 6 2020, 10:06 PM · Restricted Project
sbc100 added a comment to D92744: [WebAssembly] Fix code generated for atomic operations in PIC mode.

The alternative to this approach looks like implementing something
like PredicateControl in Mips.td where we can split the predicates
into groups so they don't clobber each other.

Dec 6 2020, 9:59 PM · Restricted Project
sbc100 requested review of D92744: [WebAssembly] Fix code generated for atomic operations in PIC mode.
Dec 6 2020, 9:55 PM · Restricted Project
sbc100 added inline comments to rG6dbd0eac02bf: [test] Split some tests which test both static and pic relocation models.
Dec 6 2020, 5:36 PM

Dec 4 2020

sbc100 committed rGab58e4cb5185: [lld][WebAssembly] Add suppport for PIC + passive data initialization (authored by sbc100).
[lld][WebAssembly] Add suppport for PIC + passive data initialization
Dec 4 2020, 5:29 PM
sbc100 closed D92620: [lld][WebAssembly] Add suppport for PIC + passive data initialization.
Dec 4 2020, 5:29 PM · Restricted Project

Dec 3 2020

sbc100 updated the diff for D92620: [lld][WebAssembly] Add suppport for PIC + passive data initialization.
  • fix start
Dec 3 2020, 8:21 PM · Restricted Project
sbc100 updated the diff for D92620: [lld][WebAssembly] Add suppport for PIC + passive data initialization.

feedback

Dec 3 2020, 7:17 PM · Restricted Project
sbc100 updated the diff for D92620: [lld][WebAssembly] Add suppport for PIC + passive data initialization.
  • rebase + add test
Dec 3 2020, 7:15 PM · Restricted Project
sbc100 committed rG1bb79875e4b8: [lld][WebAssembly] Set memory limits correctly for PIC + shared memory (authored by sbc100).
[lld][WebAssembly] Set memory limits correctly for PIC + shared memory
Dec 3 2020, 6:21 PM
sbc100 closed D92528: [lld][WebAssembly] Set memory limits correctly for PIC + shared memory.
Dec 3 2020, 6:21 PM · Restricted Project
sbc100 added a comment to D92620: [lld][WebAssembly] Add suppport for PIC + passive data initialization.

Still need to add testing..

Dec 3 2020, 4:56 PM · Restricted Project
sbc100 added a reviewer for D92620: [lld][WebAssembly] Add suppport for PIC + passive data initialization: tlively.
Dec 3 2020, 4:56 PM · Restricted Project
sbc100 requested review of D92620: [lld][WebAssembly] Add suppport for PIC + passive data initialization.
Dec 3 2020, 4:55 PM · Restricted Project
sbc100 added a comment to D92348: [WebAssembly] Fixed Writer::createInitMemoryFunction to work for wasm64.

Well, these tests are not going to tell us if the generated instructions make any sense, but ok..

Dec 3 2020, 11:53 AM · Restricted Project
sbc100 updated the diff for D92528: [lld][WebAssembly] Set memory limits correctly for PIC + shared memory.
  • rebase
Dec 3 2020, 11:10 AM · Restricted Project
sbc100 added a reviewer for D92528: [lld][WebAssembly] Set memory limits correctly for PIC + shared memory: tlively.
Dec 3 2020, 11:09 AM · Restricted Project
sbc100 committed rG701fa0b5ab04: [lld][WebAssembly] Fix malformed output with -pie + --shared-memory (authored by sbc100).
[lld][WebAssembly] Fix malformed output with -pie + --shared-memory
Dec 3 2020, 11:07 AM
sbc100 closed D92520: [lld][WebAssembly] Fix malformed output with -pie + --shared-memory.
Dec 3 2020, 11:06 AM · Restricted Project
sbc100 added a comment to D91418: [LLD][ELF] Rename lld port driver entry function to a consistent name.

I think changing from main to to avoids an issue and adds a new issue. We should fix the issues all together, and this requires consensus from others ports to proceed.

Is the new issue, the clash with lld::*::link and if so, then ideally we should replace link from all the ports to linkerMain?

Dec 3 2020, 9:38 AM · Restricted Project

Dec 2 2020

sbc100 requested review of D92528: [lld][WebAssembly] Set memory limits correctly for PIC + shared memory.
Dec 2 2020, 5:24 PM · Restricted Project
sbc100 updated the diff for D92520: [lld][WebAssembly] Fix malformed output with -pie + --shared-memory.
  • remove some debugging
Dec 2 2020, 4:01 PM · Restricted Project
sbc100 updated the summary of D92520: [lld][WebAssembly] Fix malformed output with -pie + --shared-memory.
Dec 2 2020, 4:00 PM · Restricted Project
sbc100 added a reviewer for D92520: [lld][WebAssembly] Fix malformed output with -pie + --shared-memory: tlively.
Dec 2 2020, 4:00 PM · Restricted Project
sbc100 requested review of D92520: [lld][WebAssembly] Fix malformed output with -pie + --shared-memory.
Dec 2 2020, 3:59 PM · Restricted Project

Dec 1 2020

sbc100 committed rGa38ed62ea803: [lld][WebAssembly] Feedback from D92038. NFC (authored by sbc100).
[lld][WebAssembly] Feedback from D92038. NFC
Dec 1 2020, 2:54 PM
sbc100 closed D92429: [lld][WebAssembly] Feedback from D92038. NFC.
Dec 1 2020, 2:54 PM · Restricted Project
sbc100 retitled D92429: [lld][WebAssembly] Feedback from D92038. NFC from [lld][WebAssembly] Feedback from D92038 to [lld][WebAssembly] Feedback from D92038. NFC.
Dec 1 2020, 2:05 PM · Restricted Project
sbc100 requested review of D92429: [lld][WebAssembly] Feedback from D92038. NFC.
Dec 1 2020, 2:05 PM · Restricted Project
sbc100 accepted D92150: [LTO][wasm][NewPM] Allow using new pass manager for wasm LTO.

Do all these change essentially match the ELF linker? A brief look makes me thing they do.

Dec 1 2020, 12:18 PM · Restricted Project
sbc100 added inline comments to D91870: [WebAssembly] Add support for table linking to wasm-ld.
Dec 1 2020, 12:13 PM · Restricted Project
sbc100 added a comment to D91870: [WebAssembly] Add support for table linking to wasm-ld.

Maybe there are two logical parts we can separate here:

Dec 1 2020, 12:04 PM · Restricted Project
sbc100 added a comment to D92323: [WebAssembly][MC] Fix placement of table section.

I guess we wait for D92359 and then land this on top of that.

Dec 1 2020, 1:14 AM · Restricted Project
sbc100 accepted D92323: [WebAssembly][MC] Fix placement of table section.

Oh I see .. up until now we import the table.

Dec 1 2020, 1:13 AM · Restricted Project
sbc100 added inline comments to D92323: [WebAssembly][MC] Fix placement of table section.
Dec 1 2020, 1:06 AM · Restricted Project
sbc100 accepted D92359: [WebAssembly] Support select and block for reference types.
Dec 1 2020, 1:04 AM · Restricted Project

Nov 30 2020

sbc100 added a comment to D92348: [WebAssembly] Fixed Writer::createInitMemoryFunction to work for wasm64.

I believe there is some coverage of createInitMemoryFunction in the tests.. although maybe not in a very useful/readable way.

Nov 30 2020, 10:11 PM · Restricted Project
sbc100 added inline comments to D92359: [WebAssembly] Support select and block for reference types.
Nov 30 2020, 8:31 PM · Restricted Project
sbc100 added inline comments to D92359: [WebAssembly] Support select and block for reference types.
Nov 30 2020, 7:46 PM · Restricted Project