Page MenuHomePhabricator

tlively (Thomas Lively)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 31 2018, 10:54 AM (129 w, 11 h)

Recent Activity

Today

tlively requested review of D95012: [WebAssembly] Prototype new f64x2 conversions.
Tue, Jan 19, 5:18 PM · Restricted Project, Restricted Project

Fri, Jan 15

tlively added inline comments to D94049: [WebAssembly] Fix catch unwind mismatches.
Fri, Jan 15, 9:39 PM · Restricted Project
tlively accepted D94048: [WebAssembly] Fix call unwind mismatches.
Fri, Jan 15, 2:57 PM · Restricted Project

Mon, Jan 11

tlively added a comment to D94048: [WebAssembly] Fix call unwind mismatches.

Looks good overall! Most of these comments are just me checking my understanding.

Mon, Jan 11, 3:41 PM · Restricted Project
tlively accepted D94450: [LegalizeDAG][RISCV][PowerPC][AMDGPU][WebAssembly] Improve expansion of SETONE/SETUEQ on targets without SETO/SETUO..

Nice! this looks like a good improvement for WebAssembly at least.

Mon, Jan 11, 2:53 PM · Restricted Project
tlively accepted D94045: [WebAssembly] Ensure terminate pads are a single BB.
Mon, Jan 11, 11:31 AM · Restricted Project

Fri, Jan 8

tlively accepted D94039: [WebAssembly] Update WasmEHPrepare for the new spec.
Fri, Jan 8, 2:06 PM · Restricted Project, Restricted Project

Thu, Jan 7

tlively accepted D94047: [WebAssembly] Remove more unnecessary brs in CFGStackify.
Thu, Jan 7, 10:57 AM · Restricted Project
tlively accepted D94046: [WebAssembly] Misc. refactoring in CFGStackify (NFC).
Thu, Jan 7, 10:23 AM · Restricted Project
tlively added inline comments to D94039: [WebAssembly] Update WasmEHPrepare for the new spec.
Thu, Jan 7, 10:15 AM · Restricted Project, Restricted Project
tlively added inline comments to D94045: [WebAssembly] Ensure terminate pads are a single BB.
Thu, Jan 7, 10:15 AM · Restricted Project

Tue, Jan 5

tlively accepted D94044: [WebAssembly] Remove unreachable EH pads.
Tue, Jan 5, 12:15 PM · Restricted Project
tlively accepted D94043: [WebAssembly] Update InstPrinter support for EH.
Tue, Jan 5, 11:39 AM · Restricted Project
tlively accepted D94041: [WebAssembly] Remove exnref and br_on_exn.

Nice!

Tue, Jan 5, 11:34 AM · Restricted Project
tlively committed rG497026c90233: [WebAssembly] Prototype prefetch instructions (authored by tlively).
[WebAssembly] Prototype prefetch instructions
Tue, Jan 5, 11:32 AM
tlively closed D93883: [WebAssembly] Prototype prefetch instructions.
Tue, Jan 5, 11:32 AM · Restricted Project, Restricted Project
tlively accepted D94040: [WebAssembly] Update basic EH instructions for the new spec.
Tue, Jan 5, 11:16 AM · Restricted Project
tlively added a comment to D94039: [WebAssembly] Update WasmEHPrepare for the new spec.

In the description I think "but LLVM does not have a way of that kind of behavior" is missing the word "modeling" => "but LLVM does not have a way of modeling that kind of behavior"

Tue, Jan 5, 10:41 AM · Restricted Project, Restricted Project
tlively accepted D94038: [WebAssembly] Rename wasm_rethrow_in_catch intrinsic/builtin.
Tue, Jan 5, 10:25 AM · Restricted Project, Restricted Project
tlively accepted D94037: [WebAssembly] Change label numbers to variables in test.

Looks good! A few of the replacements in the code don't match the replacements in the comments, but I assume the comments were previously just stale.

Tue, Jan 5, 10:22 AM · Restricted Project
tlively added inline comments to D93883: [WebAssembly] Prototype prefetch instructions.
Tue, Jan 5, 9:58 AM · Restricted Project, Restricted Project
tlively updated the diff for D93883: [WebAssembly] Prototype prefetch instructions.
  • Fix section headers in test file
Tue, Jan 5, 9:58 AM · Restricted Project, Restricted Project

Mon, Jan 4

tlively accepted D94036: [WebAssembly] Remove old SDT_WebAssemblyCalls (NFC).

Thanks!

Mon, Jan 4, 4:05 PM · Restricted Project

Mon, Dec 28

tlively requested review of D93883: [WebAssembly] Prototype prefetch instructions.
Mon, Dec 28, 7:40 PM · Restricted Project, Restricted Project
tlively added a comment to rG51ff04567b2f: Recommit "[DSE] Switch to MemorySSA-backed DSE by default.".

@fhahn A git bisect points to this commit as introducing https://bugs.llvm.org/show_bug.cgi?id=48616. Would you be able to take a look?

Mon, Dec 28, 2:40 PM
tlively committed rG5e09e9979bc6: [WebAssembly] Prototype extending pairwise add instructions (authored by tlively).
[WebAssembly] Prototype extending pairwise add instructions
Mon, Dec 28, 2:11 PM
tlively closed D93775: [WebAssembly] Prototype extending pairwise add instructions.
Mon, Dec 28, 2:11 PM · Restricted Project, Restricted Project
tlively committed rG44ee14f993ff: [WebAssembly][NFC] Finish cleaning up SIMD tablegen (authored by tlively).
[WebAssembly][NFC] Finish cleaning up SIMD tablegen
Mon, Dec 28, 1:59 PM
tlively closed D93771: [WebAssembly][NFC] Finish cleaning up SIMD tablegen.
Mon, Dec 28, 1:59 PM · Restricted Project
tlively updated the diff for D93771: [WebAssembly][NFC] Finish cleaning up SIMD tablegen.
  • Fix alignment
Mon, Dec 28, 1:49 PM · Restricted Project

Wed, Dec 23

tlively added inline comments to D93771: [WebAssembly][NFC] Finish cleaning up SIMD tablegen.
Wed, Dec 23, 10:26 PM · Restricted Project
tlively updated the diff for D93771: [WebAssembly][NFC] Finish cleaning up SIMD tablegen.
  • Reuse vt as suggested
  • Add IntVecs as suggested
Wed, Dec 23, 10:26 PM · Restricted Project
tlively requested review of D93775: [WebAssembly] Prototype extending pairwise add instructions.
Wed, Dec 23, 12:50 PM · Restricted Project, Restricted Project
tlively requested review of D93771: [WebAssembly][NFC] Finish cleaning up SIMD tablegen.
Wed, Dec 23, 10:36 AM · Restricted Project

Tue, Dec 22

tlively committed rGefe7f5ede0b3: [WebAssembly][NFC] Refactor SIMD load/store tablegen defs (authored by tlively).
[WebAssembly][NFC] Refactor SIMD load/store tablegen defs
Tue, Dec 22, 8:06 PM
tlively closed D93660: [WebAssembly][NFC] Refactor SIMD load/store tablegen defs.
Tue, Dec 22, 8:06 PM · Restricted Project
tlively committed rGa781a706b961: [WebAssembly][SIMD] Rename shuffle, swizzle, and load_splats (authored by tlively).
[WebAssembly][SIMD] Rename shuffle, swizzle, and load_splats
Tue, Dec 22, 2:29 PM
tlively closed D93722: [WebAssembly][SIMD] Rename shuffle, swizzle, and load_splats.
Tue, Dec 22, 2:29 PM · Restricted Project
tlively updated the diff for D93660: [WebAssembly][NFC] Refactor SIMD load/store tablegen defs.
Tue, Dec 22, 12:42 PM · Restricted Project
tlively requested review of D93722: [WebAssembly][SIMD] Rename shuffle, swizzle, and load_splats.
Tue, Dec 22, 11:31 AM · Restricted Project
tlively added inline comments to D93660: [WebAssembly][NFC] Refactor SIMD load/store tablegen defs.
Tue, Dec 22, 10:42 AM · Restricted Project

Mon, Dec 21

tlively added a comment to D93660: [WebAssembly][NFC] Refactor SIMD load/store tablegen defs.

Wow, I didn't know we can do OOP in TableGen! (Are these new functionalities?)

Mon, Dec 21, 9:33 PM · Restricted Project
tlively requested review of D93660: [WebAssembly][NFC] Refactor SIMD load/store tablegen defs.
Mon, Dec 21, 12:47 PM · Restricted Project
tlively accepted D93554: [lld][WebAssembly] Fix for TLS + --relocatable.

It would be good to add a description of the bug to the commit description.

Mon, Dec 21, 9:14 AM · Restricted Project

Dec 10 2020

tlively accepted D93066: [lld][WebAssembly] Split __wasm_apply_relocs function in two.

Nice!

Dec 10 2020, 4:53 PM · Restricted Project
tlively added a comment to D93066: [lld][WebAssembly] Split __wasm_apply_relocs function in two.

Looks good! Can you add a test that uses __wasm_start?

Dec 10 2020, 2:21 PM · Restricted Project
tlively accepted D93035: [lld][WebAssembly] Delay creation of internal __wasm_memory_init function.

"not completely elided" => "completely elided" in the description.

Dec 10 2020, 9:52 AM · Restricted Project

Dec 9 2020

tlively accepted D92997: [lld][WebAssembly] Don't emit names for data segments that we omit.

Aha, that seems important!

Dec 9 2020, 8:59 PM · Restricted Project
tlively accepted D92909: [WebAssembly] Add support for named data sections in wasm binaries.
Dec 9 2020, 12:30 PM · Restricted Project

Dec 7 2020

tlively accepted D92744: [WebAssembly] Fix code generated for atomic operations in PIC mode.

"were being honored" => "were not being honored" in the patch description.

Dec 7 2020, 12:17 PM · Restricted Project

Dec 3 2020

tlively accepted D92620: [lld][WebAssembly] Add suppport for PIC + passive data initialization.
Dec 3 2020, 8:11 PM · Restricted Project
tlively added a comment to D92620: [lld][WebAssembly] Add suppport for PIC + passive data initialization.

Looks good so far!

Dec 3 2020, 5:18 PM · Restricted Project
tlively accepted D92528: [lld][WebAssembly] Set memory limits correctly for PIC + shared memory.
Dec 3 2020, 4:00 PM · Restricted Project
tlively accepted D92348: [WebAssembly] Fixed Writer::createInitMemoryFunction to work for wasm64.

LGTM besides those last couple questions!

Dec 3 2020, 1:53 PM · Restricted Project
tlively added inline comments to D92348: [WebAssembly] Fixed Writer::createInitMemoryFunction to work for wasm64.
Dec 3 2020, 1:05 PM · Restricted Project
tlively accepted D92520: [lld][WebAssembly] Fix malformed output with -pie + --shared-memory.
Dec 3 2020, 10:33 AM · Restricted Project

Dec 1 2020

tlively requested changes to D92348: [WebAssembly] Fixed Writer::createInitMemoryFunction to work for wasm64.
Dec 1 2020, 10:16 AM · Restricted Project
tlively added a comment to D92348: [WebAssembly] Fixed Writer::createInitMemoryFunction to work for wasm64.

Oh right, I forgot about those crazy unreadable tests. Sam is totally right. For now adding new RUN and CHECK lines to those tests should be sufficient.

Dec 1 2020, 10:16 AM · Restricted Project

Nov 30 2020

tlively accepted D92348: [WebAssembly] Fixed Writer::createInitMemoryFunction to work for wasm64.

Hmm, I guess we don't. Would you mind adding one?

Nov 30 2020, 8:44 PM · Restricted Project
tlively accepted D92359: [WebAssembly] Support select and block for reference types.
Nov 30 2020, 8:40 PM · Restricted Project

Nov 19 2020

tlively accepted D91769: [WebAssembly] Add support for named globals in the object format..

Nice! This will be helpful for reading disassembled modules. In a future where we have a clang extension allowing users to define their own WebAssembly globals from C/C++, would it be easy to extend this to support names for those arbitrary globals as well?

Nov 19 2020, 12:04 AM · Restricted Project

Nov 17 2020

tlively added a comment to D91428: Add support for multiple program address spaces.

@arsenm, Are you suggesting that we just relax the verification rules to allow calling function pointers to arbitrary address spaces without needing any changes to the data layout string? That seems fine to me, but the data layout string solution does allow targets to opt in to more precise validation.

Nov 17 2020, 12:08 PM · Restricted Project, Restricted Project

Nov 13 2020

tlively accepted D91432: Move GlobalTLSAddress handling to WebAssemblyISelLowering. NFC.
Nov 13 2020, 12:22 PM · Restricted Project
tlively added a comment to D91428: Add support for multiple program address spaces.

I think this is a good direction overall, and I'm glad the code doesn't become any messier with this change. I do think it would be good to also email llvm-dev about this change to get general feedback and make sure it doesn't require a full RFC.

Nov 13 2020, 12:19 PM · Restricted Project, Restricted Project
tlively accepted D91448: [WebAssembly] Remove a temporarily added RUN line.

Wow, that bug is wild!

Nov 13 2020, 11:21 AM · Restricted Project
tlively accepted D91447: [WebAssembly] Rename atomic.notify and *.atomic.wait.
Nov 13 2020, 11:18 AM · Restricted Project, Restricted Project
tlively added a comment to D91432: Move GlobalTLSAddress handling to WebAssemblyISelLowering. NFC.

Yes, this looks better than what we had before. I think it would be generally better to use TableGen patterns rather than generating the MachineNode directly in C++.

Nov 13 2020, 11:09 AM · Restricted Project

Nov 12 2020

tlively accepted D91276: [WebAssembly] Add new relocation types for TLS data symbols.
Nov 12 2020, 11:46 PM · Restricted Project
tlively added a comment to D91276: [WebAssembly] Add new relocation types for TLS data symbols.

Why are there separate versions of the new relocation for both i32 and sleb128? Do we use both of them?

Nov 12 2020, 10:53 PM · Restricted Project
tlively accepted D91231: [lld][WebAssembly] Add test for TLS BSS data. NFC..
Nov 12 2020, 5:25 PM · Restricted Project
tlively requested changes to D91274: [WebAssembly] Ban all TLS on non-emscripten targets (even local-exec).

Thanks, Alex! I suspected that might be the case. Follow-up question: What kind of binary compatibility guarantees does Rust have when mixing compiler versions? Would it be a problem for example if we rewrote the TLS mechanism from scratch so that it worked differently in LLVM 12 than it does in LLVM 11?

Nov 12 2020, 10:17 AM · Restricted Project

Nov 11 2020

tlively accepted D91274: [WebAssembly] Ban all TLS on non-emscripten targets (even local-exec).

LGTM if we can verify that neither Rust nor WASI use this functionality.

Nov 11 2020, 9:58 PM · Restricted Project

Nov 10 2020

tlively accepted D91222: [WebAssembly] Remove wasm-specific TLS builtins.

Excellent, thanks. I hope I'm not forgetting any good reason we added these. Emscripten doesn't use them in its pthreads runtime, right?

Nov 10 2020, 6:32 PM · Restricted Project, Restricted Project
tlively accepted D91115: [lld][WebAssembly] Allow references to __tls_base without shared memory.
Nov 10 2020, 1:47 PM · Restricted Project
tlively added inline comments to D91115: [lld][WebAssembly] Allow references to __tls_base without shared memory.
Nov 10 2020, 11:39 AM · Restricted Project
tlively accepted D91113: [lld][WebAssembly] Convert tls code to asm format.

Nice, thanks!

Nov 10 2020, 11:32 AM · Restricted Project

Nov 3 2020

tlively committed rG107c3a12d627: [WebAssembly] Implement ref.null (authored by wingo).
[WebAssembly] Implement ref.null
Nov 3 2020, 10:46 AM
tlively closed D90608: [WebAssembly] Implement ref.null.
Nov 3 2020, 10:46 AM · Restricted Project
tlively accepted D90608: [WebAssembly] Implement ref.null.

Excellent, thanks! I'll land this.

Nov 3 2020, 10:03 AM · Restricted Project

Nov 2 2020

tlively added a comment to D90608: [WebAssembly] Implement ref.null.

lgtm. In a project that primarily deals with C/C++ code I find "heap time" a little confusing because it makes me think of the malloc heap used by C/C++. Why not "managed" or something like that to avoid ambiguity? I guess that is being discussed in the spec and we should probably just follow their lead.

I do think that matching the upstream spec "heap type" terminology is important, even if it's a little confusing in a C++ context.

Do you think that upstream term "heap type" is reasonable, given the pre-existing alternate meaning of heap that already exists in the unmanaged world?

Nov 2 2020, 1:49 PM · Restricted Project
tlively added a comment to D90608: [WebAssembly] Implement ref.null.

lgtm. In a project that primarily deals with C/C++ code I find "heap time" a little confusing because it makes me think of the malloc heap used by C/C++. Why not "managed" or something like that to avoid ambiguity? I guess that is being discussed in the spec and we should probably just follow their lead.

Nov 2 2020, 12:52 PM · Restricted Project
tlively added a comment to D90608: [WebAssembly] Implement ref.null.

Nice! This looks good besides that one question. Also, for the patch description, it seems slightly misleading to say that "the register form of ref.null is still unimplemented"; IIUC, the register form is implemented since the I tablegen multiclass creates both forms, but it's simply not used for anything right now.

Nov 2 2020, 12:29 PM · Restricted Project

Oct 30 2020

tlively committed rGa787e0977912: [WebAssembly] Prototype i64x2.bitmask (authored by tlively).
[WebAssembly] Prototype i64x2.bitmask
Oct 30 2020, 5:23 PM
tlively closed D90514: [WebAssembly] Prototype i64x2.bitmask.
Oct 30 2020, 5:23 PM · Restricted Project, Restricted Project
tlively added a comment to D90514: [WebAssembly] Prototype i64x2.bitmask.

Thanks for all the reviews! That's the last of them for now :)

Oct 30 2020, 5:09 PM · Restricted Project, Restricted Project
tlively requested review of D90514: [WebAssembly] Prototype i64x2.bitmask.
Oct 30 2020, 4:39 PM · Restricted Project, Restricted Project
tlively committed rG0a512a555a8d: [WebAssembly] Prototype i64x2.eq (authored by tlively).
[WebAssembly] Prototype i64x2.eq
Oct 30 2020, 4:38 PM
tlively closed D90508: [WebAssembly] Prototype i64x2.eq.
Oct 30 2020, 4:38 PM · Restricted Project, Restricted Project
tlively committed rG1cb0b5660777: [WebAssembly] Prototype i64x2.widen_{low,high}_i32x4_{s,u} (authored by tlively).
[WebAssembly] Prototype i64x2.widen_{low,high}_i32x4_{s,u}
Oct 30 2020, 3:44 PM
tlively closed D90504: [WebAssembly] Prototype i64x2.widen_{low,high}_i32x4_{s,u}.
Oct 30 2020, 3:44 PM · Restricted Project, Restricted Project
tlively requested review of D90508: [WebAssembly] Prototype i64x2.eq.
Oct 30 2020, 3:27 PM · Restricted Project, Restricted Project
tlively requested review of D90504: [WebAssembly] Prototype i64x2.widen_{low,high}_i32x4_{s,u}.
Oct 30 2020, 2:45 PM · Restricted Project, Restricted Project

Oct 29 2020

tlively committed rG6214be3a4ab9: [WebAssembly] Remove unused FileCheck test prefixes (authored by tlively).
[WebAssembly] Remove unused FileCheck test prefixes
Oct 29 2020, 1:38 PM
tlively closed D90416: [WebAssembly] Remove unused FileCheck test prefixes.
Oct 29 2020, 1:38 PM · Restricted Project
tlively updated the summary of D90416: [WebAssembly] Remove unused FileCheck test prefixes.
Oct 29 2020, 12:38 PM · Restricted Project
tlively requested review of D90416: [WebAssembly] Remove unused FileCheck test prefixes.
Oct 29 2020, 12:35 PM · Restricted Project
tlively committed rGbe6f50798e79: [WebAssembly] Implement SIMD signselect instructions (authored by tlively).
[WebAssembly] Implement SIMD signselect instructions
Oct 29 2020, 11:06 AM
tlively closed D90357: [WebAssembly] Implement SIMD signselect instructions.
Oct 29 2020, 11:06 AM · Restricted Project, Restricted Project

Oct 28 2020

tlively requested review of D90357: [WebAssembly] Implement SIMD signselect instructions.
Oct 28 2020, 5:50 PM · Restricted Project, Restricted Project
tlively committed rG5b464f2aa514: [WebAssembly] Fix incorrectly named target builtin (authored by tlively).
[WebAssembly] Fix incorrectly named target builtin
Oct 28 2020, 10:23 AM