Page MenuHomePhabricator

[PowerPC] Add `hasSideEffects=0` for PLXVP and PSTXVP instructions definition
AbandonedPublic

Authored by NeHuang on Nov 25 2020, 3:18 PM.

Details

Reviewers
amyk
steven.zhang
hfinkel
Group Reviewers
Restricted Project
Summary

In this patch, we set hasSideEffects=0 for PLXVP and PSTXVP instructions definition in the td file.

Diff Detail

Event Timeline

NeHuang created this revision.Nov 25 2020, 3:18 PM
NeHuang requested review of this revision.Nov 25 2020, 3:18 PM

Why do we need these flags for PLXVP and PSTXVP ? Please, add a test case showing why this is required.

lebedev.ri retitled this revision from Add `hasSideEffects=0` for PLXVP and PSTXVP instructions definition to [PowerPC] Add `hasSideEffects=0` for PLXVP and PSTXVP instructions definition .Nov 26 2020, 1:11 PM
steven.zhang added a comment.EditedNov 26 2020, 6:48 PM

I think, this patch isn't needed any more as we have already specified the match pattern for these instructions and tblgen will infer the sideeffects from the pattern. See what we get from tblgen now(we didn't have the sideeffect bit):

{ 1191,       3,      1,      4,      39,     0|(1ULL<<MCID::MayLoad), 0x0ULL, nullptr, nullptr, OperandInfo158 },  // Inst #1191 = LXVP
NeHuang abandoned this revision.Dec 1 2020, 8:47 AM