- User Since
- Mar 7 2019, 9:07 AM (85 w, 3 d)
Fri, Oct 23
LGTM. please address Lei's comment on commit.
Wed, Oct 21
Tue, Oct 20
Add a test to disable prefix-instrs.
Mon, Oct 19
Mon, Oct 5
Fri, Oct 2
Mon, Sep 28
Sep 24 2020
Sep 23 2020
LGTM. Only two nits comment.
Addressed nits in the implementation and test cases.
Sep 22 2020
Sep 21 2020
Move up the comment in the test case.
Sep 18 2020
Sep 17 2020
Rebased with ToT to integrate with the changes in https://reviews.llvm.org/D87486
Sep 15 2020
Sep 11 2020
Addressed review comments to
- Change the error message
- Change the LIT test accordingly
Sep 10 2020
Sep 9 2020
Sep 3 2020
LGTM. I only have some comments on the nits.
Sep 1 2020
Aug 28 2020
Updated fatal error message in the LIT test
Address Sean's comment for fatal error message.
Aug 27 2020
Update the patch without using branch_lt table.
Aug 24 2020
LGTM. Only a nit can be addressed while committing the patch.
Aug 18 2020
Aug 17 2020
Overall LGTM. I only have some comments on the nits.
Aug 14 2020
Thanks MaskRay. The additional test removed.
- Updated the LIT cases accordingly.
- Create a test case for thunk alignment fix.
Aug 12 2020
Overall the patch looks good to me. I only have two questions and a clang-format nit which can be resolved before committing the code.
Aug 7 2020
Addressed the comment to check R_PPC64_REL24 and R_PPC64_REL14 for PPC64PltCallStub compatibility check.
Aug 6 2020
Overall LGTM. I only have some nits comment/question for the test case and clang-format related issue.
Fixed nits in the test case to
- Add start address.
- Fix indentations.
Aug 4 2020
Jul 30 2020
Jul 29 2020
Thanks Sean for the review. Addressed the nits for clang-format and alignment issues.
Jul 28 2020
As the patch https://reviews.llvm.org/D83834 is reverted, updated the test case accordingly to combine ppc64-callee-global.s and ppc64-pcrel-call-to-extern.s with .ifdef AUX