Page MenuHomePhabricator

amyk (Amy Kwan)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 4 2018, 10:36 AM (109 w, 8 h)

Recent Activity

Today

amyk added inline comments to D83338: [PowerPC][Power10] Implemented Vector Shift Builtins.
Wed, Aug 5, 12:22 PM · Restricted Project, Restricted Project, Restricted Project

Yesterday

amyk updated the diff for D82725: [PowerPC] Implement Move to VSR Mask builtins in LLVM/Clang.

Rebased patch, and removed MC tests from the original patch.

Tue, Aug 4, 8:02 PM · Restricted Project, Restricted Project, Restricted Project
amyk updated the diff for D82726: [PowerPC] Implement Vector Count Mask Bits builtins in LLVM/Clang.

Rebased patch and removed MC tests from the patch.

Tue, Aug 4, 7:17 PM · Restricted Project, Restricted Project
amyk added inline comments to D82727: [PowerPC] Implement Vector Expand Mask builtins in LLVM/Clang.
Tue, Aug 4, 5:03 PM · Restricted Project, Restricted Project
amyk updated the diff for D82727: [PowerPC] Implement Vector Expand Mask builtins in LLVM/Clang.

Rebased the patch and removed MC tests.

Tue, Aug 4, 5:01 PM · Restricted Project, Restricted Project
amyk added inline comments to D84359: [PowerPC] Add vector pair load/store instructions and vector pair register class.
Tue, Aug 4, 4:41 PM · Restricted Project, Restricted Project
amyk added inline comments to D83338: [PowerPC][Power10] Implemented Vector Shift Builtins.
Tue, Aug 4, 7:33 AM · Restricted Project, Restricted Project, Restricted Project
amyk accepted D84622: [PowerPC] Implement Vector Extract Low/High Order Builtins in LLVM/Clang.

I think overall it LGTM and the indentation can be addressed when committing.

Tue, Aug 4, 7:07 AM · Restricted Project, Restricted Project

Fri, Jul 31

amyk committed rG93fd8dbdc250: [PowerPC] Add Vector String Isolate instruction definitions and MC Tests (authored by Conanap).
[PowerPC] Add Vector String Isolate instruction definitions and MC Tests
Fri, Jul 31, 10:33 AM
amyk closed D84197: [PowerPC][Power10] Vector String Isolate instruction definitions and MC Tests.
Fri, Jul 31, 10:32 AM · Restricted Project, Restricted Project, Restricted Project
amyk committed rGc4e574323210: [PowerPC] Implement low-order Vector Modulus Builtins, and add Vector… (authored by amyk).
[PowerPC] Implement low-order Vector Modulus Builtins, and add Vector…
Fri, Jul 31, 9:16 AM
amyk closed D82576: [PowerPC][Power10] Implement low-order Vector Modulus Builtins, and add Vector Multiply/Divide/Modulus Builtins Tests.
Fri, Jul 31, 9:15 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Jul 27

amyk added a comment to D82502: [PowerPC] Implement Load VSX Vector and Sign Extend and Zero Extend.

Could we also elaborate in the description on how we are utilizing the new load instructions for zero extend case but not the sign extend case?

Mon, Jul 27, 9:45 PM · Restricted Project, Restricted Project, Restricted Project
amyk accepted D84197: [PowerPC][Power10] Vector String Isolate instruction definitions and MC Tests.

Thanks for recovering the tests. LGTM.

Mon, Jul 27, 9:45 PM · Restricted Project, Restricted Project, Restricted Project
amyk updated the diff for D82675: [PowerPC] Implement Vector Extract Mask builtins in LLVM/Clang.
  • Rebased patch
  • Updated patch to remove instruction definitions and MC tests
Mon, Jul 27, 9:45 PM · Restricted Project, Restricted Project, Restricted Project
amyk updated the diff for D82609: [PowerPC] Implement Vector Multiply High/Divide Extended Builtins in LLVM/Clang.

Addressed the following comments:

  • updated CHECK lines to check for the full intrinsic call
  • updated indentation
Mon, Jul 27, 4:28 PM · Restricted Project, Restricted Project, Restricted Project
amyk updated the summary of D82675: [PowerPC] Implement Vector Extract Mask builtins in LLVM/Clang.
Mon, Jul 27, 4:00 PM · Restricted Project, Restricted Project, Restricted Project
amyk updated the summary of D82727: [PowerPC] Implement Vector Expand Mask builtins in LLVM/Clang.
Mon, Jul 27, 4:00 PM · Restricted Project, Restricted Project
amyk added a comment to D82675: [PowerPC] Implement Vector Extract Mask builtins in LLVM/Clang.

I will need to update this patch to remove the instruction definition and MC tests.

Mon, Jul 27, 3:59 PM · Restricted Project, Restricted Project, Restricted Project
amyk added a comment to D82727: [PowerPC] Implement Vector Expand Mask builtins in LLVM/Clang.

I will need to update this patch to remove the instruction definition and MC tests.

Mon, Jul 27, 3:59 PM · Restricted Project, Restricted Project
amyk updated the summary of D82725: [PowerPC] Implement Move to VSR Mask builtins in LLVM/Clang.
Mon, Jul 27, 3:58 PM · Restricted Project, Restricted Project, Restricted Project
amyk updated the summary of D82725: [PowerPC] Implement Move to VSR Mask builtins in LLVM/Clang.
Mon, Jul 27, 3:58 PM · Restricted Project, Restricted Project, Restricted Project
amyk added a comment to D82725: [PowerPC] Implement Move to VSR Mask builtins in LLVM/Clang.

I will need to update this patch to remove the instruction definition and MC tests.

Mon, Jul 27, 3:57 PM · Restricted Project, Restricted Project, Restricted Project
amyk added a comment to D82726: [PowerPC] Implement Vector Count Mask Bits builtins in LLVM/Clang.

I will need to update this patch to remove the instruction definition and MC tests.

Mon, Jul 27, 3:57 PM · Restricted Project, Restricted Project
amyk updated the summary of D82726: [PowerPC] Implement Vector Count Mask Bits builtins in LLVM/Clang.
Mon, Jul 27, 3:57 PM · Restricted Project, Restricted Project
amyk updated the summary of D82609: [PowerPC] Implement Vector Multiply High/Divide Extended Builtins in LLVM/Clang.
Mon, Jul 27, 3:43 PM · Restricted Project, Restricted Project, Restricted Project
amyk updated the summary of D82576: [PowerPC][Power10] Implement low-order Vector Modulus Builtins, and add Vector Multiply/Divide/Modulus Builtins Tests.
Mon, Jul 27, 3:42 PM · Restricted Project, Restricted Project, Restricted Project
amyk accepted D83722: [PowerPC] Add options to control paired vector memops support.

This LGTM. Thanks for addressing the comments Baptiste.

Mon, Jul 27, 10:22 AM · Restricted Project, Restricted Project, Restricted Project
amyk committed rG7c182663a857: Revert "Re-apply:" Emit DW_OP_implicit_value for Floating point constants"" (authored by amyk).
Revert "Re-apply:" Emit DW_OP_implicit_value for Floating point constants""
Mon, Jul 27, 7:45 AM

Fri, Jul 24

amyk committed rG739cd2638b12: [PowerPC] Exploit the High Order Vector Multiply Instructions on Power10 (authored by amyk).
[PowerPC] Exploit the High Order Vector Multiply Instructions on Power10
Fri, Jul 24, 7:41 PM
amyk closed D82584: [PowerPC][Power10] Exploit the High Order Vector Multiply Instructions on Power10.
Fri, Jul 24, 7:41 PM · Restricted Project, Restricted Project
amyk committed rG74790a5dde9a: [PowerPC] Implement Truncate and Store VSX Vector Builtins (authored by amyk).
[PowerPC] Implement Truncate and Store VSX Vector Builtins
Fri, Jul 24, 5:23 PM
amyk closed D82467: [PowerPC][Power10] Implement Truncate and Store VSX Vector Builtins.
Fri, Jul 24, 5:23 PM · Restricted Project, Restricted Project, Restricted Project
amyk added a comment to D82467: [PowerPC][Power10] Implement Truncate and Store VSX Vector Builtins.

The llvm/test/CodeGen/PowerPC/builtins-ppc-p10vsx.ll file actually exists, but does not have a BE RUN line. I realized I didn't rebase this diff to my previous patch that introduced it. Thus on the commit, I will append my tests to that file and add a BE line to it.

Fri, Jul 24, 3:41 PM · Restricted Project, Restricted Project, Restricted Project
amyk added a comment to D83338: [PowerPC][Power10] Implemented Vector Shift Builtins.

I realize it may be possible to open code these, as these functions already exist in altivec.h. Could you look into if this is the case?

Fri, Jul 24, 8:50 AM · Restricted Project, Restricted Project, Restricted Project
amyk requested changes to D84197: [PowerPC][Power10] Vector String Isolate instruction definitions and MC Tests.

Could you please add back the MC tests for the rightmost load/store instructions, and then add the vector string isolate tests to the end of the file?

Fri, Jul 24, 8:46 AM · Restricted Project, Restricted Project, Restricted Project
amyk accepted D83955: [PowerPC][Power10] Implementation of 128-bit Binary Vector Multiply builtins.
Fri, Jul 24, 8:44 AM · Restricted Project, Restricted Project, Restricted Project
amyk accepted D83955: [PowerPC][Power10] Implementation of 128-bit Binary Vector Multiply builtins.

I think this LGTM now. The file is already upstream, so your tests will need to be added to that file.

Fri, Jul 24, 8:44 AM · Restricted Project, Restricted Project, Restricted Project

Thu, Jul 23

amyk committed rG1dc1a3fb0c51: [PowerPC] Implement low-order Vector Multiply, Modulus and Divide Instructions (authored by amyk).
[PowerPC] Implement low-order Vector Multiply, Modulus and Divide Instructions
Thu, Jul 23, 3:19 PM
amyk closed D82510: [PowerPC][Power10] Implement low-order Vector Multiply, Modulus and Divide Instructions.
Thu, Jul 23, 3:18 PM · Restricted Project, Restricted Project
amyk added a comment to rG59a76d957a26: Re-apply:" Emit DW_OP_implicit_value for Floating point constants".

Hi there!
I believe this patch is causing failures on the following (big endian) PowerPC buildbots:
http://lab.llvm.org:8011/builders/clang-ppc64be-linux-multistage
http://lab.llvm.org:8011/builders/clang-ppc64be-linux-lnt/
http://lab.llvm.org:8011/builders/clang-ppc64be-linux

Thu, Jul 23, 2:17 PM
amyk accepted D84384: [PowerPC][Power10] Add Vector Extract Double Instruction Definitions and MC tests.

LGTM.

Thu, Jul 23, 6:57 AM · Restricted Project
amyk accepted D84382: [PowerPC][Power10] Cleanup p10vector clang test.

LGTM as well.

Thu, Jul 23, 6:56 AM · Restricted Project

Wed, Jul 22

amyk added a comment to rG33d239513c88: [MSAN] Instrument libatomic load/store calls.

Hi!
This patch is causing failures on the following (big endian) PowerPC buildbots:
http://lab.llvm.org:8011/builders/sanitizer-ppc64be-linux
http://lab.llvm.org:8011/builders/clang-ppc64be-linux
http://lab.llvm.org:8011/builders/clang-ppc64be-linux-multistage
http://lab.llvm.org:8011/builders/clang-ppc64be-linux-lnt

Wed, Jul 22, 9:38 PM
amyk committed rG5f110273954a: [PowerPC][Power10] Fix vins*vlx instructions to have i32 arguments. (authored by amyk).
[PowerPC][Power10] Fix vins*vlx instructions to have i32 arguments.
Wed, Jul 22, 3:59 PM
amyk closed D84277: [PowerPC][Power10] Fix vins*vlx instructions to have i32 arguments..
Wed, Jul 22, 3:58 PM · Restricted Project, Restricted Project, Restricted Project
amyk committed rG08b4a50e39d8: [PowerPC][Power10] Fix the Test LSB by Byte (xvtlsbb) Builtins Implementation (authored by amyk).
[PowerPC][Power10] Fix the Test LSB by Byte (xvtlsbb) Builtins Implementation
Wed, Jul 22, 11:27 AM
amyk closed D84291: [PowerPC][Power10] Fix the Test LSB by Byte (xvtlsbb) Builtins Implementation.
Wed, Jul 22, 11:27 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Jul 21

amyk created D84291: [PowerPC][Power10] Fix the Test LSB by Byte (xvtlsbb) Builtins Implementation.
Tue, Jul 21, 8:43 PM · Restricted Project, Restricted Project, Restricted Project
amyk created D84277: [PowerPC][Power10] Fix vins*vlx instructions to have i32 arguments..
Tue, Jul 21, 4:43 PM · Restricted Project, Restricted Project, Restricted Project
amyk committed rG1eb279d2a8c8: [PowerPC][Power10] Add Vector Multiply/Mod/Divide Instruction Definitions and… (authored by amyk).
[PowerPC][Power10] Add Vector Multiply/Mod/Divide Instruction Definitions and…
Tue, Jul 21, 4:11 PM
amyk closed D82929: [PowerPC][Power10] Add Vector Multiply/Mod/Divide Instruction Definitions and MC Tests.
Tue, Jul 21, 4:11 PM · Restricted Project, Restricted Project

Fri, Jul 17

amyk updated the summary of D83500: [PowerPC][Power10] Implement custom codegen for the vec_replace_elt and vec_replace_unaligned builtins..
Fri, Jul 17, 3:15 PM · Restricted Project, Restricted Project, Restricted Project
amyk added inline comments to D83404: [PowerPC][PCRelative] Thread Local Storage Support for Local Exec.
Fri, Jul 17, 2:46 PM · Restricted Project, Restricted Project
amyk added inline comments to D83722: [PowerPC] Add options to control paired vector memops support.
Fri, Jul 17, 2:38 PM · Restricted Project, Restricted Project, Restricted Project
amyk added a comment to D83338: [PowerPC][Power10] Implemented Vector Shift Builtins.

Please also change the function names.

Fri, Jul 17, 2:27 PM · Restricted Project, Restricted Project, Restricted Project
amyk accepted D81442: [PowerPC] Add clang options to control MMA support.

I think overall it LGTM.

Fri, Jul 17, 2:17 PM · Restricted Project, Restricted Project, Restricted Project

Thu, Jul 16

amyk committed rGc2735635523d: [PowerPC][Power10] Add 128-bit Binary Integer Operation instruction definitions… (authored by Conanap).
[PowerPC][Power10] Add 128-bit Binary Integer Operation instruction definitions…
Thu, Jul 16, 3:17 PM
amyk closed D83516: [PowerPC][Power10] 128-bit Binary Integer Operation instruction definitions and MC Tests.
Thu, Jul 16, 3:17 PM · Restricted Project, Restricted Project, Restricted Project
amyk updated the summary of D82576: [PowerPC][Power10] Implement low-order Vector Modulus Builtins, and add Vector Multiply/Divide/Modulus Builtins Tests.
Thu, Jul 16, 8:56 AM · Restricted Project, Restricted Project, Restricted Project
amyk requested changes to D83955: [PowerPC][Power10] Implementation of 128-bit Binary Vector Multiply builtins.
Thu, Jul 16, 8:41 AM · Restricted Project, Restricted Project, Restricted Project
amyk added inline comments to D82576: [PowerPC][Power10] Implement low-order Vector Modulus Builtins, and add Vector Multiply/Divide/Modulus Builtins Tests.
Thu, Jul 16, 8:14 AM · Restricted Project, Restricted Project, Restricted Project

Wed, Jul 15

amyk committed rGfc5530862870: [PowerPC][Power10] Fix VINS* (vector insert byte/half/word) instructions to… (authored by amyk).
[PowerPC][Power10] Fix VINS* (vector insert byte/half/word) instructions to…
Wed, Jul 15, 10:31 PM
amyk closed D83497: [PowerPC][Power10] Fix VINS* (vector insert byte/half/word) instructions to have i32 arguments..
Wed, Jul 15, 10:31 PM · Restricted Project, Restricted Project, Restricted Project
amyk accepted D83516: [PowerPC][Power10] 128-bit Binary Integer Operation instruction definitions and MC Tests.

LGTM.

Wed, Jul 15, 7:31 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Jul 14

amyk updated the diff for D83500: [PowerPC][Power10] Implement custom codegen for the vec_replace_elt and vec_replace_unaligned builtins..

Corrected the patch as it previously caused errors to the clang test case.

Tue, Jul 14, 4:39 PM · Restricted Project, Restricted Project, Restricted Project
amyk updated the summary of D83497: [PowerPC][Power10] Fix VINS* (vector insert byte/half/word) instructions to have i32 arguments..
Tue, Jul 14, 4:37 PM · Restricted Project, Restricted Project, Restricted Project
amyk added inline comments to D83338: [PowerPC][Power10] Implemented Vector Shift Builtins.
Tue, Jul 14, 11:19 AM · Restricted Project, Restricted Project, Restricted Project
amyk added a comment to D82502: [PowerPC] Implement Load VSX Vector and Sign Extend and Zero Extend.

I think the patterns for the load instructions may have accidentally been deleted. Please add them back to the patch. Thank you.

Tue, Jul 14, 11:10 AM · Restricted Project, Restricted Project, Restricted Project
amyk added inline comments to D83338: [PowerPC][Power10] Implemented Vector Shift Builtins.
Tue, Jul 14, 11:04 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Jul 13

amyk committed rG62f5ba624bfb: [PowerPC][Power10] Implement Test LSB by Byte Builtins in LLVM/Clang (authored by amyk).
[PowerPC][Power10] Implement Test LSB by Byte Builtins in LLVM/Clang
Mon, Jul 13, 8:48 PM
amyk closed D82431: [PowerPC][Power10] Implement Test LSB by Byte Builtins in LLVM/Clang.
Mon, Jul 13, 8:48 PM · Restricted Project, Restricted Project, Restricted Project
amyk created D83724: [PowerPC][Power10] Add Vector Extract/Expand/Count with Mask, Move to VSR Mask Instruction Definitions and MC Tests.
Mon, Jul 13, 3:00 PM · Restricted Project, Restricted Project

Sat, Jul 11

amyk added a comment to rG0f0c5af3db9b: [COFF] Add cg_profile directive and .llvm.call-graph-profile section.

Hi!
This patch appears to be causing failures on the following PowerPC (big endian) buildbots:
http://lab.llvm.org:8011/builders/clang-ppc64be-linux-lnt
http://lab.llvm.org:8011/builders/clang-ppc64be-linux-multistage
http://lab.llvm.org:8011/builders/clang-ppc64be-linux

Sat, Jul 11, 5:04 PM

Fri, Jul 10

amyk updated the diff for D83497: [PowerPC][Power10] Fix VINS* (vector insert byte/half/word) instructions to have i32 arguments..

Updated revision to fix vector insert byte/half/word versions to have an i32 argument.

Fri, Jul 10, 3:09 PM · Restricted Project, Restricted Project, Restricted Project
amyk added a comment to rGadd59ecb34e3: Re-land [CodeView] Add full repro to LF_BUILDINFO record.

Hi,
It appears this this patch is causing failures on the PowerPC buildbots:
http://lab.llvm.org:8011/builders/clang-ppc64le-rhel
http://lab.llvm.org:8011/builders/clang-ppc64le-linux
http://lab.llvm.org:8011/builders/clang-ppc64be-linux
http://lab.llvm.org:8011/builders/clang-ppc64le-linux-lnt
http://lab.llvm.org:8011/builders/clang-ppc64be-linux-multistage
http://lab.llvm.org:8011/builders/clang-ppc64be-linux-lnt

Fri, Jul 10, 3:04 PM
amyk added a comment to rG5ab446cfe550: [compiler-rt] [test] Use the parent process env as base env in tests.

Hi!
I believe this patch is causing sanitizer failures for PowerPC on the following buildbots:
http://lab.llvm.org:8011/builders/clang-ppc64le-linux
http://lab.llvm.org:8011/builders/clang-ppc64be-linux
http://lab.llvm.org:8011/builders/clang-ppc64le-linux-multistage
http://lab.llvm.org:8011/builders/clang-ppc64le-linux-lnt
http://lab.llvm.org:8011/builders/clang-ppc64be-linux-multistage
http://lab.llvm.org:8011/builders/clang-ppc64be-linux-lnt

Fri, Jul 10, 9:28 AM
amyk added a comment to D82502: [PowerPC] Implement Load VSX Vector and Sign Extend and Zero Extend.

Please update this patch to remove the instruction defs and MC tests. Also, you can update the patch to put your backend llc tests in the file I've introduced in: https://reviews.llvm.org/D82467

Fri, Jul 10, 8:39 AM · Restricted Project, Restricted Project, Restricted Project
amyk added inline comments to D83497: [PowerPC][Power10] Fix VINS* (vector insert byte/half/word) instructions to have i32 arguments..
Fri, Jul 10, 7:26 AM · Restricted Project, Restricted Project, Restricted Project

Thu, Jul 9

amyk updated the diff for D82467: [PowerPC][Power10] Implement Truncate and Store VSX Vector Builtins.

Rebased patch, and addressed review comments of having a single CHECK.

Thu, Jul 9, 5:18 PM · Restricted Project, Restricted Project, Restricted Project
amyk requested changes to D83338: [PowerPC][Power10] Implemented Vector Shift Builtins.

This will need to be rebased against your 2608 instruction definitions patch.
But yes, I believe you are missing the clang and llc test case for this patch. Requesting changes due to missing tests.

Thu, Jul 9, 3:43 PM · Restricted Project, Restricted Project, Restricted Project
amyk updated the diff for D83500: [PowerPC][Power10] Implement custom codegen for the vec_replace_elt and vec_replace_unaligned builtins..

Fix assignment of variable.

Thu, Jul 9, 3:27 PM · Restricted Project, Restricted Project, Restricted Project
amyk committed rG5ffec4672028: [PowerPC][Power10] Add Instruction definition/MC Tests for Load/Store Rightmost… (authored by Conanap).
[PowerPC][Power10] Add Instruction definition/MC Tests for Load/Store Rightmost…
Thu, Jul 9, 3:06 PM
amyk closed D83364: [PowerPC][Power10] Implement Instruction definition and MC Tests for Load and Store VSX Vector with Zero or Sign Extend.
Thu, Jul 9, 3:06 PM · Restricted Project, Restricted Project, Restricted Project
amyk updated the diff for D83500: [PowerPC][Power10] Implement custom codegen for the vec_replace_elt and vec_replace_unaligned builtins..

Address review comments

  • update comments
  • pull out common code
Thu, Jul 9, 2:42 PM · Restricted Project, Restricted Project, Restricted Project
amyk added inline comments to D83500: [PowerPC][Power10] Implement custom codegen for the vec_replace_elt and vec_replace_unaligned builtins..
Thu, Jul 9, 2:41 PM · Restricted Project, Restricted Project, Restricted Project
amyk updated the summary of D83497: [PowerPC][Power10] Fix VINS* (vector insert byte/half/word) instructions to have i32 arguments..
Thu, Jul 9, 12:47 PM · Restricted Project, Restricted Project, Restricted Project
amyk updated the diff for D83500: [PowerPC][Power10] Implement custom codegen for the vec_replace_elt and vec_replace_unaligned builtins..

Updated for clang format changes.

Thu, Jul 9, 12:19 PM · Restricted Project, Restricted Project, Restricted Project
amyk added inline comments to D83500: [PowerPC][Power10] Implement custom codegen for the vec_replace_elt and vec_replace_unaligned builtins..
Thu, Jul 9, 12:03 PM · Restricted Project, Restricted Project, Restricted Project
amyk created D83500: [PowerPC][Power10] Implement custom codegen for the vec_replace_elt and vec_replace_unaligned builtins..
Thu, Jul 9, 11:55 AM · Restricted Project, Restricted Project, Restricted Project
amyk created D83497: [PowerPC][Power10] Fix VINS* (vector insert byte/half/word) instructions to have i32 arguments..
Thu, Jul 9, 11:24 AM · Restricted Project, Restricted Project, Restricted Project

Wed, Jul 8

amyk added a comment to D82510: [PowerPC][Power10] Implement low-order Vector Multiply, Modulus and Divide Instructions.

Will address the comment of adding BE tests on the commit.

Wed, Jul 8, 12:55 PM · Restricted Project, Restricted Project
amyk added inline comments to D82609: [PowerPC] Implement Vector Multiply High/Divide Extended Builtins in LLVM/Clang.
Wed, Jul 8, 12:42 PM · Restricted Project, Restricted Project, Restricted Project
amyk accepted D83364: [PowerPC][Power10] Implement Instruction definition and MC Tests for Load and Store VSX Vector with Zero or Sign Extend.

This LGTM.

Wed, Jul 8, 7:46 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Jul 7

amyk added inline comments to D83308: [Power10] Implement Vector Replace Builtins in LLVM.
Tue, Jul 7, 7:59 AM · Restricted Project

Jul 6 2020

amyk committed rGc13e3e2c2e0c: [PowerPC][Power10] Exploit the xxsplti32dx instruction when lowering… (authored by amyk).
[PowerPC][Power10] Exploit the xxsplti32dx instruction when lowering…
Jul 6 2020, 6:29 PM
amyk closed D83245: [PowerPC][Power10] Exploit the xxsplti32dx instruction when lowering VECTOR_SHUFFLE..
Jul 6 2020, 6:29 PM · Restricted Project
amyk updated the diff for D83245: [PowerPC][Power10] Exploit the xxsplti32dx instruction when lowering VECTOR_SHUFFLE..

Address review comments from Nemanja:

  • update comments, variables
  • consider the case when the splat is smaller than 32-bits (and add associated test case)
Jul 6 2020, 6:24 PM · Restricted Project
amyk updated the diff for D83245: [PowerPC][Power10] Exploit the xxsplti32dx instruction when lowering VECTOR_SHUFFLE..

Addressed comments from Nemanja:

  • various variable changes
  • update comment/documentation
  • corrected the index for the xxsplti32dx instruction for LE/BE
  • Updated the instruction to use u1imm instead of i1imm so the index in assembly can be 0/1, and this allows us the index to be i32 in the pattern.
Jul 6 2020, 3:32 PM · Restricted Project
amyk accepted D82520: [Power10] Implement Vector Splat Immediate Builtins in LLVM/Clang.

Unless Lei and Nemanja have any additional comments, LGTM.

Jul 6 2020, 1:10 PM · Restricted Project, Restricted Project