Page MenuHomePhabricator

amyk (Amy Kwan)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 4 2018, 10:36 AM (132 w, 4 d)

Recent Activity

Tue, Jan 12

amyk requested review of D94498: [PowerPC][NFC] Update atomics patterns to use the refactored load/store implementation.
Tue, Jan 12, 7:58 AM · Restricted Project, Restricted Project

Thu, Jan 7

amyk added a comment to D93370: [PowerPC] Add new infrastructure to select load/store instructions, update P8/P9 load/store patterns..

Removed the addition of isIntS32Immediate() - it is no longer needed after addressing the comment of using APInt.

Thu, Jan 7, 6:28 AM · Restricted Project, Restricted Project
amyk updated the diff for D93370: [PowerPC] Add new infrastructure to select load/store instructions, update P8/P9 load/store patterns..
  • Updated names of the selection functions in the td patterns
  • Address the comment of using APInt when computing address flags
  • Removed NFC from the title as there is one test case update that we expect a DSForm in (instead of an XForm instruction)
Thu, Jan 7, 6:26 AM · Restricted Project, Restricted Project

Wed, Jan 6

amyk added a comment to D92879: [PowerPC] Materialize 34 bit constants with pli on Power 10..

Thanks for updating. I just noticed one more minor nit.

Wed, Jan 6, 1:27 PM · Restricted Project

Mon, Jan 4

amyk abandoned D51750: Simply specific sequences involving XXSPLTW (ld->permute->splat, ld->splat).
Mon, Jan 4, 9:53 AM · Restricted Project

Dec 17 2020

amyk accepted D89195: [PowerPC][Power10] Exploit store rightmost vector element instructions..

LGTM. Thanks for the update Albion.

Dec 17 2020, 1:28 PM · Restricted Project, Restricted Project
amyk accepted D92879: [PowerPC] Materialize 34 bit constants with pli on Power 10..

I just have a minor nit, but overall it looks good to me.

Dec 17 2020, 7:46 AM · Restricted Project
amyk retitled D93370: [PowerPC] Add new infrastructure to select load/store instructions, update P8/P9 load/store patterns. from [PowerPC] Add new infrastructure to select load/store instructions, update P8/P9 load/store patterns. to [PowerPC][NFC] Add new infrastructure to select load/store instructions, update P8/P9 load/store patterns..
Dec 17 2020, 7:04 AM · Restricted Project, Restricted Project
amyk accepted D90349: [DAGCombiner] Improve shift by select of constant.

I'm really sorry for the delay. LGTM to me, as well.

Dec 17 2020, 6:49 AM · Restricted Project

Dec 16 2020

amyk added inline comments to D93370: [PowerPC] Add new infrastructure to select load/store instructions, update P8/P9 load/store patterns..
Dec 16 2020, 5:26 PM · Restricted Project, Restricted Project
amyk updated the summary of D93370: [PowerPC] Add new infrastructure to select load/store instructions, update P8/P9 load/store patterns..
Dec 16 2020, 5:17 PM · Restricted Project, Restricted Project
amyk added a comment to D93370: [PowerPC] Add new infrastructure to select load/store instructions, update P8/P9 load/store patterns..

I think it is better to explicitly give some reasons why we need this big refactoring, in other words, what's the disadvantage/limitation of legacy implementation? Thank you for the big effort.

Dec 16 2020, 5:14 PM · Restricted Project, Restricted Project
amyk updated the diff for D93370: [PowerPC] Add new infrastructure to select load/store instructions, update P8/P9 load/store patterns..

Add more comments to functions, make provablyDisjointOr() static, fix pattern in PPCInstr64Bit.td.

Dec 16 2020, 5:01 PM · Restricted Project, Restricted Project
amyk added a comment to D93370: [PowerPC] Add new infrastructure to select load/store instructions, update P8/P9 load/store patterns..

@steven.zhang The idea is that this patch should be NFC. All existing load/store test cases should pass with this refactoring. I do think there should be more tests added, perhaps in a follow up patch. What do you think?

Dec 16 2020, 10:32 AM · Restricted Project, Restricted Project

Dec 15 2020

amyk requested review of D93370: [PowerPC] Add new infrastructure to select load/store instructions, update P8/P9 load/store patterns..
Dec 15 2020, 10:37 PM · Restricted Project, Restricted Project
amyk requested changes to D89195: [PowerPC][Power10] Exploit store rightmost vector element instructions..

Please address the comments regarding the test cases.

Dec 15 2020, 1:40 PM · Restricted Project, Restricted Project

Dec 4 2020

amyk accepted D91974: [PowerPC] Rename the vector pair intrinsics and builtins to replace the _mma_ prefix by _vsx_.

Just a minor comment but LGTM overall.

Dec 4 2020, 2:49 PM · Restricted Project, Restricted Project, Restricted Project
amyk added inline comments to D91819: [PowerPC] Enable paired vector type and intrinsics when MMA is disabled.
Dec 4 2020, 2:47 PM · Restricted Project, Restricted Project, Restricted Project

Dec 3 2020

amyk added inline comments to D91983: [PowerPC] Fix missing nop after call to weak callee..
Dec 3 2020, 7:49 AM · Restricted Project
amyk added inline comments to D90173: [PowerPC] Exploit splat instruction xxsplti32dx in Power10.
Dec 3 2020, 7:32 AM · Restricted Project, Restricted Project, Restricted Project

Nov 12 2020

amyk added inline comments to D91391: [PowerPC] Fix for excessive ACC copies due to PHI nodes.
Nov 12 2020, 3:43 PM · Restricted Project
amyk accepted D91323: [PowerPC] Add support for intrinsics dcbfps and dcbstps in P10..

This LGTM.

Nov 12 2020, 3:29 PM · Restricted Project
amyk accepted D90498: Fix the compilation assertion due to unreachable BB pruning not deleting the associated BB from the jump tables.

Minor nit but LGTM

Nov 12 2020, 2:42 PM · Restricted Project
amyk accepted D91200: [PowerPC] Prevent the use of MMA with P9 and earlier.

Overall LGTM.

Nov 12 2020, 7:05 AM · Restricted Project, Restricted Project

Nov 11 2020

amyk added a comment to D91279: [PowerPC] DForm instructions should be preferred when using zero register.

Please also address the clang-format comment.

Nov 11 2020, 3:22 PM · Restricted Project, Restricted Project, Restricted Project

Nov 10 2020

amyk accepted D90616: [PowerPC] Accumulator/Unprimed Accumulator register copy, spill and restore.

Aside from the clang-format, LGTM.

Nov 10 2020, 8:40 AM · Restricted Project
amyk accepted D90799: [PowerPC] Add paired vector load and store builtins and intrinsics.

Thanks for fixing for tests and formatting. LGTM if there are no other concerns.

Nov 10 2020, 7:02 AM · Restricted Project, Restricted Project, Restricted Project

Nov 4 2020

amyk accepted D82035: [PowerPC] Add Sema checks for MMA types.

Overall LGTM, thanks for addressing comments Baptiste!

Nov 4 2020, 11:57 AM · Restricted Project, Restricted Project

Nov 2 2020

amyk accepted D81748: [PowerPC] Add MMA builtin decoding and definitions.

Thanks Baptiste. LGTM.

Nov 2 2020, 9:41 AM · Restricted Project, Restricted Project
amyk added inline comments to D82035: [PowerPC] Add Sema checks for MMA types.
Nov 2 2020, 9:39 AM · Restricted Project, Restricted Project

Oct 28 2020

amyk added inline comments to D82035: [PowerPC] Add Sema checks for MMA types.
Oct 28 2020, 10:27 AM · Restricted Project, Restricted Project
amyk added inline comments to D81748: [PowerPC] Add MMA builtin decoding and definitions.
Oct 28 2020, 10:01 AM · Restricted Project, Restricted Project

Oct 27 2020

amyk accepted D81508: [PowerPC] Add __vector_pair and __vector_quad types.

Aside from the clang-format issues and as long as no one has any other concerns, this LGTM.

Oct 27 2020, 10:06 AM · Restricted Project, Restricted Project, Restricted Project
amyk added inline comments to D90173: [PowerPC] Exploit splat instruction xxsplti32dx in Power10.
Oct 27 2020, 9:47 AM · Restricted Project, Restricted Project, Restricted Project

Oct 26 2020

amyk committed rG803cc3aff2ce: [PowerPC] Implement Set Boolean Condition Instructions (authored by amyk).
[PowerPC] Implement Set Boolean Condition Instructions
Oct 26 2020, 4:43 PM
amyk closed D87705: [PowerPC] Implement Set Boolean Condition Instructions.
Oct 26 2020, 4:43 PM · Restricted Project, Restricted Project

Oct 23 2020

amyk accepted D89345: [PowerPC] Add intrinsics for MMA.

Also LGTM.

Oct 23 2020, 10:01 AM · Restricted Project, Restricted Project
amyk accepted D90041: [AIX][cmake] Adjust management of `-G` for linking.

Thanks for investigating this Hubert. Overall makes sense and LGTM, as long as there are no other concerns from anyone else.

Oct 23 2020, 9:35 AM · Restricted Project

Oct 22 2020

amyk updated the diff for D87705: [PowerPC] Implement Set Boolean Condition Instructions.

Address the following review comments:

  • indentation
  • updated RUN and CHECK lines
Oct 22 2020, 6:18 PM · Restricted Project, Restricted Project
amyk added inline comments to D87705: [PowerPC] Implement Set Boolean Condition Instructions.
Oct 22 2020, 4:45 PM · Restricted Project, Restricted Project

Oct 20 2020

amyk added a comment to D80485: [DAGCombiner][PowerPC] Remove isMulhCheaperThanMulShift TLI hook. Use isOperationLegalOrCustom directly instead..

Hi! This commit causes problems for AMDGPU backend - see attached file

. Any ideas before I start investigating this in detail?

LLVM ERROR: Cannot select: t56: i16 = mulhs t42, Constant:i16<-32509>

t42: i16 = truncate t67
  t67: i32 = add t66, t28
    t66: i32 = add t37, t34
      t37: i32 = shl nuw nsw t12, Constant:i32<13>
        t12: i32,ch = CopyFromReg t0, Register:i32 %5
          t11: i32 = Register %5
        t36: i32 = Constant<13>
      t34: i32 = shl nuw nsw t10, Constant:i32<7>
        t10: i32,ch = CopyFromReg t0, Register:i32 %4
          t9: i32 = Register %4
        t26: i32 = Constant<7>
    t28: i32 = add t16, t27
      t16: i32,ch = CopyFromReg t0, Register:i32 %7
        t15: i32 = Register %7
      t27: i32 = shl t8, Constant:i32<7>
        t8: i32,ch = CopyFromReg t0, Register:i32 %3
          t7: i32 = Register %3
        t26: i32 = Constant<7>
t52: i16 = Constant<-32509>
Oct 20 2020, 10:14 AM · Restricted Project
amyk added a comment to D89727: [PowerPC] Fix the Predicates for enabling pcrelative-memops and PLXVP/PSTXVP definitions .

Agreed that a test should be added.

Oct 20 2020, 12:07 AM · Restricted Project

Oct 19 2020

amyk accepted D89727: [PowerPC] Fix the Predicates for enabling pcrelative-memops and PLXVP/PSTXVP definitions .

I think it overall LGTM.

Oct 19 2020, 4:59 PM · Restricted Project
amyk committed rG6a946fd06fa0: [DAGCombiner][PowerPC] Remove isMulhCheaperThanMulShift TLI hook, Use… (authored by amyk).
[DAGCombiner][PowerPC] Remove isMulhCheaperThanMulShift TLI hook, Use…
Oct 19 2020, 10:24 AM
amyk closed D80485: [DAGCombiner][PowerPC] Remove isMulhCheaperThanMulShift TLI hook. Use isOperationLegalOrCustom directly instead..
Oct 19 2020, 10:23 AM · Restricted Project

Oct 15 2020

amyk added a comment to D80485: [DAGCombiner][PowerPC] Remove isMulhCheaperThanMulShift TLI hook. Use isOperationLegalOrCustom directly instead..

Thanks @dmgreen and @craig.topper for reviewing. :-)
I will fix the indentation in DAGCombiner on the commit, if that's okay.

Oct 15 2020, 8:56 AM · Restricted Project

Oct 13 2020

amyk updated the diff for D80485: [DAGCombiner][PowerPC] Remove isMulhCheaperThanMulShift TLI hook. Use isOperationLegalOrCustom directly instead..
  • Update the patch with the latest master.
  • Remove isMulhCheaperThanMulShift TLI Hook from all code segments.
  • Update test/CodeGen/X86/pmulh.ll.
Oct 13 2020, 10:40 AM · Restricted Project
amyk commandeered D80485: [DAGCombiner][PowerPC] Remove isMulhCheaperThanMulShift TLI hook. Use isOperationLegalOrCustom directly instead..
Oct 13 2020, 9:17 AM · Restricted Project

Oct 1 2020

amyk added inline comments to D88538: [PowerPC] Materialize the immediate that is Uint32 but not Int32..
Oct 1 2020, 3:34 PM · Restricted Project
amyk accepted D88278: [PowerPC] Add builtins for xvtdiv(dp|sp) and xvtsqrt(dp|sp)..

Overall I think this LGTM.

Oct 1 2020, 10:25 AM · Restricted Project, Restricted Project

Sep 30 2020

amyk added a comment to D80485: [DAGCombiner][PowerPC] Remove isMulhCheaperThanMulShift TLI hook. Use isOperationLegalOrCustom directly instead..

So, my goal was to introduce a DAG combine to combine multiply+shifts into mulh. This is done in a function I introduced within DAGCombiner.cpp (called combineShiftToMULH).

Since I was implementing something that is in target independent code, I thought it may be better to enable it on PowerPC only first since I was not quite sure if other targets were interested it this and I was seeing many other LIT failures at the time.
Thus, I introduced the hook (isMulhCheaperThanMulShift) and targets who wish to combine multiply+shifts into mulh could implement that hook. Within combineShiftToMULH, there is a check to isMulhCheaperThanMulShift.

If we wanted to enable this for everyone, I think the check isOperationLegalOrCustom would probably be sufficient. I just tried this patch again, and made the following changes for combineShiftToMULH:

@@ -8099,12 +8101,6 @@ static SDValue combineShiftToMULH(SDNode *N, SelectionDAG &DAG,
   if (NarrowVT !=  RightOp.getOperand(0).getValueType())
     return SDValue();

-  // Only transform into mulh if mulh for the narrow type is cheaper than
-  // a multiply followed by a shift. This should also check if mulh is
-  // legal for NarrowVT on the target.
-  if (!TLI.isMulhCheaperThanMulShift(NarrowVT))
-      return SDValue();
-
   // Proceed with the transformation if the wide type is twice as large
   // as the narrow type.
   unsigned NarrowVTSize = NarrowVT.getScalarSizeInBits();
@@ -8122,6 +8118,12 @@ static SDValue combineShiftToMULH(SDNode *N, SelectionDAG &DAG,
   // we use mulhs. Othewise, zero extends (zext) use mulhu.
   unsigned MulhOpcode = IsSignExt ? ISD::MULHS : ISD::MULHU;

+  // Only transform into mulh if mulh for the narrow type is cheaper than
+  // a multiply followed by a shift. This should also check if mulh is
+  // legal for NarrowVT on the target.
+  if (!TLI.isOperationLegalOrCustom(MulhOpcode, NarrowVT))
+      return SDValue();
+
   SDValue Result = DAG.getNode(MulhOpcode, DL, NarrowVT, LeftOp.getOperand(0),
                                RightOp.getOperand(0));
   return (N->getOpcode() == ISD::SRA ? DAG.getSExtOrTrunc(Result, DL, WideVT1)

I only see one LIT failure now:

Failed Tests (1):
  LLVM :: CodeGen/X86/pmulh.ll

Would this now be enabled on PPC32 or whatever !PPC64 is called? Are there tests for that?

Sep 30 2020, 2:52 PM · Restricted Project

Sep 29 2020

amyk accepted D88043: [PowerPC] Add outer product instructions for MMA.

LGTM.

Sep 29 2020, 1:57 PM · Restricted Project

Sep 26 2020

amyk committed rG6f24774fc4e2: [NFC][PowerPC] Change PPCSubTarget (introduced from D87671) to Subtarget (authored by amyk).
[NFC][PowerPC] Change PPCSubTarget (introduced from D87671) to Subtarget
Sep 26 2020, 3:54 PM

Sep 24 2020

amyk added a comment to D80485: [DAGCombiner][PowerPC] Remove isMulhCheaperThanMulShift TLI hook. Use isOperationLegalOrCustom directly instead..

So, my goal was to introduce a DAG combine to combine multiply+shifts into mulh. This is done in a function I introduced within DAGCombiner.cpp (called combineShiftToMULH).

Sep 24 2020, 3:47 PM · Restricted Project

Sep 23 2020

amyk committed rG6b136b19cbe4: [Power10] Implement custom codegen for the vec_replace_elt and… (authored by amyk).
[Power10] Implement custom codegen for the vec_replace_elt and…
Sep 23 2020, 8:56 PM
amyk closed D83500: [PowerPC][Power10] Implement custom codegen for the vec_replace_elt and vec_replace_unaligned builtins..
Sep 23 2020, 8:55 PM · Restricted Project, Restricted Project, Restricted Project
amyk updated the diff for D83500: [PowerPC][Power10] Implement custom codegen for the vec_replace_elt and vec_replace_unaligned builtins..
  • Updated the isEltOfVectorTy() to the correct semantics; making it take in a vector type and then getting the element type within the function.
Sep 23 2020, 9:56 AM · Restricted Project, Restricted Project, Restricted Project

Sep 22 2020

amyk added inline comments to D87721: [PowerPC][PCRelative] Thread Local Storage Support for Local Dynamic.
Sep 22 2020, 4:41 PM · Restricted Project
amyk added inline comments to D88043: [PowerPC] Add outer product instructions for MMA.
Sep 22 2020, 4:35 PM · Restricted Project
amyk committed rG079757b551f3: [PowerPC] Implement Vector String Isolate Builtins in Clang/LLVM (authored by amyk).
[PowerPC] Implement Vector String Isolate Builtins in Clang/LLVM
Sep 22 2020, 9:32 AM
amyk committed rGb3147058dec7: [PowerPC] Implement the 128-bit Vector Divide Extended Builtins in Clang/LLVM (authored by amyk).
[PowerPC] Implement the 128-bit Vector Divide Extended Builtins in Clang/LLVM
Sep 22 2020, 9:32 AM
amyk closed D87671: [PowerPC] Implement Vector String Isolate Builtins in Clang/LLVM.
Sep 22 2020, 9:32 AM · Restricted Project, Restricted Project, Restricted Project
amyk closed D87729: [PowerPC] Implement the 128-bit Vector Divide Extended Builtins in Clang/LLVM.
Sep 22 2020, 9:32 AM · Restricted Project, Restricted Project, Restricted Project
amyk added a comment to D87705: [PowerPC] Implement Set Boolean Condition Instructions.

Ping.

Sep 22 2020, 9:16 AM · Restricted Project, Restricted Project
amyk added a comment to D83500: [PowerPC][Power10] Implement custom codegen for the vec_replace_elt and vec_replace_unaligned builtins..

@nemanjai Would you please take another look to see if I have addressed your comments when you get a chance? Thanks.

Sep 22 2020, 8:00 AM · Restricted Project, Restricted Project, Restricted Project

Sep 21 2020

amyk updated the diff for D83500: [PowerPC][Power10] Implement custom codegen for the vec_replace_elt and vec_replace_unaligned builtins..

Address Nemanja's review comments:

  • More specific comments when bitcasting the inputs
  • Pull out conditions to bitcast the input, use ternary op depending if the input is 32 or 64-bits
  • Create new static function to check if a given type is the same type as a vector element
Sep 21 2020, 7:10 PM · Restricted Project, Restricted Project, Restricted Project
amyk updated the diff for D87910: [PowerPC] Implement the 128-bit vec_[all|any]_[eq | ne | lt | gt | le | ge] builtins in Clang/LLVM.

Updated identation/formatting of code in CGExprScalar.cpp and altivec.h.

Sep 21 2020, 7:13 AM · Restricted Project, Restricted Project, Restricted Project
amyk accepted D87394: [PowerPC][Power10] Implementation of 128-bit Binary Vector Mod and Sign Extend builtins.

Thanks for open coding. Aside from Nemanja's nits, I believe all my concerns have been addressed. LGTM.

Sep 21 2020, 6:56 AM · Restricted Project, Restricted Project, Restricted Project

Sep 18 2020

amyk committed rG37e7673c21af: [PowerPC] Implement Move to VSR Mask builtins in LLVM/Clang (authored by amyk).
[PowerPC] Implement Move to VSR Mask builtins in LLVM/Clang
Sep 18 2020, 4:16 PM
amyk closed D82725: [PowerPC] Implement Move to VSR Mask builtins in LLVM/Clang.
Sep 18 2020, 4:16 PM · Restricted Project, Restricted Project, Restricted Project
amyk added inline comments to D84968: [PowerPC] Legalize v256i1 and v512i1 and implement load and store of these types.
Sep 18 2020, 1:58 PM · Restricted Project, Restricted Project, Restricted Project
amyk accepted D84359: [PowerPC] Add vector pair load/store instructions and vector pair register class.

Aside from the clang-format issues that can be addressed on commit this looks good to me.

Sep 18 2020, 1:51 PM · Restricted Project, Restricted Project
amyk accepted D84847: [PowerPC] Add accumulator register class and instructions.

Overall LGTM as well.

Sep 18 2020, 11:38 AM · Restricted Project, Restricted Project
amyk accepted D87804: [PowerPC][Power10] Implement Vector signed/unsigned __int128 overloads for the comparison builtins.

Forgot to approve this patch.

Sep 18 2020, 9:45 AM · Restricted Project, Restricted Project, Restricted Project
amyk updated the diff for D87671: [PowerPC] Implement Vector String Isolate Builtins in Clang/LLVM.

Address clang-format concerns.

Sep 18 2020, 9:44 AM · Restricted Project, Restricted Project, Restricted Project
amyk requested review of D87910: [PowerPC] Implement the 128-bit vec_[all|any]_[eq | ne | lt | gt | le | ge] builtins in Clang/LLVM.
Sep 18 2020, 8:53 AM · Restricted Project, Restricted Project, Restricted Project
amyk added a comment to D87804: [PowerPC][Power10] Implement Vector signed/unsigned __int128 overloads for the comparison builtins.

Please address clang-format issues and Lei's comments. Other than that, I think the patch LGTM.

Sep 18 2020, 8:44 AM · Restricted Project, Restricted Project, Restricted Project

Sep 17 2020

amyk committed rG6f3c0991bf9b: [PowerPC] Add Set Boolean Condition Instruction Definitions and MC Tests (authored by amyk).
[PowerPC] Add Set Boolean Condition Instruction Definitions and MC Tests
Sep 17 2020, 4:40 PM
amyk committed rG2c3bc918db35: [PowerPC] Implement Vector Count Mask Bits builtins in LLVM/Clang (authored by amyk).
[PowerPC] Implement Vector Count Mask Bits builtins in LLVM/Clang
Sep 17 2020, 4:40 PM
amyk closed D86252: [PowerPC] Add Set Boolean Condition Instruction Definitions and MC Tests.
Sep 17 2020, 4:40 PM · Restricted Project
amyk closed D82726: [PowerPC] Implement Vector Count Mask Bits builtins in LLVM/Clang.
Sep 17 2020, 4:40 PM · Restricted Project, Restricted Project
amyk updated the diff for D82725: [PowerPC] Implement Move to VSR Mask builtins in LLVM/Clang.
  • Rebased patch.
  • Update patch to remove unnecessary immediate handling.
Sep 17 2020, 3:08 PM · Restricted Project, Restricted Project, Restricted Project
amyk added inline comments to D82725: [PowerPC] Implement Move to VSR Mask builtins in LLVM/Clang.
Sep 17 2020, 3:05 PM · Restricted Project, Restricted Project, Restricted Project
amyk added inline comments to D86819: [PowerPC][Power10] Implementation of 128-bit Binary Vector Rotate builtins.
Sep 17 2020, 2:29 PM · Restricted Project, Restricted Project, Restricted Project

Sep 16 2020

amyk added a comment to D87729: [PowerPC] Implement the 128-bit Vector Divide Extended Builtins in Clang/LLVM.

Looks like there's some unit test failures; could you double check?

Sep 16 2020, 7:20 AM · Restricted Project, Restricted Project, Restricted Project

Sep 15 2020

amyk requested changes to D87394: [PowerPC][Power10] Implementation of 128-bit Binary Vector Mod and Sign Extend builtins.

A question I have is, is it possible for the 128-bit vector modulo instructions be open coded?

Sep 15 2020, 4:40 PM · Restricted Project, Restricted Project, Restricted Project
amyk requested review of D87729: [PowerPC] Implement the 128-bit Vector Divide Extended Builtins in Clang/LLVM.
Sep 15 2020, 4:24 PM · Restricted Project, Restricted Project, Restricted Project
amyk updated the diff for D87705: [PowerPC] Implement Set Boolean Condition Instructions.

Update the run line of crbits.ll test.

Sep 15 2020, 10:28 AM · Restricted Project, Restricted Project
amyk requested review of D87705: [PowerPC] Implement Set Boolean Condition Instructions.
Sep 15 2020, 9:03 AM · Restricted Project, Restricted Project

Sep 14 2020

amyk added inline comments to D87671: [PowerPC] Implement Vector String Isolate Builtins in Clang/LLVM.
Sep 14 2020, 10:45 PM · Restricted Project, Restricted Project, Restricted Project
amyk requested review of D87671: [PowerPC] Implement Vector String Isolate Builtins in Clang/LLVM.
Sep 14 2020, 10:44 PM · Restricted Project, Restricted Project, Restricted Project
amyk added a comment to D83500: [PowerPC][Power10] Implement custom codegen for the vec_replace_elt and vec_replace_unaligned builtins..

@nemanjai Could you please take another look to see if I have addressed your comments?

Sep 14 2020, 7:03 AM · Restricted Project, Restricted Project, Restricted Project

Sep 6 2020

amyk committed rGefa57f9a7adb: [PowerPC] Implement Vector Expand Mask builtins in LLVM/Clang (authored by amyk).
[PowerPC] Implement Vector Expand Mask builtins in LLVM/Clang
Sep 6 2020, 3:14 PM
amyk closed D82727: [PowerPC] Implement Vector Expand Mask builtins in LLVM/Clang.
Sep 6 2020, 3:13 PM · Restricted Project, Restricted Project

Sep 3 2020

amyk added a comment to D86252: [PowerPC] Add Set Boolean Condition Instruction Definitions and MC Tests.

Ping.

Sep 3 2020, 10:18 AM · Restricted Project
amyk added a comment to D82726: [PowerPC] Implement Vector Count Mask Bits builtins in LLVM/Clang.

Ping.

Sep 3 2020, 10:18 AM · Restricted Project, Restricted Project
amyk added a comment to D82725: [PowerPC] Implement Move to VSR Mask builtins in LLVM/Clang.

Ping.

Sep 3 2020, 10:18 AM · Restricted Project, Restricted Project, Restricted Project

Sep 1 2020

amyk committed rG0c2d872d5dec: [PowerPC] Implement builtins for xvcvspbf16 and xvcvbf16spn (authored by amyk).
[PowerPC] Implement builtins for xvcvspbf16 and xvcvbf16spn
Sep 1 2020, 3:19 PM
amyk closed D86795: [PowerPC] Implement builtins for xvcvspbf16 and xvcvbf16spn.
Sep 1 2020, 3:19 PM · Restricted Project, Restricted Project, Restricted Project
amyk committed rGca2227c1b3f5: [PowerPC] Implement instruction definitions/MC Tests for xvcvspbf16 and… (authored by amyk).
[PowerPC] Implement instruction definitions/MC Tests for xvcvspbf16 and…
Sep 1 2020, 9:00 AM