Differential D92023

[MLIR] Fix TableGen generator for attribute interfaces.
ClosedPublic
Actions

Authored by ulysseB on Nov 24 2020, 4:43 AM.

Details

Reviewers

Commits

rG1eded173a91d: [MLIR] Fix TableGen generator for attribute interfaces.

Summary

Use the correct interface base type name when generating attribute interfaces
with TabeGen.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

ulysseB created this revision.Nov 24 2020, 4:43 AM

Herald added a project: Restricted Project. · View Herald TranscriptNov 24 2020, 4:43 AM

Herald added subscribers: teijeong, rdzhabarov, tatianashp and 14 others. · View Herald Transcript

ulysseB requested review of this revision.Nov 24 2020, 4:43 AM

Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald TranscriptNov 24 2020, 4:43 AM

ulysseB added a reviewer: ftynse.Nov 24 2020, 4:44 AM

ftynse accepted this revision.Nov 24 2020, 4:54 AM

This revision is now accepted and ready to land.Nov 24 2020, 4:54 AM

Harbormaster completed remote builds in B79931: Diff 307316.Nov 24 2020, 4:59 AM

Closed by commit rG1eded173a91d: [MLIR] Fix TableGen generator for attribute interfaces. (authored by ulysseB, committed by ftynse). · Explain WhyNov 24 2020, 5:06 AM

This revision was automatically updated to reflect the committed changes.

ftynse added a commit: rG1eded173a91d: [MLIR] Fix TableGen generator for attribute interfaces..

Can you add a test for this in-tree please?

Herald added a subscriber: nimiwio. · View Herald TranscriptNov 24 2020, 12:54 PM

Revision Contents
Changeset List

Path

Size

mlir/

tools/

mlir-tblgen/

OpInterfacesGen.cpp

2 lines

Diff 307318

mlir/tools/mlir-tblgen/OpInterfacesGen.cpp

Loading...