Page MenuHomePhabricator

[PowerPC] Delete remnant Darwin code in PPCAsmParser
ClosedPublic

Authored by MaskRay on Thu, Nov 19, 5:50 PM.

Details

Summary

Continue the work started at D50989.
The code has been long dead since the triple has been removed (D75494).

Diff Detail

Event Timeline

MaskRay created this revision.Thu, Nov 19, 5:50 PM
MaskRay requested review of this revision.Thu, Nov 19, 5:50 PM
MaskRay updated this revision to Diff 306577.Thu, Nov 19, 5:57 PM

Delete unneeded MachO includes and comments

void added inline comments.Thu, Nov 19, 6:21 PM
llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp
2065

Was this intentional?

nickdesaulniers requested changes to this revision.Fri, Nov 20, 12:37 PM
nickdesaulniers added inline comments.
llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp
2065

I agree with @void , we should keep the comment but drop the , in a format that the Darwin assembler can deal with.

This revision now requires changes to proceed.Fri, Nov 20, 12:37 PM
MaskRay added inline comments.Fri, Nov 20, 1:22 PM
llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp
2065

This is intentional. Personally I don't think the comment is of any value. The purpose is obvious from its name.

create*AsmPrinterPass is also in AMDGPUAsmPrinter.cpp, which does not have a comment.

MaskRay added inline comments.Wed, Nov 25, 8:52 AM
llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp
2065

Ping

void accepted this revision.Wed, Nov 25, 4:04 PM
MaskRay added inline comments.Sun, Nov 29, 9:05 PM
llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp
2065
nickdesaulniers accepted this revision.Mon, Nov 30, 10:05 AM
nickdesaulniers added inline comments.
llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp
2065

I would prefer you didn't remove the entire comment but,

"or enter. I'm a sign, not a cop"
https://imgur.com/gallery/mSHi8

This revision is now accepted and ready to land.Mon, Nov 30, 10:05 AM
MaskRay updated this revision to Diff 308413.Mon, Nov 30, 10:13 AM

Keep the comment attached to createPPCAsmprinterPass.
Reword it to conform to the coding standard.
/ -> since static /// is useless.

MaskRay marked 3 inline comments as done.Mon, Nov 30, 10:14 AM
This revision was landed with ongoing or failed builds.Mon, Nov 30, 10:16 AM
This revision was automatically updated to reflect the committed changes.