Page MenuHomePhabricator

[lldb] [test] Un-XFAIL tests on freebsd/i386
ClosedPublic

Authored by mgorny on Tue, Nov 17, 10:08 AM.

Details

Summary

Restrict i386-specific XFAIL on a few tests to non-FreeBSD systems,
as they pass on FreeBSD.

Diff Detail

Event Timeline

mgorny created this revision.Tue, Nov 17, 10:08 AM
mgorny requested review of this revision.Tue, Nov 17, 10:08 AM
emaste added inline comments.Tue, Nov 17, 8:16 PM
lldb/test/API/functionalities/exec/TestExec.py
19–21

Interesting, so FreeBSD is now the only OS where this test passes on i386?

Of course rdar://28656532 is opaque, would be nice if Apple folks can provide some insight on this.

labath accepted this revision.Wed, Nov 18, 1:27 AM

These seems to pass on linux as well (and possibly others too), but I guess nobody runs i386 tests these days...

This revision is now accepted and ready to land.Wed, Nov 18, 1:27 AM
mgorny added inline comments.Wed, Nov 18, 2:37 AM
lldb/test/API/functionalities/exec/TestExec.py
19–21

I suspect others might pass too and this is a Darwin-specific issue but I don't have 32-bit NetBSD install handy at the moment, and LLDB doesn't seem to work at all on Arch Linux 32 for some obscure reason.

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptWed, Nov 18, 3:10 AM
labath added inline comments.Wed, Nov 18, 4:20 AM
lldb/test/API/functionalities/exec/TestExec.py
19–21

I was actually running the test on a 64-bit multilib system. It's possible that a pure 32-bit system behaves differently.

labath added inline comments.Wed, Nov 18, 4:21 AM
lldb/test/API/functionalities/exec/TestExec.py
19–21

(or just a 32-bit build of lldb)

emaste added inline comments.Wed, Nov 18, 7:56 AM
lldb/test/API/functionalities/exec/TestExec.py
19–21

Ah, fair point. I'm not all that interested in FreeBSD/i386 tbh, it just seemed surprising.