Page MenuHomePhabricator

[lldb] [Process/FreeBSDRemote] Access debug registers via offsets
ClosedPublic

Authored by mgorny on Wed, Nov 11, 8:09 AM.

Details

Summary

Use offset-based method to access x86 debug registers. This also
involves adding a test for the correctness of these offsets, and making
GetDR() method of NativeRegisterContextWatchpoint_x86 public to avoid
duplicate code.

Diff Detail

Event Timeline

mgorny created this revision.Wed, Nov 11, 8:09 AM
mgorny updated this revision to Diff 304863.Thu, Nov 12, 9:03 AM

Update following the changes in GPR patch.

mgorny updated this revision to Diff 305089.Fri, Nov 13, 3:50 AM

Rebased.

labath accepted this revision.Fri, Nov 13, 6:21 AM
This revision is now accepted and ready to land.Fri, Nov 13, 6:21 AM
mgorny updated this revision to Diff 305364.Sun, Nov 15, 8:20 AM

Fix native_i386_dbregs on i386.

labath accepted this revision.Mon, Nov 16, 1:06 AM
labath added inline comments.
lldb/source/Plugins/Process/FreeBSDRemote/NativeRegisterContextFreeBSD_x86_64.cpp
699–711

return GetDR(0)->byte_offset?

mgorny added inline comments.Mon, Nov 16, 1:18 AM
lldb/source/Plugins/Process/FreeBSDRemote/NativeRegisterContextFreeBSD_x86_64.cpp
699–711

Is there a point in changing this given that it gets replaced by D91411?

labath added inline comments.Mon, Nov 16, 1:50 AM
lldb/source/Plugins/Process/FreeBSDRemote/NativeRegisterContextFreeBSD_x86_64.cpp
699–711

nah, that's fine

Herald added a project: Restricted Project. · View Herald TranscriptMon, Nov 16, 4:03 AM