[clang-tidy] Install run-clang-tidy.py in bin/ as run-clang-tidy

[Flow]

Summary

The run-clang-tidy.py helper script is supposed to be used by the
user, hence it should be placed in the user's PATH. Some
distributions, like Gentoo [1], won't have it in PATH unless it is
installed in bin/.

Furthermore, installed scripts in PATH usually do not carry a filename
extension, since there is no need to know that this is a Python
script. For example Debian and Ubuntu already install this script as
'run-clang-tidy' [2] and hence build systems like Meson also look for
this name first [3]. Hence we install run-clang-tidy.py as
run-clang-tidy, as suggested by Sylvestre Ledru [4].

1: https://bugs.gentoo.org/753380
2: https://salsa.debian.org/pkg-llvm-team/llvm-toolchain/-/blob/60aefb14171ab5c3867a0081844b507fc9f6e015/debian/clang-tidy-X.Y.links.in#L2
3: https://github.com/mesonbuild/meson/blob/b6dc4d5e5c6e838de0b52e62d982ba2547eb366d/mesonbuild/scripts/clangtidy.py#L44
4: https://reviews.llvm.org/D90972#2380640

[Flow]

Adding involved persons from https://reviews.llvm.org/D12700 as reviewers, which was the change introducing share/clang/ as install location.

[sylvestre.ledru]

FWIW, I am doing this change already in Debian & Ubuntu ( https://salsa.debian.org/pkg-llvm-team/llvm-toolchain/-/blob/10/debian/clang-tidy-X.Y.links.in#L2 )

By the way, while you are working on it, why not removing the python extension when installing? We don't need to know that it is Python code.

[Flow]

In D90972#2380640, @sylvestre.ledru wrote:

By the way, while you are working on it, why not removing the python extension when installing? We don't need to know that it is Python code.

Thanks for the feedback. Please see https://reviews.llvm.org/D91001

[sylvestre.ledru]

Thanks.
Could you please also update the release notes for 12?

And if you are motivated, this script should be documented (or at least mentioned in the doc a bit more)
I only found two references in:
clang-tools-extra/docs/clang-tidy/Contributing.rst

[sylvestre.ledru]

Sounds great. You might want to ask feedback to other reviews too!

[Eugene.Zelenko]

clang-tools-extra/docs/ReleaseNotes.rst

76 ↗

(On Diff #303638)

Please enclose run-clang-tidy.py, bin/, run-clang-tidy and share/clang/ in single back-ticks.

[Flow]

Use backticks in ReleaseNotes

[JonasToth]

LGTM! thanks for fixing.

[Flow]

In D90972#2394516, @JonasToth wrote:

LGTM! thanks for fixing.

I am unable to commit this myself. The latest version of this change can be found in the install-run-clang-tidy-into-bin on my LLVM fork.

[njames93]

In D90972#2446448, @Flow wrote:

In D90972#2394516, @JonasToth wrote:

LGTM! thanks for fixing.

I am unable to commit this myself. The latest version of this change can be found in the install-run-clang-tidy-into-bin on my LLVM fork.

Noticed this is a little stale, Do you still want this landing?

[Flow]

In D90972#2580020, @njames93 wrote:

In D90972#2446448, @Flow wrote:

In D90972#2394516, @JonasToth wrote:

LGTM! thanks for fixing.

I am unable to commit this myself. The latest version of this change can be found in the install-run-clang-tidy-into-bin on my LLVM fork.

Noticed this is a little stale, Do you still want this landing?

This probably was not addressed to me, but yes I want this to land but need someone to sponsor the commit. 😀

clang-tools-extra/clang-tidy/tool/CMakeLists.txt

   DESTINATION share/clang
   COMPONENT clang-tidy)
 install(PROGRAMS run-clang-tidy.py
-  DESTINATION share/clang
+  DESTINATION bin
   COMPONENT clang-tidy)