Page MenuHomePhabricator

Eugene.Zelenko (Eugene Zelenko)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 8 2015, 2:10 PM (305 w, 13 h)

Recent Activity

Fri, Apr 9

Eugene.Zelenko added inline comments to D70094: [clang-tidy] new altera ID dependent backward branch check.
Fri, Apr 9, 10:38 AM · Restricted Project, Restricted Project

Thu, Apr 8

Eugene.Zelenko added inline comments to D100092: [clang-tidy] cppcoreguidelines-declare-loop-variable-in-the-initializer: a new check.
Thu, Apr 8, 7:16 AM · Restricted Project

Tue, Apr 6

Eugene.Zelenko added a comment to D99993: [clang-tidy] bugprone-argument-comment: ignore name mismatches for decls from system headers.

Why --header-filter command line option or HeaderFilterRegex configuration file option could not solve this problem?

Tue, Apr 6, 3:17 PM · Restricted Project, Restricted Project
Eugene.Zelenko retitled D99993: [clang-tidy] bugprone-argument-comment: ignore name mismatches for decls from system headers from bugprone-argument-comment: ignore name mismatches for decls from system headers to [clang-tidy] bugprone-argument-comment: ignore name mismatches for decls from system headers.
Tue, Apr 6, 3:15 PM · Restricted Project, Restricted Project

Mon, Apr 5

Eugene.Zelenko added inline comments to D70094: [clang-tidy] new altera ID dependent backward branch check.
Mon, Apr 5, 7:03 AM · Restricted Project, Restricted Project

Fri, Apr 2

Eugene.Zelenko added inline comments to D70094: [clang-tidy] new altera ID dependent backward branch check.
Fri, Apr 2, 10:36 AM · Restricted Project, Restricted Project

Wed, Mar 31

Eugene.Zelenko added inline comments to D99646: [clang-tidy] misc-avoid-std-io-outside-main: a new check.
Wed, Mar 31, 2:19 PM · Restricted Project
Eugene.Zelenko added a comment to D99646: [clang-tidy] misc-avoid-std-io-outside-main: a new check.

It looks like new patch was not uploaded.

Wed, Mar 31, 2:01 PM · Restricted Project
Eugene.Zelenko added inline comments to D99646: [clang-tidy] misc-avoid-std-io-outside-main: a new check.
Wed, Mar 31, 7:10 AM · Restricted Project

Mon, Mar 29

Eugene.Zelenko added a reviewer for D99503: [clang-format] Fixes for bug 41870.: MyDeveloperDay.
Mon, Mar 29, 7:07 AM · Restricted Project, Restricted Project

Sat, Mar 27

Eugene.Zelenko added a reviewer for D99458: [clang-format] Fix east const pointer alignment of operators: MyDeveloperDay.
Sat, Mar 27, 2:18 PM · Restricted Project, Restricted Project

Sat, Mar 20

Eugene.Zelenko removed a reviewer for D99017: [NFC][Kaleidoscope] Modify a char type typo: Eugene.Zelenko.
Sat, Mar 20, 8:50 AM · Restricted Project

Wed, Mar 17

Eugene.Zelenko added a reviewer for D54943: WIP [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness: njames93.
Wed, Mar 17, 6:46 PM · Restricted Project, Restricted Project

Tue, Mar 16

Eugene.Zelenko added reviewers for D98738: [clang-tidy] performance-* checks: Match AllowedTypes against qualified type names when they contain "::".: alexfh, hokein, njames93.
Tue, Mar 16, 2:36 PM · Restricted Project
Eugene.Zelenko added inline comments to D98635: [libtooling][clang-tidy] Fix diagnostics not respecting and highlighting fed SourceRanges.
Tue, Mar 16, 7:34 AM · Restricted Project, Restricted Project
Eugene.Zelenko edited reviewers for D98692: [clang-tidy] Add cppcoreguidelines-comparison-operator, added: hokein; removed: Eugene.Zelenko.
Tue, Mar 16, 7:29 AM · Restricted Project
Eugene.Zelenko added inline comments to D98692: [clang-tidy] Add cppcoreguidelines-comparison-operator.
Tue, Mar 16, 7:28 AM · Restricted Project

Mar 9 2021

Eugene.Zelenko added a reviewer for D98237: [clang-format] Option for empty lines after an access modifier.: MyDeveloperDay.
Mar 9 2021, 6:17 AM · Restricted Project, Restricted Project

Mar 8 2021

Eugene.Zelenko edited reviewers for D97960: [clang-tidy] bugprone-signal-handler improvements: display call chain, added: hokein; removed: Eugene.Zelenko.
Mar 8 2021, 9:11 AM · Restricted Project, Restricted Project
Eugene.Zelenko added a comment to D97960: [clang-tidy] bugprone-signal-handler improvements: display call chain.

I think call stack may be useful for other checks too. May be code should be moved to utilities?

Mar 8 2021, 9:10 AM · Restricted Project, Restricted Project

Mar 5 2021

Eugene.Zelenko added inline comments to D72235: [clang-tidy] new altera unroll loops check.
Mar 5 2021, 4:41 PM · Restricted Project, Restricted Project
Eugene.Zelenko added reviewers for D98070: [clang-tidy] Add option to ignore macros in readability-function-cognitive-complexity check.: hokein, aaron.ballman, njames93.
Mar 5 2021, 3:29 PM · Restricted Project, Restricted Project

Mar 3 2021

Eugene.Zelenko removed a reviewer for D97874: [analyzer] Improve SVal cast from integer to bool using known RangeSet: Eugene.Zelenko.
Mar 3 2021, 10:24 AM · Restricted Project

Mar 2 2021

Eugene.Zelenko added inline comments to D97753: [clang-tidy] Add a check for enforcing minimum length for variable names.
Mar 2 2021, 7:17 PM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D97753: [clang-tidy] Add a check for enforcing minimum length for variable names.
Mar 2 2021, 6:58 PM · Restricted Project, Restricted Project

Mar 1 2021

Eugene.Zelenko retitled D97753: [clang-tidy] Add a check for enforcing minimum length for variable names from Add a check for enforcing minimum length for variable names to [clang-tidy] Add a check for enforcing minimum length for variable names.
Mar 1 2021, 8:11 PM · Restricted Project, Restricted Project
Eugene.Zelenko edited reviewers for D97753: [clang-tidy] Add a check for enforcing minimum length for variable names, added: alexfh, hokein, njames93; removed: Eugene.Zelenko.
Mar 1 2021, 8:11 PM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D97753: [clang-tidy] Add a check for enforcing minimum length for variable names.
Mar 1 2021, 8:10 PM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D97683: [clang-tidy] Add <utility> include to misc-uniqueptr-reset-release.
Mar 1 2021, 6:47 AM · Restricted Project, Restricted Project

Feb 28 2021

Eugene.Zelenko added a project to D97630: [clang-tidy] Added option to uniqueptr delete release check: Restricted Project.
Feb 28 2021, 8:45 AM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D97630: [clang-tidy] Added option to uniqueptr delete release check.
Feb 28 2021, 8:45 AM · Restricted Project, Restricted Project

Feb 26 2021

Eugene.Zelenko added reviewers for D97577: [clang-tidy] performance-for-range-copy: Don't trigger on implicit type conversions.: hokein, njames93.
Feb 26 2021, 4:15 PM · Restricted Project, Restricted Project
Eugene.Zelenko added reviewers for D97567: [clang-tidy] performance-* checks: Also allow allow member expressions to be used in a const manner.: alexfh, hokein, njames93.
Feb 26 2021, 12:10 PM · Restricted Project, Restricted Project
Eugene.Zelenko added a comment to D97361: [clang-tidy] Add readability-redundant-using check.

You can look into misc/UnusedUsingDeclsCheck.cpp (if not done yet), that check handles using too. And that check is related to this check, the module should be the same too (misc)?

Feb 26 2021, 7:06 AM · Restricted Project, Restricted Project

Feb 25 2021

Eugene.Zelenko added a comment to D97491: [clang-tidy] Deprecate readability-deleted-default check.

If Wdefaulted-function-deleted was introduced in 12.0, I think it's safe just to remove readability-deleted-default.

Wdefaulted-function-deleted was introduced in 8.0 and I think it was enabled by default even then. I'm thinking we may be able to squeeze this notice into the 12 branch and then it will be gone by 13

Feb 25 2021, 4:41 PM · Restricted Project
Eugene.Zelenko added a comment to D97491: [clang-tidy] Deprecate readability-deleted-default check.

If Wdefaulted-function-deleted was introduced in 12.0, I think it's safe just to remove readability-deleted-default.

Feb 25 2021, 2:46 PM · Restricted Project

Feb 24 2021

Eugene.Zelenko added a comment to D97361: [clang-tidy] Add readability-redundant-using check.

I think this check belongs to readability module.

Feb 24 2021, 7:25 AM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D97297: [clang-tidy] Suppress reports to patternedly named parameters in 'bugprone-easily-swappable-parameters'.
Feb 24 2021, 7:19 AM · Restricted Project, Restricted Project

Feb 23 2021

Eugene.Zelenko added a reviewer for D97297: [clang-tidy] Suppress reports to patternedly named parameters in 'bugprone-easily-swappable-parameters': njames93.
Feb 23 2021, 3:54 PM · Restricted Project, Restricted Project
Eugene.Zelenko added a comment to D97297: [clang-tidy] Suppress reports to patternedly named parameters in 'bugprone-easily-swappable-parameters'.

Please mention new option in Release Notes.

Feb 23 2021, 3:53 PM · Restricted Project, Restricted Project

Feb 22 2021

Eugene.Zelenko added reviewers for D97196: [clang-tidy] Add new check 'bugprone-unhandled-exception-at-new'.: alexfh, hokein, aaron.ballman, njames93.
Feb 22 2021, 9:14 AM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D97196: [clang-tidy] Add new check 'bugprone-unhandled-exception-at-new'..
Feb 22 2021, 9:13 AM · Restricted Project, Restricted Project

Feb 15 2021

Eugene.Zelenko added reviewers for D96719: [clang-tidy] Add new check 'concurrency-thread-canceltype-asynchronous' and alias 'cert-pos47-c'.: alexfh, njames93.
Feb 15 2021, 6:07 PM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D96719: [clang-tidy] Add new check 'concurrency-thread-canceltype-asynchronous' and alias 'cert-pos47-c'..
Feb 15 2021, 6:07 PM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D96725: [clang-tidy] Fix modernize-use-using in extern C code.
Feb 15 2021, 2:14 PM · Restricted Project

Feb 12 2021

Eugene.Zelenko added a comment to D96607: [clang-tidy] Add check 'readability-pointer-type-star-placement'..

I think it'll be much more reasonable to use clang-format and filter its output to select only changes with stars in build rule. clang-format-diff is another method to introduce formatting changes gradually.

Feb 12 2021, 3:25 PM · Restricted Project, Restricted Project
Eugene.Zelenko added reviewers for D96607: [clang-tidy] Add check 'readability-pointer-type-star-placement'.: alexfh, hokein, aaron.ballman, njames93.
Feb 12 2021, 3:18 PM · Restricted Project, Restricted Project

Feb 11 2021

Eugene.Zelenko edited reviewers for D96561: [clang-tidy] add -use-color option to clang-tidy-diff.py, added: hokein, aaron.ballman, njames93; removed: Restricted Project.
Feb 11 2021, 5:22 PM · Restricted Project, Restricted Project
Eugene.Zelenko added reviewers for D96542: [clang-tidy] Fix `TransformerClangTidyCheck`'s handling of include insertions.: hokein, aaron.ballman, njames93.
Feb 11 2021, 3:02 PM · Restricted Project, Restricted Project

Feb 5 2021

Eugene.Zelenko added a comment to D96082: [clang-tidy] Add 'readability-useless-return-value' check.

@Eugene.Zelenko Why did you remove me from the reviewers list?

Feb 5 2021, 7:29 AM · Restricted Project, Restricted Project

Feb 4 2021

Eugene.Zelenko edited reviewers for D96082: [clang-tidy] Add 'readability-useless-return-value' check, added: alexfh, hokein, aaron.ballman, njames93; removed: steveire.
Feb 4 2021, 5:19 PM · Restricted Project, Restricted Project
Eugene.Zelenko added a comment to D96082: [clang-tidy] Add 'readability-useless-return-value' check.

New check must be mentioned in Release Notes.

Feb 4 2021, 5:18 PM · Restricted Project, Restricted Project

Feb 2 2021

Eugene.Zelenko removed a reviewer for D95860: [clang][Frontend] Fix a crash in DiagnosticRenderer.: Eugene.Zelenko.
Feb 2 2021, 7:43 AM · Restricted Project

Jan 30 2021

Eugene.Zelenko added reviewers for D95736: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with `typedef` and `const &` diagnostics: alexfh, hokein, njames93.
Jan 30 2021, 8:11 AM · Restricted Project, Restricted Project
Eugene.Zelenko added reviewers for D95714: [clang-tidy] fix modernize-use-nullptr false positive with spaceship operator comparisons: alexfh, njames93.
Jan 30 2021, 8:10 AM · Restricted Project, Restricted Project

Jan 20 2021

Eugene.Zelenko added a comment to D94622: [clang-tidy] add concurrency-async-no-new-threads.

Eugene.Zelenko, njames93, any comments on the patch?

Jan 20 2021, 7:17 AM · Restricted Project, Restricted Project
Eugene.Zelenko added a comment to D94621: [clang-tidy] add concurrency-async-fs.

Eugene.Zelenko, njames93, any comments on the patch?

Jan 20 2021, 7:16 AM · Restricted Project, Restricted Project
Eugene.Zelenko added a comment to D93940: [clang-tidy] Add a check for blocking types and functions..

Eugene.Zelenko, njames93, any comments on the patch?

Jan 20 2021, 7:16 AM · Restricted Project, Restricted Project

Jan 14 2021

Eugene.Zelenko added reviewers for D94621: [clang-tidy] add concurrency-async-fs: alexfh, hokein.
Jan 14 2021, 7:23 AM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D94621: [clang-tidy] add concurrency-async-fs.
Jan 14 2021, 7:22 AM · Restricted Project, Restricted Project
Eugene.Zelenko added reviewers for D94622: [clang-tidy] add concurrency-async-no-new-threads: alexfh, hokein, aaron.ballman.
Jan 14 2021, 7:20 AM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D94622: [clang-tidy] add concurrency-async-no-new-threads.
Jan 14 2021, 7:19 AM · Restricted Project, Restricted Project

Jan 13 2021

Eugene.Zelenko edited reviewers for D94601: [clang-tidy] Use DenseSet<SourceLocation> in UpgradeDurationConversionsCheck, NFCI, added: alexfh, hokein, aaron.ballman, njames93; removed: aprantl, dexonsmith, EricWF.
Jan 13 2021, 7:26 AM · Restricted Project, Restricted Project

Dec 30 2020

Eugene.Zelenko added inline comments to D93940: [clang-tidy] Add a check for blocking types and functions..
Dec 30 2020, 4:41 PM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D93940: [clang-tidy] Add a check for blocking types and functions..
Dec 30 2020, 11:39 AM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D93940: [clang-tidy] Add a check for blocking types and functions..
Dec 30 2020, 7:48 AM · Restricted Project, Restricted Project
Eugene.Zelenko edited reviewers for D93940: [clang-tidy] Add a check for blocking types and functions., added: alexfh, aaron.ballman, hokein; removed: jfb.
Dec 30 2020, 7:40 AM · Restricted Project, Restricted Project

Dec 28 2020

Eugene.Zelenko added inline comments to D93861: [clang-tidy][NFC] Split up some headers.
Dec 28 2020, 11:03 AM · Restricted Project

Dec 13 2020

Eugene.Zelenko added a comment to D93182: [clang-tidy] Add linux kernel log functions checker.

Maybe Clang's -Wformat should be extended to cover Linux kernel-specific format options?

Dec 13 2020, 9:47 PM · Restricted Project, Restricted Project

Dec 9 2020

Eugene.Zelenko added a project to D92992: [clang-tidy] Add make_unique_for_overwrite/make_shared_for_overwrite check.: Restricted Project.
Dec 9 2020, 9:48 PM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D92992: [clang-tidy] Add make_unique_for_overwrite/make_shared_for_overwrite check..
Dec 9 2020, 9:48 PM · Restricted Project, Restricted Project

Dec 8 2020

Eugene.Zelenko added inline comments to D92777: [clang-tidy] Add bugprone-strlen-in-array-index checker.
Dec 8 2020, 6:37 AM

Dec 7 2020

Eugene.Zelenko added inline comments to D92777: [clang-tidy] Add bugprone-strlen-in-array-index checker.
Dec 7 2020, 11:24 AM

Dec 4 2020

Eugene.Zelenko accepted D92652: [clang-tidy][docs] Update check options with boolean values instead of non-zero/0/1.

Looks OK for me.

Dec 4 2020, 7:12 AM · Restricted Project

Nov 26 2020

Eugene.Zelenko added reviewers for D92179: [clang-tidy] Catch more unwanted implicit conversions in performance-implicit-conversion-in-loop: alexfh, hokein, aaron.ballman, njames93.
Nov 26 2020, 7:00 AM · Restricted Project, Restricted Project, Restricted Project
Eugene.Zelenko added a comment to D92179: [clang-tidy] Catch more unwanted implicit conversions in performance-implicit-conversion-in-loop.

Please mention renaming in Release Notes.

Nov 26 2020, 6:59 AM · Restricted Project, Restricted Project, Restricted Project

Nov 23 2020

Eugene.Zelenko edited reviewers for D91949: [clang-format] Add BeforeStructInitialization option in BraceWrapping configuration, added: MyDeveloperDay; removed: Restricted Project.
Nov 23 2020, 6:56 AM · Restricted Project, Restricted Project
Eugene.Zelenko edited reviewers for D91950: [clang-format] Add BreakBeforeInlineASMColon configuration, added: MyDeveloperDay; removed: Restricted Project.
Nov 23 2020, 6:56 AM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D86671: [clang-tidy] Add new case type to check variables with Hungarian notation.
Nov 23 2020, 6:41 AM · Restricted Project, Restricted Project, Restricted Project

Nov 21 2020

Eugene.Zelenko added a comment to D91908: [clang-tidy] Use compiled regex for AllowedRegexp in macro usage check.

Please add test case for new command-line option.

Nov 21 2020, 6:47 AM · Restricted Project, Restricted Project
Eugene.Zelenko added reviewers for D91908: [clang-tidy] Use compiled regex for AllowedRegexp in macro usage check: alexfh, hokein, aaron.ballman, njames93.
Nov 21 2020, 6:47 AM · Restricted Project, Restricted Project

Nov 20 2020

Eugene.Zelenko added reviewers for D91893: [clang-tidy] performance-unnecessary-copy-initialization: Prevent false positives when dependent variable is modified.: alexfh, njames93.
Nov 20 2020, 2:21 PM · Restricted Project, Restricted Project

Nov 19 2020

Eugene.Zelenko added a reviewer for D91789: [clang-tidy] find/fix unneeded trailing semicolons in macros: njames93.
Nov 19 2020, 7:04 AM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D91789: [clang-tidy] find/fix unneeded trailing semicolons in macros.
Nov 19 2020, 7:04 AM · Restricted Project, Restricted Project

Nov 17 2020

Eugene.Zelenko added reviewers for D91656: [clang-tidy] add concurrency module: alexfh, hokein, aaron.ballman.
Nov 17 2020, 3:09 PM · Restricted Project, Restricted Project

Nov 16 2020

Eugene.Zelenko added reviewers for D91543: [clang-tidy] Improving bugprone-sizeof-expr check.: alexfh, hokein, aaron.ballman, njames93.
Nov 16 2020, 9:15 AM · Restricted Project, Restricted Project

Nov 15 2020

Eugene.Zelenko added reviewers for D91495: [clang-tidy] false-positive for bugprone-redundant-branch-condition in case of passed-by-ref params: alexfh, hokein, njames93.
Nov 15 2020, 1:51 PM · Restricted Project, Restricted Project

Nov 9 2020

Eugene.Zelenko added reviewers for D91055: [clang-tidy] Introduce misc No Integer To Pointer Cast check: alexfh, hokein.
Nov 9 2020, 6:36 AM · Restricted Project, Restricted Project, Restricted Project

Nov 8 2020

Eugene.Zelenko added inline comments to D91037: [clang-tidy] Fix crash in bugprone-redundant-branch-condition on ExprWithCleanups.
Nov 8 2020, 4:03 PM · Restricted Project, Restricted Project
Eugene.Zelenko added reviewers for D91037: [clang-tidy] Fix crash in bugprone-redundant-branch-condition on ExprWithCleanups: alexfh, hokein, aaron.ballman, njames93.
Nov 8 2020, 4:02 PM · Restricted Project, Restricted Project

Nov 7 2020

Eugene.Zelenko added reviewers for D91009: [clang-tidy] Include std::basic_string_view in readability-redundant-string-init.: alexfh, hokein, aaron.ballman, njames93.
Nov 7 2020, 5:09 PM · Restricted Project, Restricted Project
Eugene.Zelenko set the repository for D91000: [clang-tidy] CERT MSC24-C Obsolescent Functions check to rG LLVM Github Monorepo.
Nov 7 2020, 7:25 AM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D91000: [clang-tidy] CERT MSC24-C Obsolescent Functions check.
Nov 7 2020, 7:24 AM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D90972: [clang-tidy] Install run-clang-tidy.py in bin/ as run-clang-tidy.
Nov 7 2020, 7:06 AM · Restricted Project, Restricted Project

Nov 5 2020

Eugene.Zelenko added reviewers for D90851: [clang-tidy] Extending bugprone-signal-handler with POSIX functions.: alexfh, hokein, aaron.ballman, njames93.
Nov 5 2020, 7:16 AM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D90851: [clang-tidy] Extending bugprone-signal-handler with POSIX functions..
Nov 5 2020, 7:16 AM · Restricted Project, Restricted Project

Oct 31 2020

Eugene.Zelenko added reviewers for D90535: [clang-tidy] Allow -warnings-as-errors to be specified from run_clang_tidy.py : hokein, aaron.ballman, njames93.
Oct 31 2020, 2:25 PM · Restricted Project, Restricted Project

Oct 30 2020

Eugene.Zelenko added inline comments to D90399: [clang-tidy] non-portable-integer-constant check.
Oct 30 2020, 7:00 AM · Restricted Project, Restricted Project
Eugene.Zelenko removed a reviewer for D90448: [clang] Add type check for explicit instantiation of static data members: Eugene.Zelenko.
Oct 30 2020, 6:51 AM · Restricted Project

Oct 29 2020

Eugene.Zelenko edited reviewers for D90392: [clang-tidy] Omit std::make_unique/make_shared for default initialization., added: alexfh, hokein, aaron.ballman, njames93; removed: EricWF, ymandel.
Oct 29 2020, 6:47 AM · Restricted Project, Restricted Project