User Details
- User Since
- Jul 10 2012, 10:35 AM (444 w, 4 d)
Dec 14 2020
Pre-merge builder can't apply this patch: https://buildkite.com/llvm-project/diff-checks/builds/18651
Is it based on https://reviews.llvm.org/D91302 ? Do we need the intermediate state? Maybe squash the two patches together for simplicity?
Please fix the typo that results in a compile error.
Dec 11 2020
Dec 10 2020
Removed unrelated whitespace changes.
Dec 9 2020
Nov 12 2020
Oct 26 2020
Oct 22 2020
Ah, btw, any chance of adding a test for this?
Looks good!
Oct 15 2020
LG
Oct 14 2020
Thanks for the fix! However, I'm not sure it's possible to correctly rewrite code in all cases where macros are involved. See a couple of motivating examples in the comment.
Oct 13 2020
Oct 12 2020
Sorry for the delay. This patch fell through the cracks. If you're still interested, could you rebase it on top of current HEAD and upload a full diff? Or use the arcanist tool, see https://llvm.org/docs/Phabricator.html.
Looks good!
Feel free to ping patches every week or so. It looks like in this case all the reviewers were swamped with something else at the time.
Looks good! Thanks for the fix! IIUC, this is related to https://bugs.llvm.org/show_bug.cgi?id=34879? Makes sense to specify this in the patch description.
Oct 9 2020
Sep 28 2020
- Updated release notes and default option values in docs
- clang-format
- addressed review comments
Sep 14 2020
Looks good modulo comment.
Aug 10 2020
LG with a couple of comments. Do you need someone to land the patch for you?
Thanks for the patch! Looks generally good. A few comments inline.
Jul 21 2020
Apr 13 2020
Apologies for the delay! It's sort of a crazy time now =\
Apr 12 2020
Mar 19 2020
Mar 12 2020
Mar 5 2020
Mar 4 2020
Internally we have something similar, but with unconditional inheritance and a way to include other configs. I was thinking about implementing this in the FileOptionsProvider, but decided that this would be an overkill for most real projects. Overall the patch looks good to me, but please update the documentation and add a test to ensure that check options get merged correctly.
Mar 3 2020
Mar 2 2020
Feb 27 2020
LG
Next step is to plumb this to clang-tidy.
Feb 24 2020
LG
Feb 21 2020
Do you have commit rights or should someone help you committing the patch?
Feb 19 2020
A few nits.
Feb 18 2020
Thanks for the update!
Feb 1 2020
LG. Thanks for the fix!
Jan 28 2020
Jan 27 2020
A drive-by comment.
How is this different from -Wmissing-prototypes?
Jan 23 2020
LG with an outstanding comment.
Jan 21 2020
Jan 13 2020
LG with a nit, if this works.
Jan 9 2020
Awesome! Thanks for updating the script! A few nits, otherwise LG, if this works.
Jan 8 2020
What version of clang-tidy and clang-format does this run? Whatever is available in Debian packages?
Jan 3 2020
This list used to be automatically updated by the clang-tools-extra/clang-tidy/add_new_check.py script. I suppose, this is broken now?
Dec 12 2019
Dec 10 2019
Dec 6 2019
Dec 5 2019
- Added a test with an empty attribute list.