Page MenuHomePhabricator

[mlir] Remove AppendToArgumentsList functionality from BufferizeTypeConverter.
ClosedPublic

Authored by silvas on Nov 4 2020, 11:00 AM.

Details

Summary

This functionality is superceded by BufferResultsToOutParams pass (see
https://reviews.llvm.org/D90071) for users the require buffers to be
out-params. That pass should be run immediately after all tensors are gone from
the program (before buffer optimizations and deallocation insertion), such as
immediately after a "finalizing" bufferize pass.

The -test-finalizing-bufferize pass now defaults to what used to be the
allowMemrefFunctionResults=true flag. and the
finalizing-bufferize-allowed-memref-results.mlir file is moved
to test/Transforms/finalizing-bufferize.mlir.

Diff Detail

Event Timeline

silvas created this revision.Nov 4 2020, 11:00 AM
silvas requested review of this revision.Nov 4 2020, 11:00 AM
silvas added a reviewer: dfki-albo.
dfki-mako accepted this revision.Nov 5 2020, 1:10 AM
This revision is now accepted and ready to land.Nov 5 2020, 1:10 AM
dfki-albo requested changes to this revision.Nov 5 2020, 2:11 AM
dfki-albo added inline comments.
mlir/test/Transforms/finalizing-bufferize.mlir
15

nit: %arg3: f16 in a new line.

85–86

Check if the return yields the result type.

This revision now requires changes to proceed.Nov 5 2020, 2:11 AM
This revision was not accepted when it landed; it landed in state Needs Revision.Nov 5 2020, 11:22 AM
This revision was automatically updated to reflect the committed changes.
silvas marked an inline comment as done.
silvas marked an inline comment as done.Nov 5 2020, 2:19 PM