Page MenuHomePhabricator

[flang][openacc] Enforce no modifier on enter data and exit data clauses
ClosedPublic

Authored by clementval on Oct 27 2020, 6:51 PM.

Details

Summary

Enter data can have the copyin clause and exit data can have the copyout clause.
Both clauses support modifier with other directive but for these two directives no modifier
are supported. This semantic check enforce this rule.

Diff Detail

Event Timeline

clementval created this revision.Oct 27 2020, 6:51 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 27 2020, 6:51 PM
clementval requested review of this revision.Oct 27 2020, 6:51 PM
kiranktp added inline comments.Oct 27 2020, 11:33 PM
flang/lib/Semantics/check-acc-structure.cpp
128

Possible to rephrase this?
"Modifier is not allowed for the %s clause on the %s directive"

Address review comment

clementval marked an inline comment as done.Oct 28 2020, 6:38 AM
clementval added inline comments.
flang/lib/Semantics/check-acc-structure.cpp
128

Thanks for catching this. Patch has been updated.

kiranktp added inline comments.Oct 28 2020, 8:57 AM
flang/test/Semantics/acc-clause-validity.f90
48–54

I think you forgot to modify the error message here.

clementval marked an inline comment as done.

Fix error message

clementval marked an inline comment as done.Oct 28 2020, 11:07 AM
clementval added inline comments.
flang/test/Semantics/acc-clause-validity.f90
48–54

My bad! Tired to go to fast and of course I missed it :-)

This revision is now accepted and ready to land.Oct 28 2020, 8:21 PM
This revision was automatically updated to reflect the committed changes.
clementval marked an inline comment as done.