Page MenuHomePhabricator

AMDGPU: Fix not always reserving VGPRs used for SGPR spilling
AcceptedPublic

Authored by arsenm on Thu, Oct 15, 4:13 PM.

Details

Reviewers
saiislam
rampitec
Summary

The VGPRs used for SGPR spills need to be reserved, even if we aren't
speculatively reserving one.

This was broken by 117e5609e98b43f925c678b72f816ad3a1c3eee7.

Diff Detail

Event Timeline

arsenm created this revision.Thu, Oct 15, 4:13 PM
Herald added a project: Restricted Project. · View Herald TranscriptThu, Oct 15, 4:13 PM
arsenm requested review of this revision.Thu, Oct 15, 4:13 PM

Any tests?

We apparently don't have any tests turning off the pre-reserved VGPR. With the getReservedRegs change, one test fails due to reserveVGPRforSGPRSpills returning NoRegister

rampitec accepted this revision.Fri, Oct 16, 9:11 AM
This revision is now accepted and ready to land.Fri, Oct 16, 9:11 AM