Page MenuHomePhabricator

[LangRef] Clarify `dereferenceable` -> `nonnull` implication
ClosedPublic

Authored by jdoerfert on Oct 14 2020, 11:57 AM.

Details

Summary

If null_pointer_is_valid is present, dereferenceable does not imply
nonnull, make it clear.

Came up in D17993.

Diff Detail

Unit TestsFailed

TimeTest
280 mswindows > lld.ELF/invalid::symtab-sh-info.s
Script: -- : 'RUN: at line 4'; c:\ws\w32-1\llvm-project\premerge-checks\build\bin\yaml2obj.exe --docnum=1 C:\ws\w32-1\llvm-project\premerge-checks\lld\test\ELF\invalid\symtab-sh-info.s -o C:\ws\w32-1\llvm-project\premerge-checks\build\tools\lld\test\ELF\invalid\Output\symtab-sh-info.s.tmp.o

Event Timeline

jdoerfert created this revision.Oct 14 2020, 11:57 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 14 2020, 11:57 AM
Herald added a subscriber: bollu. · View Herald Transcript
jdoerfert requested review of this revision.Oct 14 2020, 11:57 AM
uenoku added a subscriber: uenoku.Oct 14 2020, 11:59 AM
aqjune accepted this revision.Oct 14 2020, 7:51 PM

As discussed in D17993, it looks fine.

This revision is now accepted and ready to land.Oct 14 2020, 7:51 PM
This revision was landed with ongoing or failed builds.Oct 27 2020, 5:13 PM
This revision was automatically updated to reflect the committed changes.