Page MenuHomePhabricator

nlopes (Nuno Lopes)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 3 2013, 11:31 AM (380 w, 2 d)

Recent Activity

Mon, Jan 11

nlopes added a comment to D94014: [InstCombine] reduce icmp(ashr X, C1), C2 to sign-bit test.

Anyone see problems with this Alive2 implementation using count-leading-*?
https://alive2.llvm.org/ce/z/SWxadd

I also manually entered all of the i4 regression tests with fixed constants in Alive1 (rise4fun), and they appear to be correct as shown in the test diffs.

Mon, Jan 11, 9:05 AM · Restricted Project
nlopes added a comment to D94014: [InstCombine] reduce icmp(ashr X, C1), C2 to sign-bit test.

alive1 does not actually have a countLeadingOnes() precondition

Weird - maybe @nlopes can tell us how this example parses at all then: https://rise4fun.com/Alive/juX1

(at least as per https://github.com/nunoplopes/alive/blob/master/constants.py),

Mon, Jan 11, 8:00 AM · Restricted Project

Sun, Jan 10

nlopes added a comment to D93820: [InstSimplify] Don't fold gep p, -p to null.

Based on what @RalfJung mentioned on zulip, the question of whether the transform is legal for inbounds comes down to the particular choice of inbounds semantics. I was using the semantics specified in LangRef, which make the optimization illegal, while @nlopes used the semantics from https://people.mpi-sws.org/~jung/twinsem/twinsem.pdf (or something similar), which makes it legal. The relevant difference to the LangRef semantics (if we stick to the gep-inbounds-logical case) would be:

- The base pointer has an in bounds address of an allocated object [...]
+ The base pointer has an in bounds address of the allocated object it is based on [...]

In any case, regardless of whether this is legal for the inbounds case, I think everyone agrees it's not legal for the non-inbounds case (and not legal for the non-null case regardless of inbounds). Is that enough to move forward here, or do you want me to thread inbounds information through SimplifyGEPInst and retain this optimization for the inbounds case?

Sun, Jan 10, 7:52 AM · Restricted Project

Thu, Jan 7

nlopes added a comment to D89697: * [x86] Implement smarter instruction lowering for FP_TO_UINT from vXf32 to vXi32 for SSE2 and AVX2 by using the exact semantic of the CVTTPS2SI instruction..

No regression appeared in our internal testcases.
It seems the transform is correct, have you verified it with alive-tv?

I was curious to see if I could model it:
https://alive2.llvm.org/ce/z/RXcYY9

Converting #x4f800000 (4294967296) to uint32_t is poison, not 0 though. Am I reading the Alive output correctly? (cc @lebedev.ri @aqjune @nlopes @nikic )

Thu, Jan 7, 11:18 AM · Restricted Project
nlopes added a comment to D89697: * [x86] Implement smarter instruction lowering for FP_TO_UINT from vXf32 to vXi32 for SSE2 and AVX2 by using the exact semantic of the CVTTPS2SI instruction..

No regression appeared in our internal testcases.
It seems the transform is correct, have you verified it with alive-tv?

I was curious to see if I could model it:
https://alive2.llvm.org/ce/z/RXcYY9

Converting #x4f800000 (4294967296) to uint32_t is poison, not 0 though. Am I reading the Alive output correctly? (cc @lebedev.ri @aqjune @nlopes @nikic )

Thu, Jan 7, 10:43 AM · Restricted Project

Sat, Jan 2

nlopes added a comment to D87188: [InstCombine] Canonicalize SPF to abs intrinc.

Heads up: Breaks a test for us: https://bugs.chromium.org/p/chromium/issues/detail?id=1161542

(No reduced repro yet, might be UB, just fyi at this point.)

Thanks for headsup. For now i'll deal with the problem @nlopes pointed out above in a bit..

Just to follow up, this ended up being UB on our end (fix: https://android-review.googlesource.com/c/platform/external/perfetto/+/1535483)

Sat, Jan 2, 8:51 AM · Restricted Project, Restricted Project

Thu, Dec 31

nlopes added a comment to rGa2513cb8655e: remove pessimizing moves (reported by gcc 10).

I reverted this commit because it was causing problems with clang on several of the buildbots with the general flavor of the following error log:

http://lab.llvm.org:8011/#/builders/21/builds/5863/steps/5/logs/stdio

llvm-project/llvm/include/llvm/ExecutionEngine/Orc/Shared/RPCUtils.h:1519:14: error: call to deleted constructor of 'llvm::Error'
      return Err;
             ^~~

In where the changes were made and:

llvm-project/llvm/include/llvm/ExecutionEngine/Orc/Shared/RPCUtils.h:1232:29: error: no matching member function for call to 'callB'
              Impl.template callB<OrcRPCNegotiate>(Func::getPrototype())) {
Thu, Dec 31, 2:42 PM
nlopes committed rGa2513cb8655e: remove pessimizing moves (reported by gcc 10) (authored by nlopes).
remove pessimizing moves (reported by gcc 10)
Thu, Dec 31, 12:36 PM
nlopes committed rGf760d57052d8: LangRef: fix significand bits of fp128 (authored by nlopes).
LangRef: fix significand bits of fp128
Thu, Dec 31, 3:14 AM

Sat, Dec 26

nlopes added a comment to D93820: [InstSimplify] Don't fold gep p, -p to null.

I only looked at the tests and they were correct before, see here: https://alive2.llvm.org/ce/z/UzW3pv
The tests are weird because they have 'gep inbounds'. The reason they are correct (and weird) is that the only way p - (int)p/sizeof(*p) is inbounds is p being null. Anything else will overflow.

This doesn't look right to me, at least not given current LangRef wording. Lets say we have gep inbounds p, -p, where p = ptr(base_addr = 1, offset = -1). This means that the address value of p is 0, but it has provenance of the object at base_addr = 1. As such, the inbounds is not violated (both p and the gep results are inbounds of the zero address), but we still change provenance.

There's an extra catch: gep inbounds requires both the input and output pointers to be in bounds. This part is explicit in LangRef, at least.
Some examples:

p = malloc()
q = gep inbounds p, -1  // poison
r = gep p, -1           // ok
s = gep inbounds r, 1   // poison: r is not inbounds
t = gep r, 1            // ok, offset = 0
u = gep inbounds t, 1   // ok, offset = 1 (assuming malloc size > 0)

Right, but inbounds and provenance are, as far as I can tell, orthogonal concepts. Alive claims that this code has UB due to use of gep inbounds: https://alive2.llvm.org/ce/z/zTctIR At the same time, the gep inbounds itself is not poison: https://alive2.llvm.org/ce/z/wxGGyu That makes it looks like Alive also constrains provenance based on gep inbounds, not just the value of the pointer.

Sat, Dec 26, 11:21 AM · Restricted Project
nlopes added a comment to D93820: [InstSimplify] Don't fold gep p, -p to null.

I only looked at the tests and they were correct before, see here: https://alive2.llvm.org/ce/z/UzW3pv
The tests are weird because they have 'gep inbounds'. The reason they are correct (and weird) is that the only way p - (int)p/sizeof(*p) is inbounds is p being null. Anything else will overflow.

This doesn't look right to me, at least not given current LangRef wording. Lets say we have gep inbounds p, -p, where p = ptr(base_addr = 1, offset = -1). This means that the address value of p is 0, but it has provenance of the object at base_addr = 1. As such, the inbounds is not violated (both p and the gep results are inbounds of the zero address), but we still change provenance.

Sat, Dec 26, 8:15 AM · Restricted Project
nlopes added a comment to D93818: [LangRef] Update shufflevector's semantics to return poison if the mask is undef.

LGTM

Sat, Dec 26, 4:44 AM · Restricted Project
nlopes added a comment to D93820: [InstSimplify] Don't fold gep p, -p to null.

I only looked at the tests and they were correct before, see here: https://alive2.llvm.org/ce/z/UzW3pv
The tests are weird because they have 'gep inbounds'. The reason they are correct (and weird) is that the only way p - (int)p/sizeof(*p) is inbounds is p being null. Anything else will overflow.

Sat, Dec 26, 4:10 AM · Restricted Project

Thu, Dec 24

nlopes added inline comments to D93793: [IR] Let IRBuilder's CreateVectorSplat/CreateShuffleVector use poison as placeholder.
Thu, Dec 24, 2:57 AM · Restricted Project, Restricted Project

Tue, Dec 22

nlopes added a comment to D87188: [InstCombine] Canonicalize SPF to abs intrinc.

This patch regressed the following test of Transforms/InstCombine/abs-1.ll:
(need to drop NSW in this case).

define i8 @nabs_canonical_3(i8 %x) {
%0:
  %cmp = icmp slt i8 %x, 0
  %neg = sub nsw i8 0, %x
  %abs = select i1 %cmp, i8 %x, i8 %neg
  ret i8 %abs
}
=>
define i8 @nabs_canonical_3(i8 %x) {
%0:
  %1 = abs i8 %x, 1
  %abs = sub nsw i8 0, %1
  ret i8 %abs
}
Transformation doesn't verify!
ERROR: Target is more poisonous than source
Tue, Dec 22, 6:26 AM · Restricted Project, Restricted Project

Mon, Dec 21

nlopes added a comment to D93065: [InstCombine] Disable optimizations of select instructions that causes propagation of poison values.

In practice, probably not a lot. But it may have implications for loop optimization, like:

for (i=0; some_bool && i < limit; ++i) {
...
}

If you remove the poison from the i+1 < limit bit it may make the work of SCEV harder (or impossible; didn't think the example through carefully).

Can I just make sure my understanding is correct -- so when we check the SCEV of some_bool && i < limit; we do recursion backwards on this select instruction (after this patch) or on an AND instruction (before this patch). If we choose the freeze approach, we'll do recursion on the AND instruction and eventually hit a freeze instruction which SCEV does not know how to handle, hence SCEV will just return CouldNotCompute?

Mon, Dec 21, 4:07 AM · Restricted Project, Restricted Project

Fri, Dec 18

nlopes added a comment to D93376: [LangRef] Clarify the semantics of lifetime intrinsics.

As Ralf mentioned, the ship has sailed. Alloca and lifetime intrinsics were implemented like this several years ago. They were a quick hack to save stack space after inlining. That's it, and their design reflects the goals at the time.
We simply want to document what is implemented. @jdoerfert you seem to want to change the implementation and/or the design, which is a separate discussion. I suggest we first document how LLVM works and then if you want to make changes you start a *separate* discussion on the things you want to change, why, and what's the upgrade path, etc. We can't change the semantics of either alloca or lifetime intrinsics without an automatic upgrade path as otherwise we would break all frontends out there.

Fri, Dec 18, 9:01 AM · Restricted Project
nlopes added a comment to D93065: [InstCombine] Disable optimizations of select instructions that causes propagation of poison values.

Using freeze loses information (if some of the inputs was poison). Plus It requires an extra op.
If we canonicalize around select there's no loss of information and it's just 1 instruction.

The disadvantage is that then we have 2 ways or doing boolean ANDs/ORs. Though most analyses can be patched easily, as most LLVM analyses' results are of the form "x has property foo unless it's poison". So for those analyses using and/or or select is the same (as the only difference between these is propagation of poison).
Other analyses/optimization can learn about select as needed.

Thank you for raising up the good point! I understand that we lose information by preventing poison values from propagation using freeze. But I'm unclear what would be the side effect or problem with that? I'd appreciate it if you could clarify a bit, thanks!

Fri, Dec 18, 7:13 AM · Restricted Project, Restricted Project

Dec 17 2020

nlopes added a comment to D93376: [LangRef] Clarify the semantics of lifetime intrinsics.

What is the reason to restrict it to allocas? Just that we don't emit it right now? I don't see how that makes it conceptually better.

Dec 17 2020, 12:08 PM · Restricted Project
nlopes added a comment to D93065: [InstCombine] Disable optimizations of select instructions that causes propagation of poison values.

Using freeze loses information (if some of the inputs was poison). Plus It requires an extra op.
If we canonicalize around select there's no loss of information and it's just 1 instruction.

Dec 17 2020, 11:48 AM · Restricted Project, Restricted Project
nlopes added a comment to D78938: Make LLVM build in C++20 mode.

@BRevzin @nlopes This is causing MSVC build failure please can you take a look?

E:\llvm\llvm-project\llvm\include\llvm/DebugInfo/DWARF/DWARFDie.h(405): note: see declaration of 'std::reverse_iterator<llvm::DWARFDie::iterator>'
E:\llvm\llvm-project\llvm\lib\DWARFLinker\DWARFLinker.cpp(383): note: see reference to function template instantiation 'bool std::operator !=<llvm::DWARFDie::iterator,llvm::DWARFDie::iterator>(const std::reverse_iterator<llvm::DWARFDie::iterator> &,const std::reverse_iterator<llvm::DWARFDie::iterator> &)' being compiled
C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\MSVC\14.28.29333\include\xutility(2086): error C2039: '_Get_current': is not a member of 'std::reverse_iterator<llvm::DWARFDie::iterator>'
E:\llvm\llvm-project\llvm\include\llvm/DebugInfo/DWARF/DWARFDie.h(405): note: see declaration of 'std::reverse_iterator<llvm::DWARFDie::iterator>'
Dec 17 2020, 6:12 AM · Restricted Project, Restricted Project
nlopes committed rG92310454bf0f: Make LLVM build in C++20 mode (authored by BRevzin).
Make LLVM build in C++20 mode
Dec 17 2020, 2:45 AM
nlopes closed D78938: Make LLVM build in C++20 mode.
Dec 17 2020, 2:45 AM · Restricted Project, Restricted Project

Dec 16 2020

nlopes added a comment to D93376: [LangRef] Clarify the semantics of lifetime intrinsics.

A contradiction in the proposed semantics vs the comments in the code is that we state that subsequent lifetime.start don't change the address of the alloca. There's only one address per alloca, even if it may have multiple disjoint liveness ranges.
It would be good to get confirmation from some CodeGen folks that the implemented algorithm respects this condition and that there are no plans to make the algorithm more aggressive in a way that may break this assumption.
Having multiple start/end pairs for the same alloca is not common, so I think imposing this condition is fine. It gives us free movement of gep/ptr2int, which is a good tradeoff.

Dec 16 2020, 7:00 AM · Restricted Project
nlopes added a reviewer for D93376: [LangRef] Clarify the semantics of lifetime intrinsics: MatzeB.
Dec 16 2020, 6:56 AM · Restricted Project

Dec 14 2020

nlopes added a comment to D93229: [VectorCombine] allow peeking through GEPs when creating a vector load.
/builddirs/llvm-project/build-Clang11-unknown$ /builddirs/llvm-project/build-Clang11-unknown/bin/opt -load /repositories/alive2/build-Clang-release/tv/tv.so -tv -vector-combine -mtriple=x86_64-- -mattr=avx2 -tv -o /dev/null --tv-smt-to=60000 /tmp/D93229.ll 

----------------------------------------
define <8 x i16> @t(* dereferenceable(128) align(128) %base) {
%0:
  %ptr = gep inbounds * dereferenceable(128) align(128) %base, 1 x i64 1
  %p = bitcast * %ptr to *
  %gep = gep inbounds * %p, 16 x i64 0, 2 x i64 1
  %s = load i16, * %gep, align 1
  %r = insertelement <8 x i16> undef, i16 %s, i64 0
  ret <8 x i16> %r
}
=>
define <8 x i16> @t(* dereferenceable(128) align(128) %base) {
%0:
  %ptr = gep inbounds * dereferenceable(128) align(128) %base, 1 x i64 1
  %p = bitcast * %ptr to *
  %gep = gep inbounds * %p, 16 x i64 0, 2 x i64 1
  %1 = bitcast * %gep to *
  %r = load <8 x i16>, * %1, align 1
  ret <8 x i16> %r
}
Transformation doesn't verify!
Dec 14 2020, 11:36 AM · Restricted Project

Dec 13 2020

nlopes added a comment to D78938: Make LLVM build in C++20 mode.

Thanks @lebedev.ri for the pointer!
I started working on exactly the same thing as I was trying to link a C++20 project with LLVM.
@BRevzin is there anything missing in this patch? Do you have commit access or do you need help to land this?

Dec 13 2020, 10:16 AM · Restricted Project, Restricted Project
nlopes added a comment to D90529: Allow nonnull/align attribute to accept poison.

For the partial undef memory access example that Juneyoung gave.. Well, maybe we need to make it UB to dereference a non-deterministic value. Doesn't seem like it's a very useful thing to do, and this non-determinism comes from some previous undefined behavior, so it seems fine to just make dereference of partial undef UB. Simplifies things.

There was a discussion for this: https://groups.google.com/g/llvm-dev/c/2Qk4fOHUoAE/m/OxZa3bIhAgAJ
This partially undef thing is a bit painful.. :/

Dec 13 2020, 4:31 AM · Restricted Project

Dec 11 2020

nlopes added a comment to D90529: Allow nonnull/align attribute to accept poison.

I like where this is going. Most of LLVM's alias analysis produce information that only holds if the value is not poison. Since these attributes are derived from said analysis, then it makes sense then they have the same "X is poison or foo(X) holds" semantics.
I agree that certain attributes are different, like dereferenceable. It is useless if the value might be poison as well. Though we may go with the same semantics and then require the noundef attribute to make it useful. Seems like a good way to go as well.

Dec 11 2020, 2:07 PM · Restricted Project

Dec 10 2020

nlopes committed rGd2a7b83c5c7b: AA: make AliasAnalysis.h compatible with C++20 (NFC) (authored by nlopes).
AA: make AliasAnalysis.h compatible with C++20 (NFC)
Dec 10 2020, 7:32 AM

Dec 8 2020

nlopes committed rG3c01af9aeebe: DenseMap: fix build with clang in C++20 mode (authored by nlopes).
DenseMap: fix build with clang in C++20 mode
Dec 8 2020, 10:40 AM

Nov 12 2020

nlopes added a comment to D90708: [LangRef] Clarify GEP inbounds wrapping semantics.

LGTM!
Thanks a lot for working on this!

Nov 12 2020, 10:06 AM · Restricted Project

Nov 11 2020

nlopes added inline comments to D90708: [LangRef] Clarify GEP inbounds wrapping semantics.
Nov 11 2020, 12:20 PM · Restricted Project
nlopes added inline comments to D90708: [LangRef] Clarify GEP inbounds wrapping semantics.
Nov 11 2020, 11:41 AM · Restricted Project

Nov 9 2020

nlopes added a comment to D91055: [clang-tidy] Introduce misc No Integer To Pointer Cast check.

Nice!
BTW, another popular idiom is to store data in the last few bits of the pointer (e.g., LLVM's own PointerIntPair). I guess that one can also be implement by casting the ptr to char* and doing operations over that.

Nov 9 2020, 2:05 AM · Restricted Project, Restricted Project, Restricted Project

Nov 5 2020

nlopes added a comment to D90382: [InstCombine] foldSelectRotate - generalize to foldSelectFunnelShift .

@nlopes I think we should adjust the funnel shift definition to say that it blocks poison on one operand if the shift amount is zero. Basically the poison semantics should be "as if" the funnel shift were expanded, which does include an explicit select for the zero shift amount case.

Nov 5 2020, 5:32 AM · Restricted Project
nlopes added a comment to D90382: [InstCombine] foldSelectRotate - generalize to foldSelectFunnelShift .

Alive2 says this test is incorrect (because select blocks poison and funnel shift doesn't):

define i8 @fshr_select(i8 %x, i8 %y, i8 %shamt) {
%0:
  %cmp = icmp eq i8 %shamt, 0
  %sub = sub i8 8, %shamt
  %shr = lshr i8 %y, %shamt
  %shl = shl i8 %x, %sub
  %or = or i8 %shl, %shr
  %r = select i1 %cmp, i8 %y, i8 %or
  ret i8 %r
}
=>
define i8 @fshr_select(i8 %x, i8 %y, i8 %shamt) {
%0:
  %r = fshr i8 %x, i8 %y, i8 %shamt
  ret i8 %r
}
Transformation doesn't verify!
ERROR: Target is more poisonous than source
Nov 5 2020, 4:19 AM · Restricted Project

Nov 4 2020

nlopes added a reviewer for D90708: [LangRef] Clarify GEP inbounds wrapping semantics: rsmith.
Nov 4 2020, 1:04 AM · Restricted Project
nlopes added a comment to D90708: [LangRef] Clarify GEP inbounds wrapping semantics.

LGTM modulo the two comments. Thanks for writing this down!

Nov 4 2020, 1:03 AM · Restricted Project

Nov 3 2020

nlopes added a comment to D90637: [ValueTracking] Inbounds does not imply nsw.

Hm, I think we need to clarify this in LangRef. We definitely assume this interpretation (unsigned base and signed offset) in some places (e.g. https://github.com/llvm/llvm-project/blob/c938b4a1ed43f3075155e16a7c2792ca8c122258/llvm/lib/Analysis/ScalarEvolution.cpp#L5061-L5072 and I'm pretty sure I've seen it elsewhere as well), but LangRef is really not clear on this point. It's also not completely obvious where the assumption that the pointer address space is unsigned comes from. E.g. on x86-64 the canonical address space is signed (but I don't know about other architectures). We need to clarify whether having an allocated object at [0xffffffff, 0x00000001] is legal (signed address space), [0x7fffffff, 0x80000001] is legal (unsigned address space) or both.

Nov 3 2020, 5:31 AM · Restricted Project

Nov 2 2020

nlopes added a comment to D90637: [ValueTracking] Inbounds does not imply nsw.

FWIW, here's a related bug (fixed already): https://bugs.llvm.org/show_bug.cgi?id=42699

Nov 2 2020, 2:28 PM · Restricted Project

Oct 11 2020

nlopes added a comment to D88783: [InstCombine] matchFunnelShift - fold or(shl(a,x),lshr(b,sub(bw,x))) -> fshl(a,b,x) iff x < bw.

Alive2 complains about one of the test cases:

define i64 @fshr_sub_mask(i64 %x, i64 %y, i64 %a) {
  %mask = and i64 %a, 63
  %shr = lshr i64 %x, %mask
  %sub = sub nsw nuw i64 64, %mask
  %shl = shl i64 %y, %sub
  %r = or i64 %shl, %shr
  ret i64 %r
}
=>
define i64 @fshr_sub_mask(i64 %x, i64 %y, i64 %a) {
  %r = fshr i64 %x, i64 %y, i64 %a
  ret i64 %r
}
Transformation doesn't verify!
ERROR: Value mismatch
Oct 11 2020, 3:30 PM · Restricted Project
nlopes accepted D88979: [InstCombine] combineLoadToOperationType(): don't fold int<->ptr cast into load.

LGTM

@nlopes does this look good to you?

Looking through other uses of isNoopCast(), I don't think it makes sense to push this change into it, as many other usages do need it to work with ptrtoint/inttoptr (some of them using it specifically for them). The comment above the function indicates that "no-op" is to be understood as "generates no code" here. Possibly it could do with a rename.

I think i don't agree with you there.
I agree with @nlopes, the end goal will be to basically disallow fusing of inttoptr/ptrtoint into loads,
disallow dropping inttoptr-of-ptrtoint/ptrtoint-of-inttoptr, etc.
And all that eventually boils down to updating CastInst::isNoopCast()/CastInst::isEliminableCastPair().

Oct 11 2020, 10:03 AM · Restricted Project, Restricted Project
nlopes added inline comments to D88979: [InstCombine] combineLoadToOperationType(): don't fold int<->ptr cast into load.
Oct 11 2020, 8:16 AM · Restricted Project, Restricted Project
nlopes updated subscribers of D88995: Support vectors in CastInst::isBitOrNoopPointerCastable.
Oct 11 2020, 7:46 AM · Restricted Project
nlopes added inline comments to D88995: Support vectors in CastInst::isBitOrNoopPointerCastable.
Oct 11 2020, 7:46 AM · Restricted Project

Oct 6 2020

nlopes added a comment to D88788: [SROA] rewritePartition()/findCommonType(): if uses have conflicting type, try getTypePartition() before falling back to largest integral use type (PR47592).

I guess if we're relying on the allocated type of the alloca anyway, preferring it over an integer type isn't terrible.

Really, though, we should avoid relying on the allocated type where possible. Here, we could check if any of the load/store operations use a pointer type, and choose a pointer type in that case.

Agreed. But until LLVM removes pointer sub-types it's convenient to get the alloca type right to avoid bitcast on every access anyway.
When pointer sub-types goes away, I guess all this code in SROA to find the right type for alloca would go away, but as you say it would have to be replaced with code to get the right load/store type instead. (FWIW Alive2's alloca only takes the number of bytes to allocate as argument)
So I see this patch as a step in the right direction.

So i don't do this blindly to find out that is'a bad idea, can we agree on the baseline here?
How should this be done properly? Instead of relying on the allocation type, would the D88842's approach be applicable here?

Oct 6 2020, 3:52 AM · Restricted Project
nlopes added a comment to D88806: [SCEV] Model ptrtoint(SCEVUnknown) cast not as unknown, but as zext/trunc/self of SCEVUnknown.

ptrtoint and inttoptr are different beasts.
Supporting ptrtoint is much simpler. It's inttoptr that makes me uncomfortable. I don't known enough about SCEV to know how it handles these unknown nodes.
To me, the patch makes sense for ptrtoint (as you say, it's just a zext/sext of some unknown value; worst case it's poison if we want to be strict about OOB). Though I can't comment on the inttoptr case (some SCEV expert needs to chime in).

Oct 6 2020, 3:24 AM · Restricted Project
nlopes added a comment to D88788: [SROA] rewritePartition()/findCommonType(): if uses have conflicting type, try getTypePartition() before falling back to largest integral use type (PR47592).

I guess if we're relying on the allocated type of the alloca anyway, preferring it over an integer type isn't terrible.

Really, though, we should avoid relying on the allocated type where possible. Here, we could check if any of the load/store operations use a pointer type, and choose a pointer type in that case.

Oct 6 2020, 3:17 AM · Restricted Project
nlopes added a comment to D88860: [LangRef] Describe why the pointer aliasing rules are currently unsound..

My meta-comment about this patch is that I'm not sure LangRef is the right place for this content. I see LangRef as the stuff that is set in stone, not necessarily for ongoing discussions.
However, since LangRef doesn't get these bits right, it might be ok to have a warning section about stuff that is disputed/under discussion so that readers know that part is not set in stone.

Oct 6 2020, 3:05 AM · Restricted Project

Oct 5 2020

nlopes added a comment to D88842: [InstCombine] inttoptr(load) -> load.

I don't like the direction of this patch because it will remove inttoptr instructions that were present in the original program. In the same way that optimizations shouldn't introduce inttoptr, they shouldn't fuse them with loads either.
If the original program had the inttoptr cast and you fold it with a load instruction, then you are asking the load to do the cast. This sort of type punning is not ok. I strongly disagree with Chandler that LLVM's memory is not typed. It needs to distinguish between integers and pointers, otherwise I don't know how to make LLVM correct without a significant perf penalty.
If LLVM's memory was untyped, we would have to assume that every pointer load could be doing an implicit inttoptr cast, which would havoc most optimizations. The fact that some optimizations, like sroa, assume that the memory is untyped and most of the others don't is a source of miscompilations.

Oct 5 2020, 12:24 PM · Restricted Project

Oct 3 2020

nlopes accepted D88789: [InstCombine] Revert rL226781 "Teach InstCombine to canonicalize loads which are only ever stored to always use a legal integer type if one is available." (PR47592).

Love it, thanks!
This gets rid of a lot of type punning issues through load/store of integers. Not introducing inttoptr during optimization is a very healthy goal.

Oct 3 2020, 2:58 PM · Restricted Project, Restricted Project

Sep 19 2020

nlopes added inline comments to D87965: [InstCombine] replace phi values from unreachable blocks with 'undef'.
Sep 19 2020, 8:43 AM · Restricted Project

Sep 10 2020

nlopes added a comment to D87149: [InstCombine] erase instructions leading up to unreachable.

Ok, let me make it more concrete.
it seems we have 3 possible semantics:

  1. volatile accesses never trap, but rather trigger UB when the address is not dereferenceable
  2. they trap if the address is not dereferenceable
  3. they may trap regardless (i.e., they can never be removed). Alternatively we can state that the load/store address traces are externally observable and can't change
Sep 10 2020, 4:35 AM · Restricted Project
nlopes added a comment to D87149: [InstCombine] erase instructions leading up to unreachable.

I would say let's write an RFC and see if there are other opinions. Also, @nlopes what does alive2 think of such a proposal?

Sep 10 2020, 4:27 AM · Restricted Project

Sep 6 2020

nlopes added a comment to D86815: [LangRef] Adjust guarantee for llvm.memcpy to also allow equal arguments..

FYI: I've just run Alive2 (already patched for this new semantics) on the test suite and no regressions reported.

Sep 6 2020, 11:52 AM · Restricted Project

Sep 1 2020

nlopes added a comment to D86815: [LangRef] Adjust guarantee for llvm.memcpy to also allow equal arguments..

Why would we change this? What's the point of having separate memcpy and memmove intrinsics?

I'm reading this as clang mis-uses llvm.memcpy when it probably should be using llvm.memmove

There is a longstanding assumption made by ~every compiler that memcpy(p, p, n) is safe. That's what we should be encoding here. We should not be removing all overlap restrictions.

Sep 1 2020, 3:26 AM · Restricted Project

Aug 7 2020

nlopes added a comment to D85522: [Loads] Globals are dereferenceable, if offset + size <= sizeof(global)..

The reasoning looks good, though the case when offset + size overflows doesn't seem to be considered.

Aug 7 2020, 7:06 AM · Restricted Project

Jul 13 2020

nlopes added a comment to D83360: [InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X.

FYI InstSimplify doing distribution of undef is a known bug: https://bugs.llvm.org/show_bug.cgi?id=33165

Jul 13 2020, 2:13 AM · Restricted Project, Restricted Project

Jul 10 2020

nlopes added a comment to D83440: [InstSimplify] Re-enable select ?, undef, X -> X transform when X is provably not poison.

A question about this: We got a couple of dozen MSAN warnings in the Google codebase from the revision that removed these -- I'm guessing that perhaps what happened was that the undef in question was a use-of-uninitialized-value, and this optimization was hiding the use so the MSAN checks didn't trigger. Is re-enabling this going to make those MSAN warnings go away again, re-hiding this undefined behavior?

Jul 10 2020, 1:47 AM · Restricted Project

Jul 9 2020

nlopes updated subscribers of D83360: [InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X.

that's fine but I still don't understand why the counterexample to my version says %x2 in @src can be undef

If I'm understanding correctly, this reduces to something like the following:

define i32 @src() {

%x2 = freeze i32 undef
ret i32 %x2

}

define i32 @tgt() {

ret i32 undef

}

This seems a little suspect, yes.

Jul 9 2020, 2:18 PM · Restricted Project, Restricted Project
nlopes added inline comments to D83440: [InstSimplify] Re-enable select ?, undef, X -> X transform when X is provably not poison.
Jul 9 2020, 1:13 AM · Restricted Project

Jul 8 2020

nlopes added a comment to D83360: [InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X.

Alive does like this https://alive2.llvm.org/ce/z/yhibbe which is what I was going to implement.

Jul 8 2020, 3:18 PM · Restricted Project, Restricted Project
nlopes updated subscribers of D83360: [InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X.
Jul 8 2020, 1:36 AM · Restricted Project, Restricted Project
nlopes accepted D83360: [InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X.

Here's an end-to-end miscompilation: https://bugs.llvm.org/show_bug.cgi?id=31633

Jul 8 2020, 1:35 AM · Restricted Project, Restricted Project

Jul 2 2020

nlopes committed rG7f903873b8a9: DSE: fix builtin function recognition to take decl into account (authored by nlopes).
DSE: fix builtin function recognition to take decl into account
Jul 2 2020, 2:39 AM

Jun 27 2020

nlopes accepted D82316: [LangRef] Add `noundef` attribute to documentation.
Jun 27 2020, 1:21 AM · Restricted Project

Jun 25 2020

nlopes added inline comments to D82316: [LangRef] Add `noundef` attribute to documentation.
Jun 25 2020, 11:54 AM · Restricted Project

Jun 23 2020

nlopes added a comment to D81678: Introduce noundef attribute at call sites for stricter poison analysis.

I'm a bit concerned with this patch as it increases the amount of UB that LLVM exploits without any study of the impact.
For example, right now it's ok do this with clang (not with constants; make it less trivial so clang doesn't fold it right away):

int f() { return INT_MAX + 1; }
Jun 23 2020, 7:26 AM · Restricted Project, Restricted Project
nlopes added inline comments to D82316: [LangRef] Add `noundef` attribute to documentation.
Jun 23 2020, 7:26 AM · Restricted Project

May 31 2020

nlopes added a comment to D80875: [ValueTracking] Branch on poison is UB, branch cond is non-poison..

The passes we are aware that introduce branch on poison are: IndVarSimplify, LoopUnswitch, SimpleLoopUnswitch, and SimpifyCFG.
(https://web.ist.utl.pt/nuno.lopes/alive2/index.php?hash=4beb2b117e2fdd2c)

May 31 2020, 4:16 AM · Restricted Project

May 21 2020

nlopes added inline comments to D80276: [Alignment] Fix misaligned interleaved loads.
May 21 2020, 10:48 AM · Restricted Project

May 20 2020

nlopes added inline comments to D80276: [Alignment] Fix misaligned interleaved loads.
May 20 2020, 9:48 AM · Restricted Project
nlopes added inline comments to D80276: [Alignment] Fix misaligned interleaved loads.
May 20 2020, 7:02 AM · Restricted Project
nlopes updated subscribers of D80276: [Alignment] Fix misaligned interleaved loads.
May 20 2020, 7:02 AM · Restricted Project

May 11 2020

nlopes updated subscribers of D79746: [SCEV] Relax abnormal exit check in isAddRecNeverPoison..
May 11 2020, 2:35 PM · Restricted Project

May 8 2020

nlopes added inline comments to D78615: [ValueTracking] Let propagatesPoison support binops/unaryops/cast/etc..
May 8 2020, 10:10 AM · Restricted Project

Apr 22 2020

nlopes added a comment to D78631: [InstCombine] intersect FMF when reassociating FP min/max intrinsics.

Side note - Alive2 does not seem to recognize the keyword 'fast' currently (or we would have seen more tests flagged as incorrect).

Apr 22 2020, 8:06 AM · Restricted Project

Apr 13 2020

nlopes accepted D77868: [InstSimplify] fold select of bools using bitwise logic.
// select Cond, T, false --> Cond & T
if (match(F, m_ZeroInt()))
  return SimplifyAndInst(Cond, T, Q);

I still do not see how this can go wrong in practice. If InstSimplify can prove that T is poison, then doesn't it always manifest that knowledge by saying T is undef?
Looking at it another way (see if you can spot a logic flaw):

  1. Assume T is poison.
  2. Assume InstSimplify fails to simplify T to undef or constant.
  3. For poison T' (either T or some other poisoned value) to leak through as the result, InstSimplify must prove that Cond & T' == T'.
  4. So InstSimplify must prove that Cond == true or Cond == T'.
  5. If Cond == T', there's no problem (if Cond is poison, the select is poison).
  6. Therefore -- for there to be a problem -- we must prove that Cond is true.
  7. If we can prove that Cond is true, then that guarantees that value T' can't depend on Cond (nothing depends on Cond - it simplifies to constant true).
Apr 13 2020, 9:06 AM

Apr 5 2020

nlopes added a comment to D76973: [LangRef] Clarify the semantics of branch on undef.

Yes, introducing branches on a variable that may be undef/poison is not legal. However, you can use freeze to make it safe.
I think @aqjune fixed loop unswitching already. (don't recall if that was the reverted patch). It's true there a couple more places left to fix.

Apr 5 2020, 2:57 PM · Restricted Project

Mar 29 2020

nlopes added a comment to D76973: [LangRef] Clarify the semantics of branch on undef.

We should probably also think about what to do with all the tests that contain branches on undef. Also, bugpoint should probably stop creating branches on undef with this spelled out as is?

When I've updated other tests that would break with changed/improved undef semantics, I usually replace the 'undef' with a parameter like this:
rGfebcb24f1490
Maybe we can script that to fix most of the tests?

Mar 29 2020, 12:17 PM · Restricted Project

Mar 28 2020

nlopes added inline comments to D76973: [LangRef] Clarify the semantics of branch on undef.
Mar 28 2020, 12:22 PM · Restricted Project
nlopes accepted D76973: [LangRef] Clarify the semantics of branch on undef.
Mar 28 2020, 12:22 PM · Restricted Project

Feb 29 2020

nlopes accepted D75396: [ValueTracking] A value is never undef or poison if it must raise UB.

LGTM

Feb 29 2020, 9:05 AM · Restricted Project
nlopes accepted D75397: [ValueTracking] Let getGuaranteedNonFullPoisonOp consider assume, remove mentioning about br.

LGTM (modulo the style fix).
assume poison is UB.

Feb 29 2020, 8:56 AM · Restricted Project

Feb 23 2020

nlopes committed rG98ac6e76960a: [NFC] fix test nan value (authored by nlopes).
[NFC] fix test nan value
Feb 23 2020, 4:47 AM

Feb 21 2020

nlopes added a comment to D74935: [LangRef][AliasAnalysis] Clarify `noalias` affects only modified objects.

I agree with @aqjune that stating clearly the definition of object in this context.
See this example in the C spec:

For example, the second call of f in g has undefined behavior because each of d[1] through d[49] is accessed through both p and q.
Feb 21 2020, 3:23 AM · Restricted Project

Feb 17 2020

nlopes added inline comments to D74713: [ConstantFold] fold fsub -0.0, undef to undef rather than NaN.
Feb 17 2020, 2:36 PM · Restricted Project

Feb 14 2020

nlopes added a comment to D74209: [AssumeBundle] Add documentation for the operand bundles of an llvm.assume.

LGTM overall, just some nitpicks.
Something I would add is a link to the list of attributes (is this function-attributes?).

Feb 14 2020, 9:54 AM · Restricted Project

Feb 7 2020

nlopes committed rG380fe91fc6dd: [docs] update mathjax path in doxygen (authored by nlopes).
[docs] update mathjax path in doxygen
Feb 7 2020, 8:27 AM

Jan 24 2020

nlopes added a comment to D73342: Fix EarlyCSE to intersect aliasing metadata..

I'm not familiar with the code of this pass, but is there a cheap way of identifying that the two operations are in the same basic block?
If so, you could take the intersection of the aliasing information rather than the union. Because if both ops are guaranteed to execute then the tightest aliasing still has to hold.
(being in the same BB doesn't imply that both instructions are executed, but there's code in ValueTracking perhaps that can check that)

Jan 24 2020, 8:13 AM · Restricted Project

Jan 11 2020

nlopes committed rG87407fc03c82: DSE: fix bug where we would only check libcalls for name rather than whole decl (authored by nlopes).
DSE: fix bug where we would only check libcalls for name rather than whole decl
Jan 11 2020, 3:59 AM

Jan 9 2020

nlopes added a comment to D29014: [SelDag] Add FREEZE.

The patch & semantics look good to me, but I'm not a backend expert. I'll leave the final LGTM to someone else.
It would be awesome if we could get this in for 10.0 so that we have complete support for freeze.

Jan 9 2020, 6:27 AM · Restricted Project

Jan 3 2020

nlopes added a comment to D71499: Add builtins for aligning and checking alignment of pointers and integers.

@lebedev.ri I agree with you that the semantics of these alignment builtins should only return a pointer that is of the same object as the one given as input.
Otherwise, these builtins would be even worst that ptr2int/int2ptr, since their result could alias with any other pointer in the program, not just the escaped pointers.

Jan 3 2020, 9:18 AM · Restricted Project

Jan 2 2020

nlopes accepted D72101: [InstCombine] replace undef elements in vector constant when doing icmp folds (PR44383).

LGTM, thanks!

Jan 2 2020, 1:55 PM · Restricted Project

Dec 10 2019

nlopes added a comment to D71145: [InstCombine] Allow to limit the max number of iterations.

LGTM. The table you provided was very interesting to see, thanks!

Dec 10 2019, 2:18 PM · Restricted Project

Dec 4 2019

nlopes added a comment to D70749: [InstCombine] do not insert nonnull assumption for undef.

You said "Changing the semantics on non-respecting the tags from UB to poison doesn't help either.", could you elaborate why?
If there are no uses of a violating instantiation (undef/null passed to a non-null) we would not get UB but an unused poison value.

Dec 4 2019, 1:39 AM · Restricted Project

Dec 1 2019

nlopes committed rG89c47313c9b1: remove UB from test by making GV alignment explicit (authored by nlopes).
remove UB from test by making GV alignment explicit
Dec 1 2019, 7:20 AM

Nov 29 2019

nlopes added a comment to D70749: [InstCombine] do not insert nonnull assumption for undef.

I think it's clear that dead arg elimination is incorrect in replacing a valid pointer with null in an attributed with non-null tag. Changing the semantics on non-respecting the tags from UB to poison doesn't help either.
The problem with dropping attributes is that a given function call site, the attributes to be considered are the union of the attributes in the function call and in the callee declaration. We can't rely drop attributes from the callee since some linking later may add them back.

Nov 29 2019, 9:30 AM · Restricted Project
nlopes accepted D70641: [LangRef] make per-element poison behavior explicit.

LGTM
Reference to the discussion: http://lists.llvm.org/pipermail/llvm-dev/2019-November/137243.html

Nov 29 2019, 6:49 AM · Restricted Project