Page MenuHomePhabricator

Update documentation on stage3 cmake build
ClosedPublic

Authored by serge-sans-paille on Oct 7 2020, 11:01 AM.

Details

Summary

Have the build work out of the box by forcing an LLD build. That way, we don't require an external LTO-aware linker, as we build one.
Also remove reference to the seemingly dead builder.

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptOct 7 2020, 11:01 AM
serge-sans-paille requested review of this revision.Oct 7 2020, 11:01 AM
sylvestre.ledru accepted this revision.Oct 7 2020, 11:04 AM
This revision is now accepted and ready to land.Oct 7 2020, 11:04 AM
beanz requested changes to this revision.Oct 7 2020, 11:11 AM

Using lld on Darwin isn't ideal, the system linker is desirable there.

This revision now requires changes to proceed.Oct 7 2020, 11:11 AM

Using lld on Darwin isn't ideal, the system linker is desirable there.

What about making it the default on Linux and Windows?

beanz added a comment.Oct 7 2020, 12:07 PM

Using lld on Darwin isn't ideal, the system linker is desirable there.

What about making it the default on Linux and Windows?

That would be reasonable.

APPLE-specific setting wrt linker

beanz accepted this revision.Oct 7 2020, 12:45 PM

LGTM

This revision is now accepted and ready to land.Oct 7 2020, 12:45 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 7 2020, 10:55 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript