Page MenuHomePhabricator

serge-sans-paille (serge)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 10 2016, 10:44 AM (222 w, 5 d)

Recent Activity

Thu, Jan 14

serge-sans-paille added a comment to D94734: [lit] Use os.cpu_count() to cleanup TODO.
In D94734#2499865, @yln wrote:

Does the following mean that Python3 is now okay to use for lit?
https://lists.llvm.org/pipermail/llvm-dev/2020-December/147372.html
https://reviews.llvm.org/D93097

Thu, Jan 14, 10:32 PM · Restricted Project

Tue, Jan 12

serge-sans-paille added a comment to D94387: Add new LLVMComponents CMake module..

First review round. I'm pretty excited by this work, thanks for handling this!

Tue, Jan 12, 12:42 AM · Restricted Project

Mon, Jan 11

serge-sans-paille requested review of D94420: [clang-tooling] Prevent llvm::fatal_error on invalid CLI option.
Mon, Jan 11, 8:12 AM

Fri, Jan 8

serge-sans-paille updated the diff for D93095: Introduce -Wreserved-identifier.

Ignore forward declaration of tagdecl

Fri, Jan 8, 7:14 AM
serge-sans-paille added inline comments to D93095: Introduce -Wreserved-identifier.
Fri, Jan 8, 6:44 AM
serge-sans-paille updated the diff for D93095: Introduce -Wreserved-identifier.

Update codebase and testbed to reflect recent discussion.

Fri, Jan 8, 6:38 AM
serge-sans-paille added inline comments to D93095: Introduce -Wreserved-identifier.
Fri, Jan 8, 2:16 AM
serge-sans-paille added a comment to D94157: [lit] Harmonize lit and llvm versionning.

Up?

Fri, Jan 8, 2:11 AM · Restricted Project
serge-sans-paille updated the diff for D93095: Introduce -Wreserved-identifier.

Address some of the review

Fri, Jan 8, 1:33 AM

Tue, Jan 5

serge-sans-paille requested review of D94157: [lit] Harmonize lit and llvm versionning.
Tue, Jan 5, 11:18 PM · Restricted Project

Mon, Jan 4

serge-sans-paille updated the diff for D92657: Fix interaction between clang and some inline builtins from glibc under _FORTIFY_SOURCE.

Rebased on main.

Mon, Jan 4, 1:13 AM · Restricted Project
serge-sans-paille updated the diff for D93095: Introduce -Wreserved-identifier.

Rebased on main.

Mon, Jan 4, 1:03 AM

Tue, Dec 22

serge-sans-paille updated the diff for D93095: Introduce -Wreserved-identifier.

Instead of pretending to be smart, just consider that if the considered decl is at the top level, then it's a top-level decl, otherwise it's not. There may be some interpretation wrt. the standard, but this seems both simple and conservative to me. It gies a few false negative, but it's a warning here, so that should be fine.

Tue, Dec 22, 7:07 AM
serge-sans-paille accepted D92245: -fstack-clash-protection: Return an actual error when used on unsupported OS.

LGTM, thanks!

Tue, Dec 22, 2:47 AM · Restricted Project, Restricted Project
serge-sans-paille closed D93097: Remove Python2 fallback and only advertise Python3 in the doc.
Tue, Dec 22, 2:05 AM · Restricted Project
serge-sans-paille committed rG6fcb03995648: Fold comparison of __builtin_object_size expression with -1 for non-const size (authored by siddhesh).
Fold comparison of __builtin_object_size expression with -1 for non-const size
Tue, Dec 22, 1:57 AM
serge-sans-paille closed D93015: Fold comparison of __builtin_object_size expression with -1 for non-const size.
Tue, Dec 22, 1:56 AM · Restricted Project

Mon, Dec 21

serge-sans-paille added a comment to D93097: Remove Python2 fallback and only advertise Python3 in the doc.

Commited as of 5e31e226b5b2b682607a6578ff5adb33daf4fe39, I totally messed the differential revision :-)

Mon, Dec 21, 11:46 AM · Restricted Project
serge-sans-paille accepted D93015: Fold comparison of __builtin_object_size expression with -1 for non-const size.

lgtm, thanks!

Mon, Dec 21, 5:48 AM · Restricted Project

Fri, Dec 18

serge-sans-paille added a comment to D93015: Fold comparison of __builtin_object_size expression with -1 for non-const size.

@siddhesh what anout the following?

Fri, Dec 18, 6:51 AM · Restricted Project

Dec 17 2020

serge-sans-paille updated the diff for D93095: Introduce -Wreserved-identifier.

Take review into account, some extra tests suggested by @aaron.ballman and the according modification in Decl.cpp

Dec 17 2020, 12:47 PM
serge-sans-paille committed rG5e31e226b5b2: Remove Python2 fallback and only advertise Python3 in the doc (authored by serge-sans-paille).
Remove Python2 fallback and only advertise Python3 in the doc
Dec 17 2020, 6:41 AM

Dec 16 2020

serge-sans-paille added inline comments to D93351: [llvm-shlib] Build backend libraries as loadable modules.
Dec 16 2020, 8:59 AM · Restricted Project
serge-sans-paille added inline comments to D93351: [llvm-shlib] Build backend libraries as loadable modules.
Dec 16 2020, 8:41 AM · Restricted Project
serge-sans-paille added a comment to D92657: Fix interaction between clang and some inline builtins from glibc under _FORTIFY_SOURCE.

@rnk what do you find of this approach?

Dec 16 2020, 7:32 AM · Restricted Project
serge-sans-paille added inline comments to D93095: Introduce -Wreserved-identifier.
Dec 16 2020, 7:21 AM
serge-sans-paille updated the diff for D93095: Introduce -Wreserved-identifier.

Take review into account and add more tests

Dec 16 2020, 7:18 AM

Dec 15 2020

serge-sans-paille added a comment to D93095: Introduce -Wreserved-identifier.

I do think it would be good for this to somehow handle macros with reserved names, since macros are one of the primary dangers of using reserved names (if I #define _Tp 0 and then later #include <vector>

Dec 15 2020, 8:38 AM
serge-sans-paille added inline comments to D93015: Fold comparison of __builtin_object_size expression with -1 for non-const size.
Dec 15 2020, 2:27 AM · Restricted Project
serge-sans-paille added a comment to D93015: Fold comparison of __builtin_object_size expression with -1 for non-const size.

When __builtin_dynamic_object_size returns a non-constant expression, it cannot be -1 since that is an invalid return value for object size

Dec 15 2020, 2:02 AM · Restricted Project

Dec 14 2020

serge-sans-paille added inline comments to D93095: Introduce -Wreserved-identifier.
Dec 14 2020, 10:41 AM
serge-sans-paille updated the diff for D93095: Introduce -Wreserved-identifier.

More test cases and updated reserved isReserved()

Dec 14 2020, 10:40 AM
serge-sans-paille updated the summary of D92657: Fix interaction between clang and some inline builtins from glibc under _FORTIFY_SOURCE.
Dec 14 2020, 5:54 AM · Restricted Project
serge-sans-paille updated the diff for D92657: Fix interaction between clang and some inline builtins from glibc under _FORTIFY_SOURCE.

As suggested by @rnk, spot the pattern more accurately at clang level, and use a combination of nobuiltin / builtin attributes to flag it at LLVM IR level.
What I like with that approach is that we're not preventing the emission a function Body, but just handling it in a decent way.

Dec 14 2020, 5:51 AM · Restricted Project
serge-sans-paille added a comment to D93097: Remove Python2 fallback and only advertise Python3 in the doc.

Up? I'd like to land that one this week if possible.

Dec 14 2020, 5:43 AM · Restricted Project
serge-sans-paille added a comment to D92245: -fstack-clash-protection: Return an actual error when used on unsupported OS.

@sylvestre.ledru I: double checked and there's nothing in the original advisory against Darwin, but nothing that clearly states it's protected either (unlike Windows-based system). And there's also nothing specific to Darwin in the stack clash protection implementation, I think it's ok to only warn on Windows.

Dec 14 2020, 5:42 AM · Restricted Project, Restricted Project

Dec 11 2020

serge-sans-paille requested review of D93097: Remove Python2 fallback and only advertise Python3 in the doc.
Dec 11 2020, 2:40 AM · Restricted Project
serge-sans-paille requested review of D93095: Introduce -Wreserved-identifier.
Dec 11 2020, 2:03 AM

Dec 9 2020

serge-sans-paille added a comment to D92657: Fix interaction between clang and some inline builtins from glibc under _FORTIFY_SOURCE.

@rnk the new approach doesn't have the compilation time impact the previous had, still passes validation and a new test case has been added.

Dec 9 2020, 2:26 PM · Restricted Project
serge-sans-paille committed rG0ef0de65f14e: Fix typo in llvm/lib/Target/README.txt (authored by siddhesh).
Fix typo in llvm/lib/Target/README.txt
Dec 9 2020, 1:13 AM
serge-sans-paille closed D92914: Fix typo in llvm/lib/Target/README.txt.
Dec 9 2020, 1:12 AM · Restricted Project
serge-sans-paille accepted D92914: Fix typo in llvm/lib/Target/README.txt.
Dec 9 2020, 12:26 AM · Restricted Project

Dec 8 2020

serge-sans-paille updated the diff for D92657: Fix interaction between clang and some inline builtins from glibc under _FORTIFY_SOURCE.

Updated approach, much less costly: match the pattern of functions forwarding to self, as detecting if they're recursive doesn't match the reality of inline builtins.
The rational could be that if it's doing anything other than forwarding to self, then it's there on purpose and we shouldn't skip it.

Dec 8 2020, 12:36 AM · Restricted Project

Dec 7 2020

serge-sans-paille added inline comments to D92657: Fix interaction between clang and some inline builtins from glibc under _FORTIFY_SOURCE.
Dec 7 2020, 12:27 PM · Restricted Project
serge-sans-paille updated the diff for D92657: Fix interaction between clang and some inline builtins from glibc under _FORTIFY_SOURCE.

Update test case

Dec 7 2020, 12:22 PM · Restricted Project
serge-sans-paille updated the summary of D92657: Fix interaction between clang and some inline builtins from glibc under _FORTIFY_SOURCE.
Dec 7 2020, 9:40 AM · Restricted Project
serge-sans-paille added inline comments to D92657: Fix interaction between clang and some inline builtins from glibc under _FORTIFY_SOURCE.
Dec 7 2020, 9:17 AM · Restricted Project
serge-sans-paille updated the diff for D92657: Fix interaction between clang and some inline builtins from glibc under _FORTIFY_SOURCE.

Improve trivially recursive function detection

Dec 7 2020, 9:16 AM · Restricted Project

Dec 5 2020

serge-sans-paille committed rG9737c128f14d: [llvmbuildectomy] removed vestigial LLVMBuild.txt files (authored by CSears).
[llvmbuildectomy] removed vestigial LLVMBuild.txt files
Dec 5 2020, 1:01 PM
serge-sans-paille closed D92693: removed vestigial LLVMBuild.txt files.
Dec 5 2020, 1:00 PM · Restricted Project
serge-sans-paille added a comment to D92693: removed vestigial LLVMBuild.txt files.

Sure! Can you send me an email at sguelton@redhat.com with the email you want to use for authorship? Thanks!

Dec 5 2020, 10:17 AM · Restricted Project

Dec 4 2020

serge-sans-paille accepted D92693: removed vestigial LLVMBuild.txt files.

Some survivors!

Dec 4 2020, 10:43 PM · Restricted Project
serge-sans-paille added a comment to D92657: Fix interaction between clang and some inline builtins from glibc under _FORTIFY_SOURCE.

@nickdesaulniers I added you to the review because you bumped into the non-inling issue at the kernel level at some point.

Dec 4 2020, 2:16 PM · Restricted Project
serge-sans-paille retitled D92657: Fix interaction between clang and some inline builtins from glibc under _FORTIFY_SOURCE from [WIP] Fix interaction between clang and some inline builtins from glibc under _FORTIFY_SOURCE to Fix interaction between clang and some inline builtins from glibc under _FORTIFY_SOURCE.
Dec 4 2020, 2:15 PM · Restricted Project
serge-sans-paille updated the diff for D92657: Fix interaction between clang and some inline builtins from glibc under _FORTIFY_SOURCE.

Update documentation and tests

Dec 4 2020, 2:10 PM · Restricted Project
serge-sans-paille requested review of D92657: Fix interaction between clang and some inline builtins from glibc under _FORTIFY_SOURCE.
Dec 4 2020, 7:18 AM · Restricted Project
serge-sans-paille added a comment to D92245: -fstack-clash-protection: Return an actual error when used on unsupported OS.

How do things go wrong on Darwin? I was under the impression that this was implemented in LLVM as strictly inline code, no runtime support required.

That is my impression as well (although it seems that an earlier version might have emitted calls to a stack probe routine?)

Dec 4 2020, 1:21 AM · Restricted Project, Restricted Project

Dec 3 2020

serge-sans-paille committed rG9501419e879e: Speedup some unicode rendering (authored by serge-sans-paille).
Speedup some unicode rendering
Dec 3 2020, 11:11 AM
serge-sans-paille closed D92180: Speedup some unicode rendering.
Dec 3 2020, 11:11 AM · Restricted Project
serge-sans-paille updated the diff for D92180: Speedup some unicode rendering.

Update test

Dec 3 2020, 5:41 AM · Restricted Project
serge-sans-paille added inline comments to D92521: [tsan] Fix build failure with _FORTIFY_SOURCE.
Dec 3 2020, 1:49 AM · Restricted Project

Nov 30 2020

serge-sans-paille updated the diff for D92180: Speedup some unicode rendering.

Make the ascii test for isprintable locale-independent

Nov 30 2020, 8:04 AM · Restricted Project
serge-sans-paille added inline comments to D92180: Speedup some unicode rendering.
Nov 30 2020, 7:07 AM · Restricted Project
serge-sans-paille requested changes to D92100: [clang] do not limit -fstack-clash-protection to Linux.
Nov 30 2020, 5:56 AM
serge-sans-paille added a comment to D92100: [clang] do not limit -fstack-clash-protection to Linux.

The backend implementation of stack-clash-protection is incompatible with Windows, see https://github.com/llvm/llvm-project/blob/master/llvm/lib/Target/X86/X86FrameLowering.cpp#L486

Nov 30 2020, 5:56 AM
serge-sans-paille added a comment to D92309: [LegacyPM] Update InversedLastUser on the fly. NFC..

As the state of LastUser are closely tied, it would make sense to encapsulate the two members in a class that would maintain the consistency of these two states, so that the two new operations recordNewUser(Pass, User) and updatelastUser(Pass, User) become explicit ?

Nov 30 2020, 5:48 AM · Restricted Project
serge-sans-paille added a comment to D92291: clang/test: Remove platform-linker feature.

If that's okay with @leonardchan in terms of RISCV validation, I'm fine with that one. Any branch removed is less path to cover!

Nov 30 2020, 1:37 AM · Restricted Project, Restricted Project
serge-sans-paille added inline comments to D92245: -fstack-clash-protection: Return an actual error when used on unsupported OS.
Nov 30 2020, 12:49 AM · Restricted Project, Restricted Project

Nov 26 2020

serge-sans-paille committed rG1de56d6d13c0: [llvmbuildectomy] Also include component groups in llvm-config --components list (authored by mceier).
[llvmbuildectomy] Also include component groups in llvm-config --components list
Nov 26 2020, 12:07 PM
serge-sans-paille closed D92158: Also include component groups in llvm-config --components list.
Nov 26 2020, 12:07 PM · Restricted Project
serge-sans-paille accepted D92158: Also include component groups in llvm-config --components list.

Compiles fine with

Nov 26 2020, 11:57 AM · Restricted Project
serge-sans-paille added a comment to D92158: Also include component groups in llvm-config --components list.

I'm going to run a bunch of tests with different configuration before accepting :-)

Nov 26 2020, 7:56 AM · Restricted Project
serge-sans-paille requested review of D92180: Speedup some unicode rendering.
Nov 26 2020, 7:21 AM · Restricted Project
serge-sans-paille added a comment to D92158: Also include component groups in llvm-config --components list.

We already discussed this change on IRC, I'm fine with it, once the suggested renaming is done.

Nov 26 2020, 12:57 AM · Restricted Project

Nov 25 2020

serge-sans-paille added inline comments to D74704: Support -fuse-ld=lld for riscv.
Nov 25 2020, 1:50 AM · Restricted Project
serge-sans-paille added inline comments to D68720: Support -fstack-clash-protection for x86.
Nov 25 2020, 1:03 AM · Restricted Project, Restricted Project

Nov 19 2020

serge-sans-paille added a comment to D86126: Fix issue 47160: "`llvm::is_trivially_copyable` -- static assertion failure after DR 1734".

Some history on that particular problem: back to https://reviews.llvm.org/D54472 when we moved away from llvm::isPodLike<> in favor of llvm::is_trivially_copyable<>, the goal was to move to is_trivially_copyable once the minimal compiler requirements reaches a supported state.
So I'm not in favor of a diverging between the llvm and std implementation, but either

Nov 19 2020, 5:40 AM · Restricted Project
serge-sans-paille added a comment to D91677: Avoid simplification of library functions when callee has an implementation.

Interestingly, gcc and clang have different behavior here: https://godbolt.org/z/hdadhY
And clang already honors the user-defined bcopy why is -D_FORTIFY_SOURCE different from the example here?

Nov 19 2020, 2:54 AM · Restricted Project

Nov 18 2020

serge-sans-paille added a reverting change for rGc6ef6e1690d5: [build] normalize components dependencies: rG733f7b50840a: Revert "[build] normalize components dependencies".
Nov 18 2020, 10:23 AM
serge-sans-paille committed rG733f7b50840a: Revert "[build] normalize components dependencies" (authored by serge-sans-paille).
Revert "[build] normalize components dependencies"
Nov 18 2020, 10:23 AM
serge-sans-paille added a reverting change for D91461: [build] normalize components dependencies: rG733f7b50840a: Revert "[build] normalize components dependencies".
Nov 18 2020, 10:23 AM · Restricted Project
serge-sans-paille added a comment to D91461: [build] normalize components dependencies.

Or to put it the other way, LINK_COMPONENTS is not equivalent to target_link_libraries with the PUBLIC keyword.

Nov 18 2020, 7:54 AM · Restricted Project

Nov 17 2020

serge-sans-paille added a comment to D91677: Avoid simplification of library functions when callee has an implementation.

! In D91677#2401785, @siddhesh wrote:
Maybe because that D71082 is limited to clang? The bcopy survives clang but llvm forces it into a memmove without this patch.

Nov 17 2020, 11:51 PM · Restricted Project
serge-sans-paille added a comment to D91461: [build] normalize components dependencies.

@sbc100 Can you share your cmake configuration?

Nov 17 2020, 11:31 PM · Restricted Project
serge-sans-paille added a comment to D91677: Avoid simplification of library functions when callee has an implementation.

The problem you're trying to solve doesn't seem specific to bcopy: any function with an inline definition should probably *not* be replaced, and the inlined definition should be favored. This was the spirit of that patch https://reviews.llvm.org/D71082. i wonder why your test case doesn't fall into that configuration.

Nov 17 2020, 11:02 PM · Restricted Project
serge-sans-paille added a comment to D91641: [CMake] Fix ExtensionDependencies.inc with multiple extensions.

There seems to be one set of braces too much, makes me wonder how it ever worked.

Nov 17 2020, 10:05 PM · Restricted Project
serge-sans-paille added a comment to D91461: [build] normalize components dependencies.

@sbc100: This should be fixed by 6795984a47dfd2da4f451ad86a99021d6c9f85b5

Nov 17 2020, 1:06 PM · Restricted Project
serge-sans-paille added a comment to D91598: Allow packager to provide a default configuration file for clang.

Can you give an example of how this would be used to select the gcc-toolchain?

Nov 17 2020, 8:56 AM
serge-sans-paille added a comment to D91598: Allow packager to provide a default configuration file for clang.

I was thinking of `-Wl,--error-handling-script=/etc/clang/linker-script.sh` or something along the line. The initial goal would be to suggest installing the asan runtime if some asan symbols are missing.

Nov 17 2020, 5:13 AM
serge-sans-paille committed rG6795984a47df: [build] Fix dependencies of LLVMExegesis (authored by serge-sans-paille).
[build] Fix dependencies of LLVMExegesis
Nov 17 2020, 3:16 AM
serge-sans-paille committed rGc6ef6e1690d5: [build] normalize components dependencies (authored by serge-sans-paille).
[build] normalize components dependencies
Nov 17 2020, 1:44 AM
serge-sans-paille closed D91461: [build] normalize components dependencies.
Nov 17 2020, 1:44 AM · Restricted Project
serge-sans-paille added a comment to D91461: [build] normalize components dependencies.

All test green, @Meinersbur /@thopre

Nov 17 2020, 1:30 AM · Restricted Project
serge-sans-paille requested review of D91598: Allow packager to provide a default configuration file for clang.
Nov 17 2020, 1:21 AM

Nov 16 2020

serge-sans-paille added inline comments to D90848: llvmbuildectomy - part 2.
Nov 16 2020, 4:59 AM · Restricted Project
serge-sans-paille added inline comments to D90848: llvmbuildectomy - part 2.
Nov 16 2020, 3:16 AM · Restricted Project

Nov 15 2020

serge-sans-paille added a comment to D91461: [build] normalize components dependencies.

Tested with

Nov 15 2020, 11:58 PM · Restricted Project

Nov 14 2020

serge-sans-paille added inline comments to D91461: [build] normalize components dependencies.
Nov 14 2020, 12:14 PM · Restricted Project
serge-sans-paille updated the diff for D91461: [build] normalize components dependencies.

man do I feel stupid

Nov 14 2020, 12:13 PM · Restricted Project

Nov 13 2020

serge-sans-paille updated the diff for D91461: [build] normalize components dependencies.

s/LINK_COMPONENT/LINK_COMPONENTS

Nov 13 2020, 11:38 PM · Restricted Project