Page MenuHomePhabricator

tbaeder (Timm Bäder)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 2 2020, 4:41 AM (47 w, 1 d)

Recent Activity

Tue, Jan 19

tbaeder added a comment to D94873: [clang] [driver] Remove obsolete unistd.h include.

Pushed as b86e7ae66cb988dda33445c29fa64f93e7ca9c3c

Tue, Jan 19, 12:30 AM · Restricted Project
tbaeder committed rGb86e7ae66cb9: [clang][driver][NFC][obvious] Remove obsolete unistd.h include (authored by tbaeder).
[clang][driver][NFC][obvious] Remove obsolete unistd.h include
Tue, Jan 19, 12:29 AM

Sat, Jan 16

tbaeder requested review of D94873: [clang] [driver] Remove obsolete unistd.h include.
Sat, Jan 16, 11:05 PM · Restricted Project

Fri, Jan 15

tbaeder updated the diff for D84846: [MC] Add support for generating missing GNU build notes.

Sorry about the last change, that was the wrong patch.

Fri, Jan 15, 7:19 AM · Restricted Project, Restricted Project
tbaeder updated the diff for D84846: [MC] Add support for generating missing GNU build notes.
Fri, Jan 15, 7:18 AM · Restricted Project, Restricted Project

Tue, Jan 12

tbaeder added a comment to D93375: [clang][driver] Add -ansi option to CompileOnly group.

Thanks for the commits, Aaron. If you don't mind I have a short question: both commits don't seem to list the test cases, have they not been committed at all or are they filtered out in github and/or phabricator? Did I mess something up?

Tue, Jan 12, 9:17 PM · Restricted Project
tbaeder added a comment to D93375: [clang][driver] Add -ansi option to CompileOnly group.

Yes, I was gonna ask somebody else but if you have time, committing this one and https://reviews.llvm.org/D94478 would be nice

Tue, Jan 12, 10:04 AM · Restricted Project
tbaeder added a comment to D93375: [clang][driver] Add -ansi option to CompileOnly group.

And thank you for reviewing my patches :)

Tue, Jan 12, 9:52 AM · Restricted Project
tbaeder updated the diff for D93375: [clang][driver] Add -ansi option to CompileOnly group.
Tue, Jan 12, 9:14 AM · Restricted Project
tbaeder updated the diff for D93375: [clang][driver] Add -ansi option to CompileOnly group.

Okay, I've added a test and made sure it fails before and succeeds after this patch.

Tue, Jan 12, 9:06 AM · Restricted Project
tbaeder updated the diff for D94478: [clang] [lex] Return false from __has_declspec_attribute() if not explicitly enabled.

Thanks for the quick review. I've made the requested changes and added a proper commit message. I noticed I forgot that before.

Tue, Jan 12, 5:41 AM
tbaeder requested review of D94478: [clang] [lex] Return false from __has_declspec_attribute() if not explicitly enabled.
Tue, Jan 12, 1:53 AM

Fri, Jan 8

tbaeder added a comment to D93375: [clang][driver] Add -ansi option to CompileOnly group.

That sounds good but it's different to what this patch is trying to accomplish, isn't it? -ansi already doesn't get passed to the linker.
E.g. with clang 10.0.1 without this patch:

Fri, Jan 8, 1:04 AM · Restricted Project

Tue, Jan 5

tbaeder added a comment to D93375: [clang][driver] Add -ansi option to CompileOnly group.

I guess I could add a test for the example I posted, but I'm not sure of how much value that is. Or do you mean a test case that -ansi and -std=c89 behave the same in every situation?

Tue, Jan 5, 6:13 AM · Restricted Project

Mon, Jan 4

tbaeder added reviewers for D93375: [clang][driver] Add -ansi option to CompileOnly group: rsmith, aaron.ballman.
Mon, Jan 4, 1:05 AM · Restricted Project

Mon, Dec 28

tbaeder updated the diff for D93375: [clang][driver] Add -ansi option to CompileOnly group.

Rebased on lastest main branch and added a few more reviewers from git blame'ing the Options.td file

Mon, Dec 28, 10:34 AM · Restricted Project

Dec 15 2020

tbaeder requested review of D93375: [clang][driver] Add -ansi option to CompileOnly group.
Dec 15 2020, 11:52 PM · Restricted Project

Nov 27 2020

tbaeder added a comment to D84846: [MC] Add support for generating missing GNU build notes.

https://fedoraproject.org/wiki/Toolchain/Watermark Seems that .gnu.build.attributes is used with a GCC plugin (annobin?). The feature on its own is probably not that useful. .gnu.linkonce is a proto-comdat legacy feature which the patch should ignore.

Nov 27 2020, 2:03 AM · Restricted Project, Restricted Project
tbaeder added a comment to D90457: [clang][driver] Set LTO mode based on input files.

Is the motivation just to avoid -flto or -flto=lto at link time?

Nov 27 2020, 1:56 AM · Restricted Project

Oct 30 2020

tbaeder requested review of D90457: [clang][driver] Set LTO mode based on input files.
Oct 30 2020, 5:48 AM · Restricted Project

Oct 22 2020

tbaeder requested review of D89942: Disable LTO and LLD for bootstrap builds on systems unsupported by LLD.
Oct 22 2020, 3:03 AM · Restricted Project

Sep 2 2020

tbaeder added a comment to D84846: [MC] Add support for generating missing GNU build notes.

Ping

Sep 2 2020, 6:34 AM · Restricted Project, Restricted Project

Aug 21 2020

tbaeder added a reviewer for D84846: [MC] Add support for generating missing GNU build notes: pcc.
Aug 21 2020, 12:47 AM · Restricted Project, Restricted Project

Aug 10 2020

tbaeder updated the diff for D84846: [MC] Add support for generating missing GNU build notes.

Add a test that checks that clang accepts -Wa,--generate-missing-build-notes=yes and -Wa,--generate-missing-build-notes=no

Aug 10 2020, 3:48 AM · Restricted Project, Restricted Project

Jul 29 2020

tbaeder requested review of D84846: [MC] Add support for generating missing GNU build notes.
Jul 29 2020, 7:09 AM · Restricted Project, Restricted Project

Jun 5 2020

tbaeder added a comment to D75844: [clang] Set begin loc on GNU attribute parsed attrs.

I'm looking at this again and I am not sure how it is meant to work. For example in Parser::parseClassSpecifier in ParseDeclCXX.cpp.
Here attrs is a local variable of type ParsedAttributesWithRange, already before my patch. attrs is then passed to

Jun 5 2020, 6:33 AM · Restricted Project

Mar 31 2020

tbaeder added a comment to D75844: [clang] Set begin loc on GNU attribute parsed attrs.

Sorry for taking so long but it seems like I've went down a rabbit hole a bit. My previous patch sets the range in parseGNUAttributes() unconditionally, but that seems to trigger cases such as

Mar 31 2020, 1:37 AM · Restricted Project

Mar 23 2020

tbaeder added a comment to D75844: [clang] Set begin loc on GNU attribute parsed attrs.

Thanks, I'll take a look at the tests.

Mar 23 2020, 6:30 AM · Restricted Project

Mar 11 2020

tbaeder updated the diff for D75844: [clang] Set begin loc on GNU attribute parsed attrs.

Updated according to Aaron's comments. I'm not sure about changing the DeclSpec member and moving ParsedAttributesWithRange to ParsedAttr.h.

Mar 11 2020, 3:47 AM · Restricted Project

Mar 9 2020

tbaeder created D75844: [clang] Set begin loc on GNU attribute parsed attrs.
Mar 9 2020, 5:52 AM · Restricted Project

Mar 4 2020

tbaeder added a comment to D73852: [clang] detect switch fallthrough marked by a comment (PR43465).

I know this has been reverted, but for the record, the implementation has a few shortcomings that makes it hard to use it for projects that rely on fallthrough comments:

Mar 4 2020, 12:06 AM · Restricted Project

Mar 3 2020

tbaeder abandoned D75461: Ignore macro expansions when scanning for fallthrough comments.

fallthrough comment detection has been reverted, so abandon this in the meantime.

Mar 3 2020, 11:33 PM · Restricted Project

Mar 2 2020

tbaeder created D75461: Ignore macro expansions when scanning for fallthrough comments.
Mar 2 2020, 8:12 AM · Restricted Project