Page MenuHomePhabricator

IR: Move denormal mode parsing from MachineFunction to Function
ClosedPublic

Authored by arsenm on Sep 17 2020, 3:42 PM.

Details

Summary

This was just inspecting the IR to begin with, and is useful to check
in some places in the IR.

Diff Detail

Event Timeline

arsenm created this revision.Sep 17 2020, 3:42 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 17 2020, 3:42 PM
Herald added a subscriber: hiraditya. · View Herald Transcript
arsenm requested review of this revision.Sep 17 2020, 3:42 PM
jdoerfert accepted this revision.Sep 17 2020, 5:19 PM

LGTM, one nit you might want to consider

llvm/lib/CodeGen/MachineFunction.cpp
277

Is the TODO still accurate? We seem to go in the opposite direction.

This revision is now accepted and ready to land.Sep 17 2020, 5:19 PM
arsenm added inline comments.Sep 18 2020, 6:16 AM
llvm/lib/CodeGen/MachineFunction.cpp
277

Well I think it should be cached somewhere rather than string parsing every time you want to query this (this will just happen more frequently in codegen)