Page MenuHomePhabricator

Temporary fix for debug loc list bug with basic block sections
ClosedPublic

Authored by tmsriram on Wed, Sep 16, 12:38 PM.

Details

Summary

The proper fix for this is being worked out in D85085.

Until then, this one line fix removes the assert fail with basic block sections with debug info. Bug tracking this: #47549
This fix does not generate loc list or DW_AT_const_value if the argument is mentioned in a different section than the start of the function.

Temporarily fixes bugzilla : https://bugs.llvm.org/show_bug.cgi?id=47549

Diff Detail

Event Timeline

tmsriram created this revision.Wed, Sep 16, 12:38 PM
Herald added a project: Restricted Project. · View Herald TranscriptWed, Sep 16, 12:38 PM
tmsriram requested review of this revision.Wed, Sep 16, 12:38 PM
tmsriram edited the summary of this revision. (Show Details)Wed, Sep 16, 12:44 PM

Could you include the source and any command lines (clang, what optimization level, etc) was used to generate the test IR? It can make the test a bit easier to read at a glance and help if the test needs to be regenerated for some reason.

Could you include the source and any command lines (clang, what optimization level, etc) was used to generate the test IR? It can make the test a bit easier to read at a glance and help if the test needs to be regenerated for some reason.

The test IR was reduced using a reduce tool so we don't have the source unfortunately. We tried hard to generate C programs that would show this failure but with no avail.

dblaikie accepted this revision.Mon, Sep 21, 5:25 PM

sounds good - thanks!

This revision is now accepted and ready to land.Mon, Sep 21, 5:25 PM

ping @tmsriram
Lets push this if it's good to go?