Page MenuHomePhabricator

snehasish (Snehasish Kumar)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 10 2017, 12:15 PM (188 w, 11 h)

Recent Activity

Dec 8 2020

snehasish added a comment to D92882: [MBP] Prevent rotating a chain contains entry block.

Can we add a test for this?

Dec 8 2020, 2:35 PM · Restricted Project

Nov 9 2020

snehasish committed rG67cbd20469f1: [llvm] Check the debug info line table for basic block sections. (authored by snehasish).
[llvm] Check the debug info line table for basic block sections.
Nov 9 2020, 12:21 PM
snehasish closed D90989: [llvm] Check the debug info line table for basic block sections..
Nov 9 2020, 12:21 PM · Restricted Project
snehasish added a comment to D90989: [llvm] Check the debug info line table for basic block sections..

Thanks for the review David. I've added the addresses to the test for now. Extending the verbose output for dwarfdump seems like a good idea, we will look into adding that in the future.

Nov 9 2020, 11:24 AM · Restricted Project
snehasish updated the diff for D90989: [llvm] Check the debug info line table for basic block sections..

Check addresses as well, simplify triple.

Nov 9 2020, 11:11 AM · Restricted Project

Nov 6 2020

snehasish abandoned D90717: [llvm] Add a test for debug info generated with split functions..
Nov 6 2020, 4:31 PM · Restricted Project
snehasish requested review of D90989: [llvm] Check the debug info line table for basic block sections..
Nov 6 2020, 4:26 PM · Restricted Project

Nov 5 2020

snehasish added inline comments to D90717: [llvm] Add a test for debug info generated with split functions..
Nov 5 2020, 6:15 PM · Restricted Project
snehasish added a comment to D90717: [llvm] Add a test for debug info generated with split functions..

Thanks for the review all. I've updated the test to use llvm-dwarfdump to check that the line table is as expected for the hot and cold parts.

Nov 5 2020, 3:39 PM · Restricted Project
snehasish updated the diff for D90717: [llvm] Add a test for debug info generated with split functions..

Updates based on review comments.

Nov 5 2020, 3:32 PM · Restricted Project

Nov 3 2020

snehasish added a comment to D90717: [llvm] Add a test for debug info generated with split functions..

Thanks for the quick review @saugustine , I'll wait for @tmsriram take a look.

Nov 3 2020, 3:37 PM · Restricted Project
snehasish updated the diff for D90717: [llvm] Add a test for debug info generated with split functions..

Add UNSUPPORTED tag for windows and mac os.

Nov 3 2020, 3:35 PM · Restricted Project
snehasish requested review of D90717: [llvm] Add a test for debug info generated with split functions..
Nov 3 2020, 2:29 PM · Restricted Project

Oct 26 2020

snehasish accepted D90081: Test lldb backtraces with machine function splitter.

lgtm, thanks for adding the test.

Oct 26 2020, 10:25 AM · Restricted Project

Oct 24 2020

snehasish added inline comments to D90081: Test lldb backtraces with machine function splitter.
Oct 24 2020, 10:44 AM · Restricted Project

Oct 23 2020

snehasish added inline comments to D90081: Test lldb backtraces with machine function splitter.
Oct 23 2020, 7:00 PM · Restricted Project

Oct 15 2020

snehasish added inline comments to D89423: Explicitly check for entry basic block, rather than relying on MachineBasicBlock::pred_empty..
Oct 15 2020, 10:27 AM · Restricted Project

Oct 14 2020

snehasish committed rG24bf6ff4e08f: [llvm] Update default cutoff threshold for machine function splitter. (authored by snehasish).
[llvm] Update default cutoff threshold for machine function splitter.
Oct 14 2020, 12:51 PM
snehasish closed D89085: [llvm] Update default cutoff threshold for machine function splitter..
Oct 14 2020, 12:51 PM · Restricted Project
snehasish committed rG77638a5343d5: [llvm] Set the default for -bbsections-cold-text-prefix to .text.split. (authored by snehasish).
[llvm] Set the default for -bbsections-cold-text-prefix to .text.split.
Oct 14 2020, 12:29 PM
snehasish closed D88997: Set the default for -bbsections-cold-text-prefix to .text.split..
Oct 14 2020, 12:29 PM · Restricted Project

Oct 13 2020

snehasish updated the diff for D88997: Set the default for -bbsections-cold-text-prefix to .text.split..

Rebase.

Oct 13 2020, 11:13 PM · Restricted Project
snehasish added a comment to D89085: [llvm] Update default cutoff threshold for machine function splitter..

Thanks for the review.

Oct 13 2020, 11:10 PM · Restricted Project
snehasish updated the diff for D89085: [llvm] Update default cutoff threshold for machine function splitter..

Add comments, rebase.

Oct 13 2020, 11:09 PM · Restricted Project

Oct 8 2020

snehasish added a comment to D88997: Set the default for -bbsections-cold-text-prefix to .text.split..

Thanks for the review.

Oct 8 2020, 6:38 PM · Restricted Project
snehasish updated the diff for D88997: Set the default for -bbsections-cold-text-prefix to .text.split..

Update prefix to .text.split.

Oct 8 2020, 6:36 PM · Restricted Project
snehasish added a comment to D89085: [llvm] Update default cutoff threshold for machine function splitter..

PTAL, thanks!

Oct 8 2020, 6:32 PM · Restricted Project
snehasish updated the diff for D89085: [llvm] Update default cutoff threshold for machine function splitter..

Spell out TTI as TargetTransformInfo, rebase.

Oct 8 2020, 6:32 PM · Restricted Project
snehasish updated the diff for D88997: Set the default for -bbsections-cold-text-prefix to .text.split..

Update comment and rebase.

Oct 8 2020, 6:24 PM · Restricted Project
snehasish added a comment to D89085: [llvm] Update default cutoff threshold for machine function splitter..

This pass is only enabled on X86 platforms (D87047 for clang options and platform check). Longer term it does make sense to move it to TTI so I've added a FIXME to get this change off the critical path and I'll follow up with a refactoring change.

Oct 8 2020, 6:17 PM · Restricted Project
snehasish updated the diff for D89085: [llvm] Update default cutoff threshold for machine function splitter..

Add a FIXME to move defaults to TTI.

Oct 8 2020, 6:14 PM · Restricted Project
snehasish requested review of D89085: [llvm] Update default cutoff threshold for machine function splitter..
Oct 8 2020, 5:47 PM · Restricted Project

Oct 7 2020

snehasish updated the diff for D88997: Set the default for -bbsections-cold-text-prefix to .text.split..

Updated tests to use .text.split. prefix.

Oct 7 2020, 12:10 PM · Restricted Project
snehasish abandoned D88996: Set the default for -bbsections-cold-text-prefix to .text.split..
Oct 7 2020, 11:56 AM · Restricted Project
snehasish updated the summary of D88996: Set the default for -bbsections-cold-text-prefix to .text.split..
Oct 7 2020, 11:56 AM · Restricted Project
snehasish requested review of D88997: Set the default for -bbsections-cold-text-prefix to .text.split..
Oct 7 2020, 11:54 AM · Restricted Project
snehasish requested review of D88996: Set the default for -bbsections-cold-text-prefix to .text.split..
Oct 7 2020, 11:50 AM · Restricted Project

Oct 6 2020

snehasish added inline comments to D88517: [BasicBlockSections] Make sure that the labels for address-taken blocks are emitted after switching the seciton..
Oct 6 2020, 5:00 PM · Restricted Project
snehasish accepted D88517: [BasicBlockSections] Make sure that the labels for address-taken blocks are emitted after switching the seciton..

lgtm with some minor comments.

Oct 6 2020, 3:29 PM · Restricted Project

Sep 25 2020

snehasish removed reviewers for D88041: [lld] Add a flag to enable split machine functions for LTO.: MaskRay, tejohnson, espindola.
Sep 25 2020, 1:15 PM · Restricted Project
snehasish added a comment to D88041: [lld] Add a flag to enable split machine functions for LTO..

Let me look into module flags a little bit and I'll come back to this patch once I have a better understanding. Thanks for the comments!

Sep 25 2020, 1:14 PM · Restricted Project

Sep 24 2020

snehasish committed rGd2696dec45cd: [llvm] Add -bbsections-cold-text-prefix to emit cold clusters to a different… (authored by snehasish).
[llvm] Add -bbsections-cold-text-prefix to emit cold clusters to a different…
Sep 24 2020, 3:30 PM
snehasish closed D87813: [llvm] Add -bbsections-cold-text-prefix to emit cold clusters to a different section..
Sep 24 2020, 3:30 PM · Restricted Project
snehasish added a comment to D87813: [llvm] Add -bbsections-cold-text-prefix to emit cold clusters to a different section..

Thanks for the review.

Sep 24 2020, 3:16 PM · Restricted Project
snehasish updated the diff for D87813: [llvm] Add -bbsections-cold-text-prefix to emit cold clusters to a different section..

Update comment, test.

Sep 24 2020, 3:13 PM · Restricted Project
snehasish committed rG070555c6c008: [lld] Make -z keep-text-section-prefix recognize .text.split. as a prefix. (authored by snehasish).
[lld] Make -z keep-text-section-prefix recognize .text.split. as a prefix.
Sep 24 2020, 3:06 PM
snehasish closed D87840: [lld] Make -z keep-text-section-prefix recognize .text.split. as a prefix..
Sep 24 2020, 3:06 PM · Restricted Project
snehasish added a comment to D87840: [lld] Make -z keep-text-section-prefix recognize .text.split. as a prefix..

Updated description and tests, PTAL thanks!

Sep 24 2020, 2:45 PM · Restricted Project
snehasish retitled D87840: [lld] Make -z keep-text-section-prefix recognize .text.split. as a prefix. from [lld] Add a new known text prefix - ".text.split." to [lld] Make -z keep-text-section-prefix recognize .text.split. as a prefix..
Sep 24 2020, 2:44 PM · Restricted Project
snehasish updated the diff for D87840: [lld] Make -z keep-text-section-prefix recognize .text.split. as a prefix..

Update description, add test.

Sep 24 2020, 2:44 PM · Restricted Project
snehasish retitled D87813: [llvm] Add -bbsections-cold-text-prefix to emit cold clusters to a different section. from [llvm]Add an option to emit cold clusters to a different section. to [llvm] Add -bbsections-cold-text-prefix to emit cold clusters to a different section..
Sep 24 2020, 2:25 PM · Restricted Project
snehasish updated the diff for D87813: [llvm] Add -bbsections-cold-text-prefix to emit cold clusters to a different section..

Update git commit message to specify option.

Sep 24 2020, 2:25 PM · Restricted Project
snehasish added a comment to D87813: [llvm] Add -bbsections-cold-text-prefix to emit cold clusters to a different section..

PTAL, thanks!

Sep 24 2020, 2:20 PM · Restricted Project
snehasish updated the diff for D87813: [llvm] Add -bbsections-cold-text-prefix to emit cold clusters to a different section..

Add another check for the test.

Sep 24 2020, 2:19 PM · Restricted Project
snehasish updated the diff for D87813: [llvm] Add -bbsections-cold-text-prefix to emit cold clusters to a different section..

Document flag, tighten test, rename var and option for clarity.

Sep 24 2020, 2:17 PM · Restricted Project
snehasish added a comment to D87787: Temporary fix for debug loc list bug with basic block sections.

ping @tmsriram
Lets push this if it's good to go?

Sep 24 2020, 8:42 AM · Restricted Project

Sep 22 2020

snehasish updated subscribers of D88041: [lld] Add a flag to enable split machine functions for LTO..

Is it expected that the user will want to specify this only at link time and not during compile time? If it is normally specified in the compile step, you should consider adding it to the IR in some fashion (e.g. function attributes). The advantage is that the user doesn't need to pass different options for the LTO and non-LTO cases.

Ideally we should only have to specify this once. However, using function attributes doesn't seem ideal since the pass will be scheduled and repeatedly invoked only to return without actually running the pass. It would be cleaner to marshal the codegen specific options from the compile invocation and restore them for the LTO step. There are a couple of other codegen options which would also benefit from this approach --lto-unique-basic-block-section-names, --lto-basic-block-sections=<value>. @mtrofin pointed out that -fembed-bitcode saves the invocation in .llvmcmd. A similar approach to stash codegen specific options always for LTO to pick up and enable might be less intrusive. However, this is a larger effort and for current LTO builds it would be nice to have a command line option to enable it. WDYT about this alternative?

Sep 22 2020, 3:42 PM · Restricted Project

Sep 21 2020

snehasish added a comment to D87813: [llvm] Add -bbsections-cold-text-prefix to emit cold clusters to a different section..

ping @tmsriram @MaskRay

Sep 21 2020, 2:42 PM · Restricted Project
snehasish retitled D87813: [llvm] Add -bbsections-cold-text-prefix to emit cold clusters to a different section. from [llvm][lld] Add an option to emit cold clusters to a different section. to [llvm]Add an option to emit cold clusters to a different section..
Sep 21 2020, 2:42 PM · Restricted Project
snehasish updated the diff for D87813: [llvm] Add -bbsections-cold-text-prefix to emit cold clusters to a different section..

Rebase and update git commit message.

Sep 21 2020, 2:41 PM · Restricted Project
snehasish requested review of D88041: [lld] Add a flag to enable split machine functions for LTO..
Sep 21 2020, 12:48 PM · Restricted Project

Sep 18 2020

snehasish committed rGb86f1af42395: [clang] Remove profile available check for fsplit-machine-functions. (authored by snehasish).
[clang] Remove profile available check for fsplit-machine-functions.
Sep 18 2020, 3:20 PM
snehasish closed D87943: [clang] Remove profile available check for fsplit-machine-functions..
Sep 18 2020, 3:20 PM · Restricted Project
snehasish retitled D87943: [clang] Remove profile available check for fsplit-machine-functions. from [clang] Remove profile availabile check for fsplit-machine-functions. to [clang] Remove profile available check for fsplit-machine-functions..
Sep 18 2020, 2:33 PM · Restricted Project
snehasish added a comment to D87943: [clang] Remove profile available check for fsplit-machine-functions..

Thanks for the quick review!

Sep 18 2020, 2:29 PM · Restricted Project
snehasish updated the diff for D87943: [clang] Remove profile available check for fsplit-machine-functions..

Drop braces, add a test.

Sep 18 2020, 2:28 PM · Restricted Project
snehasish requested review of D87943: [clang] Remove profile available check for fsplit-machine-functions..
Sep 18 2020, 2:13 PM · Restricted Project

Sep 17 2020

snehasish added a comment to D87840: [lld] Make -z keep-text-section-prefix recognize .text.split. as a prefix..

Carrying over the discussion from D87813 since it's more appropriate here:

Sep 17 2020, 12:21 PM · Restricted Project
snehasish updated the summary of D87813: [llvm] Add -bbsections-cold-text-prefix to emit cold clusters to a different section..
Sep 17 2020, 10:18 AM · Restricted Project
snehasish added inline comments to D87813: [llvm] Add -bbsections-cold-text-prefix to emit cold clusters to a different section..
Sep 17 2020, 10:18 AM · Restricted Project
snehasish updated the diff for D87813: [llvm] Add -bbsections-cold-text-prefix to emit cold clusters to a different section..

Drop lld/ELF/Writer.cpp changes.

Sep 17 2020, 10:17 AM · Restricted Project
snehasish requested review of D87840: [lld] Make -z keep-text-section-prefix recognize .text.split. as a prefix..
Sep 17 2020, 10:07 AM · Restricted Project

Sep 16 2020

snehasish requested review of D87813: [llvm] Add -bbsections-cold-text-prefix to emit cold clusters to a different section..
Sep 16 2020, 9:54 PM · Restricted Project

Sep 15 2020

snehasish committed rGf1a3ab904439: [clang] Add a command line flag for the Machine Function Splitter. (authored by snehasish).
[clang] Add a command line flag for the Machine Function Splitter.
Sep 15 2020, 12:43 PM
snehasish closed D87047: [clang] Add command line options for the Machine Function Splitter..
Sep 15 2020, 12:43 PM · Restricted Project
snehasish added a comment to D87047: [clang] Add command line options for the Machine Function Splitter..

Thanks for the review.

Sep 15 2020, 11:27 AM · Restricted Project
snehasish updated the diff for D87047: [clang] Add command line options for the Machine Function Splitter..

Update the test.

Sep 15 2020, 11:23 AM · Restricted Project

Sep 14 2020

snehasish updated the diff for D87047: [clang] Add command line options for the Machine Function Splitter..

Remove unnecessary includes, update doc text.

Sep 14 2020, 9:36 PM · Restricted Project
snehasish added a comment to D87047: [clang] Add command line options for the Machine Function Splitter..

That makes sense. I moved the check to lib/Driver/ToolChains/Clang.cpp and updated the test. Seems cleaner to have all the checks in one place.
PTAL, thanks.

Sep 14 2020, 9:15 PM · Restricted Project
snehasish updated the diff for D87047: [clang] Add command line options for the Machine Function Splitter..

Check profile flag in Driver, update test.

Sep 14 2020, 9:11 PM · Restricted Project
snehasish added inline comments to D87047: [clang] Add command line options for the Machine Function Splitter..
Sep 14 2020, 7:17 PM · Restricted Project
snehasish updated the diff for D87047: [clang] Add command line options for the Machine Function Splitter..

Remove extra -c from test command line.

Sep 14 2020, 7:11 PM · Restricted Project
snehasish added a comment to D87047: [clang] Add command line options for the Machine Function Splitter..

@MaskRay ping, let me know if you have any further comments. Thanks!

Sep 14 2020, 4:38 PM · Restricted Project
snehasish updated the diff for D87047: [clang] Add command line options for the Machine Function Splitter..

Rebased patch.

Sep 14 2020, 4:26 PM · Restricted Project

Sep 11 2020

snehasish updated subscribers of D87047: [clang] Add command line options for the Machine Function Splitter..

It feels wrong that the assembly+llvm-profdata test is in clang/test

I agree with @dblaikie and your assessment that it feels wrong to add such a test to clang. In the first version of this patch, the test served the purpose of representing the canonical usage with profdata as well as check for the plumbing of the profile along with the presence of the flag. Enhancing the driver test removed the need for the former while adding a diagnostic warning message (and a check for it) removes the need for the latter. I've removed the clang codegen test.

Sep 11 2020, 11:34 AM · Restricted Project
snehasish updated the diff for D87047: [clang] Add command line options for the Machine Function Splitter..

Remove clang/CodeGen test, update arg render logic.

Sep 11 2020, 11:27 AM · Restricted Project

Sep 10 2020

snehasish added inline comments to D87047: [clang] Add command line options for the Machine Function Splitter..
Sep 10 2020, 8:55 PM · Restricted Project
snehasish updated the diff for D87047: [clang] Add command line options for the Machine Function Splitter..

Fix test formatting.

Sep 10 2020, 8:54 PM · Restricted Project
snehasish added a comment to D87047: [clang] Add command line options for the Machine Function Splitter..

PTAL, thanks!

Sep 10 2020, 5:58 PM · Restricted Project
snehasish updated the diff for D87047: [clang] Add command line options for the Machine Function Splitter..

Use OptInFFlag, split-file and update tests.

Sep 10 2020, 5:50 PM · Restricted Project
snehasish updated the summary of D87047: [clang] Add command line options for the Machine Function Splitter..
Sep 10 2020, 12:33 PM · Restricted Project
snehasish updated the summary of D87047: [clang] Add command line options for the Machine Function Splitter..
Sep 10 2020, 12:32 PM · Restricted Project
snehasish updated the diff for D87047: [clang] Add command line options for the Machine Function Splitter..

Check warning, specify target to avoid failures on windows.

Sep 10 2020, 12:31 PM · Restricted Project
snehasish updated the diff for D87047: [clang] Add command line options for the Machine Function Splitter..

Updated test and warning type.

Sep 10 2020, 12:07 PM · Restricted Project
snehasish committed rG157cd93b48a9: [clang] Disallow fbasic-block-sections on non-ELF, non-x86 targets. (authored by snehasish).
[clang] Disallow fbasic-block-sections on non-ELF, non-x86 targets.
Sep 10 2020, 12:20 AM
snehasish closed D87426: Disallow fbasic-block-sections on non-ELF, non-x86 targets..
Sep 10 2020, 12:20 AM · Restricted Project
snehasish added a comment to D87426: Disallow fbasic-block-sections on non-ELF, non-x86 targets..

Thanks for explaining the rationale, PTAL.

Sep 10 2020, 12:04 AM · Restricted Project
snehasish updated the diff for D87426: Disallow fbasic-block-sections on non-ELF, non-x86 targets..

Update test to use not tool and -c flag.

Sep 10 2020, 12:00 AM · Restricted Project

Sep 9 2020

snehasish added a comment to D87426: Disallow fbasic-block-sections on non-ELF, non-x86 targets..

Thanks for the quick review @MaskRay, PTAL.

Sep 9 2020, 8:58 PM · Restricted Project
snehasish updated the diff for D87426: Disallow fbasic-block-sections on non-ELF, non-x86 targets..

Update test based on review comments.

Sep 9 2020, 8:52 PM · Restricted Project