Page MenuHomePhabricator

[ARM] Skip combining base updates for vld1x NEON intrinsics
ClosedPublic

Authored by SjoerdMeijer on Aug 28 2020, 7:01 AM.

Details

Summary

Skip this for now, to avoid a back-end crash in:

UNREACHABLE executed at /disk/llvm/llvm-project/llvm/lib/Target/ARM/ARMISelLowering.cpp:13412

This should fix PR45824.

Diff Detail

Event Timeline

SjoerdMeijer created this revision.Aug 28 2020, 7:01 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 28 2020, 7:01 AM
SjoerdMeijer requested review of this revision.Aug 28 2020, 7:01 AM
dmgreen accepted this revision.Aug 28 2020, 7:12 AM

LGTM.

llvm/test/CodeGen/ARM/pr45824.ll
30

You can possibly simplify these tests a bit. Something like the tests in mve-vld2-post.ll might work, which return the postinc value.

This revision is now accepted and ready to land.Aug 28 2020, 7:12 AM
SjoerdMeijer added inline comments.Aug 28 2020, 12:26 PM
llvm/test/CodeGen/ARM/pr45824.ll
30

Hi Dave, thanks for looking, and you're right that the test can be simplified. I had a quick look, but need more time for this. That's why I will commit this first to unblock other work, and follow up on this to simplify the tests when I am back in the office.

SjoerdMeijer added inline comments.Mon, Sep 7, 7:21 AM
llvm/test/CodeGen/ARM/pr45824.ll
30

FYI: I've committed a slightly reduced test case in rG288c582fc939. I couldn't really get it down to something smaller than this and still trigger the bug.