Page MenuHomePhabricator

GlobalISel: Port smarter known bits for umin/umax from DAG
ClosedPublic

Authored by arsenm on Thu, Aug 27, 4:39 PM.

Diff Detail

Event Timeline

arsenm created this revision.Thu, Aug 27, 4:39 PM
Herald added a project: Restricted Project. · View Herald TranscriptThu, Aug 27, 4:39 PM
arsenm requested review of this revision.Thu, Aug 27, 4:39 PM
paquette accepted this revision.Tue, Sep 1, 9:33 AM

LGTM

This revision is now accepted and ready to land.Tue, Sep 1, 9:33 AM
foad added a subscriber: foad.Thu, Sep 3, 11:14 AM
foad added inline comments.
llvm/unittests/CodeGen/GlobalISel/KnownBitsTest.cpp
725–726

These lines look spurious, or did you mean to test something different here?

arsenm added inline comments.Thu, Sep 3, 11:21 AM
llvm/unittests/CodeGen/GlobalISel/KnownBitsTest.cpp
725–726

Not sure what you mean

foad added inline comments.Thu, Sep 3, 11:25 AM
llvm/unittests/CodeGen/GlobalISel/KnownBitsTest.cpp
725–726

The last two lines are just duplicates of the previous two lines.