This is an archive of the discontinued LLVM Phabricator instance.

[utils] Python utils script extract_vplan.py to extract VPlan digraphs regexp fix
ClosedPublic

Authored by Kazhuu on Aug 17 2020, 5:49 AM.

Details

Summary

Regarding this bug in Bugzilla: https://bugs.llvm.org/show_bug.cgi?id=46451

I went ahead and fixed the regexp pattern and now Python script is able to extract vplan graphs from the log files. Additionally some test for this would be nice to have but I'm not sure are Python scripts tested in LLVM and if so where they live.

Diff Detail

Event Timeline

Kazhuu created this revision.Aug 17 2020, 5:49 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 17 2020, 5:49 AM
Kazhuu requested review of this revision.Aug 17 2020, 5:49 AM
Kazhuu retitled this revision from Python utils script extract_vplan.py to extract VPlan digraphs regexp fix to [utils] Python utils script extract_vplan.py to extract VPlan digraphs regexp fix.Aug 17 2020, 6:21 AM
fhahn accepted this revision.Aug 17 2020, 6:47 AM
fhahn added a subscriber: fhahn.

LGTM thanks, the , was indeed dropped.

This revision is now accepted and ready to land.Aug 17 2020, 6:47 AM

I need someone else to commit this patch for me. Commit can be made with name Mauri Mustonen and email mauri_mustonen@hotmail.com.