Page MenuHomePhabricator

lattner (Chris Lattner)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 28 2016, 7:50 PM (237 w, 4 d)

Recent Activity

Yesterday

lattner added a comment to D94832: [mlir] Add a new builtin `unrealized_conversion_cast` operation.

+1, thanks River

Fri, Jan 15, 10:35 PM · Restricted Project
lattner added a comment to D94831: [mlir] Add an interface for Cast-Like operations.

ok

Fri, Jan 15, 10:28 PM · Restricted Project
lattner accepted D94832: [mlir] Add a new builtin `unrealized_conversion_cast` operation.
Fri, Jan 15, 10:27 PM · Restricted Project
lattner accepted D94832: [mlir] Add a new builtin `unrealized_conversion_cast` operation.

Looking forward to this!!

Fri, Jan 15, 5:37 PM · Restricted Project
lattner accepted D94831: [mlir] Add an interface for Cast-Like operations.

nice!

Fri, Jan 15, 5:29 PM · Restricted Project

Tue, Jan 12

lattner accepted D94575: [mlir][OpFormatGen] Format enum attribute cases as keywords when possible.

This is so so so awesome, thank you for doing this!

Tue, Jan 12, 11:00 PM · Restricted Project

Mon, Jan 11

lattner accepted D94412: [TableGen] Improve error message for semicolon after braced body.

Looks great, thanks Paul!

Mon, Jan 11, 9:53 PM · Restricted Project

Sun, Jan 10

lattner committed rGdcac2da10632: [IR Parser] Fix a crash handling zero width integer attributes. (authored by lattner).
[IR Parser] Fix a crash handling zero width integer attributes.
Sun, Jan 10, 9:18 PM
lattner added a comment to D94384: [IR Parser] Fix a crash handling zero width integer attributes..

Thx for the quick review!

Sun, Jan 10, 9:18 PM · Restricted Project
lattner closed D94384: [IR Parser] Fix a crash handling zero width integer attributes..
Sun, Jan 10, 9:18 PM · Restricted Project
lattner added reviewers for D94384: [IR Parser] Fix a crash handling zero width integer attributes.: mehdi_amini, jpienaar.
Sun, Jan 10, 6:34 PM · Restricted Project
lattner requested review of D94384: [IR Parser] Fix a crash handling zero width integer attributes..
Sun, Jan 10, 6:33 PM · Restricted Project

Sat, Jan 9

lattner accepted D94370: [mlir][CAPI] Introduce standard source layout for mlir-c dialect registration..

nice

Sat, Jan 9, 9:04 PM · Restricted Project
lattner added a comment to D94274: [mlir][TypeDefGen] Add support for adding builders when generating a TypeDef.

It looks like I didn't file a PR about this

Sat, Jan 9, 4:59 PM · Restricted Project
lattner updated subscribers of D94274: [mlir][TypeDefGen] Add support for adding builders when generating a TypeDef.

@jdd fyi

Sat, Jan 9, 10:52 AM · Restricted Project
lattner accepted D94274: [mlir][TypeDefGen] Add support for adding builders when generating a TypeDef.

Awesome, thank you for implementing this. The documentation and implementation look really really great, I'm excited to see this River!

Sat, Jan 9, 10:51 AM · Restricted Project

Wed, Jan 6

lattner committed rG7510c1152f0b: Update for review feedback: Inline var declaration and expand names. (authored by lattner).
Update for review feedback: Inline var declaration and expand names.
Wed, Jan 6, 9:00 PM
lattner committed rG25f23a60398e: [AsmPrinter] Make OpAsmPrinter::printFunctionalType be resilient to null values. (authored by lattner).
[AsmPrinter] Make OpAsmPrinter::printFunctionalType be resilient to null values.
Wed, Jan 6, 9:00 PM
lattner closed D94208: Update for review feedback: Inline var declaration and expand names..
Wed, Jan 6, 9:00 PM · Restricted Project
lattner closed D93908: [AsmPrinter] Make OpAsmPrinter::printFunctionalType be resilient to null values..
Wed, Jan 6, 9:00 PM · Restricted Project
lattner requested review of D94208: Update for review feedback: Inline var declaration and expand names..
Wed, Jan 6, 5:39 PM · Restricted Project
lattner accepted D93911: [TableGen] Add the assert statement, step 1.
Wed, Jan 6, 5:19 PM · Restricted Project
lattner accepted D94116: Update the maximum integer bitwidth in MLIR. .

Nice, thanks darthscsi

Wed, Jan 6, 5:16 PM · Restricted Project

Tue, Jan 5

lattner added a comment to D94116: Update the maximum integer bitwidth in MLIR. .

LLVM uses "MAX_INT_BITS = (1<<24)-1". Unless there is a reason to be different, it would probably be good to align with that.

Tue, Jan 5, 9:17 PM · Restricted Project
lattner added a comment to D93911: [TableGen] Add the assert statement, step 1.

Fair enough, good point. In C, it is a function, whereas in tblgen it is a declaration. I'm ok dropping the parens.

Tue, Jan 5, 11:15 AM · Restricted Project
lattner added a comment to D93911: [TableGen] Add the assert statement, step 1.

Looks like a great feature to me! I'd recommend requiring the message, I'd also consider requiring parens around the condition and message. This makes it more C like and makes it look less like a type definition:

Tue, Jan 5, 10:37 AM · Restricted Project
lattner added a comment to D93969: [TableGen] Add field kind to the RecordVal class..

I'm ok with this, your expertise surpasses mine Paul :-)

Tue, Jan 5, 10:34 AM · Restricted Project

Tue, Dec 29

lattner added a comment to D93869: [IR] Make Value::getType() work better with invalid IR..

Alternate approach is here: https://reviews.llvm.org/D93908

Tue, Dec 29, 11:06 AM · Restricted Project
lattner requested review of D93908: [AsmPrinter] Make OpAsmPrinter::printFunctionalType be resilient to null values..
Tue, Dec 29, 11:06 AM · Restricted Project
lattner added a comment to D93869: [IR] Make Value::getType() work better with invalid IR..

I'm preparing a patch to deabstract this, but it is ugly. The other middle-ground approach is to change ValueTypeIterator to do the null check.

Tue, Dec 29, 10:56 AM · Restricted Project
lattner added inline comments to D93869: [IR] Make Value::getType() work better with invalid IR..
Tue, Dec 29, 10:29 AM · Restricted Project

Mon, Dec 28

lattner accepted D93864: [TableGen] Continue cleaning up .td files.

This all looks reasonable to me Paul. One thing you can check to gain confidence is that the output of tblgen should be bitwise identical on all the generated .inc files.

Mon, Dec 28, 6:17 PM · Restricted Project, Restricted Project
lattner committed rG87c032f7b449: [IR] Make Value::getType() work better with invalid IR. (authored by lattner).
[IR] Make Value::getType() work better with invalid IR.
Mon, Dec 28, 12:47 PM
lattner added a comment to D93869: [IR] Make Value::getType() work better with invalid IR..

thanks for the quick review, landed in 87c032f7b44

Mon, Dec 28, 12:47 PM · Restricted Project
lattner closed D93869: [IR] Make Value::getType() work better with invalid IR..
Mon, Dec 28, 12:47 PM · Restricted Project
lattner added reviewers for D93869: [IR] Make Value::getType() work better with invalid IR.: mehdi_amini, jpienaar.
Mon, Dec 28, 12:03 PM · Restricted Project
lattner requested review of D93869: [IR] Make Value::getType() work better with invalid IR..
Mon, Dec 28, 12:01 PM · Restricted Project

Sun, Dec 27

lattner added a comment to D93361: Improve the verifier diagnostic on dominance error.

This is awesome, thank you!

Sun, Dec 27, 2:12 PM · Restricted Project

Sat, Dec 26

lattner added inline comments to D93717: [IR] Add an ImplicitLocOpBuilder helper class for building IR with the same loc..
Sat, Dec 26, 5:49 PM · Restricted Project
lattner committed rG9eb3e564d3b1: [ODS] Make the getType() method on a OneResult instruction return a specific… (authored by lattner).
[ODS] Make the getType() method on a OneResult instruction return a specific…
Sat, Dec 26, 1:53 PM
lattner added a comment to D93790: [ODS] Make the getType() method on a OneResult instruction return a specific type..

Landed in 9eb3e564d3b, thanks!

Sat, Dec 26, 1:53 PM · Restricted Project
lattner closed D93790: [ODS] Make the getType() method on a OneResult instruction return a specific type..
Sat, Dec 26, 1:52 PM · Restricted Project
lattner accepted D93814: [TableGen] Fix bug in !interleave operator.
Sat, Dec 26, 12:43 PM · Restricted Project

Wed, Dec 23

lattner requested review of D93790: [ODS] Make the getType() method on a OneResult instruction return a specific type..
Wed, Dec 23, 6:19 PM · Restricted Project

Tue, Dec 22

lattner committed rG75a3f326c3d8: [IR] Add an ImplicitLocOpBuilder helper class for building IR with the same loc. (authored by lattner).
[IR] Add an ImplicitLocOpBuilder helper class for building IR with the same loc.
Tue, Dec 22, 2:48 PM
lattner closed D93717: [IR] Add an ImplicitLocOpBuilder helper class for building IR with the same loc..
Tue, Dec 22, 2:47 PM · Restricted Project
lattner added a comment to D93717: [IR] Add an ImplicitLocOpBuilder helper class for building IR with the same loc..

Great catches, fixed. Thanks!

Tue, Dec 22, 2:37 PM · Restricted Project
lattner updated the diff for D93717: [IR] Add an ImplicitLocOpBuilder helper class for building IR with the same loc..

Fixes AlexZ recommended.

Tue, Dec 22, 2:37 PM · Restricted Project
lattner added a comment to D93654: [TableGen] Change getAllDerivedDefinitions() to return an ArrayRef.

Yeah please don't do a macro. A comment should be enough.

Tue, Dec 22, 10:42 AM · Restricted Project, Restricted Project
lattner requested review of D93717: [IR] Add an ImplicitLocOpBuilder helper class for building IR with the same loc..
Tue, Dec 22, 10:35 AM · Restricted Project
lattner added a comment to D93654: [TableGen] Change getAllDerivedDefinitions() to return an ArrayRef.

this looks great to me Paul. I don't see the client that modifies the array, but such a client can do an explicit copy into its own std::vector

Tue, Dec 22, 9:59 AM · Restricted Project, Restricted Project
lattner added a comment to D93654: [TableGen] Change getAllDerivedDefinitions() to return an ArrayRef.

Yeah C++ syntax isn't great. If you take the path of returning arrayref, it is a bad idea to allow it to convert the a 'const&'. My understanding is that operator you found on arrayref will make a copy of the data (defeating the whole purpose of this patch :-), and that the lifetime will be bound to the statement. This means the reference will actually dangle. :-(

Tue, Dec 22, 9:14 AM · Restricted Project, Restricted Project

Mon, Dec 21

lattner added a comment to D93654: [TableGen] Change getAllDerivedDefinitions() to return an ArrayRef.

Yeah just let the return construct it. On the caller side, just say: auto x = Records.getAllDerivedDefinitions(..)

Mon, Dec 21, 2:27 PM · Restricted Project, Restricted Project
lattner accepted D93654: [TableGen] Change getAllDerivedDefinitions() to return an ArrayRef.

Did you consider returning ArrayRef<Record*> instead? This is a bit more of an abstract type. Both work though

Mon, Dec 21, 11:21 AM · Restricted Project, Restricted Project

Dec 16 2020

lattner added a comment to D54891: [RFC] Checking inline assembly for validity.

This is really cool!

Dec 16 2020, 4:44 PM

Dec 15 2020

lattner added a comment to D93208: [TableGen] Slim down the data structures in xxxGenInstrInfo.inc, step 1.

I'd look at git blame, see who contributed it. We can then contact them, or just propose deletion of the code on llvm-dev and see if anyone speaks up :)

Dec 15 2020, 10:40 AM · Restricted Project
lattner accepted D93270: [mlir][IR] Define the singleton builtin types in ODS instead of C++.

This is really awesome River, I love adopting and dogfooding ODS features in the builtin/std dialect. Thanks for also fixing the TypeConstraint issue.

Dec 15 2020, 10:39 AM · Restricted Project

Dec 14 2020

lattner accepted D93208: [TableGen] Slim down the data structures in xxxGenInstrInfo.inc, step 1.

Looks reasonable to me, Paul mentions that only AVR is using it in tree.

Dec 14 2020, 9:20 PM · Restricted Project

Dec 12 2020

lattner committed rGa44e630353b8: [AsmParser] Fix support for zero bit integer types. (authored by lattner).
[AsmParser] Fix support for zero bit integer types.
Dec 12 2020, 9:25 PM
lattner added a comment to D93089: [AsmParser] Fix support for zero bit integer types..

Thanks Mehdi!

Dec 12 2020, 9:25 PM · Restricted Project
lattner closed D93089: [AsmParser] Fix support for zero bit integer types..
Dec 12 2020, 9:24 PM · Restricted Project

Dec 11 2020

lattner added a comment to D93089: [AsmParser] Fix support for zero bit integer types..

I can do that, but is there a reason to reject that?

Dec 11 2020, 9:26 AM · Restricted Project
lattner added a reviewer for D93089: [AsmParser] Fix support for zero bit integer types.: mehdi_amini.
Dec 11 2020, 9:15 AM · Restricted Project

Dec 10 2020

lattner requested review of D93089: [AsmParser] Fix support for zero bit integer types..
Dec 10 2020, 10:51 PM · Restricted Project
lattner accepted D93069: [SmallVector] Copy new docs into Doxygen comment.

nice, thank you!

Dec 10 2020, 2:14 PM · Restricted Project

Dec 7 2020

lattner added a comment to D92674: [TableGen] Cache the vectors of records returned by getAllDerivedDefinitions()..

LGTM thanks paul

Dec 7 2020, 9:43 AM · Restricted Project

Dec 6 2020

lattner added a comment to D92674: [TableGen] Cache the vectors of records returned by getAllDerivedDefinitions()..

Nice! StringMap is definitely a good way to go here, the timings in that talk don't look right at all.

Dec 6 2020, 1:48 PM · Restricted Project

Dec 5 2020

lattner accepted D92722: [TableGen] [CodeGenTarget] Cache the target's instruction namespace.
Dec 5 2020, 8:03 AM · Restricted Project

Dec 3 2020

lattner accepted D92522: [SmallVector] Allow SmallVector<T>.

Thx Sean!

Dec 3 2020, 10:58 AM · Restricted Project

Dec 2 2020

lattner accepted D92522: [SmallVector] Allow SmallVector<T>.

the patch looks good to me, I think the most important thing here is to nail down the programmer manual dox to be airtight :-)

Dec 2 2020, 9:17 PM · Restricted Project

Dec 1 2020

lattner accepted D92269: [TableGen] Eliminate the 'code' type.

Woot! Go Paul!

Dec 1 2020, 10:03 PM · Restricted Project, Restricted Project, Restricted Project

Nov 29 2020

lattner added a comment to D92247: [IR][LoopRotate] avoid leaving phi with no operands (PR48296).

But if we're in an unreachable block, then we allow other IR forms that are even less expected (self-reference), so we should loosen this restriction?

Nov 29 2020, 8:22 AM · Restricted Project

Nov 28 2020

lattner added a comment to D92269: [TableGen] Eliminate the 'code' type.

Oh ok, well I have no problem keeping it around in searchable tables, I misread this as making that more general.

Nov 28 2020, 4:57 PM · Restricted Project, Restricted Project, Restricted Project
lattner added a comment to D92269: [TableGen] Eliminate the 'code' type.

Ah, I thought TypeOf_xxx was a transitionary thing that we'd drop over time (to reduce complexity). If that's the case, I'd recommend not documenting it.

Nov 28 2020, 2:16 PM · Restricted Project, Restricted Project, Restricted Project
lattner accepted D92146: [Timer] Add the timer option -sort-timers to enable/disable report sorting.

LGTM, thanks Paul

Nov 28 2020, 8:36 AM · Restricted Project
lattner added a comment to D92247: [IR][LoopRotate] avoid leaving phi with no operands (PR48296).

I don't think this is the right way to go, this breaks the invariant that # inputs to a phi node should match the # predecessors to a block. I'd recommend allowing zero input phi nodes in zero-predecessor blocks. I'm not sure why we ban zero input phi nodes right now.

Nov 28 2020, 8:28 AM · Restricted Project

Nov 26 2020

lattner added a comment to D92146: [Timer] Add the timer option -sort-timers to enable/disable report sorting.

Huh interesting. I'd recommend making this a cl::opt flag so any client of timers can get it. Timer.cpp already has a bunch of these flags (e.g. TrackSpace) so I'd just add one more

Nov 26 2020, 12:02 PM · Restricted Project

Nov 22 2020

lattner added a comment to D91939: [MLIR] ODS typedef gen fixes & improvements.

Ah right, I suppose this will matter if/when the ODS support for custom types also provides a declarative way to specify asm printing/parsing.

Nov 22 2020, 3:59 PM · Restricted Project
lattner accepted D91939: [MLIR] ODS typedef gen fixes & improvements.

Nice, thanks! Does this add a verifier style check that makes sure that inner type is an RTLValueType, or is that still the responsibility of the custom parser logic?

Nov 22 2020, 3:38 PM · Restricted Project
lattner accepted D91932: [TableGen] Eliminte source location from CodeInit.
Nov 22 2020, 8:37 AM · Restricted Project

Nov 13 2020

lattner accepted D91388: [TableGen] Add frontend/backend phase timing capability.

Looks reasonable to me Paul! The null backend is a great idea for analysis

Nov 13 2020, 9:54 AM · Restricted Project
lattner accepted D91431: [TableGen] Clean up more .td files.
Nov 13 2020, 9:53 AM · Restricted Project

Nov 10 2020

lattner accepted D91013: [docs] link new support policy from developer policy.

I agree this is a bit redundant. I'd drop the two changes that I marked above in the diff, otherwise LGTM, thank you again!

Nov 10 2020, 9:09 AM · Restricted Project
lattner added a comment to D91174: [Support] Introduce a new InstructionCost class.

Looks reasonable to me!

Nov 10 2020, 9:02 AM · Restricted Project

Nov 7 2020

lattner added a comment to D91013: [docs] link new support policy from developer policy.

Looks great, but I'd add this to the top of the "adding a new thing" section above the "new target" section. Could you also revise the 'new target' to be defined in the terms you established? I think it makes sense to retain the majority of the text there, but aligning on terminology would be good.

Nov 7 2020, 1:24 PM · Restricted Project
lattner accepted D91008: [TableGen] Add the !filter bang operator..

Very nice Paul!

Nov 7 2020, 1:20 PM · Restricted Project
lattner accepted D90761: [docs] Adding a Support Policy.

This look really really great Renato. After this lands, please also prepare a patch (~paragraph length) for the main DeveloperPolicy doc that gives the high level idea of what is going on, and links to this doc for more information.

Nov 7 2020, 10:04 AM · Restricted Project

Nov 5 2020

lattner accepted D90881: [TableGen] Clarify text and fix errors in the Programmer's Reference.
Nov 5 2020, 8:29 PM · Restricted Project

Nov 3 2020

lattner accepted D90732: Switch from C-style comments `/* ... */` to C++ style `//` (NFC).

Wow, very impressive regex-fu mehdi! It looks like one more pattern is needed, but amazing work!

Nov 3 2020, 8:57 PM · Restricted Project

Nov 2 2020

lattner accepted D90617: [TableGen] Fix a couple of minor issues regarding the paste operator.

very nice Paul, you're a machine :)

Nov 2 2020, 8:12 AM · Restricted Project
lattner accepted D90469: [TableGen] Add !interleave operator to concatenate a list of values with delimiters.

nice!

Nov 2 2020, 8:12 AM · Restricted Project, Restricted Project

Nov 1 2020

lattner added a comment to D90469: [TableGen] Add !interleave operator to concatenate a list of values with delimiters.

FWIW, I suggested interleave because of the llvm::interleave algorithm in llvm/ADT/STLExtras.h

Nov 1 2020, 12:48 PM · Restricted Project, Restricted Project

Oct 30 2020

lattner added a comment to D90469: [TableGen] Add !interleave operator to concatenate a list of values with delimiters.

The word "adjoin" is a bit obscure and I don't think it quote connotes the right thing here. How about !interleave instead?

Oct 30 2020, 10:00 PM · Restricted Project, Restricted Project
lattner accepted D90513: [TableGen] Eliminate uses of true and false in .td files.
Oct 30 2020, 5:49 PM · Restricted Project

Oct 27 2020

lattner added a comment to D89893: [Clang] [TableGen] Clean up !if(!eq(boolean, 1) and related booleans.

Oops, thanks for the head's up @dblaikie !

Oct 27 2020, 11:59 AM · Restricted Project

Oct 21 2020

lattner accepted D89893: [Clang] [TableGen] Clean up !if(!eq(boolean, 1) and related booleans.
Oct 21 2020, 10:46 AM · Restricted Project

Oct 20 2020

lattner accepted D89822: [ARM] [TableGen] Clean up !if(!eq(boolean, 1) and related booleans.

These seem obvious to me Paul, please feel free to move forward with similar cleanups without individual approval (according to your judgement) or in a single larger patch that touches everything at once.

Oct 20 2020, 1:51 PM · Restricted Project

Oct 19 2020

lattner added a comment to D89551: [AArch64] [TableGen] Clean up boolean tests.

Cool, please do

Oct 19 2020, 10:29 AM · Restricted Project

Oct 18 2020

lattner accepted D89655: [TableGen] Enhance !empty and !size to handle strings and DAGs.

nice!

Oct 18 2020, 5:54 PM · Restricted Project

Oct 15 2020

lattner added inline comments to D89470: [mlir] ODS: support TableGen dag objects to specify OpBuilder parameters.
Oct 15 2020, 10:16 AM · Restricted Project