Page MenuHomePhabricator

[clangd] Unify macro matching in code completion for AST and Index based macros
ClosedPublic

Authored by kadircet on Aug 11 2020, 4:32 AM.

Diff Detail

Event Timeline

kadircet created this revision.Aug 11 2020, 4:32 AM
kadircet requested review of this revision.Aug 11 2020, 4:32 AM
hokein accepted this revision.Aug 11 2020, 6:24 AM
hokein added inline comments.
clang-tools-extra/clangd/CodeComplete.cpp
1619–1620

this comment seems stale, macros are not sema-only now.

This revision is now accepted and ready to land.Aug 11 2020, 6:24 AM
kadircet updated this revision to Diff 284694.Aug 11 2020, 6:54 AM
  • Drop the comment
This revision was landed with ongoing or failed builds.Aug 11 2020, 7:00 AM
This revision was automatically updated to reflect the committed changes.