Page MenuHomePhabricator

[clangd] Add more error details on the remote index server side
ClosedPublic

Authored by kbobyrev on Aug 7 2020, 12:02 AM.

Diff Detail

Event Timeline

kbobyrev created this revision.Aug 7 2020, 12:02 AM
kbobyrev requested review of this revision.Aug 7 2020, 12:02 AM
kadircet accepted this revision.Aug 7 2020, 3:39 PM

LGTM

clang-tools-extra/clangd/index/remote/marshalling/Marshalling.cpp
322

i would put this in quotes to make empty strings more easy to detect, i.e. '{0}', same for others.

also s/given/received/ ?

328

why not print the real RemoteIndexRoot here ?

This revision is now accepted and ready to land.Aug 7 2020, 3:39 PM
kbobyrev updated this revision to Diff 284230.Aug 9 2020, 1:05 PM
kbobyrev marked 2 inline comments as done.

Resolve post-LGTM comments.

This revision was landed with ongoing or failed builds.Aug 9 2020, 1:13 PM
This revision was automatically updated to reflect the committed changes.